* [PATCHv2 kvm] kvm_pv_eoi: add flag support
@ 2012-07-01 15:08 Michael S. Tsirkin
2012-07-03 19:57 ` Marcelo Tosatti
2012-07-10 8:39 ` Dor Laor
0 siblings, 2 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2012-07-01 15:08 UTC (permalink / raw)
To: Marcelo Tosatti, avi, kvm
Cc: Andreas Färber, Igor Mammedov, Eduardo Habkost,
Michael Roth, Anthony Liguori, gleb
Support the new PV EOI flag in kvm - it recently got merged
into kvm.git. Set by default with -cpu kvm.
Set for -cpu qemu by adding +kvm_pv_eoi.
Clear by adding -kvm_pv_eoi to -cpu option.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Changes from v1:
rebased to uq/master
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 5521709..ee1b64a 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
};
static const char *kvm_feature_name[] = {
- "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
+ "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
2012-07-01 15:08 [PATCHv2 kvm] kvm_pv_eoi: add flag support Michael S. Tsirkin
@ 2012-07-03 19:57 ` Marcelo Tosatti
2012-07-10 8:39 ` Dor Laor
1 sibling, 0 replies; 6+ messages in thread
From: Marcelo Tosatti @ 2012-07-03 19:57 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: avi, kvm, Andreas Färber, Igor Mammedov, Eduardo Habkost,
Michael Roth, Anthony Liguori, gleb
On Sun, Jul 01, 2012 at 06:08:30PM +0300, Michael S. Tsirkin wrote:
> Support the new PV EOI flag in kvm - it recently got merged
> into kvm.git. Set by default with -cpu kvm.
> Set for -cpu qemu by adding +kvm_pv_eoi.
> Clear by adding -kvm_pv_eoi to -cpu option.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied to uq/master, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
2012-07-01 15:08 [PATCHv2 kvm] kvm_pv_eoi: add flag support Michael S. Tsirkin
2012-07-03 19:57 ` Marcelo Tosatti
@ 2012-07-10 8:39 ` Dor Laor
2012-07-10 12:55 ` Eduardo Habkost
1 sibling, 1 reply; 6+ messages in thread
From: Dor Laor @ 2012-07-10 8:39 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Marcelo Tosatti, avi, kvm, Andreas Färber, Igor Mammedov,
Eduardo Habkost, Michael Roth, Anthony Liguori, gleb
On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> Support the new PV EOI flag in kvm - it recently got merged
> into kvm.git. Set by default with -cpu kvm.
> Set for -cpu qemu by adding +kvm_pv_eoi.
> Clear by adding -kvm_pv_eoi to -cpu option.
What about adding them to our cpu models?
It should go w/o saying for all models (SandyBridge, OpteronGx,..) but
there is the issue of backward compat. I remember we had a discussion
about pair the models w/ the current machine type (-M) but I don't
remember the final call.
What's your take Eduardo?
Cheers,
Dor
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Changes from v1:
> rebased to uq/master
>
> target-i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 5521709..ee1b64a 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
> };
>
> static const char *kvm_feature_name[] = {
> - "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> + "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
2012-07-10 8:39 ` Dor Laor
@ 2012-07-10 12:55 ` Eduardo Habkost
2012-07-13 0:03 ` Michael S. Tsirkin
0 siblings, 1 reply; 6+ messages in thread
From: Eduardo Habkost @ 2012-07-10 12:55 UTC (permalink / raw)
To: Dor Laor
Cc: Michael S. Tsirkin, Marcelo Tosatti, avi, kvm,
Andreas Färber, Igor Mammedov, Michael Roth,
Anthony Liguori, gleb
On Tue, Jul 10, 2012 at 11:39:57AM +0300, Dor Laor wrote:
> On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> >Support the new PV EOI flag in kvm - it recently got merged
> >into kvm.git. Set by default with -cpu kvm.
> >Set for -cpu qemu by adding +kvm_pv_eoi.
> >Clear by adding -kvm_pv_eoi to -cpu option.
>
> What about adding them to our cpu models?
> It should go w/o saying for all models (SandyBridge, OpteronGx,..)
> but there is the issue of backward compat. I remember we had a
> discussion about pair the models w/ the current machine type (-M) but
> I don't remember the final call.
>
> What's your take Eduardo?
We can really add it, but only after adding the infra-structure to allow
"versioned" CPU models (with per-machine-type aliases for backwards
compatibility with older machine types).
(The current status of this is "I am going to implement it", but there's
no code do do that yet).
>
> Cheers,
> Dor
>
> >
> >Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >---
> >
> >Changes from v1:
> > rebased to uq/master
> >
> > target-i386/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> >index 5521709..ee1b64a 100644
> >--- a/target-i386/cpu.c
> >+++ b/target-i386/cpu.c
> >@@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
> > };
> >
> > static const char *kvm_feature_name[] = {
> >- "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> >+ "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> >
>
>
--
Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
2012-07-10 12:55 ` Eduardo Habkost
@ 2012-07-13 0:03 ` Michael S. Tsirkin
2012-07-13 13:31 ` Eduardo Habkost
0 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2012-07-13 0:03 UTC (permalink / raw)
To: Eduardo Habkost
Cc: Dor Laor, Marcelo Tosatti, avi, kvm, Andreas Färber,
Igor Mammedov, Michael Roth, Anthony Liguori, gleb
On Tue, Jul 10, 2012 at 09:55:08AM -0300, Eduardo Habkost wrote:
> On Tue, Jul 10, 2012 at 11:39:57AM +0300, Dor Laor wrote:
> > On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> > >Support the new PV EOI flag in kvm - it recently got merged
> > >into kvm.git. Set by default with -cpu kvm.
> > >Set for -cpu qemu by adding +kvm_pv_eoi.
> > >Clear by adding -kvm_pv_eoi to -cpu option.
> >
> > What about adding them to our cpu models?
> > It should go w/o saying for all models (SandyBridge, OpteronGx,..)
> > but there is the issue of backward compat. I remember we had a
> > discussion about pair the models w/ the current machine type (-M) but
> > I don't remember the final call.
> >
> > What's your take Eduardo?
>
> We can really add it, but only after adding the infra-structure to allow
> "versioned" CPU models (with per-machine-type aliases for backwards
> compatibility with older machine types).
>
> (The current status of this is "I am going to implement it", but there's
> no code do do that yet).
OK so I'll just wait and you'll make it happen?
Also is libvirt support needed?
> >
> > Cheers,
> > Dor
> >
> > >
> > >Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >---
> > >
> > >Changes from v1:
> > > rebased to uq/master
> > >
> > > target-i386/cpu.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> > >index 5521709..ee1b64a 100644
> > >--- a/target-i386/cpu.c
> > >+++ b/target-i386/cpu.c
> > >@@ -77,7 +77,7 @@ static const char *ext3_feature_name[] = {
> > > };
> > >
> > > static const char *kvm_feature_name[] = {
> > >- "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, NULL, NULL,
> > >+ "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
> > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > >
> >
> >
>
> --
> Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 kvm] kvm_pv_eoi: add flag support
2012-07-13 0:03 ` Michael S. Tsirkin
@ 2012-07-13 13:31 ` Eduardo Habkost
0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Habkost @ 2012-07-13 13:31 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Dor Laor, Marcelo Tosatti, avi, kvm, Andreas Färber,
Igor Mammedov, Michael Roth, Anthony Liguori, gleb
On Fri, Jul 13, 2012 at 03:03:46AM +0300, Michael S. Tsirkin wrote:
> On Tue, Jul 10, 2012 at 09:55:08AM -0300, Eduardo Habkost wrote:
> > On Tue, Jul 10, 2012 at 11:39:57AM +0300, Dor Laor wrote:
> > > On 07/01/2012 06:08 PM, Michael S. Tsirkin wrote:
> > > >Support the new PV EOI flag in kvm - it recently got merged
> > > >into kvm.git. Set by default with -cpu kvm.
> > > >Set for -cpu qemu by adding +kvm_pv_eoi.
> > > >Clear by adding -kvm_pv_eoi to -cpu option.
> > >
> > > What about adding them to our cpu models?
> > > It should go w/o saying for all models (SandyBridge, OpteronGx,..)
> > > but there is the issue of backward compat. I remember we had a
> > > discussion about pair the models w/ the current machine type (-M) but
> > > I don't remember the final call.
> > >
> > > What's your take Eduardo?
> >
> > We can really add it, but only after adding the infra-structure to allow
> > "versioned" CPU models (with per-machine-type aliases for backwards
> > compatibility with older machine types).
> >
> > (The current status of this is "I am going to implement it", but there's
> > no code do do that yet).
>
> OK so I'll just wait and you'll make it happen?
Yes, when we start supporting versioned CPU models, I can send a patch
to add kvm_pv_eoi to the existing models on newer machine-types.
> Also is libvirt support needed?
Only if we want to allow libvirt to control the feature directly.
Otherwise, it would be simply controlled just by the machine-type +
cpu-model combination.
In either case, it will probably be better to add libvirt support only
after we have the proper QEMU<->libvirt CPU feature probing interface
implemented.
--
Eduardo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-13 13:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-01 15:08 [PATCHv2 kvm] kvm_pv_eoi: add flag support Michael S. Tsirkin
2012-07-03 19:57 ` Marcelo Tosatti
2012-07-10 8:39 ` Dor Laor
2012-07-10 12:55 ` Eduardo Habkost
2012-07-13 0:03 ` Michael S. Tsirkin
2012-07-13 13:31 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.