[Buildroot] [PATCH] protobuf: fix circular dependency warning

[Buildroot] [PATCH] protobuf: fix circular dependency warning

[spdawson at gmail.com]

From: Simon Dawson <spdawson@gmail.com>

The protobuf package depends on host-protobuf, which leads to a
circular dependency of host-protobuf on host-protobuf. The following
warning is output.

  make: Circular host-protobuf-depends <- host-protobuf dependency dropped.

This patch breaks the circular dependency, by explictly asserting the
dependencies of host-protobuf (currently none).

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/protobuf/protobuf.mk |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index f18261e..e0214ed 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -9,6 +9,7 @@ PROTOBUF_SITE = http://protobuf.googlecode.com/files/
 
 # N.B. Need to use host protoc during cross compilation.
 PROTOBUF_DEPENDENCIES = host-protobuf
+HOST_PROTOBUF_DEPENDENCIES =
 PROTOBUF_CONF_OPT = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 
 PROTOBUF_INSTALL_STAGING = YES
-- 
1.7.9.5

[Buildroot] [PATCH] protobuf: fix circular dependency warning

[Thomas Petazzoni]

Le Fri, 13 Jul 2012 21:49:12 +0100,
spdawson at gmail.com a ?crit :

> From: Simon Dawson <spdawson@gmail.com>
> 
> The protobuf package depends on host-protobuf, which leads to a
> circular dependency of host-protobuf on host-protobuf. The following
> warning is output.
> 
>   make: Circular host-protobuf-depends <- host-protobuf dependency dropped.
> 
> This patch breaks the circular dependency, by explictly asserting the
> dependencies of host-protobuf (currently none).
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>

I think
http://lists.busybox.net/pipermail/buildroot/2012-July/055442.html
solves that problem in a much more generic way. Could you test this
patch and report if it solves the problem for you?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] protobuf: fix circular dependency warning

[Simon Dawson]

On 13 July 2012 21:59, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> I think
> http://lists.busybox.net/pipermail/buildroot/2012-July/055442.html
> solves that problem in a much more generic way. Could you test this
> patch and report if it solves the problem for you?

Hi Thomas. This generic mechanism does indeed work in the present case
(package protobuf). However, the indicated patch is only for the
gentargets package mechanism; to apply to the protobuf package, a
similar modification of pkg-autotargets.mk is required.

I'm happy to do this modification, if you think it appropriate.

Simon.

[Buildroot] [PATCH] protobuf: fix circular dependency warning

[Thomas Petazzoni]

Le Sat, 14 Jul 2012 10:07:06 +0100,
Simon Dawson <spdawson@gmail.com> a ?crit :

> Hi Thomas. This generic mechanism does indeed work in the present case
> (package protobuf). However, the indicated patch is only for the
> gentargets package mechanism; to apply to the protobuf package, a
> similar modification of pkg-autotargets.mk is required.
> 
> I'm happy to do this modification, if you think it appropriate.

Arnout, can you extend your patch to take this into account (including
pkg-autotargets and pkg-cmaketargets)? Or if you don't have the time,
tell Simon to extend your patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH v2 1/6] pkg-infra: remove self-dependency from host packages

[Arnout Vandecappelle]

When HOST_XXX_DEPENDENCIES are derived automatically from
XXX_DEPENDENCIES, a self-dependency is created if host-xxx is a dependency
of xxx.  This was the case for miniperl.

Filter out the self-dependency.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v2:
 - Also update pkg-autotargets and pkg-cmaketargets (as suggested by
   Simon Dawson)

 package/pkg-autotargets.mk  |    2 +-
 package/pkg-cmaketargets.mk |    2 +-
 package/pkg-gentargets.mk   |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/pkg-autotargets.mk b/package/pkg-autotargets.mk
index c9887c2..d31230d 100644
--- a/package/pkg-autotargets.mk
+++ b/package/pkg-autotargets.mk
@@ -201,7 +201,7 @@ endef
 # This must be repeated from GENTARGETS_INNER, otherwise we get an empty
 # _DEPENDENCIES if _AUTORECONF is YES.  Also filter the result of _AUTORECONF
 # away from the non-host rule
-$(2)_DEPENDENCIES ?= $(filter-out host-automake host-autoconf host-libtool,\
+$(2)_DEPENDENCIES ?= $(filter-out host-automake host-autoconf host-libtool $(1),\
     $(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES))))
 
 
diff --git a/package/pkg-cmaketargets.mk b/package/pkg-cmaketargets.mk
index 371ab11..b405df5 100644
--- a/package/pkg-cmaketargets.mk
+++ b/package/pkg-cmaketargets.mk
@@ -98,7 +98,7 @@ endif
 
 # This must be repeated from GENTARGETS_INNER, otherwise we only get
 # host-cmake in _DEPENDENCIES because of the following line
-$(2)_DEPENDENCIES ?= $(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES)))
+$(2)_DEPENDENCIES ?= $(filter-out $(1),$(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES))))
 
 $(2)_DEPENDENCIES += host-cmake
 
diff --git a/package/pkg-gentargets.mk b/package/pkg-gentargets.mk
index 1c9b458..5da9cdc 100644
--- a/package/pkg-gentargets.mk
+++ b/package/pkg-gentargets.mk
@@ -245,7 +245,7 @@ $(2)_OVERRIDE_SRCDIR = $($(2)_SITE)
 endif
 endif
 
-$(2)_DEPENDENCIES ?= $(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES)))
+$(2)_DEPENDENCIES ?= $(filter-out $(1),$(patsubst host-host-%,host-%,$(addprefix host-,$($(3)_DEPENDENCIES))))
 
 $(2)_INSTALL_STAGING		?= NO
 $(2)_INSTALL_IMAGES		?= NO
-- 
tg: (830c586..) t/host-no-circular-dep (depends on: master)

[Buildroot] [PATCH 2/6] file: remove redundant HOST_FILE_DEPENDENCIES

[Arnout Vandecappelle]

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/file/file.mk |    1 -
 1 file changed, 1 deletion(-)

diff --git a/package/file/file.mk b/package/file/file.mk
index c9846e4..7f07752 100644
--- a/package/file/file.mk
+++ b/package/file/file.mk
@@ -7,7 +7,6 @@
 FILE_VERSION = 5.11
 FILE_SITE = ftp://ftp.astron.com/pub/file
 FILE_DEPENDENCIES = host-file zlib
-HOST_FILE_DEPENDENCIES = host-zlib
 FILE_INSTALL_STAGING = YES
 
 define FILE_UNINSTALL_TARGET_CMDS
-- 
tg: (e991c59..) t/host-no-circular-dep-file (depends on: t/host-no-circular-dep)

[Buildroot] [PATCH 3/6] icu: remove redundant HOST_ICU_DEPENDENCIES

[Arnout Vandecappelle]

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/icu/icu.mk |    1 -
 1 file changed, 1 deletion(-)

diff --git a/package/icu/icu.mk b/package/icu/icu.mk
index a2c24ca..42416b7 100644
--- a/package/icu/icu.mk
+++ b/package/icu/icu.mk
@@ -8,7 +8,6 @@ ICU_VERSION = 4.8.1.1
 ICU_SOURCE = icu4c-$(subst .,_,$(ICU_VERSION))-src.tgz
 ICU_SITE = http://download.icu-project.org/files/icu4c/$(ICU_VERSION)
 ICU_DEPENDENCIES = host-icu
-HOST_ICU_DEPENDENCIES =
 ICU_INSTALL_STAGING = YES
 ICU_CONF_OPT = --with-cross-build=$(HOST_ICU_DIR)/source --disable-samples \
 		--disable-tests
-- 
tg: (bd3c98f..) t/host-no-circular-dep-3-icu (depends on: t/host-no-circular-dep-file)

[Buildroot] [PATCH 4/6] libcap: remove redundant HOST_LIBCAP_DEPENDENCIES

[Arnout Vandecappelle]

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/libcap/libcap.mk |    1 -
 1 file changed, 1 deletion(-)

diff --git a/package/libcap/libcap.mk b/package/libcap/libcap.mk
index 4683121..9d6acf2 100644
--- a/package/libcap/libcap.mk
+++ b/package/libcap/libcap.mk
@@ -10,7 +10,6 @@ LIBCAP_VERSION = 2.22
 LIBCAP_SITE = $(BR2_DEBIAN_MIRROR)/debian/pool/main/libc/libcap2
 LIBCAP_SOURCE = libcap2_$(LIBCAP_VERSION).orig.tar.gz
 LIBCAP_DEPENDENCIES = host-libcap
-HOST_LIBCAP_DEPENDENCIES =
 LIBCAP_INSTALL_STAGING = YES
 
 define LIBCAP_BUILD_CMDS
-- 
tg: (a19af6a..) t/host-no-circular-dep-4-libcap (depends on: t/host-no-circular-dep-3-icu)

[Buildroot] [PATCH 5/6] ncurses: remove redundant HOST_NCURSES_DEPENDENCIES

[Arnout Vandecappelle]

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/ncurses/ncurses.mk |    2 --
 1 file changed, 2 deletions(-)

diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index afeb41b..adf18ff 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -135,8 +135,6 @@ define HOST_NCURSES_BUILD_CMDS
 	$(MAKE) -C $(@D)/progs tic
 endef
 
-HOST_NCURSES_DEPENDENCIES =
-
 HOST_NCURSES_CONF_OPT = \
 	--without-shared --without-gpm
 
-- 
tg: (b41b0de..) t/host-no-circular-dep-5-ncurses (depends on: t/host-no-circular-dep-4-libcap)

[Buildroot] [PATCH 6/6] orc: remove redundant HOST_ORC_DEPENDENCIES

[Arnout Vandecappelle]

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

---
 package/orc/orc.mk |    1 -
 1 file changed, 1 deletion(-)

diff --git a/package/orc/orc.mk b/package/orc/orc.mk
index 6602e36..97c80f2 100644
--- a/package/orc/orc.mk
+++ b/package/orc/orc.mk
@@ -7,7 +7,6 @@ ORC_VERSION = 0.4.14
 ORC_SITE = http://code.entropywave.com/download/orc/
 ORC_INSTALL_STAGING = YES
 ORC_DEPENDENCIES = host-orc
-HOST_ORC_DEPENDENCIES =
 
 define ORC_REMOVE_BUGREPORT
 	rm -f $(TARGET_DIR)/usr/bin/orc-bugreport
-- 
tg: (a24703b..) t/host-no-circular-dep-6-orc (depends on: t/host-no-circular-dep-5-ncurses)

[Buildroot] [PATCH v2 1/6] pkg-infra: remove self-dependency from host packages

[Thomas Petazzoni]

Le Sat, 14 Jul 2012 22:31:19 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be> a ?crit :

> When HOST_XXX_DEPENDENCIES are derived automatically from
> XXX_DEPENDENCIES, a self-dependency is created if host-xxx is a dependency
> of xxx.  This was the case for miniperl.
> 
> Filter out the self-dependency.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Thanks, applied, as well as the 5 related cleanups in packages.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com