All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH 00/11] make struct of_device_id.data const
Date: Sat, 14 Jul 2012 20:31:55 +0200	[thread overview]
Message-ID: <20120714183155.GP592@pengutronix.de> (raw)
In-Reply-To: <CACxGe6tXvz+rt2yrHHaD=j94-=JQEh06sHW0FWGiHb2=9GS2pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello Grant,

On Fri, Jul 13, 2012 at 01:36:59PM -0600, Grant Likely wrote:
> On Fri, Jul 13, 2012 at 6:41 AM, Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > On 07/13/2012 07:32 AM, y@pengutronix.de wrote:
> >> this series' goal is to make struct of_device_id.data const.
> >> Conceptually a driver must not modify the data contained there so making
> >> it const is the right thing.
> >>
> >> This change might introduce warnings because drivers don't use const to
> >> access the data pointed to by of_device_id.data. In most cases the fix
> >> is to add some consts.
> >>
> >> This series (apart from adding this const in patch 10) fixes all drivers
> >> covered by all arm defconfigs (based on v3.5-rc6).
> >>
> >
> > What about other arches?
> 
> This whole series is of questionable value to me.  While I agree that
> .data should be const, I don't think changing it has is measurably
> better than what we have now.  Particularly when the series isn't
> complete for all users.  And "building all defconfigs" is not the
> right way to look for affected users.
As it's not really bad if a user isn't fixed (it only introduces a
compiler warning) I think not being 100% sure to have fixed all of them
is OK. I plan to check the defconfigs and an allyes build on powerpc and
look over the patch that Arnd sent. IMHO this is enough to go on.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

WARNING: multiple messages have this Message-ID (diff)
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/11] make struct of_device_id.data const
Date: Sat, 14 Jul 2012 20:31:55 +0200	[thread overview]
Message-ID: <20120714183155.GP592@pengutronix.de> (raw)
In-Reply-To: <CACxGe6tXvz+rt2yrHHaD=j94-=JQEh06sHW0FWGiHb2=9GS2pA@mail.gmail.com>

Hello Grant,

On Fri, Jul 13, 2012 at 01:36:59PM -0600, Grant Likely wrote:
> On Fri, Jul 13, 2012 at 6:41 AM, Rob Herring <robherring2@gmail.com> wrote:
> > On 07/13/2012 07:32 AM, y at pengutronix.de wrote:
> >> this series' goal is to make struct of_device_id.data const.
> >> Conceptually a driver must not modify the data contained there so making
> >> it const is the right thing.
> >>
> >> This change might introduce warnings because drivers don't use const to
> >> access the data pointed to by of_device_id.data. In most cases the fix
> >> is to add some consts.
> >>
> >> This series (apart from adding this const in patch 10) fixes all drivers
> >> covered by all arm defconfigs (based on v3.5-rc6).
> >>
> >
> > What about other arches?
> 
> This whole series is of questionable value to me.  While I agree that
> .data should be const, I don't think changing it has is measurably
> better than what we have now.  Particularly when the series isn't
> complete for all users.  And "building all defconfigs" is not the
> right way to look for affected users.
As it's not really bad if a user isn't fixed (it only introduces a
compiler warning) I think not being 100% sure to have fixed all of them
is OK. I plan to check the defconfigs and an allyes build on powerpc and
look over the patch that Arnd sent. IMHO this is enough to go on.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  parent reply	other threads:[~2012-07-14 18:31 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-13 12:32 [PATCH 00/11] make struct of_device_id.data const y at pengutronix.de
2012-07-13 12:32 ` [PATCH 0/9] " y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 01/11] spi/imx: make spi_imx_data.devtype_data member point to const data y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` [PATCH 02/11] serial/imx: make imx_port.devdata " y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` [PATCH 03/11] ARM: cache-l2x0: add a const qualifier y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 04/11] misc/atmel_tc: make atmel_tc.tcb_config member point to const data y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 13:40   ` Nicolas Ferre
2012-07-13 13:40     ` Nicolas Ferre
2012-07-13 12:32 ` [PATCH 05/11] gpio/gpio-omap.c: add a const qualifier y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 06/11] i2c/i2c-omap: " y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers y at pengutronix.de
2012-07-13 13:54   ` Nicolas Ferre
2012-07-13 13:54     ` Nicolas Ferre
2012-07-16  6:38   ` Vinod Koul
2012-07-16  6:38     ` Vinod Koul
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 08/11] spi/spi-omap2-mcspi: add a const qualifier y
2012-07-13 12:32 ` y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 09/11] mmc/omap_hsmmc: " y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 10/11] of: add const to struct of_device_id.data y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:32 ` [PATCH 11/11] gpio/gpio-omap: make platformdata used as of_device_id.data const y at pengutronix.de
2012-07-13 12:32 ` y
2012-07-13 12:39 ` [PATCH 00/11] make struct " Uwe Kleine-König
2012-07-13 12:39   ` Uwe Kleine-König
2012-07-13 12:41 ` Rob Herring
2012-07-13 12:41   ` Rob Herring
     [not found]   ` <5000175E.4070702-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-07-13 13:46     ` Uwe Kleine-König
2012-07-13 13:46       ` Uwe Kleine-König
     [not found]       ` <20120713134638.GH592-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-13 16:24         ` Arnd Bergmann
2012-07-13 16:24           ` Arnd Bergmann
     [not found]           ` <201207131624.27266.arnd-r2nGTMty4D4@public.gmane.org>
2012-07-13 17:49             ` Uwe Kleine-König
2012-07-13 17:49               ` Uwe Kleine-König
     [not found]               ` <20120713174935.GN592-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-13 18:56                 ` Arnd Bergmann
2012-07-13 18:56                   ` Arnd Bergmann
2012-07-13 19:48                 ` Rob Herring
2012-07-13 19:48                   ` Rob Herring
2012-07-13 19:36     ` Grant Likely
2012-07-13 19:36       ` Grant Likely
     [not found]       ` <CACxGe6tXvz+rt2yrHHaD=j94-=JQEh06sHW0FWGiHb2=9GS2pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-14 18:31         ` Uwe Kleine-König [this message]
2012-07-14 18:31           ` Uwe Kleine-König
  -- strict thread matches above, loose matches on Subject: below --
2012-07-13 12:32 y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120714183155.GP592@pengutronix.de \
    --to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.