* [PATCH net-next 1/2] be2net: Add description about various RSS hash types
@ 2012-07-13 12:45 Padmanabh Ratnakar
2012-07-13 13:20 ` Eric Dumazet
2012-07-17 6:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Padmanabh Ratnakar @ 2012-07-13 12:45 UTC (permalink / raw)
To: netdev; +Cc: Padmanabh Ratnakar
Incorporated review comment from Eric Dumazet. Added description
about different RSS hash types which adapter is capable of.
Will add support for ETHTOOL_GRXFH and ETHTOOL_SRXFX as suggested
by Ben Hutchings in a later patch.
Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
---
drivers/net/ethernet/emulex/benet/be_cmds.h | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
index 45d70de..d5a4ded 100644
--- a/drivers/net/ethernet/emulex/benet/be_cmds.h
+++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
@@ -1082,8 +1082,18 @@ struct be_cmd_resp_query_fw_cfg {
u32 function_caps;
};
-/******************** RSS Config *******************/
-/* RSS types */
+/******************** RSS Config ****************************************/
+/* RSS type Input parameters used to compute RX hash
+ * RSS_ENABLE_IPV4 SRC IPv4, DST IPv4
+ * RSS_ENABLE_TCP_IPV4 SRC IPv4, DST IPv4, TCP SRC PORT, TCP DST PORT
+ * RSS_ENABLE_IPV6 SRC IPv6, DST IPv6
+ * RSS_ENABLE_TCP_IPV6 SRC IPv6, DST IPv6, TCP SRC PORT, TCP DST PORT
+ * RSS_ENABLE_UDP_IPV4 SRC IPv4, DST IPv4, UDP SRC PORT, UDP DST PORT
+ * RSS_ENABLE_UDP_IPV6 SRC IPv6, DST IPv6, UDP SRC PORT, UDP DST PORT
+ *
+ * When multiple RSS types are enabled, HW picks the best hash policy
+ * based on the type of the received packet.
+ */
#define RSS_ENABLE_NONE 0x0
#define RSS_ENABLE_IPV4 0x1
#define RSS_ENABLE_TCP_IPV4 0x2
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/2] be2net: Add description about various RSS hash types
2012-07-13 12:45 [PATCH net-next 1/2] be2net: Add description about various RSS hash types Padmanabh Ratnakar
@ 2012-07-13 13:20 ` Eric Dumazet
2012-07-17 6:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2012-07-13 13:20 UTC (permalink / raw)
To: Padmanabh Ratnakar; +Cc: netdev
On Fri, 2012-07-13 at 18:15 +0530, Padmanabh Ratnakar wrote:
> Incorporated review comment from Eric Dumazet. Added description
> about different RSS hash types which adapter is capable of.
> Will add support for ETHTOOL_GRXFH and ETHTOOL_SRXFX as suggested
> by Ben Hutchings in a later patch.
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
> ---
> drivers/net/ethernet/emulex/benet/be_cmds.h | 14 ++++++++++++--
> 1 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.h b/drivers/net/ethernet/emulex/benet/be_cmds.h
> index 45d70de..d5a4ded 100644
> --- a/drivers/net/ethernet/emulex/benet/be_cmds.h
> +++ b/drivers/net/ethernet/emulex/benet/be_cmds.h
> @@ -1082,8 +1082,18 @@ struct be_cmd_resp_query_fw_cfg {
> u32 function_caps;
> };
>
> -/******************** RSS Config *******************/
> -/* RSS types */
> +/******************** RSS Config ****************************************/
> +/* RSS type Input parameters used to compute RX hash
> + * RSS_ENABLE_IPV4 SRC IPv4, DST IPv4
> + * RSS_ENABLE_TCP_IPV4 SRC IPv4, DST IPv4, TCP SRC PORT, TCP DST PORT
> + * RSS_ENABLE_IPV6 SRC IPv6, DST IPv6
> + * RSS_ENABLE_TCP_IPV6 SRC IPv6, DST IPv6, TCP SRC PORT, TCP DST PORT
> + * RSS_ENABLE_UDP_IPV4 SRC IPv4, DST IPv4, UDP SRC PORT, UDP DST PORT
> + * RSS_ENABLE_UDP_IPV6 SRC IPv6, DST IPv6, UDP SRC PORT, UDP DST PORT
> + *
> + * When multiple RSS types are enabled, HW picks the best hash policy
> + * based on the type of the received packet.
> + */
> #define RSS_ENABLE_NONE 0x0
> #define RSS_ENABLE_IPV4 0x1
> #define RSS_ENABLE_TCP_IPV4 0x2
Thanks
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 1/2] be2net: Add description about various RSS hash types
2012-07-13 12:45 [PATCH net-next 1/2] be2net: Add description about various RSS hash types Padmanabh Ratnakar
2012-07-13 13:20 ` Eric Dumazet
@ 2012-07-17 6:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-07-17 6:02 UTC (permalink / raw)
To: padmanabh.ratnakar; +Cc: netdev
From: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Date: Fri, 13 Jul 2012 18:15:51 +0530
> Incorporated review comment from Eric Dumazet. Added description
> about different RSS hash types which adapter is capable of.
> Will add support for ETHTOOL_GRXFH and ETHTOOL_SRXFX as suggested
> by Ben Hutchings in a later patch.
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-17 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-13 12:45 [PATCH net-next 1/2] be2net: Add description about various RSS hash types Padmanabh Ratnakar
2012-07-13 13:20 ` Eric Dumazet
2012-07-17 6:02 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.