All of lore.kernel.org
 help / color / mirror / Atom feed
* obexd - bug in plugins irmc + phonebook-ebook
@ 2012-07-18  8:47 Ludek Finstrle
  0 siblings, 0 replies; only message in thread
From: Ludek Finstrle @ 2012-07-18  8:47 UTC (permalink / raw)
  To: linux-bluetooth

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

Hello,

  I find the bug in IrMC + phonebook-ebook. There is function phonebook_pull defined in
phonebook-ebook. There is test for name '/telecom/pb.vcf' but IrMC plugin send name
only 'telecom/pb.vcf'.

I attached simple patch to correct this behaviour. To be honest I tested only
phonebook-ebook.

Best regards,

Luf

[-- Attachment #2: 204_fix_irmc_open_full_path.patch --]
[-- Type: text/plain, Size: 1379 bytes --]

diff -cr plugins/irmc.c plugins/irmc.c
*** plugins/irmc.c	Thu May 17 11:12:17 2012
--- plugins/irmc.c	Tue Jul 17 12:25:27 2012
***************
*** 226,232 ****
  	param->maxlistcount = 0; /* to count the number of vcards... */
  	param->filter = 0x200085; /* UID TEL N VERSION */
  	irmc->params = param;
! 	irmc->request = phonebook_pull("telecom/pb.vcf", irmc->params,
  					phonebook_size_result, irmc, err);
  	ret = phonebook_pull_read(irmc->request);
  	if (err)
--- 226,232 ----
  	param->maxlistcount = 0; /* to count the number of vcards... */
  	param->filter = 0x200085; /* UID TEL N VERSION */
  	irmc->params = param;
! 	irmc->request = phonebook_pull("/telecom/pb.vcf", irmc->params,
  					phonebook_size_result, irmc, err);
  	ret = phonebook_pull_read(irmc->request);
  	if (err)
***************
*** 312,318 ****
  
  	if (!g_strcmp0(name, ".vcf")) {
  		/* how can we tell if the vcard count call already finished? */
! 		irmc->request = phonebook_pull("telecom/pb.vcf", irmc->params,
  						query_result, irmc, &ret);
  		if (ret < 0) {
  			DBG("phonebook_pull failed...");
--- 312,318 ----
  
  	if (!g_strcmp0(name, ".vcf")) {
  		/* how can we tell if the vcard count call already finished? */
! 		irmc->request = phonebook_pull("/telecom/pb.vcf", irmc->params,
  						query_result, irmc, &ret);
  		if (ret < 0) {
  			DBG("phonebook_pull failed...");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-18  8:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18  8:47 obexd - bug in plugins irmc + phonebook-ebook Ludek Finstrle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.