* [PATCH] powernow-k8: Fixup missing _PSS objects message
@ 2012-07-18 15:07 Borislav Petkov
2012-07-18 19:50 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2012-07-18 15:07 UTC (permalink / raw)
To: cpufreq; +Cc: Rafael J. Wysocki, LKML, Borislav Petkov
From: Borislav Petkov <borislav.petkov@amd.com>
_PSS objects can also be missing if Cool'N'Quiet is disabled in the
BIOS. Add that to the FW_BUG message for the user to try before updating
her BIOS. Fix formatting while at it.
Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
drivers/cpufreq/powernow-k8.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index c0e816468e30..33f17c4a1342 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -1265,12 +1265,15 @@ static void __cpuinit powernowk8_cpu_init_on_cpu(void *_init_on_cpu)
init_on_cpu->rc = 0;
}
+static const char missing_pss_msg[] =
+ KERN_ERR
+ FW_BUG PFX "No compatible ACPI _PSS objects found.\n"
+ FW_BUG PFX "First, make sure Cool'N'Quiet is enabled in the BIOS.\n"
+ FW_BUG PFX "If that doesn't help, try upgrading your BIOS.\n";
+
/* per CPU init entry point to the driver */
static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
{
- static const char ACPI_PSS_BIOS_BUG_MSG[] =
- KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n"
- FW_BUG PFX "Try again with latest BIOS.\n";
struct powernow_k8_data *data;
struct init_on_cpu init_on_cpu;
int rc;
@@ -1298,7 +1301,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
* an UP version, and is deprecated by AMD.
*/
if (num_online_cpus() != 1) {
- printk_once(ACPI_PSS_BIOS_BUG_MSG);
+ printk_once(missing_pss_msg);
goto err_out;
}
if (pol->cpu != 0) {
--
1.7.11.rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powernow-k8: Fixup missing _PSS objects message
2012-07-18 15:07 [PATCH] powernow-k8: Fixup missing _PSS objects message Borislav Petkov
@ 2012-07-18 19:50 ` Rafael J. Wysocki
2012-07-18 21:05 ` Borislav Petkov
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2012-07-18 19:50 UTC (permalink / raw)
To: Borislav Petkov; +Cc: cpufreq, LKML, Borislav Petkov
On Wednesday, July 18, 2012, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@amd.com>
>
> _PSS objects can also be missing if Cool'N'Quiet is disabled in the
> BIOS. Add that to the FW_BUG message for the user to try before updating
> her BIOS. Fix formatting while at it.
>
> Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
> Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
I will take this, but it's kind of too late for v3.6.
Thanks,
Rafael
> ---
> drivers/cpufreq/powernow-k8.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index c0e816468e30..33f17c4a1342 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -1265,12 +1265,15 @@ static void __cpuinit powernowk8_cpu_init_on_cpu(void *_init_on_cpu)
> init_on_cpu->rc = 0;
> }
>
> +static const char missing_pss_msg[] =
> + KERN_ERR
> + FW_BUG PFX "No compatible ACPI _PSS objects found.\n"
> + FW_BUG PFX "First, make sure Cool'N'Quiet is enabled in the BIOS.\n"
> + FW_BUG PFX "If that doesn't help, try upgrading your BIOS.\n";
> +
> /* per CPU init entry point to the driver */
> static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
> {
> - static const char ACPI_PSS_BIOS_BUG_MSG[] =
> - KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n"
> - FW_BUG PFX "Try again with latest BIOS.\n";
> struct powernow_k8_data *data;
> struct init_on_cpu init_on_cpu;
> int rc;
> @@ -1298,7 +1301,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
> * an UP version, and is deprecated by AMD.
> */
> if (num_online_cpus() != 1) {
> - printk_once(ACPI_PSS_BIOS_BUG_MSG);
> + printk_once(missing_pss_msg);
> goto err_out;
> }
> if (pol->cpu != 0) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powernow-k8: Fixup missing _PSS objects message
2012-07-18 19:50 ` Rafael J. Wysocki
@ 2012-07-18 21:05 ` Borislav Petkov
2012-09-04 23:27 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Borislav Petkov @ 2012-07-18 21:05 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: cpufreq, LKML
On Wed, Jul 18, 2012 at 09:50:51PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, July 18, 2012, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@amd.com>
> >
> > _PSS objects can also be missing if Cool'N'Quiet is disabled in the
> > BIOS. Add that to the FW_BUG message for the user to try before updating
> > her BIOS. Fix formatting while at it.
> >
> > Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
> > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
>
> I will take this, but it's kind of too late for v3.6.
Yeah, sure, whenever. I found it buried in my mbox since 3.2ish. And
since it is not urgent, you don't have to rush it for 3.6 but send it
upstream whenever you like.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powernow-k8: Fixup missing _PSS objects message
2012-07-18 21:05 ` Borislav Petkov
@ 2012-09-04 23:27 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2012-09-04 23:27 UTC (permalink / raw)
To: Borislav Petkov; +Cc: cpufreq, LKML, Linux PM list
On Wednesday, July 18, 2012, Borislav Petkov wrote:
> On Wed, Jul 18, 2012 at 09:50:51PM +0200, Rafael J. Wysocki wrote:
> > On Wednesday, July 18, 2012, Borislav Petkov wrote:
> > > From: Borislav Petkov <borislav.petkov@amd.com>
> > >
> > > _PSS objects can also be missing if Cool'N'Quiet is disabled in the
> > > BIOS. Add that to the FW_BUG message for the user to try before updating
> > > her BIOS. Fix formatting while at it.
> > >
> > > Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
> > > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
> >
> > I will take this, but it's kind of too late for v3.6.
>
> Yeah, sure, whenever. I found it buried in my mbox since 3.2ish. And
> since it is not urgent, you don't have to rush it for 3.6 but send it
> upstream whenever you like.
Applied to the linux-next branch of the linux-pm.git tree as v3.7 material.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-04 23:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 15:07 [PATCH] powernow-k8: Fixup missing _PSS objects message Borislav Petkov
2012-07-18 19:50 ` Rafael J. Wysocki
2012-07-18 21:05 ` Borislav Petkov
2012-09-04 23:27 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.