All of lore.kernel.org
 help / color / mirror / Atom feed
* + kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note.patch added to -mm tree
@ 2012-07-18 22:05 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2012-07-18 22:05 UTC (permalink / raw)
  To: mm-commits; +Cc: vgoyal, ebiederm


The patch titled
     Subject: kdump: append newline to the last lien of vmcoreinfo note
has been added to the -mm tree.  Its filename is
     kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Vivek Goyal <vgoyal@redhat.com>
Subject: kdump: append newline to the last lien of vmcoreinfo note

The last line of vmcoreinfo note does not end with \n.  Parsing all the
lines in note becomes easier if all lines end with \n instead of trying to
special case the last line.

I know at least one tool, vmcore-dmesg in kexec-tools tree which made the
assumption that all lines end with \n.  I think it is a good idea to fix
it.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/kexec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/kexec.c~kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note kernel/kexec.c
--- a/kernel/kexec.c~kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note
+++ a/kernel/kexec.c
@@ -1424,7 +1424,7 @@ static void update_vmcoreinfo_note(void)
 
 void crash_save_vmcoreinfo(void)
 {
-	vmcoreinfo_append_str("CRASHTIME=%ld", get_seconds());
+	vmcoreinfo_append_str("CRASHTIME=%ld\n", get_seconds());
 	update_vmcoreinfo_note();
 }
 
_
Subject: Subject: kdump: append newline to the last lien of vmcoreinfo note

Patches currently in -mm which might be from vgoyal@redhat.com are

kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-18 22:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-18 22:05 + kdump-append-newline-to-the-last-lien-of-vmcoreinfo-note.patch added to -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.