From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org"
<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq
Date: Tue, 24 Jul 2012 13:52:38 +0100 [thread overview]
Message-ID: <20120724125237.GB22576@sirena.org.uk> (raw)
In-Reply-To: <20120724091358.GK12034-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
On Tue, Jul 24, 2012 at 12:13:58PM +0300, Peter De Schrijver wrote:
> On Mon, Jul 23, 2012 at 08:24:38PM +0200, Stephen Warren wrote:
> > IIRC, I proposed it before solely to solve some suspend/resume ordering
> > issues, and Colin Cross NAKd it. These days, deferred probe should make
> > this change unnecessary.
> How does deferred probe solve this? Iirc the problem is that i2c is needed to
> talk to the PMIC, so we need to make sure i2c is shutdown last because drivers
> might want to do regulator control in the suspend function.
With probe deferral the drivers will be after the regulator driver in
the DPM list and so be suspended first.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
"w.sang@pengutronix.de" <w.sang@pengutronix.de>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
Stephen Warren <swarren@nvidia.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq
Date: Tue, 24 Jul 2012 13:52:38 +0100 [thread overview]
Message-ID: <20120724125237.GB22576@sirena.org.uk> (raw)
In-Reply-To: <20120724091358.GK12034@tbergstrom-lnx.Nvidia.com>
On Tue, Jul 24, 2012 at 12:13:58PM +0300, Peter De Schrijver wrote:
> On Mon, Jul 23, 2012 at 08:24:38PM +0200, Stephen Warren wrote:
> > IIRC, I proposed it before solely to solve some suspend/resume ordering
> > issues, and Colin Cross NAKd it. These days, deferred probe should make
> > this change unnecessary.
> How does deferred probe solve this? Iirc the problem is that i2c is needed to
> talk to the PMIC, so we need to make sure i2c is shutdown last because drivers
> might want to do regulator control in the suspend function.
With probe deferral the drivers will be after the regulator driver in
the DPM list and so be suspended first.
next prev parent reply other threads:[~2012-07-24 12:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 11:20 [PATCH 0/5] i2c: tegra: Code cleanups and suspend/resume related changes Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
2012-07-10 11:20 ` [PATCH 1/5] i2c: tegra: remove unused member variable Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
[not found] ` <1341919244-23327-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-10 11:33 ` Shubhrajyoti Datta
2012-07-10 11:33 ` Shubhrajyoti Datta
2012-07-10 11:20 ` [PATCH 2/5] i2c: tegra: use clk_disable_unprepare in place of clk_disable Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
[not found] ` <1341919244-23327-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-12 9:52 ` Wolfram Sang
2012-07-12 9:52 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 3/5] i2c: tegra: use of_match_ptr() for match_table initialization Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
[not found] ` <1341919244-23327-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-12 9:52 ` Wolfram Sang
2012-07-12 9:52 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 4/5] i2c: tegra: Use struct dev_pm_ops for power management Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
[not found] ` <1341919244-23327-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-12 9:53 ` Wolfram Sang
2012-07-12 9:53 ` Wolfram Sang
2012-07-10 11:20 ` [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq Laxman Dewangan
2012-07-10 11:20 ` Laxman Dewangan
[not found] ` <1341919244-23327-6-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-12 10:35 ` Wolfram Sang
2012-07-12 10:35 ` Wolfram Sang
[not found] ` <20120712103509.GF27520-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-12 10:30 ` Laxman Dewangan
2012-07-12 10:30 ` Laxman Dewangan
[not found] ` <4FFEA748.9080109-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-07-12 11:58 ` Wolfram Sang
2012-07-12 11:58 ` Wolfram Sang
[not found] ` <20120712115725.GA3772-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-07-12 11:53 ` Laxman Dewangan
2012-07-12 11:53 ` Laxman Dewangan
2012-07-23 18:24 ` Stephen Warren
[not found] ` <500D96E6.4060507-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-07-24 9:13 ` Peter De Schrijver
2012-07-24 9:13 ` Peter De Schrijver
[not found] ` <20120724091358.GK12034-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2012-07-24 12:52 ` Mark Brown [this message]
2012-07-24 12:52 ` Mark Brown
2012-07-24 15:29 ` Wolfram Sang
2012-07-24 15:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724125237.GB22576@sirena.org.uk \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.