[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Amit Daniel Kachhap]

These TMU enablement patches are needed for exynos4 and exynos5 TMU
driver patches sent earlier. The link for those are 
http://www.spinics.net/lists/lm-sensors/msg35858.html.

Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
(http://www.spinics.net/lists/arm-kernel/msg184129.html)

This patchset is based Samsung Maintainer's tree,
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next

Amit Daniel Kachhap (2):
  ARM: exynos4: Add devicetree node for TMU driver
  ARM: exynos5: Add devicetree node for TMU driver

 arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
 arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
 arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
 arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
 arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
 arch/arm/mach-exynos/include/mach/map.h  |    3 +++
 arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
 arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
 8 files changed, 33 insertions(+), 0 deletions(-)

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Amit Daniel Kachhap]

These TMU enablement patches are needed for exynos4 and exynos5 TMU
driver patches sent earlier. The link for those are 
http://www.spinics.net/lists/lm-sensors/msg35858.html.

Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
(http://www.spinics.net/lists/arm-kernel/msg184129.html)

This patchset is based Samsung Maintainer's tree,
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-next

Amit Daniel Kachhap (2):
  ARM: exynos4: Add devicetree node for TMU driver
  ARM: exynos5: Add devicetree node for TMU driver

 arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
 arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
 arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
 arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
 arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
 arch/arm/mach-exynos/include/mach/map.h  |    3 +++
 arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
 arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
 8 files changed, 33 insertions(+), 0 deletions(-)

[PATCH 1/2] ARM: exynos4: Add devicetree node for TMU driver

[Amit Daniel Kachhap]

This patch adds necessary source definations needed for TMU driver and
adds devicetree for exynos4.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
---
 arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
 arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
 arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
 arch/arm/mach-exynos/include/mach/map.h  |    2 ++
 arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
 5 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 0e4f659..7230f59 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -158,6 +158,13 @@
 		interrupts = <0 65 0>;
 	};
 
+	tmu@100C0000 {
+		compatible = "samsung,exynos4-tmu";
+		interrupt-parent = <&combiner>;
+		reg = <0x100C0000 0x100>;
+		interrupts = <2 4>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-exynos/clock-exynos4.c
index bcb7db4..1dc8606 100644
--- a/arch/arm/mach-exynos/clock-exynos4.c
+++ b/arch/arm/mach-exynos/clock-exynos4.c
@@ -564,6 +564,11 @@ static struct clk exynos4_init_clocks_off[] = {
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 15),
 	}, {
+		.name           = "tmu_apbif",
+		.enable         = exynos4_clk_ip_perir_ctrl,
+		.ctrlbit        = (1 << 17),
+	}, {
+
 		.name		= "keypad",
 		.enable		= exynos4_clk_ip_perir_ctrl,
 		.ctrlbit	= (1 << 16),
diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
index 7a4b478..f4d7bba 100644
--- a/arch/arm/mach-exynos/include/mach/irqs.h
+++ b/arch/arm/mach-exynos/include/mach/irqs.h
@@ -136,6 +136,9 @@
 #define EXYNOS4_IRQ_TSI			IRQ_SPI(115)
 #define EXYNOS4_IRQ_SATA		IRQ_SPI(116)
 
+#define EXYNOS4_IRQ_TMU_TRIG0		COMBINER_IRQ(2, 4)
+#define EXYNOS4_IRQ_TMU_TRIG1		COMBINER_IRQ(3, 4)
+
 #define EXYNOS4_IRQ_SYSMMU_MDMA0_0	COMBINER_IRQ(4, 0)
 #define EXYNOS4_IRQ_SYSMMU_SSS_0	COMBINER_IRQ(4, 1)
 #define EXYNOS4_IRQ_SYSMMU_FIMC0_0	COMBINER_IRQ(4, 2)
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index ca4aa89..c23d1c2 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -88,6 +88,8 @@
 #define EXYNOS4_PA_TWD			0x10500600
 #define EXYNOS4_PA_L2CC			0x10502000
 
+#define EXYNOS4_PA_TMU			0x100C0000
+
 #define EXYNOS4_PA_MDMA0		0x10810000
 #define EXYNOS4_PA_MDMA1		0x12840000
 #define EXYNOS4_PA_PDMA0		0x12680000
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index e7e9743..1e751f0 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -57,6 +57,8 @@ static const struct of_dev_auxdata exynos4210_auxdata_lookup[] __initconst = {
 				"s3c2440-i2c.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_PDMA0, "dma-pl330.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_PDMA1, "dma-pl330.1", NULL),
+	OF_DEV_AUXDATA("samsung,exynos4-tmu", EXYNOS4_PA_TMU,
+				"exynos-tmu", NULL),
 	{},
 };
 
-- 
1.7.1

[PATCH 1/2] ARM: exynos4: Add devicetree node for TMU driver

[Amit Daniel Kachhap]

This patch adds necessary source definations needed for TMU driver and
adds devicetree for exynos4.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
---
 arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
 arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
 arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
 arch/arm/mach-exynos/include/mach/map.h  |    2 ++
 arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
 5 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index 0e4f659..7230f59 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -158,6 +158,13 @@
 		interrupts = <0 65 0>;
 	};
 
+	tmu at 100C0000 {
+		compatible = "samsung,exynos4-tmu";
+		interrupt-parent = <&combiner>;
+		reg = <0x100C0000 0x100>;
+		interrupts = <2 4>;
+	};
+
 	amba {
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-exynos/clock-exynos4.c
index bcb7db4..1dc8606 100644
--- a/arch/arm/mach-exynos/clock-exynos4.c
+++ b/arch/arm/mach-exynos/clock-exynos4.c
@@ -564,6 +564,11 @@ static struct clk exynos4_init_clocks_off[] = {
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 15),
 	}, {
+		.name           = "tmu_apbif",
+		.enable         = exynos4_clk_ip_perir_ctrl,
+		.ctrlbit        = (1 << 17),
+	}, {
+
 		.name		= "keypad",
 		.enable		= exynos4_clk_ip_perir_ctrl,
 		.ctrlbit	= (1 << 16),
diff --git a/arch/arm/mach-exynos/include/mach/irqs.h b/arch/arm/mach-exynos/include/mach/irqs.h
index 7a4b478..f4d7bba 100644
--- a/arch/arm/mach-exynos/include/mach/irqs.h
+++ b/arch/arm/mach-exynos/include/mach/irqs.h
@@ -136,6 +136,9 @@
 #define EXYNOS4_IRQ_TSI			IRQ_SPI(115)
 #define EXYNOS4_IRQ_SATA		IRQ_SPI(116)
 
+#define EXYNOS4_IRQ_TMU_TRIG0		COMBINER_IRQ(2, 4)
+#define EXYNOS4_IRQ_TMU_TRIG1		COMBINER_IRQ(3, 4)
+
 #define EXYNOS4_IRQ_SYSMMU_MDMA0_0	COMBINER_IRQ(4, 0)
 #define EXYNOS4_IRQ_SYSMMU_SSS_0	COMBINER_IRQ(4, 1)
 #define EXYNOS4_IRQ_SYSMMU_FIMC0_0	COMBINER_IRQ(4, 2)
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index ca4aa89..c23d1c2 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -88,6 +88,8 @@
 #define EXYNOS4_PA_TWD			0x10500600
 #define EXYNOS4_PA_L2CC			0x10502000
 
+#define EXYNOS4_PA_TMU			0x100C0000
+
 #define EXYNOS4_PA_MDMA0		0x10810000
 #define EXYNOS4_PA_MDMA1		0x12840000
 #define EXYNOS4_PA_PDMA0		0x12680000
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c
index e7e9743..1e751f0 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -57,6 +57,8 @@ static const struct of_dev_auxdata exynos4210_auxdata_lookup[] __initconst = {
 				"s3c2440-i2c.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_PDMA0, "dma-pl330.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS4_PA_PDMA1, "dma-pl330.1", NULL),
+	OF_DEV_AUXDATA("samsung,exynos4-tmu", EXYNOS4_PA_TMU,
+				"exynos-tmu", NULL),
 	{},
 };
 
-- 
1.7.1

[PATCH 2/2] ARM: exynos5: Add devicetree node for TMU driver

[Amit Daniel Kachhap]

This patch adds necessary source definations needed for TMU driver and
adds devicetree for exynos5.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi       |    6 ++++++
 arch/arm/mach-exynos/clock-exynos5.c    |    5 +++++
 arch/arm/mach-exynos/include/mach/map.h |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
 4 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..9a9df51 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -58,6 +58,12 @@
 		interrupts = <0 43 0>, <0 44 0>;
 	};
 
+	tmu@10060000 {
+		compatible = "samsung,exynos5-tmu";
+		reg = <0x10060000 0x100>;
+		interrupts = <0 65 0>;
+	};
+
 	serial@12C00000 {
 		compatible = "samsung,exynos4210-uart";
 		reg = <0x12C00000 0x100>;
diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
index fefa336..30798da 100644
--- a/arch/arm/mach-exynos/clock-exynos5.c
+++ b/arch/arm/mach-exynos/clock-exynos5.c
@@ -554,6 +554,11 @@ static struct clk exynos5_init_clocks_off[] = {
 		.enable		= exynos5_clk_ip_peric_ctrl,
 		.ctrlbit	= (1 << 24),
 	}, {
+		.name		= "tmu_apbif",
+		.parent		= &exynos5_clk_aclk_66.clk,
+		.enable		= exynos5_clk_ip_peris_ctrl,
+		.ctrlbit	= (1 << 21),
+	}, {
 		.name		= "rtc",
 		.parent		= &exynos5_clk_aclk_66.clk,
 		.enable		= exynos5_clk_ip_peris_ctrl,
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index c23d1c2..4a94752 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -89,6 +89,7 @@
 #define EXYNOS4_PA_L2CC			0x10502000
 
 #define EXYNOS4_PA_TMU			0x100C0000
+#define EXYNOS5_PA_TMU			0x10060000
 
 #define EXYNOS4_PA_MDMA0		0x10810000
 #define EXYNOS4_PA_MDMA1		0x12840000
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..55f0ad8 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2", NULL),
+	OF_DEV_AUXDATA("samsung,exynos5-tmu", EXYNOS5_PA_TMU,
+				"exynos-tmu", NULL),
 	{},
 };
 
-- 
1.7.1

[PATCH 2/2] ARM: exynos5: Add devicetree node for TMU driver

[Amit Daniel Kachhap]

This patch adds necessary source definations needed for TMU driver and
adds devicetree for exynos5.

Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi       |    6 ++++++
 arch/arm/mach-exynos/clock-exynos5.c    |    5 +++++
 arch/arm/mach-exynos/include/mach/map.h |    1 +
 arch/arm/mach-exynos/mach-exynos5-dt.c  |    2 ++
 4 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 4272b29..9a9df51 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -58,6 +58,12 @@
 		interrupts = <0 43 0>, <0 44 0>;
 	};
 
+	tmu at 10060000 {
+		compatible = "samsung,exynos5-tmu";
+		reg = <0x10060000 0x100>;
+		interrupts = <0 65 0>;
+	};
+
 	serial at 12C00000 {
 		compatible = "samsung,exynos4210-uart";
 		reg = <0x12C00000 0x100>;
diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c
index fefa336..30798da 100644
--- a/arch/arm/mach-exynos/clock-exynos5.c
+++ b/arch/arm/mach-exynos/clock-exynos5.c
@@ -554,6 +554,11 @@ static struct clk exynos5_init_clocks_off[] = {
 		.enable		= exynos5_clk_ip_peric_ctrl,
 		.ctrlbit	= (1 << 24),
 	}, {
+		.name		= "tmu_apbif",
+		.parent		= &exynos5_clk_aclk_66.clk,
+		.enable		= exynos5_clk_ip_peris_ctrl,
+		.ctrlbit	= (1 << 21),
+	}, {
 		.name		= "rtc",
 		.parent		= &exynos5_clk_aclk_66.clk,
 		.enable		= exynos5_clk_ip_peris_ctrl,
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
index c23d1c2..4a94752 100644
--- a/arch/arm/mach-exynos/include/mach/map.h
+++ b/arch/arm/mach-exynos/include/mach/map.h
@@ -89,6 +89,7 @@
 #define EXYNOS4_PA_L2CC			0x10502000
 
 #define EXYNOS4_PA_TMU			0x100C0000
+#define EXYNOS5_PA_TMU			0x10060000
 
 #define EXYNOS4_PA_MDMA0		0x10810000
 #define EXYNOS4_PA_MDMA1		0x12840000
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 7b1e11a..55f0ad8 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -50,6 +50,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA0, "dma-pl330.0", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_PDMA1, "dma-pl330.1", NULL),
 	OF_DEV_AUXDATA("arm,pl330", EXYNOS5_PA_MDMA1, "dma-pl330.2", NULL),
+	OF_DEV_AUXDATA("samsung,exynos5-tmu", EXYNOS5_PA_TMU,
+				"exynos-tmu", NULL),
 	{},
 };
 
-- 
1.7.1

RE: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Kukjin Kim]

Amit Daniel Kachhap wrote:
> 
> These TMU enablement patches are needed for exynos4 and exynos5 TMU
> driver patches sent earlier. The link for those are
> http://www.spinics.net/lists/lm-sensors/msg35858.html.
> 
How was going on above patches? I can't see them you said in linux-next now,
it means if I apply this series in my tree, problem will be happened :(

Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
dev_pm_ops for pm and applied by Guenter.

Note2: would be helpful if you could do adding me in Cc of exynos tmu
patches...

> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
> 
Already in my tree.

> This patchset is based Samsung Maintainer's tree,
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
> next
> 
OK.

> Amit Daniel Kachhap (2):
>   ARM: exynos4: Add devicetree node for TMU driver
>   ARM: exynos5: Add devicetree node for TMU driver
> 
>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>  8 files changed, 33 insertions(+), 0 deletions(-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Kukjin Kim]

Amit Daniel Kachhap wrote:
> 
> These TMU enablement patches are needed for exynos4 and exynos5 TMU
> driver patches sent earlier. The link for those are
> http://www.spinics.net/lists/lm-sensors/msg35858.html.
> 
How was going on above patches? I can't see them you said in linux-next now,
it means if I apply this series in my tree, problem will be happened :(

Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
dev_pm_ops for pm and applied by Guenter.

Note2: would be helpful if you could do adding me in Cc of exynos tmu
patches...

> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
> 
Already in my tree.

> This patchset is based Samsung Maintainer's tree,
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
> next
> 
OK.

> Amit Daniel Kachhap (2):
>   ARM: exynos4: Add devicetree node for TMU driver
>   ARM: exynos5: Add devicetree node for TMU driver
> 
>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>  8 files changed, 33 insertions(+), 0 deletions(-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> Amit Daniel Kachhap wrote:
> > 
> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> > driver patches sent earlier. The link for those are
> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> > 
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(
> 
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
> 
If that is in the way, I can drop it, to be applied after the move. Let me know.
There is now another patch pending, to convert the driver to use devm_ functions.
Please let me know what you want me to do with it.

> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
> 
If you want to be copied, it might make sense to add yourself as maintainer for
this file. Otherwise you can not expect people to know.

Thanks,
Guenter

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> Amit Daniel Kachhap wrote:
> > 
> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> > driver patches sent earlier. The link for those are
> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> > 
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(
> 
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
> 
If that is in the way, I can drop it, to be applied after the move. Let me know.
There is now another patch pending, to convert the driver to use devm_ functions.
Please let me know what you want me to do with it.

> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
> 
If you want to be copied, it might make sense to add yourself as maintainer for
this file. Otherwise you can not expect people to know.

Thanks,
Guenter

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit kachhap]

On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Amit Daniel Kachhap wrote:
>>
>> These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> driver patches sent earlier. The link for those are
>> http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(

Well, the above patches were accepted by Len for 3.5 merge but could
not done because of some last minute pull issue. I hope it will go
through in this merge window. I thought it is better to get the
enablement patches also in mainline together.
>
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
I have rebased the V5 with hwmon-next changes. So this change is
already included.
>
> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
Yes sure.
>
>> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
>> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
>>
> Already in my tree.
>
>> This patchset is based Samsung Maintainer's tree,
>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
>> next
>>
> OK.
>
>> Amit Daniel Kachhap (2):
>>   ARM: exynos4: Add devicetree node for TMU driver
>>   ARM: exynos5: Add devicetree node for TMU driver
>>
>>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>>  8 files changed, 33 insertions(+), 0 deletions(-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit kachhap]

On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Amit Daniel Kachhap wrote:
>>
>> These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> driver patches sent earlier. The link for those are
>> http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(

Well, the above patches were accepted by Len for 3.5 merge but could
not done because of some last minute pull issue. I hope it will go
through in this merge window. I thought it is better to get the
enablement patches also in mainline together.
>
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
I have rebased the V5 with hwmon-next changes. So this change is
already included.
>
> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
Yes sure.
>
>> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
>> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
>>
> Already in my tree.
>
>> This patchset is based Samsung Maintainer's tree,
>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
>> next
>>
> OK.
>
>> Amit Daniel Kachhap (2):
>>   ARM: exynos4: Add devicetree node for TMU driver
>>   ARM: exynos5: Add devicetree node for TMU driver
>>
>>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>>  8 files changed, 33 insertions(+), 0 deletions(-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit kachhap]

On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
>> Amit Daniel Kachhap wrote:
>> >
>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> > driver patches sent earlier. The link for those are
>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
>> >
>> How was going on above patches? I can't see them you said in linux-next now,
>> it means if I apply this series in my tree, problem will be happened :(
>>
>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
>> dev_pm_ops for pm and applied by Guenter.
>>
> If that is in the way, I can drop it, to be applied after the move. Let me know.
> There is now another patch pending, to convert the driver to use devm_ functions.
> Please let me know what you want me to do with it.
>
Hi Guenter,

I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
changes are already included. Regarding the devm_ patch by sachin
please hold it.

Thanks,
Amit D
>> Note2: would be helpful if you could do adding me in Cc of exynos tmu
>> patches...
>>
> If you want to be copied, it might make sense to add yourself as maintainer for
> this file. Otherwise you can not expect people to know.
>
> Thanks,
> Guenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit kachhap]

On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
>> Amit Daniel Kachhap wrote:
>> >
>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> > driver patches sent earlier. The link for those are
>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
>> >
>> How was going on above patches? I can't see them you said in linux-next now,
>> it means if I apply this series in my tree, problem will be happened :(
>>
>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
>> dev_pm_ops for pm and applied by Guenter.
>>
> If that is in the way, I can drop it, to be applied after the move. Let me know.
> There is now another patch pending, to convert the driver to use devm_ functions.
> Please let me know what you want me to do with it.
>
Hi Guenter,

I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
changes are already included. Regarding the devm_ patch by sachin
please hold it.

Thanks,
Amit D
>> Note2: would be helpful if you could do adding me in Cc of exynos tmu
>> patches...
>>
> If you want to be copied, it might make sense to add yourself as maintainer for
> this file. Otherwise you can not expect people to know.
>
> Thanks,
> Guenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit daniel kachhap]

On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Amit Daniel Kachhap wrote:
>>
>> These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> driver patches sent earlier. The link for those are
>> http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(
The TMU driver patches have appeared in linux-next. If it is not late
please accept these enablement patches.
>
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
>
> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
>
>> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
>> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
>>
> Already in my tree.
>
>> This patchset is based Samsung Maintainer's tree,
>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
>> next
>>
> OK.
>
>> Amit Daniel Kachhap (2):
>>   ARM: exynos4: Add devicetree node for TMU driver
>>   ARM: exynos5: Add devicetree node for TMU driver
>>
>>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>>  8 files changed, 33 insertions(+), 0 deletions(-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[amit daniel kachhap]

On Fri, Jul 13, 2012 at 4:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Amit Daniel Kachhap wrote:
>>
>> These TMU enablement patches are needed for exynos4 and exynos5 TMU
>> driver patches sent earlier. The link for those are
>> http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>
> How was going on above patches? I can't see them you said in linux-next now,
> it means if I apply this series in my tree, problem will be happened :(
The TMU driver patches have appeared in linux-next. If it is not late
please accept these enablement patches.
>
> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> dev_pm_ops for pm and applied by Guenter.
>
> Note2: would be helpful if you could do adding me in Cc of exynos tmu
> patches...
>
>> Also patch 1 depends on combiner dt node patch sent by Thomas Abraham.
>> (http://www.spinics.net/lists/arm-kernel/msg184129.html)
>>
> Already in my tree.
>
>> This patchset is based Samsung Maintainer's tree,
>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git for-
>> next
>>
> OK.
>
>> Amit Daniel Kachhap (2):
>>   ARM: exynos4: Add devicetree node for TMU driver
>>   ARM: exynos5: Add devicetree node for TMU driver
>>
>>  arch/arm/boot/dts/exynos4210.dtsi        |    7 +++++++
>>  arch/arm/boot/dts/exynos5250.dtsi        |    6 ++++++
>>  arch/arm/mach-exynos/clock-exynos4.c     |    5 +++++
>>  arch/arm/mach-exynos/clock-exynos5.c     |    5 +++++
>>  arch/arm/mach-exynos/include/mach/irqs.h |    3 +++
>>  arch/arm/mach-exynos/include/mach/map.h  |    3 +++
>>  arch/arm/mach-exynos/mach-exynos4-dt.c   |    2 ++
>>  arch/arm/mach-exynos/mach-exynos5-dt.c   |    2 ++
>>  8 files changed, 33 insertions(+), 0 deletions(-)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Sachin Kamat]

Hi Amit,

On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
>>> Amit Daniel Kachhap wrote:
>>> >
>>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
>>> > driver patches sent earlier. The link for those are
>>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>> >
>>> How was going on above patches? I can't see them you said in linux-next now,
>>> it means if I apply this series in my tree, problem will be happened :(
>>>
>>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
>>> dev_pm_ops for pm and applied by Guenter.
>>>
>> If that is in the way, I can drop it, to be applied after the move. Let me know.
>> There is now another patch pending, to convert the driver to use devm_ functions.
>> Please let me know what you want me to do with it.
>>
> Hi Guenter,
>
> I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> changes are already included. Regarding the devm_ patch by sachin
> please hold it.

Guenter has already sent the pull request to Linus for v3.6 [1].
That does not include your patches. I do not understand why you want
to hold back my patch when you can rebase your series on top of it.

[1] https://lkml.org/lkml/2012/7/23/414



>
> Thanks,
> Amit D
>>> Note2: would be helpful if you could do adding me in Cc of exynos tmu
>>> patches...
>>>
>> If you want to be copied, it might make sense to add yourself as maintainer for
>> this file. Otherwise you can not expect people to know.
>>
>> Thanks,
>> Guenter
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With warm regards,
Sachin

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Sachin Kamat]

Hi Amit,

On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
>> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
>>> Amit Daniel Kachhap wrote:
>>> >
>>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
>>> > driver patches sent earlier. The link for those are
>>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
>>> >
>>> How was going on above patches? I can't see them you said in linux-next now,
>>> it means if I apply this series in my tree, problem will be happened :(
>>>
>>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
>>> dev_pm_ops for pm and applied by Guenter.
>>>
>> If that is in the way, I can drop it, to be applied after the move. Let me know.
>> There is now another patch pending, to convert the driver to use devm_ functions.
>> Please let me know what you want me to do with it.
>>
> Hi Guenter,
>
> I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> changes are already included. Regarding the devm_ patch by sachin
> please hold it.

Guenter has already sent the pull request to Linus for v3.6 [1].
That does not include your patches. I do not understand why you want
to hold back my patch when you can rebase your series on top of it.

[1] https://lkml.org/lkml/2012/7/23/414



>
> Thanks,
> Amit D
>>> Note2: would be helpful if you could do adding me in Cc of exynos tmu
>>> patches...
>>>
>> If you want to be copied, it might make sense to add yourself as maintainer for
>> this file. Otherwise you can not expect people to know.
>>
>> Thanks,
>> Guenter
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With warm regards,
Sachin

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote:
> Hi Amit,
> 
> On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> >>> Amit Daniel Kachhap wrote:
> >>> >
> >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> >>> > driver patches sent earlier. The link for those are
> >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> >>> >
> >>> How was going on above patches? I can't see them you said in linux-next now,
> >>> it means if I apply this series in my tree, problem will be happened :(
> >>>
> >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> >>> dev_pm_ops for pm and applied by Guenter.
> >>>
> >> If that is in the way, I can drop it, to be applied after the move. Let me know.
> >> There is now another patch pending, to convert the driver to use devm_ functions.
> >> Please let me know what you want me to do with it.
> >>
> > Hi Guenter,
> >
> > I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> > changes are already included. Regarding the devm_ patch by sachin
> > please hold it.
> 
> Guenter has already sent the pull request to Linus for v3.6 [1].
> That does not include your patches. I do not understand why you want
> to hold back my patch when you can rebase your series on top of it.
> 
> [1] https://lkml.org/lkml/2012/7/23/414
> 
Linus doesn't like rebases, especially not from one tree to another.
As it is, it may even be that he rejects my pull request because I rebased
to 3.5 before sending the pull request to him (I'll definitely not do that
again).

In addition, it may well be that some of your changes no longer apply
after the driver moved to its new location. So it is overall safer to move
the driver first, and convert it to devm_ functions afterwards.

If anything, I should not have applied Rafael's patch to the driver either.

Guenter

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote:
> Hi Amit,
> 
> On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> >>> Amit Daniel Kachhap wrote:
> >>> >
> >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> >>> > driver patches sent earlier. The link for those are
> >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> >>> >
> >>> How was going on above patches? I can't see them you said in linux-next now,
> >>> it means if I apply this series in my tree, problem will be happened :(
> >>>
> >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> >>> dev_pm_ops for pm and applied by Guenter.
> >>>
> >> If that is in the way, I can drop it, to be applied after the move. Let me know.
> >> There is now another patch pending, to convert the driver to use devm_ functions.
> >> Please let me know what you want me to do with it.
> >>
> > Hi Guenter,
> >
> > I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> > changes are already included. Regarding the devm_ patch by sachin
> > please hold it.
> 
> Guenter has already sent the pull request to Linus for v3.6 [1].
> That does not include your patches. I do not understand why you want
> to hold back my patch when you can rebase your series on top of it.
> 
> [1] https://lkml.org/lkml/2012/7/23/414
> 
Linus doesn't like rebases, especially not from one tree to another.
As it is, it may even be that he rejects my pull request because I rebased
to 3.5 before sending the pull request to him (I'll definitely not do that
again).

In addition, it may well be that some of your changes no longer apply
after the driver moved to its new location. So it is overall safer to move
the driver first, and convert it to devm_ functions afterwards.

If anything, I should not have applied Rafael's patch to the driver either.

Guenter

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Rafael J. Wysocki]

On Tuesday, July 24, 2012, Guenter Roeck wrote:
> On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote:
> > Hi Amit,
> > 
> > On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> > > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> > >>> Amit Daniel Kachhap wrote:
> > >>> >
> > >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> > >>> > driver patches sent earlier. The link for those are
> > >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> > >>> >
> > >>> How was going on above patches? I can't see them you said in linux-next now,
> > >>> it means if I apply this series in my tree, problem will be happened :(
> > >>>
> > >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> > >>> dev_pm_ops for pm and applied by Guenter.
> > >>>
> > >> If that is in the way, I can drop it, to be applied after the move. Let me know.
> > >> There is now another patch pending, to convert the driver to use devm_ functions.
> > >> Please let me know what you want me to do with it.
> > >>
> > > Hi Guenter,
> > >
> > > I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> > > changes are already included. Regarding the devm_ patch by sachin
> > > please hold it.
> > 
> > Guenter has already sent the pull request to Linus for v3.6 [1].
> > That does not include your patches. I do not understand why you want
> > to hold back my patch when you can rebase your series on top of it.
> > 
> > [1] https://lkml.org/lkml/2012/7/23/414
> > 
> Linus doesn't like rebases, especially not from one tree to another.
> As it is, it may even be that he rejects my pull request because I rebased
> to 3.5 before sending the pull request to him (I'll definitely not do that
> again).
> 
> In addition, it may well be that some of your changes no longer apply
> after the driver moved to its new location. So it is overall safer to move
> the driver first, and convert it to devm_ functions afterwards.
> 
> If anything, I should not have applied Rafael's patch to the driver either.

Well, it looks like I sent it at a wrong time.  Sorry about that.

Rafael

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Rafael J. Wysocki]

On Tuesday, July 24, 2012, Guenter Roeck wrote:
> On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote:
> > Hi Amit,
> > 
> > On 14 July 2012 12:55, amit kachhap <amit.kachhap@gmail.com> wrote:
> > > On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > >> On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
> > >>> Amit Daniel Kachhap wrote:
> > >>> >
> > >>> > These TMU enablement patches are needed for exynos4 and exynos5 TMU
> > >>> > driver patches sent earlier. The link for those are
> > >>> > http://www.spinics.net/lists/lm-sensors/msg35858.html.
> > >>> >
> > >>> How was going on above patches? I can't see them you said in linux-next now,
> > >>> it means if I apply this series in my tree, problem will be happened :(
> > >>>
> > >>> Note1: I've seen Rafael's updating exynos4_tmu patch which is using struct
> > >>> dev_pm_ops for pm and applied by Guenter.
> > >>>
> > >> If that is in the way, I can drop it, to be applied after the move. Let me know.
> > >> There is now another patch pending, to convert the driver to use devm_ functions.
> > >> Please let me know what you want me to do with it.
> > >>
> > > Hi Guenter,
> > >
> > > I rebased my V5 patch series with  hwmon-next branch so Rafael's pm
> > > changes are already included. Regarding the devm_ patch by sachin
> > > please hold it.
> > 
> > Guenter has already sent the pull request to Linus for v3.6 [1].
> > That does not include your patches. I do not understand why you want
> > to hold back my patch when you can rebase your series on top of it.
> > 
> > [1] https://lkml.org/lkml/2012/7/23/414
> > 
> Linus doesn't like rebases, especially not from one tree to another.
> As it is, it may even be that he rejects my pull request because I rebased
> to 3.5 before sending the pull request to him (I'll definitely not do that
> again).
> 
> In addition, it may well be that some of your changes no longer apply
> after the driver moved to its new location. So it is overall safer to move
> the driver first, and convert it to devm_ functions afterwards.
> 
> If anything, I should not have applied Rafael's patch to the driver either.

Well, it looks like I sent it at a wrong time.  Sorry about that.

Rafael

Re: [PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Tue, Jul 24, 2012 at 09:53:11PM +0200, Rafael J. Wysocki wrote:
[ ... ]
> > If anything, I should not have applied Rafael's patch to the driver either.
> 
> Well, it looks like I sent it at a wrong time.  Sorry about that.
> 
My fault, not yours.

Guenter

[PATCH 0/2] ARM: exynos: Enable TMU support in exynos platforms

[Guenter Roeck]

On Tue, Jul 24, 2012 at 09:53:11PM +0200, Rafael J. Wysocki wrote:
[ ... ]
> > If anything, I should not have applied Rafael's patch to the driver either.
> 
> Well, it looks like I sent it at a wrong time.  Sorry about that.
> 
My fault, not yours.

Guenter