* [PATCH] sh: pfc: Fix build issues in pinctrl.c
@ 2012-07-27 22:07 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2012-07-27 22:07 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linux-sh list, LKML, Magnus Damm
First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
sh_pfc_pinctrl_remove() uses the function that has been removed by
that commit. Fix this by removing the pinctrl_remove_gpio_range()
call, which is not necessary any more, from sh_pfc_pinctrl_remove().
Second, the compiler complains correctly that there's an unused
local variable in sh_pfc_pinconf_set(). Fix this by removing the
definition of that variable.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/sh/pfc/pinctrl.c | 2 --
1 file changed, 2 deletions(-)
Index: linux/drivers/sh/pfc/pinctrl.c
=================================--- linux.orig/drivers/sh/pfc/pinctrl.c
+++ linux/drivers/sh/pfc/pinctrl.c
@@ -276,7 +276,6 @@ static int sh_pfc_pinconf_set(struct pin
unsigned long config)
{
struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
- struct sh_pfc *pfc = pmx->pfc;
/* Validate the new type */
if (config >= PINMUX_FLAG_TYPE)
@@ -481,7 +480,6 @@ static int __devexit sh_pfc_pinctrl_remo
{
struct sh_pfc_pinctrl *pmx = platform_get_drvdata(pdev);
- pinctrl_remove_gpio_range(pmx->pctl, &sh_pfc_gpio_range);
pinctrl_unregister(pmx->pctl);
platform_set_drvdata(pdev, NULL);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] sh: pfc: Fix build issues in pinctrl.c
@ 2012-07-27 22:07 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2012-07-27 22:07 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linux-sh list, LKML, Magnus Damm
First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
sh_pfc_pinctrl_remove() uses the function that has been removed by
that commit. Fix this by removing the pinctrl_remove_gpio_range()
call, which is not necessary any more, from sh_pfc_pinctrl_remove().
Second, the compiler complains correctly that there's an unused
local variable in sh_pfc_pinconf_set(). Fix this by removing the
definition of that variable.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/sh/pfc/pinctrl.c | 2 --
1 file changed, 2 deletions(-)
Index: linux/drivers/sh/pfc/pinctrl.c
===================================================================
--- linux.orig/drivers/sh/pfc/pinctrl.c
+++ linux/drivers/sh/pfc/pinctrl.c
@@ -276,7 +276,6 @@ static int sh_pfc_pinconf_set(struct pin
unsigned long config)
{
struct sh_pfc_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev);
- struct sh_pfc *pfc = pmx->pfc;
/* Validate the new type */
if (config >= PINMUX_FLAG_TYPE)
@@ -481,7 +480,6 @@ static int __devexit sh_pfc_pinctrl_remo
{
struct sh_pfc_pinctrl *pmx = platform_get_drvdata(pdev);
- pinctrl_remove_gpio_range(pmx->pctl, &sh_pfc_gpio_range);
pinctrl_unregister(pmx->pctl);
platform_set_drvdata(pdev, NULL);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
2012-07-27 22:07 ` Rafael J. Wysocki
@ 2012-07-28 0:29 ` Paul Mundt
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2012-07-28 0:29 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux-sh list, LKML, Magnus Damm
On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
>
> First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> sh_pfc_pinctrl_remove() uses the function that has been removed by
> that commit. Fix this by removing the pinctrl_remove_gpio_range()
> call, which is not necessary any more, from sh_pfc_pinctrl_remove().
>
> Second, the compiler complains correctly that there's an unused
> local variable in sh_pfc_pinconf_set(). Fix this by removing the
> definition of that variable.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
@ 2012-07-28 0:29 ` Paul Mundt
0 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2012-07-28 0:29 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux-sh list, LKML, Magnus Damm
On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
>
> First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> sh_pfc_pinctrl_remove() uses the function that has been removed by
> that commit. Fix this by removing the pinctrl_remove_gpio_range()
> call, which is not necessary any more, from sh_pfc_pinctrl_remove().
>
> Second, the compiler complains correctly that there's an unused
> local variable in sh_pfc_pinconf_set(). Fix this by removing the
> definition of that variable.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
2012-07-28 0:29 ` Paul Mundt
@ 2012-07-28 13:13 ` Rafael J. Wysocki
-1 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2012-07-28 13:13 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linux-sh list, LKML, Magnus Damm
On Saturday, July 28, 2012, Paul Mundt wrote:
> On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
> >
> > First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> > 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> > sh_pfc_pinctrl_remove() uses the function that has been removed by
> > that commit. Fix this by removing the pinctrl_remove_gpio_range()
> > call, which is not necessary any more, from sh_pfc_pinctrl_remove().
> >
> > Second, the compiler complains correctly that there's an unused
> > local variable in sh_pfc_pinconf_set(). Fix this by removing the
> > definition of that variable.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
> patch.
I must have overlooked that one. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sh: pfc: Fix build issues in pinctrl.c
@ 2012-07-28 13:13 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2012-07-28 13:13 UTC (permalink / raw)
To: Paul Mundt; +Cc: Linux-sh list, LKML, Magnus Damm
On Saturday, July 28, 2012, Paul Mundt wrote:
> On Sat, Jul 28, 2012 at 12:07:04AM +0200, Rafael J. Wysocki wrote:
> >
> > First off, drivers/sh/pfc/pinctrl.c doesn't build after commit
> > 5d589b0 (pinctrl: remove pinctrl_remove_gpio_range), because
> > sh_pfc_pinctrl_remove() uses the function that has been removed by
> > that commit. Fix this by removing the pinctrl_remove_gpio_range()
> > call, which is not necessary any more, from sh_pfc_pinctrl_remove().
> >
> > Second, the compiler complains correctly that there's an unused
> > local variable in sh_pfc_pinconf_set(). Fix this by removing the
> > definition of that variable.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> Already fixed in my tree, as pointed out when Iwamatsu-san sent the same
> patch.
I must have overlooked that one. Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-28 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-27 22:07 [PATCH] sh: pfc: Fix build issues in pinctrl.c Rafael J. Wysocki
2012-07-27 22:07 ` Rafael J. Wysocki
2012-07-28 0:29 ` Paul Mundt
2012-07-28 0:29 ` Paul Mundt
2012-07-28 13:13 ` Rafael J. Wysocki
2012-07-28 13:13 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.