* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
@ 2012-07-27 19:50 Marek Vasut
2012-07-30 6:32 ` Prafulla Wadaskar
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Marek Vasut @ 2012-07-27 19:50 UTC (permalink / raw)
To: u-boot
Apply the following questionable adjustment to silence GCC.
armada100_fec.c: In function ?armdfec_send?:
armada100_fec.c:589:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Joe Hershberger <joe.hershberger@ni.com>
---
drivers/net/armada100_fec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/armada100_fec.c b/drivers/net/armada100_fec.c
index d318a36..ed7cf20 100644
--- a/drivers/net/armada100_fec.c
+++ b/drivers/net/armada100_fec.c
@@ -565,7 +565,7 @@ static int armdfec_send(struct eth_device *dev, void *dataptr, int datasize)
struct tx_desc *p_txdesc = darmdfec->p_txdesc;
void *p = (void *)dataptr;
int retry = PHY_WAIT_ITERATIONS * PHY_WAIT_MICRO_SECONDS;
- u32 cmd_sts;
+ u32 cmd_sts, temp;
/* Copy buffer if it's misaligned */
if ((u32)dataptr & 0x07) {
@@ -586,7 +586,8 @@ static int armdfec_send(struct eth_device *dev, void *dataptr, int datasize)
p_txdesc->byte_cnt = datasize;
/* Apply send command using high priority TX queue */
- writel((u32)p_txdesc, ®s->txcdp[TXQ]);
+ temp = (u32)®s->txcdp[TXQ];
+ writel((u32)p_txdesc, temp);
writel(SDMA_CMD_TXDL | SDMA_CMD_TXDH | SDMA_CMD_ERD, ®s->sdma_cmd);
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-27 19:50 [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver Marek Vasut
@ 2012-07-30 6:32 ` Prafulla Wadaskar
2012-07-30 6:35 ` Marek Vasut
2012-09-03 9:09 ` Prafulla Wadaskar
2012-09-28 15:53 ` [U-Boot] [U-Boot-DM] " Joe Hershberger
2 siblings, 1 reply; 8+ messages in thread
From: Prafulla Wadaskar @ 2012-07-30 6:32 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> bounces at lists.denx.de] On Behalf Of Marek Vasut
> Sent: 28 July 2012 01:20
> To: u-boot at lists.denx.de
> Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
> Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
>
> Apply the following questionable adjustment to silence GCC.
>
> armada100_fec.c: In function 'armdfec_send':
> armada100_fec.c:589:2: warning: dereferencing type-punned pointer will
> break strict-aliasing rules [-Wstrict-aliasing]
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> ---
> drivers/net/armada100_fec.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/armada100_fec.c b/drivers/net/armada100_fec.c
> index d318a36..ed7cf20 100644
> --- a/drivers/net/armada100_fec.c
> +++ b/drivers/net/armada100_fec.c
> @@ -565,7 +565,7 @@ static int armdfec_send(struct eth_device *dev,
> void *dataptr, int datasize)
> struct tx_desc *p_txdesc = darmdfec->p_txdesc;
> void *p = (void *)dataptr;
> int retry = PHY_WAIT_ITERATIONS * PHY_WAIT_MICRO_SECONDS;
> - u32 cmd_sts;
> + u32 cmd_sts, temp;
>
> /* Copy buffer if it's misaligned */
> if ((u32)dataptr & 0x07) {
> @@ -586,7 +586,8 @@ static int armdfec_send(struct eth_device *dev,
> void *dataptr, int datasize)
> p_txdesc->byte_cnt = datasize;
>
> /* Apply send command using high priority TX queue */
> - writel((u32)p_txdesc, ®s->txcdp[TXQ]);
> + temp = (u32)®s->txcdp[TXQ];
> + writel((u32)p_txdesc, temp);
> writel(SDMA_CMD_TXDL | SDMA_CMD_TXDH | SDMA_CMD_ERD, ®s-
> >sdma_cmd);
>
> /*
> --
Acked-By: Prafulla Wadaskar <prafulla@marvell.com>
Regards...
Prafulla . . .
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-30 6:32 ` Prafulla Wadaskar
@ 2012-07-30 6:35 ` Marek Vasut
2012-07-30 15:24 ` Joe Hershberger
0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2012-07-30 6:35 UTC (permalink / raw)
To: u-boot
Dear Prafulla Wadaskar,
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> > bounces at lists.denx.de] On Behalf Of Marek Vasut
> > Sent: 28 July 2012 01:20
> > To: u-boot at lists.denx.de
> > Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
> > Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
> >
> > Apply the following questionable adjustment to silence GCC.
> >
> > armada100_fec.c: In function 'armdfec_send':
> > armada100_fec.c:589:2: warning: dereferencing type-punned pointer will
> > break strict-aliasing rules [-Wstrict-aliasing]
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Joe Hershberger <joe.hershberger@ni.com>
[...]
Joe, can you please pick this for -next (or -master already?) ?
> Acked-By: Prafulla Wadaskar <prafulla@marvell.com>
>
> Regards...
> Prafulla . . .
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-30 6:35 ` Marek Vasut
@ 2012-07-30 15:24 ` Joe Hershberger
2012-07-30 15:35 ` Marek Vasut
0 siblings, 1 reply; 8+ messages in thread
From: Joe Hershberger @ 2012-07-30 15:24 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Mon, Jul 30, 2012 at 1:35 AM, Marek Vasut <marex@denx.de> wrote:
> Dear Prafulla Wadaskar,
>
>> > -----Original Message-----
>> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
>> > bounces at lists.denx.de] On Behalf Of Marek Vasut
>> > Sent: 28 July 2012 01:20
>> > To: u-boot at lists.denx.de
>> > Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
>> > Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
>> >
>> > Apply the following questionable adjustment to silence GCC.
>> >
>> > armada100_fec.c: In function 'armdfec_send':
>> > armada100_fec.c:589:2: warning: dereferencing type-punned pointer will
>> > break strict-aliasing rules [-Wstrict-aliasing]
>> >
>> > Signed-off-by: Marek Vasut <marex@denx.de>
>> > Cc: Joe Hershberger <joe.hershberger@ni.com>
> [...]
>
> Joe, can you please pick this for -next (or -master already?) ?
OK... I figured this was just an RFC, since it was sent to the u-boot-dm list.
I'll pull it into master after release.
Thanks,
-Joe
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-30 15:24 ` Joe Hershberger
@ 2012-07-30 15:35 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2012-07-30 15:35 UTC (permalink / raw)
To: u-boot
Dear Joe Hershberger,
> Hi Marek,
>
> On Mon, Jul 30, 2012 at 1:35 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Prafulla Wadaskar,
> >
> >> > -----Original Message-----
> >> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> >> > bounces at lists.denx.de] On Behalf Of Marek Vasut
> >> > Sent: 28 July 2012 01:20
> >> > To: u-boot at lists.denx.de
> >> > Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
> >> > Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
> >> >
> >> > Apply the following questionable adjustment to silence GCC.
> >> >
> >> > armada100_fec.c: In function 'armdfec_send':
> >> > armada100_fec.c:589:2: warning: dereferencing type-punned pointer will
> >> > break strict-aliasing rules [-Wstrict-aliasing]
> >> >
> >> > Signed-off-by: Marek Vasut <marex@denx.de>
> >> > Cc: Joe Hershberger <joe.hershberger@ni.com>
> >
> > [...]
> >
> > Joe, can you please pick this for -next (or -master already?) ?
>
> OK... I figured this was just an RFC, since it was sent to the u-boot-dm
> list.
That was a bad choice to cross post it to both MLs ... and I was already told
so, quite a lot.
> I'll pull it into master after release.
>
> Thanks,
> -Joe
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-27 19:50 [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver Marek Vasut
2012-07-30 6:32 ` Prafulla Wadaskar
@ 2012-09-03 9:09 ` Prafulla Wadaskar
2012-09-06 1:50 ` Joe Hershberger
2012-09-28 15:53 ` [U-Boot] [U-Boot-DM] " Joe Hershberger
2 siblings, 1 reply; 8+ messages in thread
From: Prafulla Wadaskar @ 2012-09-03 9:09 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Prafulla Wadaskar
> Sent: 30 July 2012 12:02
> To: 'Marek Vasut'; u-boot at lists.denx.de
> Cc: Joe Hershberger; u-boot-dm at lists.denx.de
> Subject: RE: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
>
>
>
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> > bounces at lists.denx.de] On Behalf Of Marek Vasut
> > Sent: 28 July 2012 01:20
> > To: u-boot at lists.denx.de
> > Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
> > Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
> >
> > Apply the following questionable adjustment to silence GCC.
> >
> > armada100_fec.c: In function 'armdfec_send':
> > armada100_fec.c:589:2: warning: dereferencing type-punned pointer
> will
> > break strict-aliasing rules [-Wstrict-aliasing]
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Joe Hershberger <joe.hershberger@ni.com>
> > ---
> > drivers/net/armada100_fec.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/armada100_fec.c
> b/drivers/net/armada100_fec.c
> > index d318a36..ed7cf20 100644
> > --- a/drivers/net/armada100_fec.c
> > +++ b/drivers/net/armada100_fec.c
> > @@ -565,7 +565,7 @@ static int armdfec_send(struct eth_device *dev,
> > void *dataptr, int datasize)
> > struct tx_desc *p_txdesc = darmdfec->p_txdesc;
> > void *p = (void *)dataptr;
> > int retry = PHY_WAIT_ITERATIONS * PHY_WAIT_MICRO_SECONDS;
> > - u32 cmd_sts;
> > + u32 cmd_sts, temp;
> >
> > /* Copy buffer if it's misaligned */
> > if ((u32)dataptr & 0x07) {
> > @@ -586,7 +586,8 @@ static int armdfec_send(struct eth_device *dev,
> > void *dataptr, int datasize)
> > p_txdesc->byte_cnt = datasize;
> >
> > /* Apply send command using high priority TX queue */
> > - writel((u32)p_txdesc, ®s->txcdp[TXQ]);
> > + temp = (u32)®s->txcdp[TXQ];
> > + writel((u32)p_txdesc, temp);
> > writel(SDMA_CMD_TXDL | SDMA_CMD_TXDH | SDMA_CMD_ERD, ®s-
> > >sdma_cmd);
> >
> > /*
> > --
>
> Acked-By: Prafulla Wadaskar <prafulla@marvell.com>
Hi Joe
May you please pull this patch?
Regards...
Prafulla . . .
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-09-03 9:09 ` Prafulla Wadaskar
@ 2012-09-06 1:50 ` Joe Hershberger
0 siblings, 0 replies; 8+ messages in thread
From: Joe Hershberger @ 2012-09-06 1:50 UTC (permalink / raw)
To: u-boot
Hi Prafulla,
On Mon, Sep 3, 2012 at 4:09 AM, Prafulla Wadaskar <prafulla@marvell.com> wrote:
>
>
>> -----Original Message-----
>> From: Prafulla Wadaskar
>> Sent: 30 July 2012 12:02
>> To: 'Marek Vasut'; u-boot at lists.denx.de
>> Cc: Joe Hershberger; u-boot-dm at lists.denx.de
>> Subject: RE: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
>>
>>
>>
>> > -----Original Message-----
>> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
>> > bounces at lists.denx.de] On Behalf Of Marek Vasut
>> > Sent: 28 July 2012 01:20
>> > To: u-boot at lists.denx.de
>> > Cc: Marek Vasut; Joe Hershberger; u-boot-dm at lists.denx.de
>> > Subject: [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver
>> >
>> > Apply the following questionable adjustment to silence GCC.
>> >
>> > armada100_fec.c: In function 'armdfec_send':
>> > armada100_fec.c:589:2: warning: dereferencing type-punned pointer
>> will
>> > break strict-aliasing rules [-Wstrict-aliasing]
>> >
>> > Signed-off-by: Marek Vasut <marex@denx.de>
>> > Cc: Joe Hershberger <joe.hershberger@ni.com>
>> > ---
>> > drivers/net/armada100_fec.c | 5 +++--
>> > 1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/armada100_fec.c
>> b/drivers/net/armada100_fec.c
>> > index d318a36..ed7cf20 100644
>> > --- a/drivers/net/armada100_fec.c
>> > +++ b/drivers/net/armada100_fec.c
>> > @@ -565,7 +565,7 @@ static int armdfec_send(struct eth_device *dev,
>> > void *dataptr, int datasize)
>> > struct tx_desc *p_txdesc = darmdfec->p_txdesc;
>> > void *p = (void *)dataptr;
>> > int retry = PHY_WAIT_ITERATIONS * PHY_WAIT_MICRO_SECONDS;
>> > - u32 cmd_sts;
>> > + u32 cmd_sts, temp;
>> >
>> > /* Copy buffer if it's misaligned */
>> > if ((u32)dataptr & 0x07) {
>> > @@ -586,7 +586,8 @@ static int armdfec_send(struct eth_device *dev,
>> > void *dataptr, int datasize)
>> > p_txdesc->byte_cnt = datasize;
>> >
>> > /* Apply send command using high priority TX queue */
>> > - writel((u32)p_txdesc, ®s->txcdp[TXQ]);
>> > + temp = (u32)®s->txcdp[TXQ];
>> > + writel((u32)p_txdesc, temp);
>> > writel(SDMA_CMD_TXDL | SDMA_CMD_TXDH | SDMA_CMD_ERD, ®s-
>> > >sdma_cmd);
>> >
>> > /*
>> > --
>>
>> Acked-By: Prafulla Wadaskar <prafulla@marvell.com>
>
> Hi Joe
> May you please pull this patch?
It's in my queue on patchwork. I'll try to get to the back-log next week.
Cheers!
-Joe
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [U-Boot-DM] [PATCH] dm: net: Fixup the armada100 FEC driver
2012-07-27 19:50 [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver Marek Vasut
2012-07-30 6:32 ` Prafulla Wadaskar
2012-09-03 9:09 ` Prafulla Wadaskar
@ 2012-09-28 15:53 ` Joe Hershberger
2 siblings, 0 replies; 8+ messages in thread
From: Joe Hershberger @ 2012-09-28 15:53 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Fri, Jul 27, 2012 at 2:50 PM, Marek Vasut <marex@denx.de> wrote:
> Apply the following questionable adjustment to silence GCC.
>
> armada100_fec.c: In function ?armdfec_send?:
> armada100_fec.c:589:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
Applied, thanks.
-Joe
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-09-28 15:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-27 19:50 [U-Boot] [PATCH] dm: net: Fixup the armada100 FEC driver Marek Vasut
2012-07-30 6:32 ` Prafulla Wadaskar
2012-07-30 6:35 ` Marek Vasut
2012-07-30 15:24 ` Joe Hershberger
2012-07-30 15:35 ` Marek Vasut
2012-09-03 9:09 ` Prafulla Wadaskar
2012-09-06 1:50 ` Joe Hershberger
2012-09-28 15:53 ` [U-Boot] [U-Boot-DM] " Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.