From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se,
ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org,
lrg@ti.com
Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
Date: Mon, 30 Jul 2012 16:01:30 +0100 [thread overview]
Message-ID: <20120730150129.GF4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <501692B8.6050102@linaro.org>
On Mon, Jul 30, 2012 at 02:57:12PM +0100, Lee Jones wrote:
> On 30/07/12 14:39, Mark Brown wrote:
> >Why does the driver care - doesn't the pinctrl abstraction and/or
> >bindings handle this sensibly?
> Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0,
> MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only
> then did it fail. Would it be more sane to retract the error
> messages and just let it fail silently? It's either that or have
> lots of "could not get MSP defstate" clogging up the log.
This sounds to me like we should be ensuring that there's a single
fixed state available for these MSPs (representing the fact that the
pins are always in the right mode) in the pinctrl bindings.
As with several of other changes for this platform it seems like we need
to think carefully about the abstraction level we're working at.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org,
linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com, lrg@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
Date: Mon, 30 Jul 2012 16:01:30 +0100 [thread overview]
Message-ID: <20120730150129.GF4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <501692B8.6050102@linaro.org>
On Mon, Jul 30, 2012 at 02:57:12PM +0100, Lee Jones wrote:
> On 30/07/12 14:39, Mark Brown wrote:
> >Why does the driver care - doesn't the pinctrl abstraction and/or
> >bindings handle this sensibly?
> Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0,
> MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only
> then did it fail. Would it be more sane to retract the error
> messages and just let it fail silently? It's either that or have
> lots of "could not get MSP defstate" clogging up the log.
This sounds to me like we should be ensuring that there's a single
fixed state available for these MSPs (representing the fact that the
pins are always in the right mode) in the pinctrl bindings.
As with several of other changes for this platform it seems like we need
to think carefully about the abstraction level we're working at.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree
Date: Mon, 30 Jul 2012 16:01:30 +0100 [thread overview]
Message-ID: <20120730150129.GF4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <501692B8.6050102@linaro.org>
On Mon, Jul 30, 2012 at 02:57:12PM +0100, Lee Jones wrote:
> On 30/07/12 14:39, Mark Brown wrote:
> >Why does the driver care - doesn't the pinctrl abstraction and/or
> >bindings handle this sensibly?
> Not when I tested it. pinctrl_get() came back !IS_ERR() for MSP0,
> MSP2 & MSP3, then when it went on to pinctrl_lookup_state(), only
> then did it fail. Would it be more sane to retract the error
> messages and just let it fail silently? It's either that or have
> lots of "could not get MSP defstate" clogging up the log.
This sounds to me like we should be ensuring that there's a single
fixed state available for these MSPs (representing the fact that the
pins are always in the right mode) in the pinctrl bindings.
As with several of other changes for this platform it seems like we need
to think carefully about the abstraction level we're working at.
next prev parent reply other threads:[~2012-07-30 15:01 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 12:45 [PATCH 00/18] Configure ux500 Audio Drivers for Device Tree Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 01/18] Documentation: Describe the ux500 realated audio related DT nodes Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-29 20:31 ` Mark Brown
2012-07-29 20:31 ` Mark Brown
2012-07-29 20:31 ` Mark Brown
2012-07-30 7:38 ` Lee Jones
2012-07-30 7:38 ` Lee Jones
2012-07-30 7:38 ` Lee Jones
2012-07-30 13:48 ` Mark Brown
2012-07-30 13:48 ` Mark Brown
2012-07-30 13:48 ` Mark Brown
2012-07-30 14:32 ` Lee Jones
2012-07-30 14:32 ` Lee Jones
2012-07-30 14:32 ` Lee Jones
2012-07-30 15:07 ` Mark Brown
2012-07-30 15:07 ` Mark Brown
2012-07-30 15:07 ` Mark Brown
2012-07-27 12:45 ` [PATCH 02/18] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 03/18] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 04/18] ASoC: Ux500: Enable ux500 PCM " Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP " Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-29 20:42 ` Mark Brown
2012-07-29 20:42 ` Mark Brown
2012-07-29 20:42 ` Mark Brown
2012-07-30 6:53 ` Lee Jones
2012-07-30 6:53 ` Lee Jones
2012-07-30 6:53 ` Lee Jones
2012-07-30 13:39 ` Mark Brown
2012-07-30 13:39 ` Mark Brown
2012-07-30 13:39 ` Mark Brown
2012-07-30 13:57 ` Lee Jones
2012-07-30 13:57 ` Lee Jones
2012-07-30 13:57 ` Lee Jones
2012-07-30 15:01 ` Mark Brown [this message]
2012-07-30 15:01 ` Mark Brown
2012-07-30 15:01 ` Mark Brown
2012-07-27 12:45 ` [PATCH 06/18] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 07/18] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 08/18] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 09/18] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 10/18] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-29 20:45 ` Mark Brown
2012-07-29 20:45 ` Mark Brown
2012-07-29 20:45 ` Mark Brown
2012-07-30 6:54 ` Lee Jones
2012-07-30 6:54 ` Lee Jones
2012-07-27 12:45 ` [PATCH 11/18] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 12/18] ARM: ux500: Stop registering the MOP500 Audio driver from platform code Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-29 20:50 ` Mark Brown
2012-07-29 20:50 ` Mark Brown
2012-07-29 20:50 ` Mark Brown
2012-07-30 7:32 ` Lee Jones
2012-07-30 7:32 ` Lee Jones
2012-07-30 7:32 ` Lee Jones
2012-07-30 13:40 ` Mark Brown
2012-07-30 13:40 ` Mark Brown
2012-07-30 13:40 ` Mark Brown
2012-07-30 14:26 ` Lee Jones
2012-07-30 14:26 ` Lee Jones
2012-07-30 14:26 ` Lee Jones
2012-07-30 15:02 ` Mark Brown
2012-07-30 15:02 ` Mark Brown
2012-07-30 15:02 ` Mark Brown
2012-07-27 12:45 ` [PATCH 14/18] ARM: ux500: Stop registering the PCM driver from platform code Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:45 ` [PATCH 15/18] ARM: ux500: Add MSP devices to DB8500 Device Tree Lee Jones
2012-07-27 12:45 ` Lee Jones
2012-07-27 12:46 ` [PATCH 16/18] ARM: ux500: Remove platform registration of MSP devices Lee Jones
2012-07-27 12:46 ` Lee Jones
2012-07-27 12:46 ` [PATCH 17/18] ARM: ux500: Add all encompassing Sound node to DB8500 Device Tree Lee Jones
2012-07-27 12:46 ` Lee Jones
2012-07-29 20:52 ` Mark Brown
2012-07-29 20:52 ` Mark Brown
2012-07-29 20:52 ` Mark Brown
2012-07-30 7:35 ` Lee Jones
2012-07-30 7:35 ` Lee Jones
2012-07-30 7:35 ` Lee Jones
2012-07-30 13:42 ` Mark Brown
2012-07-30 13:42 ` Mark Brown
2012-07-30 13:42 ` Mark Brown
2012-07-30 14:30 ` Lee Jones
2012-07-30 14:30 ` Lee Jones
2012-07-30 14:30 ` Lee Jones
2012-07-27 12:46 ` [PATCH 18/18] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones
2012-07-27 12:46 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730150129.GF4468@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
--cc=olalilja@yahoo.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.