From: Borislav Petkov <bp@alien8.de>
To: Benjamin Poirier <bpoirier@suse.de>
Cc: Michal Marek <mmarek@suse.cz>,
Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Arnaud Lacombe <lacombar@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH 0/6] menuconfig: jump to search results
Date: Mon, 30 Jul 2012 21:58:26 +0200 [thread overview]
Message-ID: <20120730195826.GA8242@liondog.tnic> (raw)
In-Reply-To: <1343676130-29770-1-git-send-email-bpoirier@suse.de>
On Mon, Jul 30, 2012 at 03:22:04PM -0400, Benjamin Poirier wrote:
> Hello,
>
> This patch series adds "jump to" keys (similar to the cscope interface) to the
> search results of "make menuconfig" so that we can go directly to the menu
> entry for a config option after searching for it.
>
> Patches 1-4 implement the basic functionnality.
> Patches 5-6 are an optionnal improvement.
Generally,
a nice idea, I like it.
A couple of notes though:
* patches 2/6 and 3/6 don't have commit messages and it would be good if
they had, even though it is obvious what the changes in there do.
* this patchset must be against some kbuild tree because it doesn't
apply against 3.5:
$ patch -p1 --dry-run -i ~/0001-menuconfig_extend_dialog_textbox_so_that_it_can_exit_on_arbitrary_keypresses.patch
patching file scripts/kconfig/lxdialog/dialog.h
patching file scripts/kconfig/lxdialog/textbox.c
Hunk #3 FAILED at 132.
Hunk #4 succeeded at 157 (offset -1 lines).
Hunk #5 succeeded at 172 (offset -1 lines).
Hunk #6 succeeded at 252 (offset -3 lines).
Hunk #7 succeeded at 261 (offset -3 lines).
1 out of 7 hunks FAILED -- saving rejects to file scripts/kconfig/lxdialog/textbox.c.rej
patching file scripts/kconfig/mconf.c
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-07-30 19:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 19:22 [PATCH 0/6] menuconfig: jump to search results Benjamin Poirier
2012-07-30 19:22 ` [PATCH 1/6] menuconfig: Remove superfluous conditionnal Benjamin Poirier
2012-07-30 19:22 ` [PATCH 2/6] menuconfig: Extend dialog_textbox so that it can exit on arbitrary keypresses Benjamin Poirier
2012-07-30 19:22 ` [PATCH 3/6] menuconfig: Extend dialog_textbox so that it can return to a scrolled position Benjamin Poirier
2012-07-30 19:22 ` [PATCH 4/6] menuconfig: Add jump keys to search results Benjamin Poirier
2012-07-30 19:22 ` [PATCH 5/6] menuconfig: Do not open code textbox scroll up/down Benjamin Poirier
2012-07-30 19:22 ` [PATCH 6/6] menuconfig: Assign jump keys per-page instead of globally Benjamin Poirier
2012-07-30 19:58 ` Borislav Petkov [this message]
2012-07-30 20:22 ` [PATCH 0/6] menuconfig: jump to search results Benjamin Poirier
2012-07-31 7:57 ` Borislav Petkov
2012-07-31 13:17 ` Benjamin Poirier
2012-08-02 13:32 ` Borislav Petkov
2012-08-02 14:18 ` Benjamin Poirier
2012-08-02 21:38 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730195826.GA8242@liondog.tnic \
--to=bp@alien8.de \
--cc=bpoirier@suse.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=mmarek@suse.cz \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.