All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Poirier <bpoirier@suse.de>
To: Borislav Petkov <borislav.petkov@amd.com>,
	Michal Marek <mmarek@suse.cz>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	Arnaud Lacombe <lacombar@gmail.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH 0/6] menuconfig: jump to search results
Date: Tue, 31 Jul 2012 09:17:51 -0400	[thread overview]
Message-ID: <20120731131751.GA10910@d2.synalogic.ca> (raw)
In-Reply-To: <20120731075751.GB23595@liondog.tnic>

On 2012/07/31 09:57, Borislav Petkov wrote:
> On Mon, Jul 30, 2012 at 04:22:12PM -0400, Benjamin Poirier wrote:
> > It's against linux-next, which already contains some patches for
> > menuconfig.
> 
> Ok, applying against the linux-next from today succeeds. And they seem
> to work, I can search for CONFIG_* stuff and then go straight to the
> results.
> 
> A couple more observations:
> 
> * The numbering in the search results looks kinda strange and
> non-intuitive IMHO. Would it be possible to use the ncurses cursor to
> iterate over the search results like one does in the normal menus? I.e.,
> the horizontal bar which highlights the item with the background color
> or whatever - can it be moved up and down with the arrow keys through
> the search results too?

Further patches are welcome ;) It's not a trivial difference though.
The "horizontal bar" is not a curses concept, it's implemented via the
menubox lxdialog whereas search results are currently presented via a
textbox lxdialog.

> 
> * when searching for "DELAY" for example, I get results without numbers
> to which I can't jump to:
> 
> ...
>   │ Symbol: DEFAULT_IO_DELAY_TYPE [=0]
>   │ Type  : integer
>   │
>   │
>   │ Symbol: IO_DELAY_TYPE_0X80 [=0]
>   │ Type  : integer
> ...
> 
> maybe because they don't have "---help---" section?

Because they don't have a prompt - they don't appear in any menu at all.
In that case there's nowhere to jump to. That's why those symbols don't
get a number.

> 
> In those cases, you probably want to hide those from the search results?
> 
> Other than that it looks good and I'd say we need more menuconfig
> functionality like that which eases/speeds up working with that thing :).
> 
> Thanks.
> 
> -- 
> Regards/Gruss,
>     Boris.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2012-07-31 13:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 19:22 [PATCH 0/6] menuconfig: jump to search results Benjamin Poirier
2012-07-30 19:22 ` [PATCH 1/6] menuconfig: Remove superfluous conditionnal Benjamin Poirier
2012-07-30 19:22 ` [PATCH 2/6] menuconfig: Extend dialog_textbox so that it can exit on arbitrary keypresses Benjamin Poirier
2012-07-30 19:22 ` [PATCH 3/6] menuconfig: Extend dialog_textbox so that it can return to a scrolled position Benjamin Poirier
2012-07-30 19:22 ` [PATCH 4/6] menuconfig: Add jump keys to search results Benjamin Poirier
2012-07-30 19:22 ` [PATCH 5/6] menuconfig: Do not open code textbox scroll up/down Benjamin Poirier
2012-07-30 19:22 ` [PATCH 6/6] menuconfig: Assign jump keys per-page instead of globally Benjamin Poirier
2012-07-30 19:58 ` [PATCH 0/6] menuconfig: jump to search results Borislav Petkov
2012-07-30 20:22   ` Benjamin Poirier
2012-07-31  7:57     ` Borislav Petkov
2012-07-31 13:17       ` Benjamin Poirier [this message]
2012-08-02 13:32         ` Borislav Petkov
2012-08-02 14:18           ` Benjamin Poirier
2012-08-02 21:38             ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120731131751.GA10910@d2.synalogic.ca \
    --to=bpoirier@suse.de \
    --cc=borislav.petkov@amd.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mmarek@suse.cz \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.