All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
Date: Sun, 5 Aug 2012 14:20:02 +0100	[thread overview]
Message-ID: <20120805132001.GA1591@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1344033762-3296-1-git-send-email-sboyd@codeaurora.org>

On Fri, Aug 03, 2012 at 11:42:42PM +0100, Stephen Boyd wrote:
> Now that ARM has implemented its spinlocks with tickets we don't
> need to use the generic lockbreak algorithm. Remove the Kconfig
> from ARM so that we use the arch_spin_is_contended() definition
> from the asm header. This also saves a word in each lock because
> we don't need the break_lock member anymore.
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> It seems we define the arch_spin_is_contended() macro but we don't
> use it on SMP && PREEMPT kernels?

Thanks, I missed that.

Acked-by: Will Deacon <will.deacon@arm.com>

Will

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks
Date: Sun, 5 Aug 2012 14:20:02 +0100	[thread overview]
Message-ID: <20120805132001.GA1591@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <1344033762-3296-1-git-send-email-sboyd@codeaurora.org>

On Fri, Aug 03, 2012 at 11:42:42PM +0100, Stephen Boyd wrote:
> Now that ARM has implemented its spinlocks with tickets we don't
> need to use the generic lockbreak algorithm. Remove the Kconfig
> from ARM so that we use the arch_spin_is_contended() definition
> from the asm header. This also saves a word in each lock because
> we don't need the break_lock member anymore.
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> It seems we define the arch_spin_is_contended() macro but we don't
> use it on SMP && PREEMPT kernels?

Thanks, I missed that.

Acked-by: Will Deacon <will.deacon@arm.com>

Will

  reply	other threads:[~2012-08-05 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 22:42 [PATCH] ARM: Don't enable GENERIC_LOCKBREAK with ticket spinlocks Stephen Boyd
2012-08-03 22:42 ` Stephen Boyd
2012-08-05 13:20 ` Will Deacon [this message]
2012-08-05 13:20   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120805132001.GA1591@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.