All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
@ 2012-08-06 10:10 ` qiang.liu
  0 siblings, 0 replies; 6+ messages in thread
From: qiang.liu @ 2012-08-06 10:10 UTC (permalink / raw)
  To: linux-crypto, vinod.koul, dan.j.williams, herbert, arnd, gregkh,
	linuxppc-dev, linux-kernel, dan.j.williams
  Cc: leoli, kim.phillips

Hi all,

The following 8 patches enabling fsl-dma and talitos offload raid
operations for improving raid performance and balancing CPU load.

These patches include talitos, fsl-dma and carma module (caram uses
some features of fsl-dma).

Write performance will be improved by 25-30% tested by iozone.
Write performance is improved about 2% after using spin_lock_bh replace
spin_lock_irqsave.
CPU load will be reduced by 8%.

Changes in v6:
	- swap the order of original patch 3/6 and 4/6;
	- merge Ira's patch to reduce the size of original patch;
	- merge Ira's patch of carma in 8/8;
	- update documents and descriptions according to Ira's advice;

Changes in v5:
	- add detail description in patch 3/6 about the process of completed
	descriptor, the process is in align with fsl-dma Reference Manual,
	illustrate the potential risk and how to reproduce it;
	- drop the patch 7/7 in v4 according to Timur's comments;

Changes in v4:
	- fix an error in talitos when dest addr is same with src addr, dest
	should be freed only one time if src is same with dest addr;
	- correct coding style in fsl-dma according to Ira's comments;
	- fix a race condition in fsl-dma fsl_tx_status(), remove the interface
	which is used to free descriptors in queue ld_completed, this interface
	has been included in fsldma_cleanup_descriptor(), in v3, there is one
	place missed spin_lock protect;
	- split the original patch 3/4 up to 2 patches 3/7 and 4/7 according to
	Li Yang's comments;
	- fix a warning of unitialized cookie;
	- add memory copy self test in fsl-dma;
	- add more detail description about use spin_lock_bh() to instead of
	spin_lock_irqsave() according to Timur's comments.

Changes in v3:
	- change release process of fsl-dma descriptor for resolve the
	potential race condition;
	- add test result when use spin_lock_bh replace spin_lock_irqsave;
	- modify the benchmark results according to the latest patch.

Changes in v2:
	- rebase onto cryptodev tree;
	- split the patch 3/4 up to 3 independent patches;
	- remove the patch 4/4, the fix is not for cryptodev tree;

Qiang Liu (8):
      Talitos: Support for async_tx XOR offload
      fsl-dma: remove attribute DMA_INTERRUPT of dmaengine
      fsl-dma: add fsl_dma_free_descriptor() to reduce code duplication
      fsl-dma: move functions to avoid forward declarations
      fsl-dma: change release process of dma descriptor for supporting async_tx
      fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
      fsl-dma: fix a warning of unitialized cookie
      carma: remove unnecessary DMA_INTERRUPT capability

 drivers/crypto/Kconfig                  |    9 +
 drivers/crypto/talitos.c                |  413 ++++++++++++++++++++++++++
 drivers/crypto/talitos.h                |   53 ++++
 drivers/dma/fsldma.c                    |  487 +++++++++++++++++--------------
 drivers/dma/fsldma.h                    |   17 +-
 drivers/misc/carma/carma-fpga-program.c |    1 -
 drivers/misc/carma/carma-fpga.c         |    2 +-
 7 files changed, 760 insertions(+), 222 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
@ 2012-08-06 10:10 ` qiang.liu
  0 siblings, 0 replies; 6+ messages in thread
From: qiang.liu @ 2012-08-06 10:10 UTC (permalink / raw)
  To: linux-crypto, vinod.koul, dan.j.williams, herbert, arnd, gregkh,
	linuxppc-dev, linux-kernel, dan.j.williams

Hi all,

The following 8 patches enabling fsl-dma and talitos offload raid
operations for improving raid performance and balancing CPU load.

These patches include talitos, fsl-dma and carma module (caram uses
some features of fsl-dma).

Write performance will be improved by 25-30% tested by iozone.
Write performance is improved about 2% after using spin_lock_bh replace
spin_lock_irqsave.
CPU load will be reduced by 8%.

Changes in v6:
	- swap the order of original patch 3/6 and 4/6;
	- merge Ira's patch to reduce the size of original patch;
	- merge Ira's patch of carma in 8/8;
	- update documents and descriptions according to Ira's advice;

Changes in v5:
	- add detail description in patch 3/6 about the process of completed
	descriptor, the process is in align with fsl-dma Reference Manual,
	illustrate the potential risk and how to reproduce it;
	- drop the patch 7/7 in v4 according to Timur's comments;

Changes in v4:
	- fix an error in talitos when dest addr is same with src addr, dest
	should be freed only one time if src is same with dest addr;
	- correct coding style in fsl-dma according to Ira's comments;
	- fix a race condition in fsl-dma fsl_tx_status(), remove the interface
	which is used to free descriptors in queue ld_completed, this interface
	has been included in fsldma_cleanup_descriptor(), in v3, there is one
	place missed spin_lock protect;
	- split the original patch 3/4 up to 2 patches 3/7 and 4/7 according to
	Li Yang's comments;
	- fix a warning of unitialized cookie;
	- add memory copy self test in fsl-dma;
	- add more detail description about use spin_lock_bh() to instead of
	spin_lock_irqsave() according to Timur's comments.

Changes in v3:
	- change release process of fsl-dma descriptor for resolve the
	potential race condition;
	- add test result when use spin_lock_bh replace spin_lock_irqsave;
	- modify the benchmark results according to the latest patch.

Changes in v2:
	- rebase onto cryptodev tree;
	- split the patch 3/4 up to 3 independent patches;
	- remove the patch 4/4, the fix is not for cryptodev tree;

Qiang Liu (8):
      Talitos: Support for async_tx XOR offload
      fsl-dma: remove attribute DMA_INTERRUPT of dmaengine
      fsl-dma: add fsl_dma_free_descriptor() to reduce code duplication
      fsl-dma: move functions to avoid forward declarations
      fsl-dma: change release process of dma descriptor for supporting async_tx
      fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
      fsl-dma: fix a warning of unitialized cookie
      carma: remove unnecessary DMA_INTERRUPT capability

 drivers/crypto/Kconfig                  |    9 +
 drivers/crypto/talitos.c                |  413 ++++++++++++++++++++++++++
 drivers/crypto/talitos.h                |   53 ++++
 drivers/dma/fsldma.c                    |  487 +++++++++++++++++--------------
 drivers/dma/fsldma.h                    |   17 +-
 drivers/misc/carma/carma-fpga-program.c |    1 -
 drivers/misc/carma/carma-fpga.c         |    2 +-
 7 files changed, 760 insertions(+), 222 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
  2012-08-06 10:10 ` qiang.liu
@ 2012-08-07  1:35   ` Kim Phillips
  -1 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2012-08-07  1:35 UTC (permalink / raw)
  To: qiang.liu
  Cc: arnd, vinod.koul, gregkh, linux-kernel, dan.j.williams, herbert,
	linux-crypto, dan.j.williams, linuxppc-dev

On Mon, 6 Aug 2012 18:10:15 +0800
<qiang.liu@freescale.com> wrote:

> Changes in v6:
> 	- swap the order of original patch 3/6 and 4/6;
> 	- merge Ira's patch to reduce the size of original patch;
> 	- merge Ira's patch of carma in 8/8;
> 	- update documents and descriptions according to Ira's advice;

fwiw, I gave v5 a test-drive, setting up a RAID5 array on ramdisks
[1], and this patchseries, along with FSL_DMA && NET_DMA set seems
to be holding water, so this series gets my:

Tested-by: Kim Phillips <kim.phillips@freescale.com>

Thanks,

Kim

[1] mdadm --create --verbose --force /dev/md0 --level=raid5 --raid-devices=4 /dev/ram[0123]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
@ 2012-08-07  1:35   ` Kim Phillips
  0 siblings, 0 replies; 6+ messages in thread
From: Kim Phillips @ 2012-08-07  1:35 UTC (permalink / raw)
  To: qiang.liu
  Cc: linux-crypto, vinod.koul, dan.j.williams, herbert, arnd, gregkh,
	linuxppc-dev, linux-kernel, dan.j.williams, leoli

On Mon, 6 Aug 2012 18:10:15 +0800
<qiang.liu@freescale.com> wrote:

> Changes in v6:
> 	- swap the order of original patch 3/6 and 4/6;
> 	- merge Ira's patch to reduce the size of original patch;
> 	- merge Ira's patch of carma in 8/8;
> 	- update documents and descriptions according to Ira's advice;

fwiw, I gave v5 a test-drive, setting up a RAID5 array on ramdisks
[1], and this patchseries, along with FSL_DMA && NET_DMA set seems
to be holding water, so this series gets my:

Tested-by: Kim Phillips <kim.phillips@freescale.com>

Thanks,

Kim

[1] mdadm --create --verbose --force /dev/md0 --level=raid5 --raid-devices=4 /dev/ram[0123]


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
  2012-08-07  1:35   ` Kim Phillips
@ 2012-08-07  3:27     ` Liu Qiang-B32616
  -1 siblings, 0 replies; 6+ messages in thread
From: Liu Qiang-B32616 @ 2012-08-07  3:27 UTC (permalink / raw)
  To: Phillips Kim-R1AAHA
  Cc: linux-crypto, vinod.koul, dan.j.williams, herbert, arnd, gregkh,
	linuxppc-dev, linux-kernel, dan.j.williams, Li Yang-R58472

> -----Original Message-----
> From: Phillips Kim-R1AAHA
> Sent: Tuesday, August 07, 2012 9:35 AM
> To: Liu Qiang-B32616
> Cc: linux-crypto@vger.kernel.org; vinod.koul@intel.com;
> dan.j.williams@intel.com; herbert@gondor.hengli.com.au; arnd@arndb.de;
> gregkh@linuxfoundation.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; dan.j.williams@gmail.com; Li Yang-R58472
> Subject: Re: [PATCH v6 0/8] Raid: enable talitos xor offload for
> improving performance
> 
> On Mon, 6 Aug 2012 18:10:15 +0800
> <qiang.liu@freescale.com> wrote:
> 
> > Changes in v6:
> > 	- swap the order of original patch 3/6 and 4/6;
> > 	- merge Ira's patch to reduce the size of original patch;
> > 	- merge Ira's patch of carma in 8/8;
> > 	- update documents and descriptions according to Ira's advice;
> 
> fwiw, I gave v5 a test-drive, setting up a RAID5 array on ramdisks [1],
> and this patchseries, along with FSL_DMA && NET_DMA set seems to be
> holding water, so this series gets my:
> 
> Tested-by: Kim Phillips <kim.phillips@freescale.com>
Thanks, Kim. I will add this line in v7:)

> 
> Thanks,
> 
> Kim
> 
> [1] mdadm --create --verbose --force /dev/md0 --level=raid5 --raid-
> devices=4 /dev/ram[0123]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance
@ 2012-08-07  3:27     ` Liu Qiang-B32616
  0 siblings, 0 replies; 6+ messages in thread
From: Liu Qiang-B32616 @ 2012-08-07  3:27 UTC (permalink / raw)
  To: Phillips Kim-R1AAHA
  Cc: Li Yang-R58472, arnd, vinod.koul, gregkh, linux-kernel,
	dan.j.williams, herbert, linux-crypto, dan.j.williams,
	linuxppc-dev

> -----Original Message-----
> From: Phillips Kim-R1AAHA
> Sent: Tuesday, August 07, 2012 9:35 AM
> To: Liu Qiang-B32616
> Cc: linux-crypto@vger.kernel.org; vinod.koul@intel.com;
> dan.j.williams@intel.com; herbert@gondor.hengli.com.au; arnd@arndb.de;
> gregkh@linuxfoundation.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org; dan.j.williams@gmail.com; Li Yang-R58472
> Subject: Re: [PATCH v6 0/8] Raid: enable talitos xor offload for
> improving performance
>=20
> On Mon, 6 Aug 2012 18:10:15 +0800
> <qiang.liu@freescale.com> wrote:
>=20
> > Changes in v6:
> > 	- swap the order of original patch 3/6 and 4/6;
> > 	- merge Ira's patch to reduce the size of original patch;
> > 	- merge Ira's patch of carma in 8/8;
> > 	- update documents and descriptions according to Ira's advice;
>=20
> fwiw, I gave v5 a test-drive, setting up a RAID5 array on ramdisks [1],
> and this patchseries, along with FSL_DMA && NET_DMA set seems to be
> holding water, so this series gets my:
>=20
> Tested-by: Kim Phillips <kim.phillips@freescale.com>
Thanks, Kim. I will add this line in v7:)

>=20
> Thanks,
>=20
> Kim
>=20
> [1] mdadm --create --verbose --force /dev/md0 --level=3Draid5 --raid-
> devices=3D4 /dev/ram[0123]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-08-07  3:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-06 10:10 [PATCH v6 0/8] Raid: enable talitos xor offload for improving performance qiang.liu
2012-08-06 10:10 ` qiang.liu
2012-08-07  1:35 ` Kim Phillips
2012-08-07  1:35   ` Kim Phillips
2012-08-07  3:27   ` Liu Qiang-B32616
2012-08-07  3:27     ` Liu Qiang-B32616

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.