All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: kuninori.morimoto.gx@renesas.com,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [Regression, post-3.5] System suspend broken on the Mackerel board
Date: Tue, 07 Aug 2012 01:55:51 +0000	[thread overview]
Message-ID: <20120807015551.GB1614@linux-sh.org> (raw)
In-Reply-To: <201208050002.43465.rjw@sisk.pl>

On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote:
> On Wednesday, August 01, 2012, Paul Mundt wrote:
> > Turns out we can just collapse the probe/init stuff anyways, so this
> > ought to fix it. I've verified that it fixes Morimoto-san's issue, my
> > expectation is that the mackerel case is likewise getting tripped up but
> > no one bothered implementing any error detecting logic for gpio_request()
> > failing, so it doesn't fail gracefully.
> > 
> > I'll be pushing this out to Linus shortly:
> 
> Thanks, this helped.  Resume works correctly on Mackerel with 3.6-rc1.
> 
> However, I'm now seeing a different problem related to system suspend on that,
> board which is that sh7372_enter_a3sm_common() returns immediately, as though
> at least one of the wakeup signals was permanently asserted.  This hadn't
> happened before your last pull request was merged, so I suspect that one
> of the irqdomain patches might introduce this behavior.
> 
Ok, I'll back off the irqdomain selection until we have a chance to test
it more on the other platforms.

WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: kuninori.morimoto.gx@renesas.com,
	Magnus Damm <magnus.damm@gmail.com>,
	"Linux-sh list" <linux-sh@vger.kernel.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [Regression, post-3.5] System suspend broken on the Mackerel board
Date: Tue, 7 Aug 2012 10:55:51 +0900	[thread overview]
Message-ID: <20120807015551.GB1614@linux-sh.org> (raw)
In-Reply-To: <201208050002.43465.rjw@sisk.pl>

On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote:
> On Wednesday, August 01, 2012, Paul Mundt wrote:
> > Turns out we can just collapse the probe/init stuff anyways, so this
> > ought to fix it. I've verified that it fixes Morimoto-san's issue, my
> > expectation is that the mackerel case is likewise getting tripped up but
> > no one bothered implementing any error detecting logic for gpio_request()
> > failing, so it doesn't fail gracefully.
> > 
> > I'll be pushing this out to Linus shortly:
> 
> Thanks, this helped.  Resume works correctly on Mackerel with 3.6-rc1.
> 
> However, I'm now seeing a different problem related to system suspend on that,
> board which is that sh7372_enter_a3sm_common() returns immediately, as though
> at least one of the wakeup signals was permanently asserted.  This hadn't
> happened before your last pull request was merged, so I suspect that one
> of the irqdomain patches might introduce this behavior.
> 
Ok, I'll back off the irqdomain selection until we have a chance to test
it more on the other platforms.

  reply	other threads:[~2012-08-07  1:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 22:53 [Regression, post-3.5] System suspend broken on the Mackerel board Rafael J. Wysocki
2012-07-27 22:53 ` Rafael J. Wysocki
2012-07-28  0:48 ` Paul Mundt
2012-07-28  0:48   ` Paul Mundt
2012-08-01  3:57 ` bug report: ecovec boot got WARNING kuninori.morimoto.gx
2012-08-01  5:04   ` Paul Mundt
2012-08-01  5:39   ` Kuninori Morimoto
2012-08-01  7:30   ` [Regression, post-3.5] System suspend broken on the Mackerel board Paul Mundt
2012-08-01  7:30     ` Paul Mundt
2012-08-04 22:02     ` Rafael J. Wysocki
2012-08-04 22:02       ` Rafael J. Wysocki
2012-08-07  1:55       ` Paul Mundt [this message]
2012-08-07  1:55         ` Paul Mundt
2012-08-08  9:23         ` Rafael J. Wysocki
2012-08-08  9:23           ` Rafael J. Wysocki
2012-08-09  4:40           ` Paul Mundt
2012-08-09  4:40             ` Paul Mundt
2012-08-09 21:20             ` Rafael J. Wysocki
2012-08-09 21:20               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807015551.GB1614@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.