All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>, Liam Girdwood <lrg@ti.com>,
	Tony Lindgren <tony@atomide.com>, Dmitry Torokhov <dtor@mail.ru>,
	alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support
Date: Wed, 8 Aug 2012 15:18:50 +0100	[thread overview]
Message-ID: <20120808141849.GA24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <502274DA.9020204@ti.com>

On Wed, Aug 08, 2012 at 05:16:58PM +0300, Peter Ujfalusi wrote:
> On 08/08/2012 04:52 PM, Mark Brown wrote:

> > Is the point it's at in the sequence the end?

> On both ends :o
> On HS enable: the extmute has to be enabled, run the power on sequence for the
> HS, wait for ramp, disable the HS extmute.

> On stop: enable the extmute, run the sequence, wait for ramp, release the extmute.

I'm struggling to see any reason not to just hold the external mute on
for the entire time the headset is powered off?

> > We can always add a patch stubbing it out as part of the series, or in a
> > branch in the OF tree that we can pull in.

> If you are OK with the hassle I can add a patch to the series for
> include/linux/of.h to handle this.

Yes, please.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, Samuel Ortiz <sameo@linux.intel.com>,
	Tony Lindgren <tony@atomide.com>, Dmitry Torokhov <dtor@mail.ru>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH 04/11] MFD: twl4030-audio: Add DT support
Date: Wed, 8 Aug 2012 15:18:50 +0100	[thread overview]
Message-ID: <20120808141849.GA24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <502274DA.9020204@ti.com>

On Wed, Aug 08, 2012 at 05:16:58PM +0300, Peter Ujfalusi wrote:
> On 08/08/2012 04:52 PM, Mark Brown wrote:

> > Is the point it's at in the sequence the end?

> On both ends :o
> On HS enable: the extmute has to be enabled, run the power on sequence for the
> HS, wait for ramp, disable the HS extmute.

> On stop: enable the extmute, run the sequence, wait for ramp, release the extmute.

I'm struggling to see any reason not to just hold the external mute on
for the entire time the headset is powered off?

> > We can always add a patch stubbing it out as part of the series, or in a
> > branch in the OF tree that we can pull in.

> If you are OK with the hassle I can add a patch to the series for
> include/linux/of.h to handle this.

Yes, please.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/11] MFD: twl4030-audio: Add DT support
Date: Wed, 8 Aug 2012 15:18:50 +0100	[thread overview]
Message-ID: <20120808141849.GA24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <502274DA.9020204@ti.com>

On Wed, Aug 08, 2012 at 05:16:58PM +0300, Peter Ujfalusi wrote:
> On 08/08/2012 04:52 PM, Mark Brown wrote:

> > Is the point it's at in the sequence the end?

> On both ends :o
> On HS enable: the extmute has to be enabled, run the power on sequence for the
> HS, wait for ramp, disable the HS extmute.

> On stop: enable the extmute, run the sequence, wait for ramp, release the extmute.

I'm struggling to see any reason not to just hold the external mute on
for the entire time the headset is powered off?

> > We can always add a patch stubbing it out as part of the series, or in a
> > branch in the OF tree that we can pull in.

> If you are OK with the hassle I can add a patch to the series for
> include/linux/of.h to handle this.

Yes, please.

  reply	other threads:[~2012-08-08 14:18 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08  9:41 [PATCH 00/11] MFD/ASoC/Input: twl4030-audio submodule DT support Peter Ujfalusi
2012-08-08  9:41 ` Peter Ujfalusi
2012-08-08  9:41 ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 01/11] MFD: twl4030-audio: Clean up MODULE_* and platform_driver part Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 02/11] MFD: twl4030-audio: Convert to use devm_kzalloc Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 03/11] MFD: twl4030-audio: Rearange and clean-up the probe function Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 04/11] MFD: twl4030-audio: Add DT support Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08 11:50   ` Benoit Cousson
2012-08-08 11:50     ` Benoit Cousson
2012-08-08 11:50     ` Benoit Cousson
2012-08-08 12:43     ` Peter Ujfalusi
2012-08-08 12:43       ` Peter Ujfalusi
2012-08-08 12:43       ` Peter Ujfalusi
2012-08-08 12:52     ` Mark Brown
2012-08-08 12:52       ` Mark Brown
2012-08-08 14:35       ` Peter Ujfalusi
2012-08-08 14:35         ` Peter Ujfalusi
2012-08-08 14:35         ` Peter Ujfalusi
2012-08-08 14:39         ` Mark Brown
2012-08-08 14:39           ` Mark Brown
2012-08-08 14:39           ` Mark Brown
2012-08-08 15:41         ` Benoit Cousson
2012-08-08 15:41           ` Benoit Cousson
2012-08-08 15:41           ` Benoit Cousson
2012-08-08 13:13   ` Mark Brown
2012-08-08 13:13     ` Mark Brown
2012-08-08 13:43     ` Peter Ujfalusi
2012-08-08 13:43       ` Peter Ujfalusi
2012-08-08 13:43       ` Peter Ujfalusi
2012-08-08 13:52       ` Mark Brown
2012-08-08 13:52         ` Mark Brown
2012-08-08 13:52         ` Mark Brown
2012-08-08 14:16         ` Peter Ujfalusi
2012-08-08 14:16           ` Peter Ujfalusi
2012-08-08 14:16           ` Peter Ujfalusi
2012-08-08 14:18           ` Mark Brown [this message]
2012-08-08 14:18             ` Mark Brown
2012-08-08 14:18             ` Mark Brown
2012-08-08 14:31             ` Peter Ujfalusi
2012-08-08 14:31               ` Peter Ujfalusi
2012-08-08 14:49               ` Mark Brown
2012-08-08 14:49                 ` Mark Brown
2012-08-08 14:49                 ` Mark Brown
2012-08-09 10:18                 ` Peter Ujfalusi
2012-08-09 10:18                   ` Peter Ujfalusi
2012-08-09 10:18                   ` Peter Ujfalusi
2012-08-09 10:36                   ` Mark Brown
2012-08-09 10:36                     ` Mark Brown
2012-08-09 10:36                     ` Mark Brown
2012-08-09 13:53                     ` Peter Ujfalusi
2012-08-09 13:53                       ` Peter Ujfalusi
2012-08-09 13:53                       ` Peter Ujfalusi
2012-08-12 18:50                       ` Mark Brown
2012-08-12 18:50                         ` Mark Brown
2012-08-12 18:50                         ` Mark Brown
2012-08-08  9:41 ` [PATCH 05/11] Input: twl4030-vibra: Support for DT booted kernel Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 06/11] ASoC: twl4030: Move hs_extmute GPIO handling to driver Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 07/11] ARM: OMAP/ASoC: Zoom2: Let the codec to handle the hs_extmute GPIO Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-10  6:28   ` Tony Lindgren
2012-08-10  6:28     ` Tony Lindgren
2012-08-08  9:41 ` [PATCH 08/11] ASoC/MFD: twl4030: Remove set_hs_extmute callback from platform data Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 09/11] ASoC: twl4030: Convert to use devm_kzalloc Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 10/11] ASoC: twl4030: Add pointer to pdata within the private data Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi
2012-08-08  9:41 ` [PATCH 11/11] ASoC: twl4030: Support for DT booted kernel Peter Ujfalusi
2012-08-08  9:41   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808141849.GA24328@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dtor@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.