All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@suse.cz>
To: Hillf Danton <dhillf@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach
Date: Mon, 13 Aug 2012 15:49:00 +0200	[thread overview]
Message-ID: <20120813134900.GE24248@dhcp22.suse.cz> (raw)
In-Reply-To: <CAJd=RBCJL+oPRZMNNmtwSWH6CM1fiUNh=X+Leuk25Lyd3uKB5Q@mail.gmail.com>

On Mon 13-08-12 21:24:36, Hillf Danton wrote:
> On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko <mhocko@suse.cz> wrote:
> > On Mon 13-08-12 20:10:41, Hillf Danton wrote:
> >> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko <mhocko@suse.cz> wrote:
> >> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001
> >> > From: Michal Hocko <mhocko@suse.cz>
> >> > Date: Fri, 10 Aug 2012 15:03:07 +0200
> >> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
> >> >  vma_prio_tree_foreach
> >> >
> >> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
> >> > from vma) fixed pgoff calculation but it has replaced it by
> >> > vma_hugecache_offset which is not approapriate for offsets used for
> >> > vma_prio_tree_foreach because that one expects index in page units
> >> > rather than in huge_page_shift.
> >>
> >>
> >> What if another case of vma_prio_tree_foreach in try_to_unmap_file
> >> is correct?
> >
> > That one is surely correct (linear_page_index converts the page offset).
> 
> But linear_page_index is not used in this patch, why?

I will leave it as an excersise for the careful reader...
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@suse.cz>
To: Hillf Danton <dhillf@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach
Date: Mon, 13 Aug 2012 15:49:00 +0200	[thread overview]
Message-ID: <20120813134900.GE24248@dhcp22.suse.cz> (raw)
In-Reply-To: <CAJd=RBCJL+oPRZMNNmtwSWH6CM1fiUNh=X+Leuk25Lyd3uKB5Q@mail.gmail.com>

On Mon 13-08-12 21:24:36, Hillf Danton wrote:
> On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko <mhocko@suse.cz> wrote:
> > On Mon 13-08-12 20:10:41, Hillf Danton wrote:
> >> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko <mhocko@suse.cz> wrote:
> >> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001
> >> > From: Michal Hocko <mhocko@suse.cz>
> >> > Date: Fri, 10 Aug 2012 15:03:07 +0200
> >> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for
> >> >  vma_prio_tree_foreach
> >> >
> >> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page
> >> > from vma) fixed pgoff calculation but it has replaced it by
> >> > vma_hugecache_offset which is not approapriate for offsets used for
> >> > vma_prio_tree_foreach because that one expects index in page units
> >> > rather than in huge_page_shift.
> >>
> >>
> >> What if another case of vma_prio_tree_foreach in try_to_unmap_file
> >> is correct?
> >
> > That one is surely correct (linear_page_index converts the page offset).
> 
> But linear_page_index is not used in this patch, why?

I will leave it as an excersise for the careful reader...
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-08-13 13:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-03 12:56 [patch] hugetlb: correct page offset index for sharing pmd Hillf Danton
2012-08-03 12:56 ` Hillf Danton
2012-08-03 13:32 ` Michal Hocko
2012-08-03 13:32   ` Michal Hocko
2012-08-10  9:48   ` Michal Hocko
2012-08-10  9:48     ` Michal Hocko
2012-08-10 12:07     ` Hillf Danton
2012-08-10 12:07       ` Hillf Danton
2012-08-10 12:27       ` Michal Hocko
2012-08-10 12:27         ` Michal Hocko
2012-08-10 12:37         ` Hillf Danton
2012-08-10 12:37           ` Hillf Danton
2012-08-10 12:51           ` Michal Hocko
2012-08-10 12:51             ` Michal Hocko
2012-08-10 12:53             ` Hillf Danton
2012-08-10 12:53               ` Hillf Danton
2012-08-10 13:16               ` Michal Hocko
2012-08-10 13:16                 ` Michal Hocko
2012-08-10 13:21                 ` Hillf Danton
2012-08-10 13:21                   ` Hillf Danton
2012-08-10 13:39                   ` Hillf Danton
2012-08-10 13:39                     ` Hillf Danton
2012-08-10 13:48                   ` Michal Hocko
2012-08-10 13:48                     ` Michal Hocko
2012-08-12  4:08                     ` Hillf Danton
2012-08-12  4:08                       ` Hillf Danton
2012-08-12  9:31                       ` Michal Hocko
2012-08-12  9:31                         ` Michal Hocko
2012-08-13 12:10                         ` Hillf Danton
2012-08-13 12:10                           ` Hillf Danton
2012-08-13 13:09                           ` Michal Hocko
2012-08-13 13:09                             ` Michal Hocko
2012-08-13 13:24                             ` [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach Hillf Danton
2012-08-13 13:24                               ` Hillf Danton
2012-08-13 13:49                               ` Michal Hocko [this message]
2012-08-13 13:49                                 ` Michal Hocko
2012-08-13 13:51                                 ` Hillf Danton
2012-08-13 13:51                                   ` Hillf Danton
2012-08-13 13:55 Michal Hocko
2012-08-13 13:55 ` Michal Hocko
2012-08-16 12:45 ` Hillf Danton
2012-08-16 12:45   ` Hillf Danton
2012-08-16 15:11   ` Michal Hocko
2012-08-16 15:11     ` Michal Hocko
2012-09-26 20:56 ` Johannes Weiner
2012-09-26 20:56   ` Johannes Weiner
2012-10-01 16:22   ` Michal Hocko
2012-10-01 16:22     ` Michal Hocko
2012-10-01 18:29     ` Johannes Weiner
2012-10-01 18:29       ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120813134900.GE24248@dhcp22.suse.cz \
    --to=mhocko@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=dhillf@gmail.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.