Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 3/3] spapr: Add support for -vga option

From: David Gibson <dwg@au1.ibm.com>
To: Li Zhang <zhlcindy@gmail.com>
Cc: aliguori@us.ibm.com, Alexander Graf <agraf@suse.de>,
	Li Zhang <zhlcindy@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org, afaerber@suse.de
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v7 3/3] spapr: Add support for -vga option
Date: Wed, 15 Aug 2012 09:11:30 +1000	[thread overview]
Message-ID: <20120814231130.GC8136@truffula.fritz.box> (raw)
In-Reply-To: <CAD8of+oUfThoYwZ0YC7-0SCD6At=JbTziHPKwVEAGw0yfLJ6hQ@mail.gmail.com>

On Wed, Aug 15, 2012 at 01:52:55AM +0800, Li Zhang wrote:
> On Wed, Aug 15, 2012 at 1:19 AM, Li Zhang <zhlcindy@gmail.com> wrote:
> > On Tue, Aug 14, 2012 at 11:13 PM, Li Zhang <zhlcindy@gmail.com> wrote:
> >> On Tue, Aug 14, 2012 at 8:13 PM, David Gibson <dwg@au1.ibm.com> wrote:
> >>> On Tue, Aug 14, 2012 at 10:04:03PM +1000, Benjamin Herrenschmidt wrote:
> >>>> On Tue, 2012-08-14 at 13:04 +0200, Alexander Graf wrote:
> >>>> > Thanks, applied to ppc-next without the USB bits. I also get the
> >>>> > following warning now:
> >>>> >
> >>>> > $ ./ppc64-softmmu/qemu-system-ppc64 -nographic -M pseries -kernel
> >>>> > /boot/vmlinux -initrd /boot/initrd -enable-kvm -m 1G -append
> >>>> > root=/dev/null
> >>>> > This vga model is not supported,currently it only supports -vga std
> >>>> > [...]
> >>>> >
> >>>> > Fixing with a follow-up patch.
> >>>>
> >>>> Right, nowadays qemu defaults to cirrus regardless of the arch which is
> >>>> annoying. In fact it even creates a vga card with -nographic, you have
> >>>> to do -vga none to avoid it which is even more annoying for us :-)
> >>>
> >>> No, that's not the problem, or at least it's not the only problem.  It
> >>> actually rejected -vga none.  I fixed that in the version in my tree,
> >>> but I hadn't sent that out to Alex yet.
> >> OK, I see.
> >> I will redo USB patches.
> >> Let me pull the version from the internal tree and resend it with USB patches.
> >>
> > David, I didn't find your latest version.
> > I think I have to send out tomorrow morning.
> > It seems that VPN server is down again. :(
> >
> VPN can work now. I have sent out USB part.
> David, would you please send out the latest version of VGA part.

There's no need, Alex already pulled your patch and put an equivalent
fix in.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson