All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: aliguori@us.ibm.com, agraf@suse.de,
	Li Zhang <zhlcindy@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Li Zhang <zhlcindy@gmail.com>,
	Eugene Dvurechenski <jno@linux.vnet.ibm.com>,
	qemu-ppc@nongnu.org, afaerber@suse.de,
	david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390
Date: Tue, 7 Aug 2012 13:26:26 +0100	[thread overview]
Message-ID: <CAFEAcA-mLAvgUwSfyT52oKrKa-WG454UfVgoMVxwQ3hfogJEgA@mail.gmail.com> (raw)
In-Reply-To: <1344341985-10065-2-git-send-email-borntraeger@de.ibm.com>

On 7 August 2012 13:19, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> +#if defined(TARGET_HAS_USB) && (TARGET_HAS_USB == 1)
>      /* init USB devices */
>      if (usb_enabled) {
>          if (foreach_device_config(DEV_USB, usb_parse) < 0)
>              exit(1);
>      }
> +#endif

Whether there is USB or not is a property of the machine model,
not the target CPU architecture, so a TARGET_HAS_USB define
is definitely the wrong approach.

-- PMM

  reply	other threads:[~2012-08-07 12:26 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  2:41 [Qemu-devel] [Qemu-ppc][PATCH v7 0/3] Add USB enablement and VGA enablement on sPAPR Li Zhang
2012-08-07  2:41 ` [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options Li Zhang
2012-08-07 12:19   ` [Qemu-devel] [RFC] usb and s390 Christian Borntraeger
2012-08-07 12:50     ` Li Zhang
2012-08-07 14:20     ` Eric Blake
2012-08-07 12:19   ` [Qemu-devel] [RFC/PATCH 1/1] USB code fenced for s390 Christian Borntraeger
2012-08-07 12:26     ` Peter Maydell [this message]
2012-08-07 20:22       ` Blue Swirl
2012-08-08  6:29         ` Christian Borntraeger
2012-08-07 12:57     ` Andreas Färber
2012-08-07 12:59     ` Li Zhang
2012-08-14 10:39   ` [Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options Alexander Graf
2012-08-14 14:59     ` Li Zhang
2012-08-14 10:46   ` Alexander Graf
2012-08-14 15:01     ` Li Zhang
2012-08-14 23:10       ` [Qemu-devel] [Qemu-ppc] [PATCH " David Gibson
2012-08-14 23:41         ` Alexander Graf
2012-08-15  0:09         ` Benjamin Herrenschmidt
2012-08-15  1:24           ` Li Zhang
2012-08-15  1:47             ` David Gibson
2012-08-15  2:50               ` Li Zhang
2012-08-15  2:57                 ` David Gibson
2012-08-15  5:44                   ` Li Zhang
2012-08-15 11:13                     ` David Gibson
2012-08-15 14:17                       ` Li Zhang
2012-08-07  2:41 ` [Qemu-devel] [Qemu-ppc][PATCH v7 2/3] Add one new file vga-pci.h and cleanup on all platforms Li Zhang
2012-08-14 11:04   ` Alexander Graf
2012-08-07  2:42 ` [Qemu-devel] [Qemu-ppc][PATCH v7 3/3] spapr: Add support for -vga option Li Zhang
2012-08-14 11:04   ` Alexander Graf
2012-08-14 12:04     ` Benjamin Herrenschmidt
2012-08-14 12:13       ` David Gibson
2012-08-14 15:13         ` Li Zhang
2012-08-14 17:19           ` Li Zhang
2012-08-14 17:52             ` Li Zhang
2012-08-14 23:11               ` [Qemu-devel] [Qemu-ppc] [PATCH " David Gibson
2012-08-14 15:07     ` [Qemu-devel] [Qemu-ppc][PATCH " Li Zhang
2012-08-07 15:05 ` [Qemu-devel] [Qemu-ppc][PATCH v7 0/3] Add USB enablement and VGA enablement on sPAPR Li Zhang
2012-08-14 11:04   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-mLAvgUwSfyT52oKrKa-WG454UfVgoMVxwQ3hfogJEgA@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=jno@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=zhlcindy@gmail.com \
    --cc=zhlcindy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.