[PATCH] xfs: kill struct declarations in xfs_mount.h

[PATCH] xfs: kill struct declarations in xfs_mount.h

[Alex Elder]

I noticed that "struct xfs_mount_args" was still declared in
"fs/xfs/xfs_mount.h".  That struct doesn't even exist any more (and
is obviously not referenced elsewhere in that header file).  While
in there, delete four other unneeded struct declarations in that
file.

Doing so highlights that "fs/xfs/xfs_trace.h" was relying indirectly
on "xfs_mount.h" to be #included in order to declare "struct
xfs_bmbt_irec", so add that declaration to resolve that issue.

Signed-off-by: Alex Elder <elder@inktank.com>
---
 fs/xfs/xfs_mount.h |    5 -----
 fs/xfs/xfs_trace.h |    1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

Index: b/fs/xfs/xfs_mount.h
===================================================================
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -54,12 +54,7 @@ typedef struct xfs_trans_reservations {
 #include "xfs_sync.h"

 struct xlog;
-struct xfs_mount_args;
 struct xfs_inode;
-struct xfs_bmbt_irec;
-struct xfs_bmap_free;
-struct xfs_extdelta;
-struct xfs_swapext;
 struct xfs_mru_cache;
 struct xfs_nameops;
 struct xfs_ail;
Index: b/fs/xfs/xfs_trace.h
===================================================================
--- a/fs/xfs/xfs_trace.h
+++ b/fs/xfs/xfs_trace.h
@@ -37,6 +37,7 @@ struct xlog_recover;
 struct xlog_recover_item;
 struct xfs_buf_log_format;
 struct xfs_inode_log_format;
+struct xfs_bmbt_irec;

 DECLARE_EVENT_CLASS(xfs_attr_list_class,
 	TP_PROTO(struct xfs_attr_list_context *ctx),

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: kill struct declarations in xfs_mount.h

[Ben Myers]

On Wed, Aug 01, 2012 at 09:56:49AM -0500, Alex Elder wrote:
> I noticed that "struct xfs_mount_args" was still declared in
> "fs/xfs/xfs_mount.h".  That struct doesn't even exist any more (and
> is obviously not referenced elsewhere in that header file).  While
> in there, delete four other unneeded struct declarations in that
> file.
> 
> Doing so highlights that "fs/xfs/xfs_trace.h" was relying indirectly
> on "xfs_mount.h" to be #included in order to declare "struct
> xfs_bmbt_irec", so add that declaration to resolve that issue.
> 
> Signed-off-by: Alex Elder <elder@inktank.com>

Looks fine to me.
Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs: kill struct declarations in xfs_mount.h

[Christoph Hellwig]

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs