* [nacked] backlight-atmel-pwm-bl-remove-goto-err_free_mem.patch removed from -mm tree
@ 2012-08-16 18:31 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-08-16 18:31 UTC (permalink / raw)
To: jg1.han, egtvedt, rpurdie, mm-commits
The patch titled
Subject: drivers/video/backlight/atmel-pwm-bl.c: remove goto err_free_mem
has been removed from the -mm tree. Its filename was
backlight-atmel-pwm-bl-remove-goto-err_free_mem.patch
This patch was dropped because it was nacked
------------------------------------------------------
From: Jingoo Han <jg1.han@samsung.com>
Subject: drivers/video/backlight/atmel-pwm-bl.c: remove goto err_free_mem
Remove goto err_free_mem, which makes code a bit smaller.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/video/backlight/atmel-pwm-bl.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff -puN drivers/video/backlight/atmel-pwm-bl.c~backlight-atmel-pwm-bl-remove-goto-err_free_mem drivers/video/backlight/atmel-pwm-bl.c
--- a/drivers/video/backlight/atmel-pwm-bl.c~backlight-atmel-pwm-bl-remove-goto-err_free_mem
+++ a/drivers/video/backlight/atmel-pwm-bl.c
@@ -135,24 +135,20 @@ static int atmel_pwm_bl_probe(struct pla
pwmbl->pdev = pdev;
pdata = pdev->dev.platform_data;
- if (!pdata) {
- retval = -ENODEV;
- goto err_free_mem;
- }
+ if (!pdata)
+ return -ENODEV;
if (pdata->pwm_compare_max < pdata->pwm_duty_max ||
pdata->pwm_duty_min > pdata->pwm_duty_max ||
- pdata->pwm_frequency == 0) {
- retval = -EINVAL;
- goto err_free_mem;
- }
+ pdata->pwm_frequency == 0)
+ return -EINVAL;
pwmbl->pdata = pdata;
pwmbl->gpio_on = pdata->gpio_on;
retval = pwm_channel_alloc(pdata->pwm_channel, &pwmbl->pwmc);
if (retval)
- goto err_free_mem;
+ return retval;
if (pwmbl->gpio_on != -1) {
retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
@@ -200,7 +196,6 @@ err_free_bl_dev:
backlight_device_unregister(bldev);
err_free_pwm:
pwm_channel_free(&pwmbl->pwmc);
-err_free_mem:
return retval;
}
_
Patches currently in -mm which might be from jg1.han@samsung.com are
linux-next.patch
drivers-video-backlight-da9052_blc-use-usleep_range-instead-of-msleep-for-small-sleeps.patch
drivers-video-backlight-ltv350qvc-use-usleep_range-instead-of-msleep-for-small-sleeps.patch
drivers-video-backlight-kb3886_blc-use-usleep_range-instead-of-msleep-for-small-sleeps.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-16 18:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-16 18:31 [nacked] backlight-atmel-pwm-bl-remove-goto-err_free_mem.patch removed from -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.