[BUG] net/core/sock.c won't compile on alpha

[BUG] net/core/sock.c won't compile on alpha

[Bob Tracy]

Kernel version 3.6.0-rc2, and probably -rc1 as well.  I get the
following compile-time error on alpha architecture:

(...)
  CC      net/core/sock.o
net/core/sock.c:274:36: error: initializer element is not constant
net/core/sock.c:274:36: error: (near initialization for "memalloc_socks")
net/core/sock.c:274:36: error: initializer element is not constant
make[2]: *** [net/core/sock.o] Error 1
make[1]: *** [net/core] Error 2
make: *** [net] Error 2

Compiler is gcc-4.6.3.

Line 274 of net/core/sock.c is

struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE;

which made its first appearance in 3.6.0-rc1.

--Bob

Re: [BUG] net/core/sock.c won't compile on alpha

[Michael Cree]

On 23/08/2012, at 12:14 AM, Bob Tracy wrote:
> Kernel version 3.6.0-rc2, and probably -rc1 as well.  I get the
> following compile-time error on alpha architecture:
>
> (...)
>  CC      net/core/sock.o
> net/core/sock.c:274:36: error: initializer element is not constant

Try v3.6-rc3.  It should be fixed now.

Cheers
Michael.

Re: [BUG] net/core/sock.c won't compile on alpha

[Simon Brown]

Bob,

Is this a different issue to the one discussed and fixed earlier in the month
with this email subject:
Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant

Sounds very similar.

Simon

At Wed, 22 Aug 2012 07:14:07 -0500,
Bob Tracy wrote:
> 
> Kernel version 3.6.0-rc2, and probably -rc1 as well.  I get the
> following compile-time error on alpha architecture:
> 
> (...)
>   CC      net/core/sock.o
> net/core/sock.c:274:36: error: initializer element is not constant
> net/core/sock.c:274:36: error: (near initialization for "memalloc_socks")
> net/core/sock.c:274:36: error: initializer element is not constant
> make[2]: *** [net/core/sock.o] Error 1
> make[1]: *** [net/core] Error 2
> make: *** [net] Error 2
> 
> Compiler is gcc-4.6.3.
> 
> Line 274 of net/core/sock.c is
> 
> struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE;
> 
> which made its first appearance in 3.6.0-rc1.
> 
> --Bob
> --
> To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [BUG] net/core/sock.c won't compile on alpha

[Bob Tracy]

On Thu, Aug 23, 2012 at 09:16:53AM +1200, Michael Cree wrote:
> On 23/08/2012, at 12:14 AM, Bob Tracy wrote:
> >Kernel version 3.6.0-rc2, and probably -rc1 as well.  I get the
> >following compile-time error on alpha architecture:
> >
> >(...)
> > CC      net/core/sock.o
> >net/core/sock.c:274:36: error: initializer element is not constant
> 
> Try v3.6-rc3.  It should be fixed now.

That got it.  Finally saw the discussion on the bug (from about a month
ago -- thanks, Simon).

--Bob