All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: add Maxim MAX197 support
Date: Thu, 30 Aug 2012 14:14:44 -0700	[thread overview]
Message-ID: <20120830211444.GA11181@roeck-us.net> (raw)
In-Reply-To: <1040994502.402858.1346361031972.JavaMail.root@mail.savoirfairelinux.com>

On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote:
> Hi Guenter,
> 
> Thanks for your detailed comments. I'll send a new version soon.
> 
> About the following comment, I agree with you. However as there is no convention for this case, for now I would prefer to stick with the model as seen in drivers such as sht15.
> 
Actually, there is a convention, and it is much cleaner than using
multiple platform driver instances. I sent you a separate e-mail a
minute ago, describing how it works.

We should actually fix the sht15 driver as well to use the same approach.

Thanks,
Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: add Maxim MAX197 support
Date: Thu, 30 Aug 2012 21:14:44 +0000	[thread overview]
Message-ID: <20120830211444.GA11181@roeck-us.net> (raw)
In-Reply-To: <1040994502.402858.1346361031972.JavaMail.root@mail.savoirfairelinux.com>

On Thu, Aug 30, 2012 at 05:10:32PM -0400, Vivien Didelot wrote:
> Hi Guenter,
> 
> Thanks for your detailed comments. I'll send a new version soon.
> 
> About the following comment, I agree with you. However as there is no convention for this case, for now I would prefer to stick with the model as seen in drivers such as sht15.
> 
Actually, there is a convention, and it is much cleaner than using
multiple platform driver instances. I sent you a separate e-mail a
minute ago, describing how it works.

We should actually fix the sht15 driver as well to use the same approach.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2012-08-30 21:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30 18:39 [PATCH] hwmon: add Maxim MAX197 support Vivien Didelot
2012-08-30 18:39 ` [lm-sensors] " Vivien Didelot
2012-08-30 20:10 ` Guenter Roeck
2012-08-30 20:10   ` [lm-sensors] " Guenter Roeck
2012-08-30 21:10   ` Vivien Didelot
2012-08-30 21:10     ` [lm-sensors] " Vivien Didelot
2012-08-30 21:14     ` Guenter Roeck [this message]
2012-08-30 21:14       ` Guenter Roeck
2012-08-30 21:22       ` Vivien Didelot
2012-08-30 21:22         ` [lm-sensors] " Vivien Didelot
2012-08-30 21:25         ` Guenter Roeck
2012-08-30 21:25           ` [lm-sensors] " Guenter Roeck
2012-08-30 21:09 ` Guenter Roeck
2012-08-30 21:09   ` [lm-sensors] " Guenter Roeck
2012-08-31 14:37   ` Jean Delvare
2012-08-31 14:37     ` [lm-sensors] " Jean Delvare
2012-08-31 16:07     ` Guenter Roeck
2012-08-31 16:07       ` [lm-sensors] " Guenter Roeck
2012-08-31 17:38       ` Vivien Didelot
2012-08-31 17:38         ` [lm-sensors] " Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120830211444.GA11181@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.