* re: Bluetooth: Use GFP_KERNEL in read_index_list
@ 2012-09-04 16:21 Dan Carpenter
2012-09-04 18:52 ` Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-09-04 16:21 UTC (permalink / raw)
To: szymon.janc; +Cc: linux-bluetooth
Hello Szymon Janc,
The patch 7cfeb868eb85: "Bluetooth: Use GFP_KERNEL in
read_index_list" from Aug 31, 2012, leads to the following warning:
net/bluetooth/mgmt.c:343 read_index_list()
error: scheduling with locks held: 'read_lock:hci_dev_list_lock'
This patch should be reverted because we're not allowed to schedule
while holding the read lock. The way to avoid these bugs in the future
is to test with CONFIG_DEBUG_ATOMIC_SLEEP=y. It will give a big splat.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bluetooth: Use GFP_KERNEL in read_index_list
2012-09-04 16:21 Bluetooth: Use GFP_KERNEL in read_index_list Dan Carpenter
@ 2012-09-04 18:52 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2012-09-04 18:52 UTC (permalink / raw)
To: Dan Carpenter; +Cc: szymon.janc, linux-bluetooth
Hi Dan,
* Dan Carpenter <dan.carpenter@oracle.com> [2012-09-04 19:21:37 +0300]:
> Hello Szymon Janc,
>
> The patch 7cfeb868eb85: "Bluetooth: Use GFP_KERNEL in
> read_index_list" from Aug 31, 2012, leads to the following warning:
> net/bluetooth/mgmt.c:343 read_index_list()
> error: scheduling with locks held: 'read_lock:hci_dev_list_lock'
>
> This patch should be reverted because we're not allowed to schedule
> while holding the read lock. The way to avoid these bugs in the future
> is to test with CONFIG_DEBUG_ATOMIC_SLEEP=y. It will give a big splat.
I reverted this patch earlier this morning. It should be ok now.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-04 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-04 16:21 Bluetooth: Use GFP_KERNEL in read_index_list Dan Carpenter
2012-09-04 18:52 ` Gustavo Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.