All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Gerald Schaefer <gerald.schaefer@de.ibm.com>,
	Andi Kleen <ak@linux.intel.com>, Hugh Dickins <hughd@google.com>,
	Hillf Danton <dhillf@gmail.com>,
	linux-kernel@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [RFC v2 PATCH 0/7] thp: transparent hugepages on s390
Date: Wed, 5 Sep 2012 00:40:27 +0200	[thread overview]
Message-ID: <20120904224027.GM3334@redhat.com> (raw)
In-Reply-To: <20120831124702.8980b637.akpm@linux-foundation.org>

Hi Andrew and Martin,

On Fri, Aug 31, 2012 at 12:47:02PM -0700, Andrew Morton wrote:
> On Fri, 31 Aug 2012 09:07:57 +0200
> Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> 
> > > I grabbed them all.  Patches 1-3 look sane to me and I cheerfully
> > > didn't read the s390 changes at all.  Hopefully Andrea will be able to
> > > review at least patches 1-3 for us.
> > > 
> > > If that all goes well, how do we play this?  I'd prefer to merge 1-3
> > > myself, as they do interact with ongoing MM development.  I can also
> > > merge 4-7 if appropriate s390 maintainer acks are seen.  Or I can drop
> > > them and the s390 parts can be merged via the s390 tree at a later
> > > date?
> > 
> > I would really appreciate if Andrea could have a look at the code.
> 
> Yes please ;)

:) Sorry for the delay! I was at the Plumbers until last Friday and
I'm catching up with the emails.

I finished reviewing them and they look perfectly fine. In fact it was
a pleasure to read them. Patch 1 and 2 are noops in x86 context, patch
3 is fine as well.

The s390 solution to send a dummy IPIs to wait gup-fast to exit the
critical section after setting the splitting bit looks fine as well.

The only additional code cleanup suggestion I can give is to also add
a HAVE_ARCH_TRANSPARENT_HUGEPAGE on the same lines of:

http://git.kernel.org/?p=linux/kernel/git/andrea/aa.git;a=commitdiff;h=36c2d096cce61fcfc1726ea1c1fd6dd65ddf8b08;hp=b2a86603629e2401d85f9ed1acbcf6c0043b2b23

as patch 8. In order to convert the below:

+       depends on (X86 || (S390 && 64BIT)) && MMU

to:

       depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE

The MMU check looks already superflous, even more so after adding the
HAVE_ARCH_TRANSPARENT_HUGEPAGE (if something it'll be up to the arch
code to add a dependency on it before defining HAVE_ARCH_).

Thanks,
Andrea

      reply	other threads:[~2012-09-04 22:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29 15:32 [RFC v2 PATCH 0/7] thp: transparent hugepages on s390 Gerald Schaefer
2012-08-29 15:32 ` [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type Gerald Schaefer
2012-08-31  5:29   ` Aneesh Kumar K.V
2012-08-31  7:10     ` Martin Schwidefsky
2012-09-04 22:56   ` Andrea Arcangeli
2012-09-05 17:12     ` Gerald Schaefer
2012-08-29 15:32 ` [RFC v2 PATCH 2/7] thp: introduce pmdp_invalidate() Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 3/7] thp: make MADV_HUGEPAGE check for mm->def_flags Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 4/7] thp, s390: thp splitting backend for s390 Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 5/7] thp, s390: thp pagetable pre-allocation " Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 6/7] thp, s390: disable thp for kvm host on s390 Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 7/7] thp, s390: architecture backend for thp " Gerald Schaefer
2012-08-30 19:54 ` [RFC v2 PATCH 0/7] thp: transparent hugepages " Andrew Morton
2012-08-31  7:07   ` Martin Schwidefsky
2012-08-31 19:47     ` Andrew Morton
2012-09-04 22:40       ` Andrea Arcangeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120904224027.GM3334@redhat.com \
    --to=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhillf@gmail.com \
    --cc=gerald.schaefer@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.