From: Andrea Arcangeli <aarcange@redhat.com>
To: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Hugh Dickins <hughd@google.com>,
Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type
Date: Wed, 5 Sep 2012 00:56:33 +0200 [thread overview]
Message-ID: <20120904225632.GN3334@redhat.com> (raw)
In-Reply-To: <1346254384-30046-2-git-send-email-gerald.schaefer@de.ibm.com>
Hi Gerald,
On Wed, Aug 29, 2012 at 05:32:58PM +0200, Gerald Schaefer wrote:
> +#ifndef __HAVE_ARCH_PGTABLE_DEPOSIT
> +extern void pgtable_deposit(struct mm_struct *mm, pgtable_t pgtable);
> +#endif
One minor nitpick on the naming of the two functions: considering that
those are global exports, that they can only be used by THP and they
mangle internally with the mm->pmd_huge_pte field (also only defined
if TRANSPARENT_HUGEPAGE=y), a more specific THP naming may be clearer.
If the current prepare_pmd_huge_pte/get_pmd_huge_pte wasn't good other
options could be pgtable_trans_huge_deposit/withdraw.
next prev parent reply other threads:[~2012-09-04 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 15:32 [RFC v2 PATCH 0/7] thp: transparent hugepages on s390 Gerald Schaefer
2012-08-29 15:32 ` [RFC v2 PATCH 1/7] thp: remove assumptions on pgtable_t type Gerald Schaefer
2012-08-31 5:29 ` Aneesh Kumar K.V
2012-08-31 7:10 ` Martin Schwidefsky
2012-09-04 22:56 ` Andrea Arcangeli [this message]
2012-09-05 17:12 ` Gerald Schaefer
2012-08-29 15:32 ` [RFC v2 PATCH 2/7] thp: introduce pmdp_invalidate() Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 3/7] thp: make MADV_HUGEPAGE check for mm->def_flags Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 4/7] thp, s390: thp splitting backend for s390 Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 5/7] thp, s390: thp pagetable pre-allocation " Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 6/7] thp, s390: disable thp for kvm host on s390 Gerald Schaefer
2012-08-29 15:33 ` [RFC v2 PATCH 7/7] thp, s390: architecture backend for thp " Gerald Schaefer
2012-08-30 19:54 ` [RFC v2 PATCH 0/7] thp: transparent hugepages " Andrew Morton
2012-08-31 7:07 ` Martin Schwidefsky
2012-08-31 19:47 ` Andrew Morton
2012-09-04 22:40 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904225632.GN3334@redhat.com \
--to=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.