From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/6] video: cfb_console: logo can be positioned via the splashpos variable
Date: Wed, 5 Sep 2012 13:11:27 +0200 [thread overview]
Message-ID: <20120905131127.06589ed2@wker> (raw)
In-Reply-To: <OF10D7C3FF.F3F2D35A-ONC1257A70.003AD336-C1257A70.003BEB1B@sewerin.de>
Hello Bastian,
On Wed, 5 Sep 2012 12:52:59 +0200
Bastian.Ruppert at sewerin.de wrote:
...
> > + video_logo_height += video_logo_ypos;
> > + return video_fb_address + video_logo_height * VIDEO_LINE_LEN;
> > + }
> > +#endif
>
> I have some trouble with this version when using splashpos = m,m .
> In this case video_logo_ypos is 32767 (BMP_ALIGN_CENTER) here.
> Following extension isworking for me:
Ah, indeed. Thanks for testing and catching it.
> #ifdef CONFIG_SPLASH_SCREEN_ALIGN
> /*
> * when using splashpos for video_logo, skip any info
> * output on video console if the logo is not at 0,0
> */
> if (video_logo_xpos || video_logo_ypos) {
> /*
> * video_logo_height is used in text and cursor offset
> * calculations. Since the console is below the logo,
> * we need to adjust the logo height
> */
> if (video_logo_ypos == BMP_ALIGN_CENTER)
> video_logo_height += max(0, (VIDEO_VISIBLE_ROWS - \
> VIDEO_LOGO_HEIGHT) /
> 2);
> else if (video_logo_ypos >= 0)
> video_logo_height += video_logo_ypos;
OK. But please use
else if (video_logo_ypos > 0)
video_logo_height += video_logo_ypos;
...
> Should i post a version 3 for this patch?
Yes, please.
Thanks,
Anatolij
next prev parent reply other threads:[~2012-09-05 11:11 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 7:26 [U-Boot] [PATCH 1/6] davinci: ea20: reorganisation LCD startup Bastian Ruppert
2012-08-10 7:26 ` [U-Boot] [PATCH 2/6] davinci: ea20: the console is always set to the serial line Bastian Ruppert
2012-08-15 17:04 ` Stefano Babic
2012-08-10 7:26 ` [U-Boot] [PATCH 3/6] video: cfb_console: logo can be positioned via the splashpos variable Bastian Ruppert
2012-09-01 22:29 ` [U-Boot] [PATCH v2 " Anatolij Gustschin
2012-09-05 10:52 ` Bastian.Ruppert at sewerin.de
2012-09-05 11:11 ` Anatolij Gustschin [this message]
2012-09-06 6:07 ` [U-Boot] [PATCH v3 1/6] davinci: ea20: reorganisation LCD startup Bastian Ruppert
2012-09-06 6:07 ` [U-Boot] [PATCH v3 2/6] davinci: ea20: the console is always set to the serial line Bastian Ruppert
2012-09-06 6:07 ` [U-Boot] [PATCH v3 3/6] video: cfb_console: logo can be positioned via the splashpos variable Bastian Ruppert
2012-09-06 18:55 ` Anatolij Gustschin
2012-09-06 6:07 ` [U-Boot] [PATCH v3 4/6] video: cfb_console: add function to plot the logo area black Bastian Ruppert
2012-09-06 18:56 ` Anatolij Gustschin
2012-09-06 6:07 ` [U-Boot] [PATCH v3 5/6] da850/omap-l138: davinci_emac: Suppress auto negotiation if needed Bastian Ruppert
2012-09-07 8:08 ` Prabhakar Lad
2012-09-09 2:14 ` Tom Rini
2012-09-10 6:01 ` Bastian.Ruppert at sewerin.de
2012-09-10 16:08 ` Tom Rini
2012-09-11 4:16 ` Prabhakar Lad
2012-09-11 5:32 ` Bastian.Ruppert at sewerin.de
2012-09-12 16:15 ` Tom Rini
2012-09-06 6:07 ` [U-Boot] [PATCH v3 6/6] davinci: ea20: add some configs and default environmet variables Bastian Ruppert
2012-09-01 22:50 ` [U-Boot] [PATCH 3/6] video: cfb_console: logo can be positioned via the splashpos variable Anatolij Gustschin
2012-09-05 10:52 ` Bastian.Ruppert at sewerin.de
2012-09-14 8:28 ` [U-Boot] [PATCH v4 1/6] davinci: ea20: reorganisation LCD startup Bastian Ruppert
2012-09-14 8:29 ` [U-Boot] [PATCH v4 2/6] davinci: ea20: the console is always set to the serial line Bastian Ruppert
2012-09-14 8:29 ` [U-Boot] [PATCH v4 3/6] video: cfb_console: logo can be positioned via the splashpos variable Bastian Ruppert
2012-09-14 8:29 ` [U-Boot] [PATCH v4 4/6] video: cfb_console: add function to plot the logo area black Bastian Ruppert
2012-09-14 8:29 ` [U-Boot] [PATCH v4 5/6] da850/omap-l138: davinci_emac: Suppress auto negotiation if needed Bastian Ruppert
2012-09-17 5:19 ` Prabhakar Lad
2012-09-14 8:29 ` [U-Boot] [PATCH v4 6/6] davinci: ea20: add some configs and default environmet variables Bastian Ruppert
2012-08-10 7:26 ` [U-Boot] [PATCH 4/6] video: cfb_console: add function to plot the logo area black Bastian Ruppert
2012-08-10 7:26 ` [U-Boot] [PATCH 5/6] da850/omap-l138: davinci_emac: Suppress auto negotiation if needed Bastian Ruppert
2012-08-15 17:04 ` Stefano Babic
2012-08-10 7:26 ` [U-Boot] [PATCH 6/6] davinci: ea20: add some configs and default environmet variables Bastian Ruppert
2012-08-15 17:03 ` Stefano Babic
2012-08-15 16:55 ` [U-Boot] [PATCH 1/6] davinci: ea20: reorganisation LCD startup Tom Rini
2012-08-24 17:55 ` Tom Rini
2012-09-07 4:48 ` Bastian.Ruppert at sewerin.de
2012-08-15 17:04 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905131127.06589ed2@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.