* [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
@ 2012-09-05 14:35 Fabio Estevam
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-09-05 14:35 UTC (permalink / raw)
To: artem.bityutskiy; +Cc: marex, b32955, linux-mtd, Fabio Estevam, kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Using module_platform_driver() makes the code smaller and cleaner.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
This patch depends on: "mtd: gpmi-nand: Improve logging style"
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 29 +++++++----------------------
1 file changed, 7 insertions(+), 22 deletions(-)
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 9493507..5999b15 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1651,6 +1651,8 @@ static int __devinit gpmi_nand_probe(struct platform_device *pdev)
if (ret)
goto exit_nfc_init;
+ dev_info(this->dev, "driver registered.\n");
+
return 0;
exit_nfc_init:
@@ -1658,10 +1660,12 @@ exit_nfc_init:
exit_acquire_resources:
platform_set_drvdata(pdev, NULL);
kfree(this);
+ dev_err(this->dev, "driver registration failed: %d\n", ret);
+
return ret;
}
-static int __exit gpmi_nand_remove(struct platform_device *pdev)
+static int __devexit gpmi_nand_remove(struct platform_device *pdev)
{
struct gpmi_nand_data *this = platform_get_drvdata(pdev);
@@ -1678,29 +1682,10 @@ static struct platform_driver gpmi_nand_driver = {
.of_match_table = gpmi_nand_id_table,
},
.probe = gpmi_nand_probe,
- .remove = __exit_p(gpmi_nand_remove),
+ .remove = __devexit_p(gpmi_nand_remove),
.id_table = gpmi_ids,
};
-
-static int __init gpmi_nand_init(void)
-{
- int err;
-
- err = platform_driver_register(&gpmi_nand_driver);
- if (err == 0)
- pr_info("driver registered.\n");
- else
- pr_err("driver registration failed.\n");
- return err;
-}
-
-static void __exit gpmi_nand_exit(void)
-{
- platform_driver_unregister(&gpmi_nand_driver);
-}
-
-module_init(gpmi_nand_init);
-module_exit(gpmi_nand_exit);
+module_platform_driver(gpmi_nand_driver);
MODULE_AUTHOR("Freescale Semiconductor, Inc.");
MODULE_DESCRIPTION("i.MX GPMI NAND Flash Controller Driver");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] mtd: mxc_nand: Convert to platform driver
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
@ 2012-09-05 14:35 ` Fabio Estevam
2012-09-15 13:33 ` Fabio Estevam
2012-09-05 18:55 ` [PATCH 1/2] mtd: gpmi-nand: " Marek Vasut
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2012-09-05 14:35 UTC (permalink / raw)
To: artem.bityutskiy; +Cc: marex, b32955, linux-mtd, Fabio Estevam, kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Using module_platform_driver() makes the code smaller and cleaner.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/mtd/nand/mxc_nand.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index e59a45f..cc8b1e1 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1389,7 +1389,7 @@ static int __init mxcnd_probe_pdata(struct mxc_nand_host *host)
return 0;
}
-static int __init mxcnd_probe(struct platform_device *pdev)
+static int __devinit mxcnd_probe(struct platform_device *pdev)
{
struct nand_chip *this;
struct mtd_info *mtd;
@@ -1581,22 +1581,10 @@ static struct platform_driver mxcnd_driver = {
.owner = THIS_MODULE,
.of_match_table = of_match_ptr(mxcnd_dt_ids),
},
+ .probe = mxcnd_probe,
.remove = __devexit_p(mxcnd_remove),
};
-
-static int __init mxc_nd_init(void)
-{
- return platform_driver_probe(&mxcnd_driver, mxcnd_probe);
-}
-
-static void __exit mxc_nd_cleanup(void)
-{
- /* Unregister the device structure */
- platform_driver_unregister(&mxcnd_driver);
-}
-
-module_init(mxc_nd_init);
-module_exit(mxc_nd_cleanup);
+module_platform_driver(mxcnd_driver);
MODULE_AUTHOR("Freescale Semiconductor, Inc.");
MODULE_DESCRIPTION("MXC NAND MTD driver");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
@ 2012-09-05 18:55 ` Marek Vasut
2012-09-05 19:00 ` Fabio Estevam
2012-09-21 12:19 ` Fabio Estevam
2012-09-22 14:59 ` Artem Bityutskiy
3 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2012-09-05 18:55 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, artem.bityutskiy, linux-mtd, kernel, b32955
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using module_platform_driver() makes the code smaller and cleaner.
You did not document the dev_info() etc. addition, dunno if it's important or
not.
Otherwise,
Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> This patch depends on: "mtd: gpmi-nand: Improve logging style"
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 29
> +++++++---------------------- 1 file changed, 7 insertions(+), 22
> deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 9493507..5999b15 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1651,6 +1651,8 @@ static int __devinit gpmi_nand_probe(struct
> platform_device *pdev) if (ret)
> goto exit_nfc_init;
>
> + dev_info(this->dev, "driver registered.\n");
> +
> return 0;
>
> exit_nfc_init:
> @@ -1658,10 +1660,12 @@ exit_nfc_init:
> exit_acquire_resources:
> platform_set_drvdata(pdev, NULL);
> kfree(this);
> + dev_err(this->dev, "driver registration failed: %d\n", ret);
> +
> return ret;
> }
>
> -static int __exit gpmi_nand_remove(struct platform_device *pdev)
> +static int __devexit gpmi_nand_remove(struct platform_device *pdev)
> {
> struct gpmi_nand_data *this = platform_get_drvdata(pdev);
>
> @@ -1678,29 +1682,10 @@ static struct platform_driver gpmi_nand_driver = {
> .of_match_table = gpmi_nand_id_table,
> },
> .probe = gpmi_nand_probe,
> - .remove = __exit_p(gpmi_nand_remove),
> + .remove = __devexit_p(gpmi_nand_remove),
> .id_table = gpmi_ids,
> };
> -
> -static int __init gpmi_nand_init(void)
> -{
> - int err;
> -
> - err = platform_driver_register(&gpmi_nand_driver);
> - if (err == 0)
> - pr_info("driver registered.\n");
> - else
> - pr_err("driver registration failed.\n");
> - return err;
> -}
> -
> -static void __exit gpmi_nand_exit(void)
> -{
> - platform_driver_unregister(&gpmi_nand_driver);
> -}
> -
> -module_init(gpmi_nand_init);
> -module_exit(gpmi_nand_exit);
> +module_platform_driver(gpmi_nand_driver);
>
> MODULE_AUTHOR("Freescale Semiconductor, Inc.");
> MODULE_DESCRIPTION("i.MX GPMI NAND Flash Controller Driver");
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 18:55 ` [PATCH 1/2] mtd: gpmi-nand: " Marek Vasut
@ 2012-09-05 19:00 ` Fabio Estevam
2012-09-05 19:23 ` Marek Vasut
0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2012-09-05 19:00 UTC (permalink / raw)
To: Marek Vasut; +Cc: Fabio Estevam, artem.bityutskiy, linux-mtd, kernel, b32955
Hi Marek,
On Wed, Sep 5, 2012 at 3:55 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Fabio Estevam,
>
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Using module_platform_driver() makes the code smaller and cleaner.
>
> You did not document the dev_info() etc. addition, dunno if it's important or
> not.
It is not an addition. I just moved "pr_info("driver registered.\n")"
from gpmi_nand_init, (which is removed by this patch) to the probe
function.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 19:00 ` Fabio Estevam
@ 2012-09-05 19:23 ` Marek Vasut
2012-09-05 19:51 ` Fabio Estevam
0 siblings, 1 reply; 10+ messages in thread
From: Marek Vasut @ 2012-09-05 19:23 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, artem.bityutskiy, linux-mtd, kernel, b32955
Dear Fabio Estevam,
> Hi Marek,
>
> On Wed, Sep 5, 2012 at 3:55 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Fabio Estevam,
> >
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Using module_platform_driver() makes the code smaller and cleaner.
> >
> > You did not document the dev_info() etc. addition, dunno if it's
> > important or not.
>
> It is not an addition. I just moved "pr_info("driver registered.\n")"
> from gpmi_nand_init, (which is removed by this patch) to the probe
> function.
Ah, just noticed. I'd say drop it completely then, there's now value in this
print (or make it pr_debug() ). Besides, the init call was called only once if
compiled in / every time if built as a module. The probe call is done per GPMI
nand driver instance.
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 19:23 ` Marek Vasut
@ 2012-09-05 19:51 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-09-05 19:51 UTC (permalink / raw)
To: Marek Vasut; +Cc: Fabio Estevam, artem.bityutskiy, linux-mtd, kernel, b32955
On Wed, Sep 5, 2012 at 4:23 PM, Marek Vasut <marex@denx.de> wrote:
> Ah, just noticed. I'd say drop it completely then, there's now value in this
> print (or make it pr_debug() ). Besides, the init call was called only once if
I think we can keep this info. It does not hurt and this is how the
current driver does.
> compiled in / every time if built as a module. The probe call is done per GPMI
> nand driver instance.
,which is fine too.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] mtd: mxc_nand: Convert to platform driver
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
@ 2012-09-15 13:33 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2012-09-15 13:33 UTC (permalink / raw)
To: artem.bityutskiy; +Cc: marex, b32955, linux-mtd, Fabio Estevam, kernel
Hi Artem,
On Wed, Sep 5, 2012 at 11:35 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using module_platform_driver() makes the code smaller and cleaner.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Does this series look fine?
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
2012-09-05 18:55 ` [PATCH 1/2] mtd: gpmi-nand: " Marek Vasut
@ 2012-09-21 12:19 ` Fabio Estevam
2012-09-21 12:53 ` Marek Vasut
2012-09-22 14:59 ` Artem Bityutskiy
3 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2012-09-21 12:19 UTC (permalink / raw)
To: artem.bityutskiy; +Cc: marex, b32955, linux-mtd, Fabio Estevam, kernel
Hi Artem.
On Wed, Sep 5, 2012 at 11:35 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using module_platform_driver() makes the code smaller and cleaner.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> This patch depends on: "mtd: gpmi-nand: Improve logging style"
Any comments, please?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-21 12:19 ` Fabio Estevam
@ 2012-09-21 12:53 ` Marek Vasut
0 siblings, 0 replies; 10+ messages in thread
From: Marek Vasut @ 2012-09-21 12:53 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, artem.bityutskiy, b32955, linux-mtd, kernel, Shawn Guo
Dear Fabio Estevam,
> Hi Artem.
>
> On Wed, Sep 5, 2012 at 11:35 AM, Fabio Estevam <festevam@gmail.com> wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Using module_platform_driver() makes the code smaller and cleaner.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > This patch depends on: "mtd: gpmi-nand: Improve logging style"
>
> Any comments, please?
WFM
Reviewed-by: Marek Vasut <marex@denx.de>
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
` (2 preceding siblings ...)
2012-09-21 12:19 ` Fabio Estevam
@ 2012-09-22 14:59 ` Artem Bityutskiy
3 siblings, 0 replies; 10+ messages in thread
From: Artem Bityutskiy @ 2012-09-22 14:59 UTC (permalink / raw)
To: Fabio Estevam
Cc: marex, Fabio Estevam, artem.bityutskiy, b32955, linux-mtd, kernel
[-- Attachment #1: Type: text/plain, Size: 328 bytes --]
On Wed, 2012-09-05 at 11:35 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Using module_platform_driver() makes the code smaller and cleaner.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Pushed both to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-09-22 14:59 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-05 14:35 [PATCH 1/2] mtd: gpmi-nand: Convert to platform driver Fabio Estevam
2012-09-05 14:35 ` [PATCH 2/2] mtd: mxc_nand: " Fabio Estevam
2012-09-15 13:33 ` Fabio Estevam
2012-09-05 18:55 ` [PATCH 1/2] mtd: gpmi-nand: " Marek Vasut
2012-09-05 19:00 ` Fabio Estevam
2012-09-05 19:23 ` Marek Vasut
2012-09-05 19:51 ` Fabio Estevam
2012-09-21 12:19 ` Fabio Estevam
2012-09-21 12:53 ` Marek Vasut
2012-09-22 14:59 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.