From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
b-cousson@ti.com, balbi@ti.com, santosh.shilimkar@ti.com,
sameo@linux.intel.com
Subject: Re: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Sat, 8 Sep 2012 04:12:38 +0100 [thread overview]
Message-ID: <20120908031237.GA31018@sirena.org.uk> (raw)
In-Reply-To: <1346844964-24839-1-git-send-email-sourav.poddar@ti.com>
On Wed, Sep 05, 2012 at 05:06:04PM +0530, Sourav Poddar wrote:
> +static struct regmap_config smsc_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = SMSC_MAX_REGISTER - 1;
That max_register setup looks very odd...
> + .cache_type = REGCACHE_COMPRESSED,
> +};
Are you sure the compressed type is sensible? It would normally only
make sense with a large number of closely packed registers but this
device has 8 bit register values.
> +#ifdef CONFIG_OF
> + of_property_read_u32(node, "clock", &smsc->clk);
> +#endif
> + ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk);
> + if (ret)
> + goto err;
What happens on non-DT systems?
> +static int smsc_i2c_remove(struct i2c_client *i2c)
> +{
> + return 0;
> +}
Remove empty functions, though it's rather surprising that there's
nothing at all to do here.. Normally an MFD would at least remove its
children.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Sat, 8 Sep 2012 04:12:38 +0100 [thread overview]
Message-ID: <20120908031237.GA31018@sirena.org.uk> (raw)
In-Reply-To: <1346844964-24839-1-git-send-email-sourav.poddar@ti.com>
On Wed, Sep 05, 2012 at 05:06:04PM +0530, Sourav Poddar wrote:
> +static struct regmap_config smsc_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = SMSC_MAX_REGISTER - 1;
That max_register setup looks very odd...
> + .cache_type = REGCACHE_COMPRESSED,
> +};
Are you sure the compressed type is sensible? It would normally only
make sense with a large number of closely packed registers but this
device has 8 bit register values.
> +#ifdef CONFIG_OF
> + of_property_read_u32(node, "clock", &smsc->clk);
> +#endif
> + ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk);
> + if (ret)
> + goto err;
What happens on non-DT systems?
> +static int smsc_i2c_remove(struct i2c_client *i2c)
> +{
> + return 0;
> +}
Remove empty functions, though it's rather surprising that there's
nothing at all to do here.. Normally an MFD would at least remove its
children.
next prev parent reply other threads:[~2012-09-08 3:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:36 [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Sourav Poddar
2012-09-05 11:36 ` Sourav Poddar
2012-09-05 11:36 ` Sourav Poddar
2012-09-05 17:53 ` Vaibhav Hiremath
2012-09-05 17:53 ` Vaibhav Hiremath
2012-09-05 17:53 ` Vaibhav Hiremath
2012-09-06 5:50 ` Poddar, Sourav
2012-09-06 5:50 ` Poddar, Sourav
2012-09-08 3:12 ` Mark Brown [this message]
2012-09-08 3:12 ` Mark Brown
2012-09-25 17:52 ` Mark Brown
2012-09-25 17:52 ` Mark Brown
2012-09-25 18:01 ` Poddar, Sourav
2012-09-25 18:01 ` Poddar, Sourav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908031237.GA31018@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.