All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc MERLIN <marc@merlins.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>, David Rientjes <rientjes@google.com>,
	sgruszka@redhat.com, linux-wireless@vger.kernel.org,
	johannes.berg@intel.com, wey-yi.w.guy@intel.com,
	ilw@linux.intel.com, Andrew Morton <akpm@osdl.org>,
	Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: iwl3945: order 5 allocation during ifconfig up; vm problem?
Date: Tue, 11 Sep 2012 22:57:12 -0700	[thread overview]
Message-ID: <20120912055712.GE11613@merlins.org> (raw)
In-Reply-To: <1347426988.13103.684.camel@edumazet-glaptop>

On Wed, Sep 12, 2012 at 07:16:28AM +0200, Eric Dumazet wrote:
> On Tue, 2012-09-11 at 16:25 -0700, Andrew Morton wrote:
> 
> > Asking for a 256k allocation is pretty crazy - this is an operating
> > system kernel, not a userspace application.
> > 
> > I'm wondering if this is due to a recent change, but I'm having trouble
> > working out where the allocation call site is.
> > --
> 
> (Adding Marc Merlin to CC, since he reported same problem)
> 
> Thats the firmware loading in iwlwifi driver. Not sure if it can use SG.
> 
> drivers/net/wireless/iwlwifi/iwl-drv.c
> 
> iwl_alloc_ucode() -> iwl_alloc_fw_desc() -> dma_alloc_coherent()
> 
> It seems some sections of /lib/firmware/iwlwifi*.ucode files are above
> 128 Kbytes, so dma_alloc_coherent() try order-5 allocations

Thanks for looping me in, yes, this looks very familiar to me :)

In the other thread, Johannes Berg gave me this patch which is supposed to
help: http://p.sipsolutions.net/11ea33b376a5bac5.txt

Unfortunately due to very long work days, I haven't had the time to try it
out yet, but I will soon.

Would that help in this case too?

And to answer David Rientjes, I also have compaction on:
gandalfthegreat:~# zgrep CONFIG_COMPACTION /proc/config.gz 
CONFIG_COMPACTION=y

Full config:
http://marc.merlins.org/tmp/config-3.5.2-amd64-preempt-noide-20120731

If that helps for comparison, my thread is here:
http://www.spinics.net/lists/linux-wireless/msg96438.html

Thanks,
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  

WARNING: multiple messages have this Message-ID (diff)
From: Marc MERLIN <marc@merlins.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>, David Rientjes <rientjes@google.com>,
	sgruszka@redhat.com, linux-wireless@vger.kernel.org,
	johannes.berg@intel.com, wey-yi.w.guy@intel.com,
	ilw@linux.intel.com, Andrew Morton <akpm@osdl.org>,
	Mel Gorman <mgorman@suse.de>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: iwl3945: order 5 allocation during ifconfig up; vm problem?
Date: Tue, 11 Sep 2012 22:57:12 -0700	[thread overview]
Message-ID: <20120912055712.GE11613@merlins.org> (raw)
In-Reply-To: <1347426988.13103.684.camel@edumazet-glaptop>

On Wed, Sep 12, 2012 at 07:16:28AM +0200, Eric Dumazet wrote:
> On Tue, 2012-09-11 at 16:25 -0700, Andrew Morton wrote:
> 
> > Asking for a 256k allocation is pretty crazy - this is an operating
> > system kernel, not a userspace application.
> > 
> > I'm wondering if this is due to a recent change, but I'm having trouble
> > working out where the allocation call site is.
> > --
> 
> (Adding Marc Merlin to CC, since he reported same problem)
> 
> Thats the firmware loading in iwlwifi driver. Not sure if it can use SG.
> 
> drivers/net/wireless/iwlwifi/iwl-drv.c
> 
> iwl_alloc_ucode() -> iwl_alloc_fw_desc() -> dma_alloc_coherent()
> 
> It seems some sections of /lib/firmware/iwlwifi*.ucode files are above
> 128 Kbytes, so dma_alloc_coherent() try order-5 allocations

Thanks for looping me in, yes, this looks very familiar to me :)

In the other thread, Johannes Berg gave me this patch which is supposed to
help: http://p.sipsolutions.net/11ea33b376a5bac5.txt

Unfortunately due to very long work days, I haven't had the time to try it
out yet, but I will soon.

Would that help in this case too?

And to answer David Rientjes, I also have compaction on:
gandalfthegreat:~# zgrep CONFIG_COMPACTION /proc/config.gz 
CONFIG_COMPACTION=y

Full config:
http://marc.merlins.org/tmp/config-3.5.2-amd64-preempt-noide-20120731

If that helps for comparison, my thread is here:
http://www.spinics.net/lists/linux-wireless/msg96438.html

Thanks,
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-09-12  5:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-09 21:32 iwl3945: order 5 allocation during ifconfig up; vm problem? Pavel Machek
2012-09-09 21:32 ` Pavel Machek
2012-09-09 22:40 ` David Rientjes
2012-09-09 22:40   ` David Rientjes
2012-09-10 11:11   ` Pavel Machek
2012-09-10 11:11     ` Pavel Machek
2012-09-11 23:25     ` Andrew Morton
2012-09-11 23:25       ` Andrew Morton
2012-09-12  5:16       ` Eric Dumazet
2012-09-12  5:16         ` Eric Dumazet
2012-09-12  5:57         ` Marc MERLIN [this message]
2012-09-12  5:57           ` Marc MERLIN
2012-09-12  6:54           ` Johannes Berg
2012-09-12  6:54             ` Johannes Berg
2012-09-24  9:03             ` Dan Carpenter
2012-09-24  9:03               ` Dan Carpenter
2012-09-24  9:14               ` Johannes Berg
2012-09-24  9:14                 ` Johannes Berg
2012-09-12  9:22       ` Stanislaw Gruszka
2012-09-12  9:22         ` Stanislaw Gruszka
2012-09-12 10:18       ` Mel Gorman
2012-09-12 10:18         ` Mel Gorman
2012-10-03 11:37         ` Stanislaw Gruszka
2012-10-03 11:37           ` Stanislaw Gruszka
2012-10-03 18:07           ` David Rientjes
2012-10-03 18:07             ` David Rientjes
2012-10-05  8:37             ` Stanislaw Gruszka
2012-10-05  8:37               ` Stanislaw Gruszka
2012-10-06 12:08               ` Pavel Machek
2012-10-06 12:08                 ` Pavel Machek
2012-10-08 15:38                 ` Stanislaw Gruszka
2012-10-08 15:38                   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912055712.GE11613@merlins.org \
    --to=marc@merlins.org \
    --cc=akpm@linux-foundation.org \
    --cc=akpm@osdl.org \
    --cc=eric.dumazet@gmail.com \
    --cc=ilw@linux.intel.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=pavel@ucw.cz \
    --cc=rientjes@google.com \
    --cc=sgruszka@redhat.com \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.