All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Stuge <peter@stuge.se>
To: Rene Buergel <rene.buergel@sohard.de>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [Patch v5] ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
Date: Wed, 26 Sep 2012 23:27:10 +0200	[thread overview]
Message-ID: <20120926212710.5775.qmail@stuge.se> (raw)
In-Reply-To: <47b117b0-5776-41c4-8b49-e3a21e80a6a4@shmail0>

Rene Buergel wrote:
> - renamed CONFIG_USB_EZUSB to CONFIG_USB_EZUSB_FX2 to avoid build errors

Is this really the reason for the build error? I doubt it.

Also, does the code in fact support only FX2, neither older chips nor
newer FX3?


> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 1bfcd02..bf7dc43 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -244,3 +244,8 @@ config USB_YUREX
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called yurex.
>  
> +config USB_EZUSB_FX2
> +	tristate "Functions for loading firmware on EZUSB chips"

If only FX2 then I suggest mentioning that also in the immediately
user-visible option description, not only in the help.


> +	help
> +	  Say Y here if you need EZUSB device support.
> +	  (Cypress FX/FX2/FX2LP microcontrollers)

If FX is also supported then perhaps still rename the option,
although I think renaming is unrelated to the build problems.

I think it makes sense to call the option after the "highest"
supported chip.


//Peter

  parent reply	other threads:[~2012-09-26 21:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c28594f9-45a3-4232-82fc-2f7c65cfb30c@shmail0>
2012-09-26 20:20 ` [Patch v5] ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc Rene Buergel
2012-09-26 20:28   ` Greg KH
2012-09-26 21:27   ` Peter Stuge [this message]
2012-09-26 22:08     ` Greg KH
2012-09-26 22:36     ` Rene Buergel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120926212710.5775.qmail@stuge.se \
    --to=peter@stuge.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rene.buergel@sohard.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.