Re: ASoC: dapm: Allow regulators to bypass as well as disable when idle

Re: ASoC: dapm: Allow regulators to bypass as well as disable when idle

[Dan Carpenter]

Hi Mark,

I had a question about patch c05b84d14b23: "ASoC: dapm: Allow regulators
to bypass as well as disable when idle" from Sep 7, 2012.

  1022          if (SND_SOC_DAPM_EVENT_ON(event)) {
  1023                  if (w->invert & SND_SOC_DAPM_REGULATOR_BYPASS) {
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  1024                          ret = regulator_allow_bypass(w->regulator, true);
  1025                          if (ret != 0)
  1026                                  dev_warn(w->dapm->dev,
  1027                                           "Failed to bypass %s: %d\n",
  1028                                           w->name, ret);
  1029                  }
  1030  
  1031                  return regulator_enable(w->regulator);
  1032          } else {
  1033                  if (w->invert & SND_SOC_DAPM_REGULATOR_BYPASS) {
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Right now ->invert is a single bit bitfield.  We mostly test
"if (w->invert) {...".  Are we planning to add some more bits in there?

  1034                          ret = regulator_allow_bypass(w->regulator, false);
  1035                          if (ret != 0)
  1036                                  dev_warn(w->dapm->dev,
  1037                                           "Failed to unbypass %s: %d\n",
  1038                                           w->name, ret);
  1039                  }

regards,
dan carpenter

Re: ASoC: dapm: Allow regulators to bypass as well as disable when idle

[Mark Brown]

On Thu, Sep 27, 2012 at 10:57:58PM +0300, Dan Carpenter wrote:

> Right now ->invert is a single bit bitfield.  We mostly test
> "if (w->invert) {...".  Are we planning to add some more bits in there?

There aren't any plans at present, but it's possible we might add some.
When we do the definition of invert will have to change as you point
out.