[git pull][vfs.git] a couple of fixes

[git pull][vfs.git] a couple of fixes

[Al Viro]

	A couple of fixes; one for automount/lazy umount race, another
a classic "we don't protect the refcount transition to zero with the
lock that protects looking for object in hash" kind of crap in lockd.
Please, pull.  The usual place -
git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

Shortlog:
Al Viro (2):
      do_add_mount()/umount -l races
      close the race in nlmsvc_free_block()

Diffstat:
 fs/lockd/svclock.c |    3 +--
 fs/namespace.c     |   10 ++++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

Re: [git pull][vfs.git] a couple of fixes

[Linus Torvalds]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

Hmm. What is the status of the rename_lock write-lock recursion
deadlock patch from Miklos?

Attached is a simpler version of it (Miklos, can you verify this
simplified version also works for you?), but it's still fairly ugly.

            Linus

[-- Attachment #2: patch.diff --]
[-- Type: application/octet-stream, Size: 627 bytes --]

 fs/dcache.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/dcache.c b/fs/dcache.c
index 0364af2311f4..693f95bf1cae 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1134,6 +1134,8 @@ positive:
 	return 1;
 
 rename_retry:
+	if (locked)
+		goto again;
 	locked = 1;
 	write_seqlock(&rename_lock);
 	goto again;
@@ -1236,6 +1238,8 @@ out:
 rename_retry:
 	if (found)
 		return found;
+	if (locked)
+		goto again;
 	locked = 1;
 	write_seqlock(&rename_lock);
 	goto again;
@@ -3035,6 +3039,8 @@ resume:
 	return;
 
 rename_retry:
+	if (locked)
+		goto again;
 	locked = 1;
 	write_seqlock(&rename_lock);
 	goto again;

Re: [git pull] (vfs.git) a couple of fixes

[pr-tracker-bot]

The pull request you sent on Fri, 25 Nov 2022 03:52:22 +0000:

> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git tags/pull-fixes

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b308570957332422032e34b0abb9233790344e2b

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

[git pull] (vfs.git) a couple of fixes

[Al Viro]

The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780:

  Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git tags/pull-fixes

for you to fetch changes up to 406c706c7b7f1730aa787e914817b8d16b1e99f6:

  vfs: vfs_tmpfile: ensure O_EXCL flag is enforced (2022-11-19 02:22:11 -0500)

----------------------------------------------------------------
a couple of fixes, one of them for this cycle regression...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

----------------------------------------------------------------
Jann Horn (1):
      fs: use acquire ordering in __fget_light()

Peter Griffin (1):
      vfs: vfs_tmpfile: ensure O_EXCL flag is enforced

 fs/file.c  | 11 ++++++++++-
 fs/namei.c |  3 ++-
 2 files changed, 12 insertions(+), 2 deletions(-)

Re: [git pull][vfs.git] a couple of fixes

[Al Viro]

On Thu, Sep 21, 2017 at 05:59:57AM -1000, Linus Torvalds wrote:
> On Wed, Sep 20, 2017 at 6:13 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >         A couple of regression fixes, one for this merge window, one for
> > the previous cycle.
> 
> That older fix for 4.13 doesn't seem to be marked for stable.
> 
> Can you make sure it gets to Greg?

Will do - sorry, forgot to add Cc:stable.

Re: [git pull][vfs.git] a couple of fixes

[Linus Torvalds]

On Wed, Sep 20, 2017 at 6:13 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>         A couple of regression fixes, one for this merge window, one for
> the previous cycle.

That older fix for 4.13 doesn't seem to be marked for stable.

Can you make sure it gets to Greg?

                  Linus

[git pull][vfs.git] a couple of fixes

[Al Viro]

	A couple of regression fixes, one for this merge window, one for
the previous cycle.

The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e:

  Linux 4.14-rc1 (2017-09-16 15:47:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

for you to fetch changes up to 58aff0af757356065f33290d96a9cd46dfbcae88:

  ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user (2017-09-20 23:27:48 -0400)

----------------------------------------------------------------
Petar Penkov (1):
      iov_iter: fix page_copy_sane for compound pages

Will Deacon (1):
      ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user

 ipc/shm.c      | 2 +-
 lib/iov_iter.c | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)