* [PATCH] pch_gbe: Fix PTP dependencies.
@ 2012-10-03 2:35 David Miller
2012-10-05 13:04 ` Richard Cochran
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2012-10-03 2:35 UTC (permalink / raw)
To: netdev
The config combination:
CONFIG_PCH_GBE=y
CONFIG_PCH_PTP=y
CONFIG_PTP_1588_CLOCK=m
doesn't work, because then you have a built-in kernel
object (the PCH_PTP code) referring to symbols in a
module (PTP_1588_CLOCK).
Fix this like IXGBE, by using "select PTP_1588_CLOCK"
instead of a "depends on".
Reported-by: Haicheng Li <haicheng.li@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index bce0164..9730241 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -26,7 +26,7 @@ if PCH_GBE
config PCH_PTP
bool "PCH PTP clock support"
default n
- depends on PTP_1588_CLOCK_PCH
+ select PTP_1588_CLOCK_PCH
---help---
Say Y here if you want to use Precision Time Protocol (PTP) in the
driver. PTP is a method to precisely synchronize distributed clocks
--
1.7.11.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pch_gbe: Fix PTP dependencies.
2012-10-03 2:35 [PATCH] pch_gbe: Fix PTP dependencies David Miller
@ 2012-10-05 13:04 ` Richard Cochran
0 siblings, 0 replies; 2+ messages in thread
From: Richard Cochran @ 2012-10-05 13:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On Tue, Oct 02, 2012 at 10:35:04PM -0400, David Miller wrote:
>
> The config combination:
>
> CONFIG_PCH_GBE=y
> CONFIG_PCH_PTP=y
> CONFIG_PTP_1588_CLOCK=m
...
> @@ -26,7 +26,7 @@ if PCH_GBE
> config PCH_PTP
> bool "PCH PTP clock support"
> default n
> - depends on PTP_1588_CLOCK_PCH
> + select PTP_1588_CLOCK_PCH
Based on Fengguang Wu's complaint, maybe this would work better:
depends on PTP_1588_CLOCK && !(PCH_GBE=y && PTP_1588_CLOCK=m)
Thanks,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-05 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-03 2:35 [PATCH] pch_gbe: Fix PTP dependencies David Miller
2012-10-05 13:04 ` Richard Cochran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.