* [PATCH] be2net: Remove code that stops further access to BE NIC based on UE bits
@ 2012-10-09 4:18 Ajit Khaparde
2012-10-09 17:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2012-10-09 4:18 UTC (permalink / raw)
To: netdev, davem
On certain platforms, BE hardware could falsely indicate UE.
For BE family of NICs, do not set hw_error based on the UE bits.
If there was a real fatal error, the corresponding h/w block will
automatically go offline and stop traffic.
Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
---
drivers/net/ethernet/emulex/benet/be_main.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index eb3f2cb..d1b6cc5 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -2129,8 +2129,11 @@ void be_detect_error(struct be_adapter *adapter)
ue_hi = (ue_hi & ~ue_hi_mask);
}
- if (ue_lo || ue_hi ||
- sliport_status & SLIPORT_STATUS_ERR_MASK) {
+ /* On certain platforms BE hardware can indicate spurious UEs.
+ * Allow the h/w to stop working completely in case of a real UE.
+ * Hence not setting the hw_error for UE detection.
+ */
+ if (sliport_status & SLIPORT_STATUS_ERR_MASK) {
adapter->hw_error = true;
dev_err(&adapter->pdev->dev,
"Error detected in the card\n");
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] be2net: Remove code that stops further access to BE NIC based on UE bits
2012-10-09 4:18 [PATCH] be2net: Remove code that stops further access to BE NIC based on UE bits Ajit Khaparde
@ 2012-10-09 17:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-10-09 17:55 UTC (permalink / raw)
To: ajit.khaparde; +Cc: netdev
From: Ajit Khaparde <ajit.khaparde@emulex.com>
Date: Mon, 8 Oct 2012 23:18:21 -0500
> On certain platforms, BE hardware could falsely indicate UE.
> For BE family of NICs, do not set hw_error based on the UE bits.
> If there was a real fatal error, the corresponding h/w block will
> automatically go offline and stop traffic.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-09 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 4:18 [PATCH] be2net: Remove code that stops further access to BE NIC based on UE bits Ajit Khaparde
2012-10-09 17:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.