All of lore.kernel.org
 help / color / mirror / Atom feed
* omap3isp: no pixel rate control in subdev
@ 2012-10-06 13:47 P Jackson
  2012-10-08 22:33 ` Sakari Ailus
  0 siblings, 1 reply; 6+ messages in thread
From: P Jackson @ 2012-10-06 13:47 UTC (permalink / raw)
  To: linux-media

I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board using the latest omap3isp-omap3isp-stable branch from the linuxtv.org/media.git repository.

When I 'modprobe omap-isp' I see:

Linux media interface: v0.10
Linux video capture interface: v2.00
omap3isp omap3isp: Revision 15.0 found
omap-iommu omap-iommu.0: isp: version 1.1
mt9t001 3-005d: Probing MT9T001 at address 0x5d
mt9t001 3-005d: MT9T001 detected at address 0x5d

I then do:

media-ctl -r
media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'

Followed by:

yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin


For which I get:

Device /dev/video2 opened.
Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
4 buffers requested.
length: 6291456 offset: 0
Buffer 0 mapped at address 0x40272000.
length: 6291456 offset: 6291456
Buffer 1 mapped at address 0x4096b000.
length: 6291456 offset: 12582912
Buffer 2 mapped at address 0x4102f000.
length: 6291456 offset: 18874368
Buffer 3 mapped at address 0x416ac000.
Press enter to start capture

After pressing enter I get:

omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
Unable to start streaming: Invalid argument (22).
1 buffers released.

Thinking it might be the mt9t001 code, I also tried the mt9v032 code as I have one of those sensors too. I got exactly the same error message.

Is there a patch I have missed or have I not configured something I should have done?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: omap3isp: no pixel rate control in subdev
  2012-10-06 13:47 omap3isp: no pixel rate control in subdev P Jackson
@ 2012-10-08 22:33 ` Sakari Ailus
  2012-10-09  8:06   ` P Jackson
  0 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2012-10-08 22:33 UTC (permalink / raw)
  To: P Jackson; +Cc: linux-media, laurent.pinchart

Hi,

On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote:
> I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board using the latest omap3isp-omap3isp-stable branch from the linuxtv.org/media.git repository.
> 
> When I 'modprobe omap-isp' I see:
> 
> Linux media interface: v0.10
> Linux video capture interface: v2.00
> omap3isp omap3isp: Revision 15.0 found
> omap-iommu omap-iommu.0: isp: version 1.1
> mt9t001 3-005d: Probing MT9T001 at address 0x5d
> mt9t001 3-005d: MT9T001 detected at address 0x5d
> 
> I then do:
> 
> media-ctl -r
> media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
> media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
> media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'
> 
> Followed by:
> 
> yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin
> 
> 
> For which I get:
> 
> Device /dev/video2 opened.
> Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
> Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> 4 buffers requested.
> length: 6291456 offset: 0
> Buffer 0 mapped at address 0x40272000.
> length: 6291456 offset: 6291456
> Buffer 1 mapped at address 0x4096b000.
> length: 6291456 offset: 12582912
> Buffer 2 mapped at address 0x4102f000.
> length: 6291456 offset: 18874368
> Buffer 3 mapped at address 0x416ac000.
> Press enter to start capture
> 
> After pressing enter I get:
> 
> omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
> Unable to start streaming: Invalid argument (22).

Really?

Could you check if you have this patch in your tree?

---
commit 0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:   Wed May 9 09:55:57 2012 -0300

    [media] mt9t001: Implement V4L2_CID_PIXEL_RATE control
    
    The pixel rate control is required by the OMAP3 ISP driver and should be
    implemented by all media controller-compatible sensor drivers.
    
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

Cc Laurent, too.

Regards,

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: omap3isp: no pixel rate control in subdev
  2012-10-08 22:33 ` Sakari Ailus
@ 2012-10-09  8:06   ` P Jackson
  2012-10-09  9:18     ` Laurent Pinchart
  2012-10-09  9:21     ` Sakari Ailus
  0 siblings, 2 replies; 6+ messages in thread
From: P Jackson @ 2012-10-09  8:06 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: linux-media, laurent.pinchart

Hi Sakari,




From: Sakari Ailus <sakari.ailus@iki.fi>
Sent: Monday, 8 October 2012, 23:33

Hi,

On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote:
> I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board using the latest omap3isp-omap3isp-stable branch from the linuxtv.org/media.git repository.
> 
> When I 'modprobe omap3-isp' I see:
> 
> Linux media interface: v0.10
> Linux video capture interface: v2.00
> omap3isp omap3isp: Revision 15.0 found
> omap-iommu omap-iommu.0: isp: version 1.1
> mt9t001 3-005d: Probing MT9T001 at address 0x5d
> mt9t001 3-005d: MT9T001 detected at address 0x5d
> 
> I then do:
> 
> media-ctl -r
> media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
> media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
> media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'
> 
> Followed by:
> 
> yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin
> 
> 
> For which I get:
> 
> Device /dev/video2 opened.
> Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
> Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> 4 buffers requested.
> length: 6291456 offset: 0
> Buffer 0 mapped at address 0x40272000.
> length: 6291456 offset: 6291456
> Buffer 1 mapped at address 0x4096b000.
> length: 6291456 offset: 12582912
> Buffer 2 mapped at address 0x4102f000.
> length: 6291456 offset: 18874368
> Buffer 3 mapped at address 0x416ac000.
> Press enter to start capture
> 
> After pressing enter I get:
> 
> omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
> Unable to start streaming: Invalid argument (22).

Really?

Could you check if you have this patch in your tree?

---
commit 0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date:   Wed May 9 09:55:57 2012 -0300

    [media] mt9t001: Implement V4L2_CID_PIXEL_RATE control
    
    The pixel rate control is required by the OMAP3 ISP driver and should be
    implemented by all media controller-compatible sensor drivers.
    
    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

I have checked my tree and cannot find that patch.

Regards,

Pete

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: omap3isp: no pixel rate control in subdev
  2012-10-09  8:06   ` P Jackson
@ 2012-10-09  9:18     ` Laurent Pinchart
  2012-10-09  9:21     ` Sakari Ailus
  1 sibling, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2012-10-09  9:18 UTC (permalink / raw)
  To: P Jackson; +Cc: Sakari Ailus, linux-media

Hi,

On Tuesday 09 October 2012 09:06:04 P Jackson wrote:
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: Monday, 8 October 2012, 23:33
> On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote:
> > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board
> > using the latest omap3isp-omap3isp-stable branch from the
> > linuxtv.org/media.git repository.
> > 
> > When I 'modprobe omap3-isp' I see:
> > 
> > Linux media interface: v0.10
> > Linux video capture interface: v2.00
> > omap3isp omap3isp: Revision 15.0 found
> > omap-iommu omap-iommu.0: isp: version 1.1
> > mt9t001 3-005d: Probing MT9T001 at address 0x5d
> > mt9t001 3-005d: MT9T001 detected at address 0x5d
> > 
> > I then do:
> > 
> > media-ctl -r
> > media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
> > media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> > media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
> > media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'
> > 
> > Followed by:
> > 
> > yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin
> > 
> > 
> > For which I get:
> > 
> > Device /dev/video2 opened.
> > Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
> > Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size
> > 6291456 Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer
> > size 6291456 4 buffers requested.
> > length: 6291456 offset: 0
> > Buffer 0 mapped at address 0x40272000.
> > length: 6291456 offset: 6291456
> > Buffer 1 mapped at address 0x4096b000.
> > length: 6291456 offset: 12582912
> > Buffer 2 mapped at address 0x4102f000.
> > length: 6291456 offset: 18874368
> > Buffer 3 mapped at address 0x416ac000.
> > Press enter to start capture
> > 
> > After pressing enter I get:
> > 
> > omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
> > Unable to start streaming: Invalid argument (22).
> 
> Really?
> 
> Could you check if you have this patch in your tree?
> 
> ---
> commit 0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date:   Wed May 9 09:55:57 2012 -0300
> 
>     [media] mt9t001: Implement V4L2_CID_PIXEL_RATE control
>    
>     The pixel rate control is required by the OMAP3 ISP driver and should be
> implemented by all media controller-compatible sensor drivers. 
>     Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> 
> I have checked my tree and cannot find that patch.

You should then upgrade to v3.6 or backport the patch to your kernel.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: omap3isp: no pixel rate control in subdev
  2012-10-09  8:06   ` P Jackson
  2012-10-09  9:18     ` Laurent Pinchart
@ 2012-10-09  9:21     ` Sakari Ailus
  2012-10-16  9:54       ` P Jackson
  1 sibling, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2012-10-09  9:21 UTC (permalink / raw)
  To: P Jackson; +Cc: linux-media, laurent.pinchart

Hi Pete,

On Tue, Oct 09, 2012 at 09:06:04AM +0100, P Jackson wrote:
> On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote:
> > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board using the latest omap3isp-omap3isp-stable branch from the linuxtv.org/media.git repository.
> > 
> > When I 'modprobe omap3-isp' I see:
> > 
> > Linux media interface: v0.10
> > Linux video capture interface: v2.00
> > omap3isp omap3isp: Revision 15.0 found
> > omap-iommu omap-iommu.0: isp: version 1.1
> > mt9t001 3-005d: Probing MT9T001 at address 0x5d
> > mt9t001 3-005d: MT9T001 detected at address 0x5d
> > 
> > I then do:
> > 
> > media-ctl -r
> > media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
> > media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> > media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
> > media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'
> > 
> > Followed by:
> > 
> > yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin
> > 
> > 
> > For which I get:
> > 
> > Device /dev/video2 opened.
> > Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
> > Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> > Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> > 4 buffers requested.
> > length: 6291456 offset: 0
> > Buffer 0 mapped at address 0x40272000.
> > length: 6291456 offset: 6291456
> > Buffer 1 mapped at address 0x4096b000.
> > length: 6291456 offset: 12582912
> > Buffer 2 mapped at address 0x4102f000.
> > length: 6291456 offset: 18874368
> > Buffer 3 mapped at address 0x416ac000.
> > Press enter to start capture
> > 
> > After pressing enter I get:
> > 
> > omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
> > Unable to start streaming: Invalid argument (22).
> 
> Really?
> 
> Could you check if you have this patch in your tree?
> 
> ---
> commit 0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date:   Wed May 9 09:55:57 2012 -0300
> 
>     [media] mt9t001: Implement V4L2_CID_PIXEL_RATE control
>     
>     The pixel rate control is required by the OMAP3 ISP driver and should be
>     implemented by all media controller-compatible sensor drivers.
>     
>     Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> 
> I have checked my tree and cannot find that patch.

Your tree might be more or less out of date. You can find the patch here:

<URL:http://git.linuxtv.org/media_tree.git/commit/0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1>

Apply it and your problem should be resolved.

Regards,

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: omap3isp: no pixel rate control in subdev
  2012-10-09  9:21     ` Sakari Ailus
@ 2012-10-16  9:54       ` P Jackson
  0 siblings, 0 replies; 6+ messages in thread
From: P Jackson @ 2012-10-16  9:54 UTC (permalink / raw)
  To: Sakari Ailus; +Cc: linux-media, laurent.pinchart

Hi Sakari,

I installed the patch you suggested and am now able to acquire images which appear to have a green 'halo' around the boundary of the objects in view.
One of the PNM-format images converted using raw2rgbpnm is here: http://dl.dropbox.com/u/3851193/F0.pnm and the raw data for it is here: http://dl.dropbox.com/u/3851193/F0.raw

I am performing a sensor (RAW Bayer) -> CCDC -> memory operation. The media-ctl script I used is here: http://pastebin.com/Ld9sbz4F

I have tried changing the pixel clock polarity from 1 to 0 but that just makes the green-coloured halo appear as a pink-coloured one instead. My MT9T001 sensor has an external 48 MHz oscillator and feeds all 10-bits of data into the DM3730 ISP.

I wondered if the new ext_clk value was causing the issue? The segment of code from my board-overo.c which sets up the structs and functions for the MT9T001 is shown here: http://pastebin.com/K032v7f1

I also encounter a number of error messages from omap3isp when I acquire the images: "omap3isp omap3isp: CCDC won't become idle!"
Which is followed by: "omap3isp omap3isp: Unable to stop OMAP3 ISP CCDC"
A console log for a typical yavta session is shown here: http://pastebin.com/11QkcWrz
Most often it goes into a loop displaying the "won't become idle" message repeatedly and has to be stopped with a Ctrl+C
 
 

----- Original Message -----
From: Sakari Ailus <sakari.ailus@iki.fi>
To: P Jackson <pej02@yahoo.co.uk>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>; "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>
Sent: Tuesday, 9 October 2012, 10:21
Subject: Re: omap3isp: no pixel rate control in subdev

Hi Pete,

On Tue, Oct 09, 2012 at 09:06:04AM +0100, P Jackson wrote:
> On Sat, Oct 06, 2012 at 02:47:44PM +0100, P Jackson wrote:
> > I'm trying to get an mt9t001 sensor board working on a Gumstix Overo board using the latest omap3isp-omap3isp-stable branch from the linuxtv.org/media.git repository.
> > 
> > When I 'modprobe omap3-isp' I see:
> > 
> > Linux media interface: v0.10
> > Linux video capture interface: v2.00
> > omap3isp omap3isp: Revision 15.0 found
> > omap-iommu omap-iommu.0: isp: version 1.1
> > mt9t001 3-005d: Probing MT9T001 at address 0x5d
> > mt9t001 3-005d: MT9T001 detected at address 0x5d
> > 
> > I then do:
> > 
> > media-ctl -r
> > media-ctl -l '"mt9t001 3-005d":0->"OMAP3 ISP CCDC":0[1]'
> > media-ctl -l '"OMAP3 ISP CCDC":1->"OMAP3 ISP CCDC output":0[1]'
> > media-ctl -V '"mt9t001 3-005d":0 [SGRBG10 2048x1536]'
> > media-ctl -V '"OMAP3 ISP CCDC":1 [SGRBG10 2048x1536]'
> > 
> > Followed by:
> > 
> > yavta -p -f SGRBG10 -s 2048x1536 -n 4 --capture=1 /dev/video2 file=m.bin
> > 
> > 
> > For which I get:
> > 
> > Device /dev/video2 opened.
> > Device `OMAP3 ISP CCDC output' on `media' is a video capture device.
> > Video format set: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> > Video format: SGRBG10 (30314142) 2048x1536 (stride 4096) buffer size 6291456
> > 4 buffers requested.
> > length: 6291456 offset: 0
> > Buffer 0 mapped at address 0x40272000.
> > length: 6291456 offset: 6291456
> > Buffer 1 mapped at address 0x4096b000.
> > length: 6291456 offset: 12582912
> > Buffer 2 mapped at address 0x4102f000.
> > length: 6291456 offset: 18874368
> > Buffer 3 mapped at address 0x416ac000.
> > Press enter to start capture
> > 
> > After pressing enter I get:
> > 
> > omap3isp omap3isp: no pixel rate control in subdev mt9t001 3-005d
> > Unable to start streaming: Invalid argument (22).
> 
> Really?
> 
> Could you check if you have this patch in your tree?
> 
> ---
> commit 0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1
> Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Date:   Wed May 9 09:55:57 2012 -0300
> 
>     [media] mt9t001: Implement V4L2_CID_PIXEL_RATE control
>     
>     The pixel rate control is required by the OMAP3 ISP driver and should be
>     implemented by all media controller-compatible sensor drivers.
>     
>     Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>     Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
>     Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> 
> I have checked my tree and cannot find that patch.

Your tree might be more or less out of date. You can find the patch here:

<URL:http://git.linuxtv.org/media_tree.git/commit/0bc77f3f06fcf2ca7b7fad782d70926cd4d235f1>

Apply it and your problem should be resolved.

Regards,

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi    XMPP: sailus@retiisi.org.uk


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-10-16  9:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-06 13:47 omap3isp: no pixel rate control in subdev P Jackson
2012-10-08 22:33 ` Sakari Ailus
2012-10-09  8:06   ` P Jackson
2012-10-09  9:18     ` Laurent Pinchart
2012-10-09  9:21     ` Sakari Ailus
2012-10-16  9:54       ` P Jackson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.