* [PATCH] w1/ds2482: use module_i2c_driver to simplify the code
@ 2012-10-08 14:06 Wei Yongjun
2012-10-09 15:51 ` Evgeniy Polyakov
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-10-08 14:06 UTC (permalink / raw)
To: zbr; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/w1/masters/ds2482.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
index e5f7441..6429b9e 100644
--- a/drivers/w1/masters/ds2482.c
+++ b/drivers/w1/masters/ds2482.c
@@ -505,19 +505,8 @@ static int ds2482_remove(struct i2c_client *client)
return 0;
}
-static int __init sensors_ds2482_init(void)
-{
- return i2c_add_driver(&ds2482_driver);
-}
-
-static void __exit sensors_ds2482_exit(void)
-{
- i2c_del_driver(&ds2482_driver);
-}
+module_i2c_driver(ds2482_driver);
MODULE_AUTHOR("Ben Gardner <bgardner@wabtec.com>");
MODULE_DESCRIPTION("DS2482 driver");
MODULE_LICENSE("GPL");
-
-module_init(sensors_ds2482_init);
-module_exit(sensors_ds2482_exit);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] w1/ds2482: use module_i2c_driver to simplify the code
2012-10-08 14:06 [PATCH] w1/ds2482: use module_i2c_driver to simplify the code Wei Yongjun
@ 2012-10-09 15:51 ` Evgeniy Polyakov
0 siblings, 0 replies; 2+ messages in thread
From: Evgeniy Polyakov @ 2012-10-09 15:51 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, linux-kernel, Ben Gardner, GregKH
On Mon, Oct 08, 2012 at 10:06:07PM +0800, Wei Yongjun (weiyj.lk@gmail.com) wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Use the module_i2c_driver() macro to make the code smaller
> and a bit simpler.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Looks good for me, but I added Ben Gardner (original author) to hear
from him if it is ok.
Greg, please pull it into your tree, when things are settled.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> drivers/w1/masters/ds2482.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index e5f7441..6429b9e 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -505,19 +505,8 @@ static int ds2482_remove(struct i2c_client *client)
> return 0;
> }
>
> -static int __init sensors_ds2482_init(void)
> -{
> - return i2c_add_driver(&ds2482_driver);
> -}
> -
> -static void __exit sensors_ds2482_exit(void)
> -{
> - i2c_del_driver(&ds2482_driver);
> -}
> +module_i2c_driver(ds2482_driver);
>
> MODULE_AUTHOR("Ben Gardner <bgardner@wabtec.com>");
> MODULE_DESCRIPTION("DS2482 driver");
> MODULE_LICENSE("GPL");
> -
> -module_init(sensors_ds2482_init);
> -module_exit(sensors_ds2482_exit);
>
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-09 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-08 14:06 [PATCH] w1/ds2482: use module_i2c_driver to simplify the code Wei Yongjun
2012-10-09 15:51 ` Evgeniy Polyakov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.