[RFC PATCH 0/3] mca_config stuff

* [RFC PATCH 0/3] mca_config stuff
@ 2012-10-10 14:19 Borislav Petkov
  2012-10-10 14:19 ` [RFC PATCH 1/3] Add DEVICE_BIT_ATTR Borislav Petkov
                   ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Borislav Petkov @ 2012-10-10 14:19 UTC (permalink / raw)
  To: Tony Luck; +Cc: LKML, Borislav Petkov

From: Borislav Petkov <borislav.petkov@amd.com>

Right,

so I did give that a try and it turned out to be a bit more involved
than I thought. Basically, I'm relying on the assumption that if I use a
u64 bitfield and pass a pointer to it, accessing it through that pointer
as a u64 value works. Actually, I have the u64 bitfield as the first
member of a struct and if I cast a pointer to that struct to u64 *, I'm
expecting to have the 64 bits of the same bitfield.

Therefore, I can toggle the bits in the mce code with mca_cfg.<bitname>.
When defining accessing them through the device attributes in sysfs, I
use a new macro DEVICE_BIT_ATTR which gets the corresponding bit number
of that same bit in the bitfield. This gives only one function which
operates on a bitfield instead of a single function per bit in the
bitfield.

For example,

mca_cfg {
	u64 dont_log_ce : 1,

is the first bit in the bitfield and I also have a MCA_CFG_DONT_LOG_CE
define which is 0, i.e. the first bit, which I use to toggle the
corresponding bit in the u64 in device_{show,store}_bit.

So I converted mce_dont_log_ce and mce_disabled (renaming it into the
more correct mca_disabled) and it seems to work.

The asm looks sane too. One other advantage is that it makes the code
much more cleaner and compact by collecting all those bool config values
in a single struct, which was my original incentive to do that.

So please take a look and let me know whether this is sane, especially
the above assumption that I can access a u64 bitfield through a u64 *
and the bits are where they're expected to be. gcc seems to do that...
and I don't see anything in the C99 standard that would object to it but
I could be overlooking something.

Thanks.

Borislav Petkov (3):
  Add DEVICE_BIT_ATTR
  Change mce_dont_log_ce
  Convert mce_disabled

 arch/x86/include/asm/mce.h       |  9 ++++++++-
 arch/x86/kernel/cpu/mcheck/mce.c | 21 ++++++++++-----------
 arch/x86/lguest/boot.c           |  2 +-
 drivers/base/core.c              | 36 ++++++++++++++++++++++++++++++++++++
 include/linux/device.h           |  9 +++++++++
 5 files changed, 64 insertions(+), 13 deletions(-)

-- 
1.8.0.rc0.18.gf84667d

^ permalink raw reply	[flat|nested] 13+ messages in thread