[PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[jc]

From: Jean-Christian de Rivaz <jc@eclis.ch>

This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.

Reference:
http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5

Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
---
 drivers/usb/class/cdc-acm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index f763ed7..e8007b8 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1551,6 +1551,9 @@ static const struct usb_device_id acm_ids[] = {
 					   Maybe we should define a new
 					   quirk for this. */
 	},
+	{ USB_DEVICE(0x0572, 0x1340), /* Conexant CX93010-2x UCMxx */
+	.driver_info = NO_UNION_NORMAL,
+	},
 	{ USB_DEVICE(0x1bbb, 0x0003), /* Alcatel OT-I650 */
 	.driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
 	},
-- 
1.7.2.5

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Oliver Neukum]

On Friday 28 September 2012 16:16:04 jc@eclis.ch wrote:
> From: Jean-Christian de Rivaz <jc@eclis.ch>
> 
> This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> 
> Reference:
> http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> 
> Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
Acked-by: Oliver Neukum <oneukum@SUSE.DE>

However, this went to the wrong list. Please repost to

davem@davemloft.net
netdev@vger.kernel.org

	Regards
		Oliver

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Jean-Christian de Rivaz]

On Wed, Oct 10, 2012 at 09:42:32PM +0200, Oliver Neukum wrote:
> On Friday 28 September 2012 16:16:04 jc@eclis.ch wrote:
> > From: Jean-Christian de Rivaz <jc@eclis.ch>
> > 
> > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> > and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> > 
> > Reference:
> > http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> > 
> > Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
> Acked-by: Oliver Neukum <oneukum@SUSE.DE>
> 
> However, this went to the wrong list. Please repost to
> 
> davem@davemloft.net
> netdev@vger.kernel.org
> 
> 	Regards
> 		Oliver
> 

Sorry for the wrong list, I used the scripts/get_maintainer.pl to get the
destinations, as recommanded in Documentation/SubmittingPatches. Is there
something to be fixed there or should I use an other procedure to get the
right destinations?

I will rebase and repost the patch.

Regards,

Jean-Christain

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Greg Kroah-Hartman]

On Wed, Oct 10, 2012 at 09:42:32PM +0200, Oliver Neukum wrote:
> On Friday 28 September 2012 16:16:04 jc@eclis.ch wrote:
> > From: Jean-Christian de Rivaz <jc@eclis.ch>
> > 
> > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> > and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> > 
> > Reference:
> > http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> > 
> > Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
> Acked-by: Oliver Neukum <oneukum@SUSE.DE>
> 
> However, this went to the wrong list. Please repost to
> 
> davem@davemloft.net
> netdev@vger.kernel.org

No it isn't, this is the cdc-acm driver, not the wdm driver, it was sent
to the right list.  I'll pick it up now.

greg k-h

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Greg Kroah-Hartman]

On Thu, Oct 11, 2012 at 12:29:06AM +0200, Jean-Christian de Rivaz wrote:
> On Wed, Oct 10, 2012 at 09:42:32PM +0200, Oliver Neukum wrote:
> > On Friday 28 September 2012 16:16:04 jc@eclis.ch wrote:
> > > From: Jean-Christian de Rivaz <jc@eclis.ch>
> > > 
> > > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> > > and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> > > 
> > > Reference:
> > > http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> > > 
> > > Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
> > Acked-by: Oliver Neukum <oneukum@SUSE.DE>
> > 
> > However, this went to the wrong list. Please repost to
> > 
> > davem@davemloft.net
> > netdev@vger.kernel.org
> > 
> > 	Regards
> > 		Oliver
> > 
> 
> Sorry for the wrong list, I used the scripts/get_maintainer.pl to get the
> destinations, as recommanded in Documentation/SubmittingPatches. Is there
> something to be fixed there or should I use an other procedure to get the
> right destinations?
> 
> I will rebase and repost the patch.

No need, you did this correctly.

greg k-h

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Greg Kroah-Hartman]

On Wed, Oct 17, 2012 at 01:32:39PM -0700, Greg Kroah-Hartman wrote:
> On Thu, Oct 11, 2012 at 12:29:06AM +0200, Jean-Christian de Rivaz wrote:
> > On Wed, Oct 10, 2012 at 09:42:32PM +0200, Oliver Neukum wrote:
> > > On Friday 28 September 2012 16:16:04 jc@eclis.ch wrote:
> > > > From: Jean-Christian de Rivaz <jc@eclis.ch>
> > > > 
> > > > This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> > > > and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> > > > 
> > > > Reference:
> > > > http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> > > > 
> > > > Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
> > > Acked-by: Oliver Neukum <oneukum@SUSE.DE>
> > > 
> > > However, this went to the wrong list. Please repost to
> > > 
> > > davem@davemloft.net
> > > netdev@vger.kernel.org
> > > 
> > > 	Regards
> > > 		Oliver
> > > 
> > 
> > Sorry for the wrong list, I used the scripts/get_maintainer.pl to get the
> > destinations, as recommanded in Documentation/SubmittingPatches. Is there
> > something to be fixed there or should I use an other procedure to get the
> > right destinations?
> > 
> > I will rebase and repost the patch.
> 
> No need, you did this correctly.

Well, nevermind, David took this already :)

greg k-h

Re: [PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[David Miller]

From: Jean-Christian de Rivaz <jc@eclis.ch>
Date: Thu, 11 Oct 2012 00:49:02 +0200

> This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
> and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.
> 
> Reference:
> http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
> See idVendor and idProduct in table 6-1. Device Descriptors
> 
> Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>

Applied.

[PATCH] Add CDC-ACM support for the CX93010-2x UCMxx USB Modem

[Jean-Christian de Rivaz]

This USB V.92/V.32bis Controllered Modem have the USB vendor ID 0x0572
and device ID 0x1340. It need the NO_UNION_NORMAL quirk to be recognized.

Reference:
http://www.conexant.com/servlets/DownloadServlet/DSH-201723-005.pdf?docid=1725&revid=5
See idVendor and idProduct in table 6-1. Device Descriptors

Signed-off-by: Jean-Christian de Rivaz <jc@eclis.ch>
---
 drivers/usb/class/cdc-acm.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 36f2be4..981f213 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1551,6 +1551,9 @@ static const struct usb_device_id acm_ids[] = {
 					   Maybe we should define a new
 					   quirk for this. */
 	},
+	{ USB_DEVICE(0x0572, 0x1340), /* Conexant CX93010-2x UCMxx */
+	.driver_info = NO_UNION_NORMAL,
+	},
 	{ USB_DEVICE(0x1bbb, 0x0003), /* Alcatel OT-I650 */
 	.driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
 	},
-- 
1.7.2.5