* [PATCH 2/6] udf: don't increment lenExtents while writing to a hole
@ 2012-10-09 15:09 Namjae Jeon
2012-10-11 18:11 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2012-10-09 15:09 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, Namjae Jeon, Namjae Jeon, Ashish Sangwan
From: Namjae Jeon <namjae.jeon@samsung.com>
Incrementing lenExtents even while writing to a hole is bad
for performance as calls to udf_discard_prealloc and
udf_truncate_tail_extent would not return from start if
isize != lenExtents
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
fs/udf/inode.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 2b77593..8266f2e 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -601,6 +601,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
struct udf_inode_info *iinfo = UDF_I(inode);
int goal = 0, pgoal = iinfo->i_location.logicalBlockNum;
int lastblock = 0;
+ bool isBeyondEOF;
*err = 0;
*new = 0;
@@ -680,7 +681,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
/* Are we beyond EOF? */
if (etype == -1) {
int ret;
-
+ isBeyondEOF = 1;
if (count) {
if (c)
laarr[0] = laarr[1];
@@ -723,6 +724,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
endnum = c + 1;
lastblock = 1;
} else {
+ isBeyondEOF = 0;
endnum = startnum = ((count > 2) ? 2 : count);
/* if the current extent is in position 0,
@@ -770,7 +772,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
*err = -ENOSPC;
return 0;
}
- iinfo->i_lenExtents += inode->i_sb->s_blocksize;
+ if (isBeyondEOF)
+ iinfo->i_lenExtents += inode->i_sb->s_blocksize;
}
/* if the extent the requsted block is located in contains multiple
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/6] udf: don't increment lenExtents while writing to a hole
2012-10-09 15:09 [PATCH 2/6] udf: don't increment lenExtents while writing to a hole Namjae Jeon
@ 2012-10-11 18:11 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2012-10-11 18:11 UTC (permalink / raw)
To: Namjae Jeon; +Cc: jack, linux-kernel, Namjae Jeon, Ashish Sangwan
On Wed 10-10-12 00:09:12, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> Incrementing lenExtents even while writing to a hole is bad
> for performance as calls to udf_discard_prealloc and
> udf_truncate_tail_extent would not return from start if
> isize != lenExtents
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Thanks. I've merged the patch.
Honza
> ---
> fs/udf/inode.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index 2b77593..8266f2e 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -601,6 +601,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> struct udf_inode_info *iinfo = UDF_I(inode);
> int goal = 0, pgoal = iinfo->i_location.logicalBlockNum;
> int lastblock = 0;
> + bool isBeyondEOF;
>
> *err = 0;
> *new = 0;
> @@ -680,7 +681,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> /* Are we beyond EOF? */
> if (etype == -1) {
> int ret;
> -
> + isBeyondEOF = 1;
> if (count) {
> if (c)
> laarr[0] = laarr[1];
> @@ -723,6 +724,7 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> endnum = c + 1;
> lastblock = 1;
> } else {
> + isBeyondEOF = 0;
> endnum = startnum = ((count > 2) ? 2 : count);
>
> /* if the current extent is in position 0,
> @@ -770,7 +772,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> *err = -ENOSPC;
> return 0;
> }
> - iinfo->i_lenExtents += inode->i_sb->s_blocksize;
> + if (isBeyondEOF)
> + iinfo->i_lenExtents += inode->i_sb->s_blocksize;
> }
>
> /* if the extent the requsted block is located in contains multiple
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-11 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 15:09 [PATCH 2/6] udf: don't increment lenExtents while writing to a hole Namjae Jeon
2012-10-11 18:11 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.