From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO
Date: Fri, 12 Oct 2012 10:13:22 +0100 [thread overview]
Message-ID: <20121012091322.GC21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1349885000-22887-1-git-send-email-ulf.hansson@stericsson.com>
On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote:
> From: Ulf Hansson <ulf.hansson@linaro.org>
>
> For data writes <= 8 bytes, HW flow control was disabled but
> never re-enabled when the transfer was completed. This meant
> that a following read request would give buffer overrun errors.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Both look fine to me too. Linus' has already said what needs to happen
with these two. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO
Date: Fri, 12 Oct 2012 10:13:22 +0100 [thread overview]
Message-ID: <20121012091322.GC21164@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1349885000-22887-1-git-send-email-ulf.hansson@stericsson.com>
On Wed, Oct 10, 2012 at 06:03:19PM +0200, Ulf Hansson wrote:
> From: Ulf Hansson <ulf.hansson@linaro.org>
>
> For data writes <= 8 bytes, HW flow control was disabled but
> never re-enabled when the transfer was completed. This meant
> that a following read request would give buffer overrun errors.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Both look fine to me too. Linus' has already said what needs to happen
with these two. Thanks.
next prev parent reply other threads:[~2012-10-12 9:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 16:03 [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO Ulf Hansson
2012-10-10 16:03 ` Ulf Hansson
2012-10-10 16:03 ` [RESEND PATCH 2/2] mmc: mmci: Switching off HWFC for SDIO depends on MCLK Ulf Hansson
2012-10-10 16:03 ` Ulf Hansson
2012-10-10 17:33 ` Linus Walleij
2012-10-10 17:33 ` Linus Walleij
2012-10-11 6:50 ` Johan Rudholm
2012-10-11 6:50 ` Johan Rudholm
2012-10-10 17:32 ` [RESEND PATCH 1/2] mmc: mmci: Fix incorrect handling of HW flow control for SDIO Linus Walleij
2012-10-10 17:32 ` Linus Walleij
2012-10-11 6:51 ` Johan Rudholm
2012-10-11 6:51 ` Johan Rudholm
2012-10-12 9:13 ` Russell King - ARM Linux [this message]
2012-10-12 9:13 ` Russell King - ARM Linux
2012-10-12 11:54 ` Russell King - ARM Linux
2012-10-12 11:54 ` Russell King - ARM Linux
2012-10-12 12:24 ` Ulf Hansson
2012-10-12 12:24 ` Ulf Hansson
2012-10-12 12:35 ` Russell King - ARM Linux
2012-10-12 12:35 ` Russell King - ARM Linux
2012-10-12 12:39 ` Ulf Hansson
2012-10-12 12:39 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012091322.GC21164@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=cjb@laptop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.