All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
@ 2012-10-15 13:56 ` nicolas.dichtel
  0 siblings, 0 replies; 6+ messages in thread
From: nicolas.dichtel @ 2012-10-15 13:56 UTC (permalink / raw)
  To: linux-sctp, vyasevich; +Cc: netdev, Zijie Pan, Nicolas Dichtel

From: Zijie Pan <zijie.pan@6wind.com>

Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
(sctp: check src addr when processing SACK to update transport state)

Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 net/sctp/sm_sideeffect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 57f7de8..6773d78 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 					asoc->outqueue.outstanding_bytes;
 			sackh.num_gap_ack_blocks = 0;
 			sackh.num_dup_tsns = 0;
+			chunk->subh.sack_hdr = &sackh;
 			sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
-					SCTP_SACKH(&sackh));
+					SCTP_CHUNK(chunk));
 			break;
 
 		case SCTP_CMD_DISCARD_PACKET:
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
@ 2012-10-15 13:56 ` nicolas.dichtel
  0 siblings, 0 replies; 6+ messages in thread
From: nicolas.dichtel @ 2012-10-15 13:56 UTC (permalink / raw)
  To: linux-sctp, vyasevich; +Cc: netdev, Zijie Pan, Nicolas Dichtel

From: Zijie Pan <zijie.pan@6wind.com>

Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
(sctp: check src addr when processing SACK to update transport state)

Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 net/sctp/sm_sideeffect.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 57f7de8..6773d78 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
 					asoc->outqueue.outstanding_bytes;
 			sackh.num_gap_ack_blocks = 0;
 			sackh.num_dup_tsns = 0;
+			chunk->subh.sack_hdr = &sackh;
 			sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
-					SCTP_SACKH(&sackh));
+					SCTP_CHUNK(chunk));
 			break;
 
 		case SCTP_CMD_DISCARD_PACKET:
-- 
1.7.12


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
  2012-10-15 13:56 ` nicolas.dichtel
@ 2012-10-15 15:40   ` Vlad Yasevich
  -1 siblings, 0 replies; 6+ messages in thread
From: Vlad Yasevich @ 2012-10-15 15:40 UTC (permalink / raw)
  To: nicolas.dichtel; +Cc: linux-sctp, netdev, Zijie Pan

On 10/15/2012 09:56 AM, nicolas.dichtel@6wind.com wrote:
> From: Zijie Pan <zijie.pan@6wind.com>
>
> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
> (sctp: check src addr when processing SACK to update transport state)
>
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Shutdown case..  ACK.

Acked-by: Vlad Yasevich <vyasevich@gmail.com>


> ---
>   net/sctp/sm_sideeffect.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 57f7de8..6773d78 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>   					asoc->outqueue.outstanding_bytes;
>   			sackh.num_gap_ack_blocks = 0;
>   			sackh.num_dup_tsns = 0;
> +			chunk->subh.sack_hdr = &sackh;
>   			sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
> -					SCTP_SACKH(&sackh));
> +					SCTP_CHUNK(chunk));
>   			break;
>
>   		case SCTP_CMD_DISCARD_PACKET:
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
@ 2012-10-15 15:40   ` Vlad Yasevich
  0 siblings, 0 replies; 6+ messages in thread
From: Vlad Yasevich @ 2012-10-15 15:40 UTC (permalink / raw)
  To: nicolas.dichtel; +Cc: linux-sctp, netdev, Zijie Pan

On 10/15/2012 09:56 AM, nicolas.dichtel@6wind.com wrote:
> From: Zijie Pan <zijie.pan@6wind.com>
>
> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
> (sctp: check src addr when processing SACK to update transport state)
>
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

Shutdown case..  ACK.

Acked-by: Vlad Yasevich <vyasevich@gmail.com>


> ---
>   net/sctp/sm_sideeffect.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
> index 57f7de8..6773d78 100644
> --- a/net/sctp/sm_sideeffect.c
> +++ b/net/sctp/sm_sideeffect.c
> @@ -1642,8 +1642,9 @@ static int sctp_cmd_interpreter(sctp_event_t event_type,
>   					asoc->outqueue.outstanding_bytes;
>   			sackh.num_gap_ack_blocks = 0;
>   			sackh.num_dup_tsns = 0;
> +			chunk->subh.sack_hdr = &sackh;
>   			sctp_add_cmd_sf(commands, SCTP_CMD_PROCESS_SACK,
> -					SCTP_SACKH(&sackh));
> +					SCTP_CHUNK(chunk));
>   			break;
>
>   		case SCTP_CMD_DISCARD_PACKET:
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
  2012-10-15 15:40   ` Vlad Yasevich
@ 2012-10-16 18:56     ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-10-16 18:56 UTC (permalink / raw)
  To: vyasevich; +Cc: nicolas.dichtel, linux-sctp, netdev, zijie.pan

From: Vlad Yasevich <vyasevich@gmail.com>
Date: Mon, 15 Oct 2012 11:40:38 -0400

> On 10/15/2012 09:56 AM, nicolas.dichtel@6wind.com wrote:
>> From: Zijie Pan <zijie.pan@6wind.com>
>>
>> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
>> (sctp: check src addr when processing SACK to update transport state)
>>
>> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> Shutdown case..  ACK.
> 
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter()
@ 2012-10-16 18:56     ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-10-16 18:56 UTC (permalink / raw)
  To: vyasevich; +Cc: nicolas.dichtel, linux-sctp, netdev, zijie.pan

From: Vlad Yasevich <vyasevich@gmail.com>
Date: Mon, 15 Oct 2012 11:40:38 -0400

> On 10/15/2012 09:56 AM, nicolas.dichtel@6wind.com wrote:
>> From: Zijie Pan <zijie.pan@6wind.com>
>>
>> Bug introduced by commit edfee0339e681a784ebacec7e8c2dc97dc6d2839
>> (sctp: check src addr when processing SACK to update transport state)
>>
>> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 
> Shutdown case..  ACK.
> 
> Acked-by: Vlad Yasevich <vyasevich@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-16 18:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-15 13:56 [PATCH] sctp: fix call to SCTP_CMD_PROCESS_SACK in sctp_cmd_interpreter() nicolas.dichtel
2012-10-15 13:56 ` nicolas.dichtel
2012-10-15 15:40 ` Vlad Yasevich
2012-10-15 15:40   ` Vlad Yasevich
2012-10-16 18:56   ` David Miller
2012-10-16 18:56     ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.