* + drivers-video-backlight-lp855x_blc-remove-unnecessary-mutex-code.patch added to -mm tree
@ 2012-10-22 22:30 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2012-10-22 22:30 UTC (permalink / raw)
To: mm-commits; +Cc: Milo.Kim, bryan.wu, milo.kim, rpurdie, thierry.reding
The patch titled
Subject: drivers/video/backlight/lp855x_bl.c: remove unnecessary mutex code
has been added to the -mm tree. Its filename is
drivers-video-backlight-lp855x_blc-remove-unnecessary-mutex-code.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: "Kim, Milo" <Milo.Kim@ti.com>
Subject: drivers/video/backlight/lp855x_bl.c: remove unnecessary mutex code
The mutex for accessing lp855x registers is used in case of the user-space
interaction. When the brightness is changed via sysfs, the mutex is
required. But the backlight class device already provides it. Thus, the
lp855x mutex is unnecessary.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Bryan Wu <bryan.wu@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/video/backlight/lp855x_bl.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff -puN drivers/video/backlight/lp855x_bl.c~drivers-video-backlight-lp855x_blc-remove-unnecessary-mutex-code drivers/video/backlight/lp855x_bl.c
--- a/drivers/video/backlight/lp855x_bl.c~drivers-video-backlight-lp855x_blc-remove-unnecessary-mutex-code
+++ a/drivers/video/backlight/lp855x_bl.c
@@ -35,7 +35,6 @@ struct lp855x {
struct i2c_client *client;
struct backlight_device *bl;
struct device *dev;
- struct mutex xfer_lock;
struct lp855x_platform_data *pdata;
struct pwm_device *pwm;
};
@@ -44,14 +43,11 @@ static int lp855x_read_byte(struct lp855
{
int ret;
- mutex_lock(&lp->xfer_lock);
ret = i2c_smbus_read_byte_data(lp->client, reg);
if (ret < 0) {
- mutex_unlock(&lp->xfer_lock);
dev_err(lp->dev, "failed to read 0x%.2x\n", reg);
return ret;
}
- mutex_unlock(&lp->xfer_lock);
*data = (u8)ret;
return 0;
@@ -59,13 +55,7 @@ static int lp855x_read_byte(struct lp855
static int lp855x_write_byte(struct lp855x *lp, u8 reg, u8 data)
{
- int ret;
-
- mutex_lock(&lp->xfer_lock);
- ret = i2c_smbus_write_byte_data(lp->client, reg, data);
- mutex_unlock(&lp->xfer_lock);
-
- return ret;
+ return i2c_smbus_write_byte_data(lp->client, reg, data);
}
static bool lp855x_is_valid_rom_area(struct lp855x *lp, u8 addr)
@@ -281,8 +271,6 @@ static int lp855x_probe(struct i2c_clien
lp->chip_id = id->driver_data;
i2c_set_clientdata(cl, lp);
- mutex_init(&lp->xfer_lock);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-10-22 22:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-22 22:30 + drivers-video-backlight-lp855x_blc-remove-unnecessary-mutex-code.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.