* [PATCH] xen-netback: allow changing the MAC address of the interface
@ 2012-10-19 17:34 Matt Wilson
2012-10-23 9:04 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Matt Wilson @ 2012-10-19 17:34 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Paul Harvey, Nikita Borzykh, Ian Campbell, Matt Wilson, xen-devel
Reported-by: Nikita Borzykh <sample.n@gmail.com>
Reported-by: Paul Harvey <stockingpaul@hotmail.com>
Suggested-by: Ian Campbell <Ian.Campbell@citrix.com>
Signed-off-by: Matt Wilson <msw@amazon.com>
---
drivers/net/xen-netback/interface.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index b7d41f8..f733cae 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
.ndo_stop = xenvif_close,
.ndo_change_mtu = xenvif_change_mtu,
.ndo_fix_features = xenvif_fix_features,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
};
struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
--
1.7.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: allow changing the MAC address of the interface
2012-10-19 17:34 [PATCH] xen-netback: allow changing the MAC address of the interface Matt Wilson
@ 2012-10-23 9:04 ` Ian Campbell
2012-10-23 22:14 ` Matt Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2012-10-23 9:04 UTC (permalink / raw)
To: Matt Wilson; +Cc: Paul Harvey, xen-devel, Nikita Borzykh, Konrad Rzeszutek Wilk
On Fri, 2012-10-19 at 18:34 +0100, Matt Wilson wrote:
> Reported-by: Nikita Borzykh <sample.n@gmail.com>
> Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> Suggested-by: Ian Campbell <Ian.Campbell@citrix.com>
I can't remember that but it seems reasonable:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
But, can you remind us of the usecase? Perhaps in the commit message?
Lastly, netback patches should be sent to netdev@vger.kernel.org as per
MAINTAINERS in order to be applied.
Thanks,
Ian.
> Signed-off-by: Matt Wilson <msw@amazon.com>
> ---
> drivers/net/xen-netback/interface.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index b7d41f8..f733cae 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
> .ndo_stop = xenvif_close,
> .ndo_change_mtu = xenvif_change_mtu,
> .ndo_fix_features = xenvif_fix_features,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> };
>
> struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xen-netback: allow changing the MAC address of the interface
2012-10-23 9:04 ` Ian Campbell
@ 2012-10-23 22:14 ` Matt Wilson
0 siblings, 0 replies; 3+ messages in thread
From: Matt Wilson @ 2012-10-23 22:14 UTC (permalink / raw)
To: Ian Campbell
Cc: Paul Harvey, xen-devel, Nikita Borzykh, Konrad Rzeszutek Wilk
On Tue, Oct 23, 2012 at 10:04:57AM +0100, Ian Campbell wrote:
> On Fri, 2012-10-19 at 18:34 +0100, Matt Wilson wrote:
> > Reported-by: Nikita Borzykh <sample.n@gmail.com>
> > Reported-by: Paul Harvey <stockingpaul@hotmail.com>
> > Suggested-by: Ian Campbell <Ian.Campbell@citrix.com>
>
> I can't remember that but it seems reasonable:
http://lists.xen.org/archives/html/xen-devel/2011-01/msg01427.html
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> But, can you remind us of the usecase? Perhaps in the commit message?
It could be useful for some ebtables configurations, I think.
> Lastly, netback patches should be sent to netdev@vger.kernel.org as per
> MAINTAINERS in order to be applied.
Indeed. I wrongly assumed that Konrad would take care of bringing it
into his tree and that it'd get pulled from there. I'll expand the
commit message, add your Acked-by:, and send it on.
Matt
> > Signed-off-by: Matt Wilson <msw@amazon.com>
> > ---
> > drivers/net/xen-netback/interface.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> > index b7d41f8..f733cae 100644
> > --- a/drivers/net/xen-netback/interface.c
> > +++ b/drivers/net/xen-netback/interface.c
> > @@ -238,6 +238,8 @@ static const struct net_device_ops xenvif_netdev_ops = {
> > .ndo_stop = xenvif_close,
> > .ndo_change_mtu = xenvif_change_mtu,
> > .ndo_fix_features = xenvif_fix_features,
> > + .ndo_set_mac_address = eth_mac_addr,
> > + .ndo_validate_addr = eth_validate_addr,
> > };
> >
> > struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 22:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-19 17:34 [PATCH] xen-netback: allow changing the MAC address of the interface Matt Wilson
2012-10-23 9:04 ` Ian Campbell
2012-10-23 22:14 ` Matt Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.