* [PATCH] pvr2: fix minor storage
@ 2012-10-25 14:38 Alan Cox
2012-10-26 4:13 ` Mike Isely
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2012-10-25 14:38 UTC (permalink / raw)
To: linux-media
From: Alan Cox <alan@linux.intel.com>
This should have break statements in it.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
index fb828ba..299751a 100644
--- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
+++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
@@ -3563,9 +3563,9 @@ void pvr2_hdw_v4l_store_minor_number(struct pvr2_hdw *hdw,
enum pvr2_v4l_type index,int v)
{
switch (index) {
- case pvr2_v4l_type_video: hdw->v4l_minor_number_video = v;
- case pvr2_v4l_type_vbi: hdw->v4l_minor_number_vbi = v;
- case pvr2_v4l_type_radio: hdw->v4l_minor_number_radio = v;
+ case pvr2_v4l_type_video: hdw->v4l_minor_number_video = v;break;
+ case pvr2_v4l_type_vbi: hdw->v4l_minor_number_vbi = v;break;
+ case pvr2_v4l_type_radio: hdw->v4l_minor_number_radio = v;break;
default: break;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pvr2: fix minor storage
2012-10-25 14:38 [PATCH] pvr2: fix minor storage Alan Cox
@ 2012-10-26 4:13 ` Mike Isely
0 siblings, 0 replies; 2+ messages in thread
From: Mike Isely @ 2012-10-26 4:13 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-media
Completely agree! Thanks for spotting that one.
Signed-off-by: Mike Isely <isely@pobox.com>
-Mike
On Thu, 25 Oct 2012, Alan Cox wrote:
> From: Alan Cox <alan@linux.intel.com>
>
> This should have break statements in it.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> index fb828ba..299751a 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> @@ -3563,9 +3563,9 @@ void pvr2_hdw_v4l_store_minor_number(struct pvr2_hdw *hdw,
> enum pvr2_v4l_type index,int v)
> {
> switch (index) {
> - case pvr2_v4l_type_video: hdw->v4l_minor_number_video = v;
> - case pvr2_v4l_type_vbi: hdw->v4l_minor_number_vbi = v;
> - case pvr2_v4l_type_radio: hdw->v4l_minor_number_radio = v;
> + case pvr2_v4l_type_video: hdw->v4l_minor_number_video = v;break;
> + case pvr2_v4l_type_vbi: hdw->v4l_minor_number_vbi = v;break;
> + case pvr2_v4l_type_radio: hdw->v4l_minor_number_radio = v;break;
> default: break;
> }
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-26 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-25 14:38 [PATCH] pvr2: fix minor storage Alan Cox
2012-10-26 4:13 ` Mike Isely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.