All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections
Date: Fri, 26 Oct 2012 23:44:35 +0200	[thread overview]
Message-ID: <20121026234435.26102ad0@lilith> (raw)
In-Reply-To: <20121026232501.7d844277@lilith>

On Fri, 26 Oct 2012 23:25:01 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:

> Hi Stephen,
> 
> On Thu, 18 Oct 2012 17:25:55 -0600, Stephen Warren
> <swarren@wwwdotorg.org> wrote:
> 
> > From: Stephen Warren <swarren@nvidia.com>
> > 
> > When -ffunction-sections or -fdata-section are used, symbols are placed
> > into sections such as .data.eserial1_device and .bss.serial_current.
> > Update the linker script to explicitly include these. Without this
> > change (at least with my gcc-4.5.3 built using crosstool-ng), I see that
> > the sections do end up being included, but __bss_end__ gets set to the
> > same value as __bss_start.
> > 
> > Signed-off-by: Stephen Warren <swarren@nvidia.com>
> > ---
> > v2: Removed changes from some entries where it wasn't needed.
> > ---
> >  arch/arm/cpu/u-boot.lds |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/cpu/u-boot.lds b/arch/arm/cpu/u-boot.lds
> > index e49ca0c..9153c3d 100644
> > --- a/arch/arm/cpu/u-boot.lds
> > +++ b/arch/arm/cpu/u-boot.lds
> > @@ -34,8 +34,8 @@ SECTIONS
> >  	.text :
> >  	{
> >  		__image_copy_start = .;
> > -		CPUDIR/start.o (.text)
> > -		*(.text)
> > +		CPUDIR/start.o (.text*)
> > +		*(.text*)
> >  	}
> >  
> >  	. = ALIGN(4);
> > @@ -43,7 +43,7 @@ SECTIONS
> >  
> >  	. = ALIGN(4);
> >  	.data : {
> > -		*(.data)
> > +		*(.data*)
> >  	}
> >  
> >  	. = ALIGN(4);
> > @@ -81,7 +81,7 @@ SECTIONS
> >  
> >  	.bss __rel_dyn_start (OVERLAY) : {
> >  		__bss_start = .;
> > -		*(.bss)
> > +		*(.bss*)
> >  		 . = ALIGN(4);
> >  		__bss_end__ = .;
> >  	}
> 
> Applied (this patch only in the series) to u-boot-arm/master, thanks!

Correction applied was V3, not V2, of the patch.

Amicalement,
-- 
Albert.

      reply	other threads:[~2012-10-26 21:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 23:25 [U-Boot] [PATCH V2 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Stephen Warren
2012-10-18 23:25 ` [U-Boot] [PATCH V2 2/5] ARM: enhance u-boot.lds to detect over-sized SPL Stephen Warren
2012-10-19 19:52   ` Simon Glass
2012-10-20  5:49   ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 3/5] ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it Stephen Warren
2012-10-19 19:49   ` Simon Glass
2012-10-20  5:53   ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 4/5] ARM: tegra: select between Seaboard/Ventana at compile time Stephen Warren
2012-10-19 19:51   ` Simon Glass
2012-10-19 21:50     ` Stephen Warren
2012-10-20  5:54   ` Allen Martin
2012-10-22 16:09     ` Stephen Warren
2012-10-22 17:26       ` Allen Martin
2012-10-18 23:25 ` [U-Boot] [PATCH V2 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL Stephen Warren
2012-10-19 19:53   ` Simon Glass
2012-10-20  5:58   ` Allen Martin
2012-10-20  5:46 ` [U-Boot] [PATCH V2 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Allen Martin
2012-10-26 21:25 ` Albert ARIBAUD
2012-10-26 21:44   ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026234435.26102ad0@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.