* [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()
@ 2012-10-29 9:26 Mika Westerberg
2012-10-29 9:26 ` [PATCH 2/2] ACPI, ia64: " Mika Westerberg
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mika Westerberg @ 2012-10-29 9:26 UTC (permalink / raw)
To: linux-kernel
Cc: tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo, hpa, x86,
Andy Shevchenko, Mika Westerberg
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
These functions might be called from modules as well so make sure they are
exported. In addition we implement empty version of acpi_unregister_gsi() and
remove the one from pci_irq.c.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
Although there are no modules that use this currently, we are working on
ACPI 5 device enumeration support that is going to use these functions and
some of that code can be compiled as a module.
arch/x86/kernel/acpi/boot.c | 6 ++++++
drivers/acpi/pci_irq.c | 5 -----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index e651f7a..2616d2b 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -574,6 +574,12 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
return irq;
}
+EXPORT_SYMBOL(acpi_register_gsi);
+
+void acpi_unregister_gsi(u32 gsi)
+{
+}
+EXPORT_SYMBOL(acpi_unregister_gsi);
void __init acpi_set_irq_model_pic(void)
{
diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
index 0eefa12..1be25a5 100644
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -495,11 +495,6 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
return 0;
}
-/* FIXME: implement x86/x86_64 version */
-void __attribute__ ((weak)) acpi_unregister_gsi(u32 i)
-{
-}
-
void acpi_pci_irq_disable(struct pci_dev *dev)
{
struct acpi_prt_entry *entry;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ACPI, ia64: export acpi_[un]register_gsi()
2012-10-29 9:26 [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi() Mika Westerberg
@ 2012-10-29 9:26 ` Mika Westerberg
2012-10-30 21:01 ` Konrad Rzeszutek Wilk
2012-10-29 11:12 ` [PATCH 1/2] ACPI, x86: " Ingo Molnar
2012-10-30 21:01 ` Konrad Rzeszutek Wilk
2 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2012-10-29 9:26 UTC (permalink / raw)
To: linux-kernel
Cc: tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo, hpa, x86,
Andy Shevchenko, Mika Westerberg
These functions might be called from modules as well so make sure they are
exported.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
arch/ia64/kernel/acpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
index 44057885..bd86e39 100644
--- a/arch/ia64/kernel/acpi.c
+++ b/arch/ia64/kernel/acpi.c
@@ -633,6 +633,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int triggering, int polarity)
ACPI_EDGE_SENSITIVE) ? IOSAPIC_EDGE :
IOSAPIC_LEVEL);
}
+EXPORT_SYMBOL(acpi_register_gsi);
void acpi_unregister_gsi(u32 gsi)
{
@@ -644,6 +645,7 @@ void acpi_unregister_gsi(u32 gsi)
iosapic_unregister_intr(gsi);
}
+EXPORT_SYMBOL(acpi_unregister_gsi);
static int __init acpi_parse_fadt(struct acpi_table_header *table)
{
--
1.7.12.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()
2012-10-29 9:26 [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi() Mika Westerberg
2012-10-29 9:26 ` [PATCH 2/2] ACPI, ia64: " Mika Westerberg
@ 2012-10-29 11:12 ` Ingo Molnar
2012-10-30 6:56 ` Mika Westerberg
2012-10-30 21:01 ` Konrad Rzeszutek Wilk
2 siblings, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2012-10-29 11:12 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-kernel, tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo,
hpa, x86, Andy Shevchenko
* Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> These functions might be called from modules as well so make sure they are
> exported. In addition we implement empty version of acpi_unregister_gsi() and
> remove the one from pci_irq.c.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Although there are no modules that use this currently, we are working on
> ACPI 5 device enumeration support that is going to use these functions and
> some of that code can be compiled as a module.
So why not submit these patches together with those patches?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()
2012-10-29 11:12 ` [PATCH 1/2] ACPI, x86: " Ingo Molnar
@ 2012-10-30 6:56 ` Mika Westerberg
0 siblings, 0 replies; 6+ messages in thread
From: Mika Westerberg @ 2012-10-30 6:56 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo,
hpa, x86, Andy Shevchenko
On Mon, Oct 29, 2012 at 12:12:10PM +0100, Ingo Molnar wrote:
>
> * Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > These functions might be called from modules as well so make sure they are
> > exported. In addition we implement empty version of acpi_unregister_gsi() and
> > remove the one from pci_irq.c.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > Although there are no modules that use this currently, we are working on
> > ACPI 5 device enumeration support that is going to use these functions and
> > some of that code can be compiled as a module.
>
> So why not submit these patches together with those patches?
Ok, we will do that. At the same time we change them to use _GPL version of
the EXPORT_SYMBOL.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ACPI, ia64: export acpi_[un]register_gsi()
2012-10-29 9:26 ` [PATCH 2/2] ACPI, ia64: " Mika Westerberg
@ 2012-10-30 21:01 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-10-30 21:01 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-kernel, tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo,
hpa, x86, Andy Shevchenko
On Mon, Oct 29, 2012 at 11:26:32AM +0200, Mika Westerberg wrote:
> These functions might be called from modules as well so make sure they are
> exported.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> arch/ia64/kernel/acpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
> index 44057885..bd86e39 100644
> --- a/arch/ia64/kernel/acpi.c
> +++ b/arch/ia64/kernel/acpi.c
> @@ -633,6 +633,7 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int triggering, int polarity)
> ACPI_EDGE_SENSITIVE) ? IOSAPIC_EDGE :
> IOSAPIC_LEVEL);
> }
> +EXPORT_SYMBOL(acpi_register_gsi);
_GPL ?
>
> void acpi_unregister_gsi(u32 gsi)
> {
> @@ -644,6 +645,7 @@ void acpi_unregister_gsi(u32 gsi)
>
> iosapic_unregister_intr(gsi);
> }
> +EXPORT_SYMBOL(acpi_unregister_gsi);
>
> static int __init acpi_parse_fadt(struct acpi_table_header *table)
> {
> --
> 1.7.12.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi()
2012-10-29 9:26 [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi() Mika Westerberg
2012-10-29 9:26 ` [PATCH 2/2] ACPI, ia64: " Mika Westerberg
2012-10-29 11:12 ` [PATCH 1/2] ACPI, x86: " Ingo Molnar
@ 2012-10-30 21:01 ` Konrad Rzeszutek Wilk
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2012-10-30 21:01 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-kernel, tony.luck, fenghua.yu, len.brown, rjw, tglx, mingo,
hpa, x86, Andy Shevchenko
On Mon, Oct 29, 2012 at 11:26:31AM +0200, Mika Westerberg wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> These functions might be called from modules as well so make sure they are
> exported. In addition we implement empty version of acpi_unregister_gsi() and
> remove the one from pci_irq.c.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Although there are no modules that use this currently, we are working on
> ACPI 5 device enumeration support that is going to use these functions and
> some of that code can be compiled as a module.
>
> arch/x86/kernel/acpi/boot.c | 6 ++++++
> drivers/acpi/pci_irq.c | 5 -----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index e651f7a..2616d2b 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -574,6 +574,12 @@ int acpi_register_gsi(struct device *dev, u32 gsi, int trigger, int polarity)
>
> return irq;
> }
> +EXPORT_SYMBOL(acpi_register_gsi);
_GPL ?
> +
> +void acpi_unregister_gsi(u32 gsi)
> +{
> +}
> +EXPORT_SYMBOL(acpi_unregister_gsi);
>
> void __init acpi_set_irq_model_pic(void)
> {
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> index 0eefa12..1be25a5 100644
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -495,11 +495,6 @@ int acpi_pci_irq_enable(struct pci_dev *dev)
> return 0;
> }
>
> -/* FIXME: implement x86/x86_64 version */
> -void __attribute__ ((weak)) acpi_unregister_gsi(u32 i)
> -{
> -}
> -
> void acpi_pci_irq_disable(struct pci_dev *dev)
> {
> struct acpi_prt_entry *entry;
> --
> 1.7.12.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-30 21:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-29 9:26 [PATCH 1/2] ACPI, x86: export acpi_[un]register_gsi() Mika Westerberg
2012-10-29 9:26 ` [PATCH 2/2] ACPI, ia64: " Mika Westerberg
2012-10-30 21:01 ` Konrad Rzeszutek Wilk
2012-10-29 11:12 ` [PATCH 1/2] ACPI, x86: " Ingo Molnar
2012-10-30 6:56 ` Mika Westerberg
2012-10-30 21:01 ` Konrad Rzeszutek Wilk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.