* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
@ 2012-10-20 10:31 ` bugzilla-daemon
2012-10-20 10:33 ` bugzilla-daemon
` (53 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-20 10:31 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #1 from Phillip Wood <phillip.wood@dunelm.org.uk> 2012-10-20 10:31:00 ---
Created an attachment (id=84101)
--> (https://bugzilla.kernel.org/attachment.cgi?id=84101)
Second page of backtrace
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
2012-10-20 10:31 ` [Bug 49151] " bugzilla-daemon
@ 2012-10-20 10:33 ` bugzilla-daemon
2012-10-20 12:00 ` [Bug 49151] New: " Borislav Petkov
` (52 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-20 10:33 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #2 from Phillip Wood <phillip.wood@dunelm.org.uk> 2012-10-20 10:33:09 ---
Created an attachment (id=84111)
--> (https://bugzilla.kernel.org/attachment.cgi?id=84111)
First page of backtrace
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
2012-10-20 10:31 ` [Bug 49151] " bugzilla-daemon
2012-10-20 10:33 ` bugzilla-daemon
@ 2012-10-20 12:00 ` Borislav Petkov
2012-10-21 16:04 ` Phillip Wood
2012-10-20 12:00 ` [Bug 49151] " bugzilla-daemon
` (51 subsequent siblings)
54 siblings, 1 reply; 70+ messages in thread
From: Borislav Petkov @ 2012-10-20 12:00 UTC (permalink / raw)
To: Anton V. Boyarshinov, phillip.wood
Cc: bugzilla-daemon, linux-ide, Jeff Garzik, Alan Cox
On Sat, Oct 20, 2012 at 10:19:22AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=49151
>
> Summary: NULL pointer dereference in pata_acpi
> Product: IO/Storage
> Version: 2.5
> Kernel Version: 3.6.2
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: IDE
> AssignedTo: io_ide@kernel-bugs.osdl.org
> ReportedBy: phillip.wood@dunelm.org.uk
> Regression: No
>
>
> Just upgraded from 3.2.20 to 3.6.2 and when I try to boot a get
>
> BUG unable to handle kernel NULL pointer dereference at 00000010
> IP [<efe4c2407>] pacpi_set_dmamode+0x50/0xa0 [pata_acpi]
>
> and it wont find my hard disc. I'm using the standard arch linux kernel config
> available at
> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/config?h=packages/linux
>
> I've attached a couple of photos of the message and backtrace
Ok,
let's first switch to mail.
FWIW, there's another report of this
http://marc.info/?l=linux-ide&m=134995465614435&w=2
and it is on 64-bit while Phillip's is 32-bit. Adding Anton and a couple
more people to CC.
From Anton's disassembly I get:
Ä 2.703078Ü Code: 01 00 00 00 f6 43 10 10 74 0a 41 89 c7 43 8d 0c 3f 41 d3 e6 41 0f b6 bd e1 02 00 00 e8 ce 74 0f 00 41 80 bd e1 02 00 00 3f 77 44 <0f> b7 40 10 41 f7 d6 44 21 73 10 4d 63 ff 42 89 44 fb 04 48 89
All code
========
0: 01 00 add %eax,(%rax)
2: 00 00 add %al,(%rax)
4: f6 43 10 10 testb $0x10,0x10(%rbx)
8: 74 0a je 0x14
a: 41 89 c7 mov %eax,%r15d
d: 43 8d 0c 3f lea (%r15,%r15,1),%ecx
11: 41 d3 e6 shl %cl,%r14d
14: 41 0f b6 bd e1 02 00 movzbl 0x2e1(%r13),%edi
1b: 00
1c: e8 ce 74 0f 00 callq 0xf74ef
21: 41 80 bd e1 02 00 00 cmpb $0x3f,0x2e1(%r13)
28: 3f
29: 77 44 ja 0x6f
2b:* 0f b7 40 10 movzwl 0x10(%rax),%eax <-- trapping instruction
2f: 41 f7 d6 not %r14d
32: 44 21 73 10 and %r14d,0x10(%rbx)
36: 4d 63 ff movslq %r15d,%r15
39: 42 89 44 fb 04 mov %eax,0x4(%rbx,%r15,8)
3e: 48 rex.W
3f: 89 .byte 0x89
And although I cannot generate the exact code here, building
drivers/ata/pata_acpi.c locally gives only one instruction like the
trapping one (thankfully, function is short enough):
sall %cl, %eax # tmp92, tmp93
orl %eax, 16(%rbx) # tmp93, acpi_6->gtm.flags
jmp .L30 #
.LVL46:
.L29:
.loc 1 151 0
movzwl 16(%rax), %eax # t_12->cycle, t_12->cycle <---
.LVL47:
.loc 1 152 0
leal (%r12,%r12), %ecx #, tmp97
which could mean that ata_timing_find_mode() might be returning NULL
on those systems (t is in %(r|e)ax in both oopses and the 0x10 offset
points to ata_timing->cycle).
So, Anton, Phillip, can you guys try the following debugging patch
to confirm (it is against mainline but should apply cleanly ontop of
3.6-stable):
---
diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index 09723b76beac..c5a54faecb98 100644
--- a/drivers/ata/pata_acpi.c
+++ b/drivers/ata/pata_acpi.c
@@ -144,6 +144,12 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
/* Now stuff the nS values into the structure */
t = ata_timing_find_mode(adev->dma_mode);
+
+ if (!t) {
+ WARN(1, "%s: ata_timing_find_mode gives NULL\n", __func__);
+ return;
+ }
+
if (adev->dma_mode >= XFER_UDMA_0) {
acpi->gtm.drive[unit].dma = t->udma;
acpi->gtm.flags |= (1 << (2 * unit));
--
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply related [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-20 12:00 ` [Bug 49151] New: " Borislav Petkov
@ 2012-10-21 16:04 ` Phillip Wood
2012-10-21 16:57 ` Borislav Petkov
0 siblings, 1 reply; 70+ messages in thread
From: Phillip Wood @ 2012-10-21 16:04 UTC (permalink / raw)
To: Borislav Petkov
Cc: Anton V. Boyarshinov, phillip.wood, bugzilla-daemon, linux-ide,
Jeff Garzik, Alan Cox
On 10/20/2012 01:00 PM, Borislav Petkov wrote:
> On Sat, Oct 20, 2012 at 10:19:22AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=49151
>>
>> Summary: NULL pointer dereference in pata_acpi
>> Product: IO/Storage
>> Version: 2.5
>> Kernel Version: 3.6.2
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: normal
>> Priority: P1
>> Component: IDE
>> AssignedTo: io_ide@kernel-bugs.osdl.org
>> ReportedBy: phillip.wood@dunelm.org.uk
>> Regression: No
>>
>>
>> Just upgraded from 3.2.20 to 3.6.2 and when I try to boot a get
>>
>> BUG unable to handle kernel NULL pointer dereference at 00000010
>> IP [<efe4c2407>] pacpi_set_dmamode+0x50/0xa0 [pata_acpi]
>>
>> and it wont find my hard disc. I'm using the standard arch linux kernel config
>> available at
>> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/config?h=packages/linux
>>
>> I've attached a couple of photos of the message and backtrace
>
> Ok,
>
> let's first switch to mail.
>
> FWIW, there's another report of this
>
> http://marc.info/?l=linux-ide&m=134995465614435&w=2
>
> and it is on 64-bit while Phillip's is 32-bit. Adding Anton and a couple
> more people to CC.
>
> From Anton's disassembly I get:
>
> Ä 2.703078Ü Code: 01 00 00 00 f6 43 10 10 74 0a 41 89 c7 43 8d 0c 3f 41 d3 e6 41 0f b6 bd e1 02 00 00 e8 ce 74 0f 00 41 80 bd e1 02 00 00 3f 77 44 <0f> b7 40 10 41 f7 d6 44 21 73 10 4d 63 ff 42 89 44 fb 04 48 89
> All code
> ========
> 0: 01 00 add %eax,(%rax)
> 2: 00 00 add %al,(%rax)
> 4: f6 43 10 10 testb $0x10,0x10(%rbx)
> 8: 74 0a je 0x14
> a: 41 89 c7 mov %eax,%r15d
> d: 43 8d 0c 3f lea (%r15,%r15,1),%ecx
> 11: 41 d3 e6 shl %cl,%r14d
> 14: 41 0f b6 bd e1 02 00 movzbl 0x2e1(%r13),%edi
> 1b: 00
> 1c: e8 ce 74 0f 00 callq 0xf74ef
> 21: 41 80 bd e1 02 00 00 cmpb $0x3f,0x2e1(%r13)
> 28: 3f
> 29: 77 44 ja 0x6f
> 2b:* 0f b7 40 10 movzwl 0x10(%rax),%eax <-- trapping instruction
> 2f: 41 f7 d6 not %r14d
> 32: 44 21 73 10 and %r14d,0x10(%rbx)
> 36: 4d 63 ff movslq %r15d,%r15
> 39: 42 89 44 fb 04 mov %eax,0x4(%rbx,%r15,8)
> 3e: 48 rex.W
> 3f: 89 .byte 0x89
>
> And although I cannot generate the exact code here, building
> drivers/ata/pata_acpi.c locally gives only one instruction like the
> trapping one (thankfully, function is short enough):
>
> sall %cl, %eax # tmp92, tmp93
> orl %eax, 16(%rbx) # tmp93, acpi_6->gtm.flags
> jmp .L30 #
> .LVL46:
> .L29:
> .loc 1 151 0
> movzwl 16(%rax), %eax # t_12->cycle, t_12->cycle <---
> .LVL47:
> .loc 1 152 0
> leal (%r12,%r12), %ecx #, tmp97
>
> which could mean that ata_timing_find_mode() might be returning NULL
> on those systems (t is in %(r|e)ax in both oopses and the 0x10 offset
> points to ata_timing->cycle).
>
> So, Anton, Phillip, can you guys try the following debugging patch
> to confirm (it is against mainline but should apply cleanly ontop of
> 3.6-stable):
>
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..c5a54faecb98 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,12 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> +
> + if (!t) {
> + WARN(1, "%s: ata_timing_find_mode gives NULL\n", __func__);
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
>
> Thanks.
>
Hi Borislav
Thanks for responding to the bug report so quickly. I've applied your
patch and the kernel now finds my hard drive and the logs (pasted below)
have a couple of warnings generated by the patch. So if I've understood
correctly then your theory that ata_timing_find_mode() is returning NULL
is correct.
Thanks for looking into this, just let me know if you want me to do
anything else
Best Wishes
Phillip
[ 1.932509] ------------[ cut here ]------------
[ 1.932509] WARNING: at drivers/ata/pata_acpi.c:149
pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 1.932509] Hardware name: Portable PC
[ 1.932509] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 1.932509] Modules linked in: pata_acpi ata_generic
[ 1.932509] Pid: 857, comm: scsi_eh_0 Not tainted 3.6.0-1-custom #1
[ 1.932509] Call Trace:
[ 1.932509] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<ef77e375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 1.932509] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 1.932509] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 1.932509] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 1.932509] [<c127d2d0>] ? ata_release_transport+0x40/0x40
[ 1.932509] [<c1039145>] ? msleep+0x15/0x20
[ 1.932509] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 1.932509] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 1.932509] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 1.932509] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 1.932509] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 1.932509] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 1.932509] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 1.932509] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 1.932509] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 1.932509] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 1.932509] [<c104719c>] ? kthread+0x6c/0x80
[ 1.932509] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 1.932509] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 1.932509] ---[ end trace 7db6a26b2c0e9208 ]---
[ 2.106520] ------------[ cut here ]------------
[ 2.106520] WARNING: at drivers/ata/pata_acpi.c:149
pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 2.106520] Hardware name: Portable PC
[ 2.106520] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 1.951725] ACPI: Invalid Power Resource to register!
[ 2.106520] Modules linked in: pata_acpi ata_generic
[ 2.106520] Pid: 863, comm: scsi_eh_1 Tainted: G W
3.6.0-1-custom #1
[ 2.106520] Call Trace:
[ 2.106520] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<ef77e375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 2.106520] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 2.106520] [<c11cda30>] ? acpi_os_release_object+0x5/0x8
[ 2.106520] [<c10b0e7b>] ? __kmalloc+0x2b/0x130
[ 2.106520] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 2.106520] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 2.106520] [<c11eaa87>] ? acpi_ut_delete_internal_obj+0x162/0x172
[ 2.106520] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 2.106520] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 2.106520] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 2.106520] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 2.106520] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 2.106520] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 2.106520] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 2.106520] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 2.106520] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.106520] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.106520] [<c104719c>] ? kthread+0x6c/0x80
[ 2.106520] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 2.106520] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 2.106520] ---[ end trace 7db6a26b2c0e9209 ]---
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-21 16:04 ` Phillip Wood
@ 2012-10-21 16:57 ` Borislav Petkov
2012-10-22 15:47 ` Phillip Wood
0 siblings, 1 reply; 70+ messages in thread
From: Borislav Petkov @ 2012-10-21 16:57 UTC (permalink / raw)
To: phillip.wood
Cc: Anton V. Boyarshinov, bugzilla-daemon, linux-ide, Jeff Garzik, Alan Cox
On Sun, Oct 21, 2012 at 05:04:12PM +0100, Phillip Wood wrote:
> Thanks for responding to the bug report so quickly. I've applied your
> patch and the kernel now finds my hard drive and the logs (pasted
> below) have a couple of warnings generated by the patch. So if I've
> understood correctly then your theory that ata_timing_find_mode() is
> returning NULL is correct.
Yes, it appears so.
> Thanks for looking into this, just let me know if you want me to do
> anything else.
Right, so we know what exactly happens and I think we have the right
people on CC who can make sense of why it happens.
If I'd be to guess, this is most probably a BIOS bug (what else?! :-))
which the pata_acpi code is not ready to handle.
Btw, Jeff, AFAICT, libata code should the very least catch this
situation so that we know. Patch for this below. From a quick look there
a couple of drivers which do not check ata_timing_find_mode()'s retval
and I guess at least issuing a warning in such situations could be
helpful with future issues.
However, I don't know how chatty this warning could become and whether
this is the right approach and not auditing all users is better.
What you can do, Phillip, is check whether some other specific PATA
driver supports your hardware and enable it instead of PATA_ACPI. What
does lspci on the box say? Or rather 'lspci -v' for more details. You
can also send dmesg from the box.
Thanks.
--
From: Borislav Petkov <bp@alien8.de>
Date: Sun, 21 Oct 2012 18:49:08 +0200
Subject: [PATCH] libata: Warn when unable to find timing descriptor based on
xfer_mode
ata_timing_find_mode could return NULL which is not checked by all
low-level ATA drivers using it and cause a NULL ptr deref. Warn at least
so that possible issues can get fixed easily.
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
drivers/ata/libata-core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 3cc7096cfda7..f46fbd3bd3fb 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2942,6 +2942,10 @@ const struct ata_timing *ata_timing_find_mode(u8 xfer_mode)
if (xfer_mode == t->mode)
return t;
+
+ WARN_ONCE(true, "%s: unable to find timing for xfer_mode 0x%x\n",
+ __func__, xfer_mode);
+
return NULL;
}
--
1.8.0.rc2
--
Regards/Gruss,
Boris.
^ permalink raw reply related [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-21 16:57 ` Borislav Petkov
@ 2012-10-22 15:47 ` Phillip Wood
2012-10-22 20:27 ` Borislav Petkov
0 siblings, 1 reply; 70+ messages in thread
From: Phillip Wood @ 2012-10-22 15:47 UTC (permalink / raw)
To: Borislav Petkov
Cc: phillip.wood, Anton V. Boyarshinov, bugzilla-daemon, linux-ide,
Jeff Garzik, Alan Cox
[-- Attachment #1: Type: text/plain, Size: 5701 bytes --]
On 10/21/2012 05:57 PM, Borislav Petkov wrote:
>
> What you can do, Phillip, is check whether some other specific PATA
> driver supports your hardware and enable it instead of PATA_ACPI. What
> does lspci on the box say? Or rather 'lspci -v' for more details. You
> can also send dmesg from the box.
>
lspci -v gives
00:00.0 Host bridge: ULi Electronics Inc. M1644/M1644T
Northbridge+Trident (rev 01)
Flags: bus master, medium devsel, latency 0
Memory at f0000000 (32-bit, prefetchable) [size=64M]
Capabilities: [b0] AGP version 2.0
Capabilities: [a4] Power Management version 1
Kernel driver in use: agpgart-ali
00:01.0 PCI bridge: ULi Electronics Inc. PCI to AGP Controller (prog-if
00 [Normal decode])
Flags: bus master, slow devsel, latency 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
Memory behind bridge: f7f00000-fdffffff
Prefetchable memory behind bridge: 30100000-301fffff
00:02.0 USB controller: ULi Electronics Inc. USB 1.1 Controller (rev 03)
(prog-if 10 [OHCI])
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 64, IRQ 11
Memory at f7eff000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [60] Power Management version 2
Kernel driver in use: ohci_hcd
00:04.0 IDE interface: ULi Electronics Inc. M5229 IDE (rev c3) (prog-if f0)
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 64, IRQ 255
[virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 000003f0 (type 3, non-prefetchable)
[virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 00000370 (type 3, non-prefetchable)
I/O ports at eff0 [size=16]
Capabilities: [60] Power Management version 2
Kernel driver in use: pata_ali
00:06.0 Multimedia audio controller: ULi Electronics Inc. M5451 PCI
AC-Link Controller Audio Device (rev 01)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, medium devsel, latency 64, IRQ 11
I/O ports at 1000 [size=256]
Memory at 30001000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [dc] Power Management version 2
Kernel driver in use: snd_ali5451
00:07.0 ISA bridge: ULi Electronics Inc. M1533/M1535/M1543 PCI to ISA
Bridge [Aladdin IV/V/V+]
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 0
Capabilities: [a0] Power Management version 1
00:08.0 Bridge: ULi Electronics Inc. M7101 Power Management Controller [PMU]
Subsystem: Toshiba America Info Systems Device 0001
Flags: medium devsel
Kernel driver in use: ali1535_smbus
00:0a.0 Ethernet controller: Intel Corporation 82557/8/9/0/1 Ethernet
Pro 100 (rev 0d)
Subsystem: Toshiba America Info Systems 8255x-based Ethernet Adapter
(10/100)
Flags: bus master, medium devsel, latency 64, IRQ 11
Memory at f7efe000 (32-bit, non-prefetchable) [size=4K]
I/O ports at eec0 [size=64]
Memory at f7ec0000 (32-bit, non-prefetchable) [size=128K]
Capabilities: [dc] Power Management version 2
Kernel driver in use: e100
00:11.0 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to
Cardbus Bridge with ZV Support (rev 32)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, slow devsel, latency 168, IRQ 11
Memory at 30000000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=00, secondary=02, subordinate=05, sec-latency=0
Memory window 0: 34000000-37ffffff (prefetchable)
Memory window 1: 38000000-3bffffff
I/O window 0: 00001400-000014ff
I/O window 1: 00001800-000018ff
16-bit legacy interface ports at 0001
Kernel driver in use: yenta_cardbus
00:11.1 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to
Cardbus Bridge with ZV Support (rev 32)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, slow devsel, latency 168, IRQ 11
Memory at 3c000000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=00, secondary=06, subordinate=09, sec-latency=0
Memory window 0: 40000000-43ffffff (prefetchable)
Memory window 1: 44000000-47ffffff
I/O window 0: 00001c00-00001cff
I/O window 1: 00002000-000020ff
16-bit legacy interface ports at 0001
Kernel driver in use: yenta_cardbus
00:12.0 System peripheral: Toshiba America Info Systems SD TypA
Controller (rev 03)
Subsystem: Toshiba America Info Systems Device 0001
Flags: medium devsel, IRQ 255
Memory at 30002000 (32-bit, non-prefetchable) [disabled] [size=512]
Capabilities: [80] Power Management version 2
01:00.0 VGA compatible controller: Trident Microsystems CyberBlade XPAi1
(rev 82) (prog-if 00 [VGA controller])
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, 66MHz, medium devsel, latency 8, IRQ 11
Memory at fc000000 (32-bit, non-prefetchable) [size=32M]
Memory at fbc00000 (32-bit, non-prefetchable) [size=4M]
Memory at f8000000 (32-bit, non-prefetchable) [size=32M]
Memory at f7ff8000 (32-bit, non-prefetchable) [size=32K]
[virtual] Expansion ROM at 30100000 [disabled] [size=64K]
Capabilities: [80] AGP version 2.0
Capabilities: [90] Power Management version 2
06:00.0 Network controller: Broadcom Corporation BCM4306 802.11b/g
Wireless LAN Controller (rev 03)
Subsystem: Belkin F5D7011 v1000 High-Speed Mode Wireless G Notebook Card
Flags: bus master, fast devsel, latency 64, IRQ 11
Memory at 44000000 (32-bit, non-prefetchable) [size=8K]
Kernel driver in use: b43-pci-bridge
If I blacklist pata_acpi and remove it from the initrd image then my
unpatched distro kernel boots and seems to run fine (I've not checked if
the hard drive power management is affected though). I've attached the
dmesg from the patched kernel which was built with a minimal config.
Best Wishes
Phillip
[-- Attachment #2: dmesg_patched_v3.6.txt --]
[-- Type: text/plain, Size: 43998 bytes --]
[ 0.000000] Linux version 3.6.0-1-custom (phil@lindisfarne) (gcc version 4.7.2 (GCC) ) #1 PREEMPT Sat Oct 20 15:58:54 UTC 2012
[ 0.000000] e820: BIOS-provided physical RAM map:
[ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000009fbff] usable
[ 0.000000] BIOS-e820: [mem 0x000000000009fc00-0x000000000009ffff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000000e0000-0x00000000000eedff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000000eee00-0x00000000000eefff] ACPI NVS
[ 0.000000] BIOS-e820: [mem 0x00000000000ef000-0x00000000000fffff] reserved
[ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x000000002ef5ffff] usable
[ 0.000000] BIOS-e820: [mem 0x000000002ef60000-0x000000002ef6ffff] ACPI data
[ 0.000000] BIOS-e820: [mem 0x000000002ef70000-0x000000002fffffff] reserved
[ 0.000000] BIOS-e820: [mem 0x00000000fff80000-0x00000000ffffffff] reserved
[ 0.000000] Notice: NX (Execute Disable) protection missing in CPU!
[ 0.000000] DMI 2.3 present.
[ 0.000000] DMI: TOSHIBA Portable PC/Portable PC, BIOS Version 1.40 03/26/2002
[ 0.000000] e820: update [mem 0x00000000-0x0000ffff] usable ==> reserved
[ 0.000000] e820: remove [mem 0x000a0000-0x000fffff] usable
[ 0.000000] e820: last_pfn = 0x2ef60 max_arch_pfn = 0x100000
[ 0.000000] MTRR default type: uncachable
[ 0.000000] MTRR fixed ranges enabled:
[ 0.000000] 00000-9FFFF write-back
[ 0.000000] A0000-BFFFF uncachable
[ 0.000000] C0000-CBFFF write-protect
[ 0.000000] CC000-DFFFF uncachable
[ 0.000000] E0000-E7FFF write-protect
[ 0.000000] E8000-EFFFF write-back
[ 0.000000] F0000-FFFFF write-protect
[ 0.000000] MTRR variable ranges enabled:
[ 0.000000] 0 base 0FFF80000 mask FFFF80000 write-protect
[ 0.000000] 1 base 000000000 mask FE0000000 write-back
[ 0.000000] 2 base 020000000 mask FF0000000 write-back
[ 0.000000] 3 disabled
[ 0.000000] 4 disabled
[ 0.000000] 5 disabled
[ 0.000000] 6 disabled
[ 0.000000] 7 disabled
[ 0.000000] PAT not supported by CPU.
[ 0.000000] initial memory mapped: [mem 0x00000000-0x01bfffff]
[ 0.000000] Base memory trampoline at [c009b000] 9b000 size 16384
[ 0.000000] init_memory_mapping: [mem 0x00000000-0x2ef5ffff]
[ 0.000000] [mem 0x00000000-0x003fffff] page 4k
[ 0.000000] [mem 0x00400000-0x2ebfffff] page 2M
[ 0.000000] [mem 0x2ec00000-0x2ef5ffff] page 4k
[ 0.000000] kernel direct mapping tables up to 0x2ef5ffff @ [mem 0x01bfa000-0x01bfffff]
[ 0.000000] RAMDISK: [mem 0x2eda8000-0x2ef5efff]
[ 0.000000] ACPI: RSDP 000f0090 00014 (v00 TOSHIB)
[ 0.000000] ACPI: RSDT 2ef60000 0002C (v01 TOSHIB 750 00970814 TASM 04010000)
[ 0.000000] ACPI: FACP 2ef60054 00084 (v02 TOSHIB 750 00970814 TASM 04010000)
[ 0.000000] ACPI: DSDT 2ef600d8 063FB (v01 TOSHIB 6000 20011016 MSFT 0100000A)
[ 0.000000] ACPI: FACS 000eee00 00040
[ 0.000000] ACPI: BOOT 2ef6002c 00028 (v01 TOSHIB 750 00970814 TASM 04010000)
[ 0.000000] 751MB LOWMEM available.
[ 0.000000] mapped low ram: 0 - 2ef60000
[ 0.000000] low ram: 0 - 2ef60000
[ 0.000000] Zone ranges:
[ 0.000000] DMA [mem 0x00010000-0x00ffffff]
[ 0.000000] Normal [mem 0x01000000-0x2ef5ffff]
[ 0.000000] Movable zone start for each node
[ 0.000000] Early memory node ranges
[ 0.000000] node 0: [mem 0x00010000-0x0009efff]
[ 0.000000] node 0: [mem 0x00100000-0x2ef5ffff]
[ 0.000000] On node 0 totalpages: 192239
[ 0.000000] free_area_init_node: node 0, pgdat c1548400, node_mem_map ee7c8200
[ 0.000000] DMA zone: 32 pages used for memmap
[ 0.000000] DMA zone: 0 pages reserved
[ 0.000000] DMA zone: 3951 pages, LIFO batch:0
[ 0.000000] Normal zone: 1471 pages used for memmap
[ 0.000000] Normal zone: 186785 pages, LIFO batch:31
[ 0.000000] Using APIC driver default
[ 0.000000] ACPI: PM-Timer IO Port: 0xee08
[ 0.000000] Local APIC disabled by BIOS -- you can enable it with "lapic"
[ 0.000000] APIC: disable apic facility
[ 0.000000] APIC: switched to apic NOOP
[ 0.000000] nr_irqs_gsi: 16
[ 0.000000] PM: Registered nosave memory: 000000000009f000 - 00000000000a0000
[ 0.000000] PM: Registered nosave memory: 00000000000a0000 - 00000000000e0000
[ 0.000000] PM: Registered nosave memory: 00000000000e0000 - 00000000000ee000
[ 0.000000] PM: Registered nosave memory: 00000000000ee000 - 00000000000ef000
[ 0.000000] PM: Registered nosave memory: 00000000000ef000 - 0000000000100000
[ 0.000000] e820: [mem 0x30000000-0xfff7ffff] available for PCI devices
[ 0.000000] pcpu-alloc: s0 r0 d32768 u32768 alloc=1*32768
[ 0.000000] pcpu-alloc: [0] 0
[ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 190736
[ 0.000000] Kernel command line: root=/dev/sda2 resume=/dev/sda1 vga=792 quiet ro systemd.unit=multi-user.target initrd=../initramfs-linux-custom.img BOOT_IMAGE=../vmlinuz-linux-custom
[ 0.000000] PID hash table entries: 4096 (order: 2, 16384 bytes)
[ 0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes)
[ 0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)
[ 0.000000] __ex_table already sorted, skipping sort
[ 0.000000] Initializing CPU#0
[ 0.000000] Memory: 754096k/769408k available (4161k kernel code, 14860k reserved, 1278k data, 376k init, 0k highmem)
[ 0.000000] virtual kernel memory layout:
[ 0.000000] fixmap : 0xfffa3000 - 0xfffff000 ( 368 kB)
[ 0.000000] vmalloc : 0xef760000 - 0xfffa1000 ( 264 MB)
[ 0.000000] lowmem : 0xc0000000 - 0xeef60000 ( 751 MB)
[ 0.000000] .init : 0xc1550000 - 0xc15ae000 ( 376 kB)
[ 0.000000] .data : 0xc14104a9 - 0xc154ffe0 (1278 kB)
[ 0.000000] .text : 0xc1000000 - 0xc14104a9 (4161 kB)
[ 0.000000] Checking if this processor honours the WP bit even in supervisor mode...Ok.
[ 0.000000] SLUB: Genslabs=15, HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1
[ 0.000000] NR_IRQS:2304 nr_irqs:256 16
[ 0.000000] CPU 0 irqstacks, hard=ee006000 soft=ee008000
[ 0.000000] Console: colour dummy device 80x25
[ 0.000000] console [tty0] enabled
[ 0.000000] tsc: Fast TSC calibration using PIT
[ 0.000000] tsc: Detected 996.024 MHz processor
[ 0.002004] Calibrating delay loop (skipped), value calculated using timer frequency.. 1992.04 BogoMIPS (lpj=996024)
[ 0.002015] pid_max: default: 32768 minimum: 301
[ 0.002099] Mount-cache hash table entries: 512
[ 0.002550] mce: CPU supports 5 MCE banks
[ 0.002604] Last level iTLB entries: 4KB 32, 2MB 0, 4MB 2
[ 0.002604] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 8
[ 0.002604] tlb_flushall_shift is 0x6
[ 0.002611] CPU: Intel(R) Pentium(R) III Mobile CPU 1000MHz stepping 01
[ 0.002648] ACPI: Core revision 20120711
[ 0.006400] ACPI: setting ELCR to 0200 (from 0a00)
[ 0.006939] Performance Events:
[ 0.006947] no APIC, boot with the "lapic" boot parameter to force-enable it.
[ 0.006951] no hardware sampling interrupt available.
[ 0.006957] p6 PMU driver.
[ 0.006964] ... version: 0
[ 0.006968] ... bit width: 32
[ 0.006971] ... generic registers: 2
[ 0.006975] ... value mask: 00000000ffffffff
[ 0.006978] ... max period: 000000007fffffff
[ 0.006982] ... fixed-purpose events: 0
[ 0.006985] ... event mask: 0000000000000003
[ 0.007444] devtmpfs: initialized
[ 0.008234] PM: Registering ACPI NVS region [mem 0x000eee00-0x000eefff] (512 bytes)
[ 0.008415] NET: Registered protocol family 16
[ 0.009695] ACPI: bus type pci registered
[ 0.010683] PCI: PCI BIOS revision 2.10 entry at 0xf97ab, last bus=5
[ 0.010689] PCI: Using configuration type 1 for base access
[ 0.020545] bio: create slab <bio-0> at 0
[ 0.020778] ACPI: Added _OSI(Module Device)
[ 0.020784] ACPI: Added _OSI(Processor Device)
[ 0.020789] ACPI: Added _OSI(3.0 _SCP Extensions)
[ 0.020795] ACPI: Added _OSI(Processor Aggregator Device)
[ 0.022261] ACPI: EC: Look up EC in DSDT
[ 0.027309] ACPI: Interpreter enabled
[ 0.027329] ACPI: (supports S0 S3 S4 S5)
[ 0.027371] ACPI: Using PIC for interrupt routing
[ 0.038069] [Firmware Bug]: ACPI: No _BQC method, cannot determine initial brightness
[ 0.040200] ACPI: Power Resource [PFAN] (off)
[ 0.043271] ACPI: ACPI Dock Station Driver: 2 docks/bays found
[ 0.043289] PCI: Ignoring host bridge windows from ACPI; if necessary, use "pci=use_crs" and report a bug
[ 0.043348] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-ff])
[ 0.043395] pci_root PNP0A03:00: host bridge window [io 0x0000-0x0cf7] (ignored)
[ 0.043403] pci_root PNP0A03:00: host bridge window [io 0x0d00-0xffff] (ignored)
[ 0.043411] pci_root PNP0A03:00: host bridge window [mem 0x000a0000-0x000bffff] (ignored)
[ 0.043418] pci_root PNP0A03:00: host bridge window [mem 0x000d8000-0x000dffff] (ignored)
[ 0.043425] pci_root PNP0A03:00: host bridge window [mem 0x40100000-0xfee9ffff] (ignored)
[ 0.043432] PCI: root bus 00: using default resources
[ 0.043443] pci_root PNP0A03:00: fail to add MMCONFIG information, can't access extended PCI configuration space under this bridge.
[ 0.043564] PCI host bridge to bus 0000:00
[ 0.043577] pci_bus 0000:00: busn_res: [bus 00-ff] is inserted under domain [bus 00-ff]
[ 0.043585] pci_bus 0000:00: root bus resource [bus 00-ff]
[ 0.043593] pci_bus 0000:00: root bus resource [io 0x0000-0xffff]
[ 0.043599] pci_bus 0000:00: root bus resource [mem 0x00000000-0xffffffff]
[ 0.043634] pci 0000:00:00.0: [10b9:1644] type 00 class 0x060000
[ 0.043662] pci 0000:00:00.0: reg 10: [mem 0xf0000000-0xf3ffffff pref]
[ 0.043763] pci 0000:00:01.0: [10b9:5247] type 01 class 0x060400
[ 0.043824] pci 0000:00:02.0: [10b9:5237] type 00 class 0x0c0310
[ 0.043846] pci 0000:00:02.0: reg 10: [mem 0xf7eff000-0xf7efffff]
[ 0.043915] pci 0000:00:02.0: PME# supported from D3hot D3cold
[ 0.043946] pci 0000:00:04.0: [10b9:5229] type 00 class 0x0101f0
[ 0.044035] pci 0000:00:04.0: reg 20: [io 0xeff0-0xefff]
[ 0.044097] pci 0000:00:06.0: [10b9:5451] type 00 class 0x040100
[ 0.044119] pci 0000:00:06.0: reg 10: [io 0x0000-0x00ff]
[ 0.044135] pci 0000:00:06.0: reg 14: [mem 0x00000000-0x00000fff]
[ 0.044196] pci 0000:00:06.0: supports D1 D2
[ 0.044203] pci 0000:00:06.0: PME# supported from D2 D3hot D3cold
[ 0.044230] pci 0000:00:07.0: [10b9:1533] type 00 class 0x060100
[ 0.044335] pci 0000:00:08.0: [10b9:7101] type 00 class 0x068000
[ 0.044416] pci 0000:00:08.0: quirk: [io 0xee00-0xee3f] claimed by ali7101 ACPI
[ 0.044425] pci 0000:00:08.0: quirk: [io 0xef00-0xef1f] claimed by ali7101 SMB
[ 0.044454] pci 0000:00:0a.0: [8086:1229] type 00 class 0x020000
[ 0.044477] pci 0000:00:0a.0: reg 10: [mem 0xf7efe000-0xf7efefff]
[ 0.044492] pci 0000:00:0a.0: reg 14: [io 0xeec0-0xeeff]
[ 0.044507] pci 0000:00:0a.0: reg 18: [mem 0xf7ec0000-0xf7edffff]
[ 0.044560] pci 0000:00:0a.0: supports D1 D2
[ 0.044567] pci 0000:00:0a.0: PME# supported from D0 D1 D2 D3hot D3cold
[ 0.044604] pci 0000:00:11.0: [1179:0617] type 02 class 0x060700
[ 0.044629] pci 0000:00:11.0: reg 10: [mem 0x00000000-0x00000fff]
[ 0.044676] pci 0000:00:11.1: [1179:0617] type 02 class 0x060700
[ 0.044701] pci 0000:00:11.1: reg 10: [mem 0x00000000-0x00000fff]
[ 0.044755] pci 0000:00:12.0: [1179:0805] type 00 class 0x088000
[ 0.044779] pci 0000:00:12.0: reg 10: [mem 0x00000000-0x000001ff]
[ 0.044855] pci 0000:00:12.0: supports D1 D2
[ 0.044862] pci 0000:00:12.0: PME# supported from D0 D1 D2 D3hot D3cold
[ 0.044910] pci_bus 0000:01: busn_res: [bus 01] is inserted under [bus 00-ff]
[ 0.044930] pci 0000:01:00.0: [1023:8820] type 00 class 0x030000
[ 0.044949] pci 0000:01:00.0: reg 10: [mem 0xfc000000-0xfdffffff]
[ 0.044962] pci 0000:01:00.0: reg 14: [mem 0xfbc00000-0xfbffffff]
[ 0.044974] pci 0000:01:00.0: reg 18: [mem 0xf8000000-0xf9ffffff]
[ 0.044987] pci 0000:01:00.0: reg 1c: [mem 0xf7ff8000-0xf7ffffff]
[ 0.045019] pci 0000:01:00.0: reg 30: [mem 0x00000000-0x0000ffff pref]
[ 0.045043] pci 0000:01:00.0: supports D1 D2
[ 0.045079] pci 0000:00:01.0: PCI bridge to [bus 01]
[ 0.045093] pci 0000:00:01.0: bridge window [mem 0xf7f00000-0xfdffffff]
[ 0.045151] pci_bus 0000:02: busn_res: [bus 02-ff] is inserted under [bus 00-ff]
[ 0.045165] pci_bus 0000:02: busn_res: [bus 02-ff] end is updated to 05
[ 0.045205] pci_bus 0000:06: busn_res: [bus 06-ff] is inserted under [bus 00-ff]
[ 0.045215] pci_bus 0000:06: busn_res: [bus 06-ff] end is updated to 09
[ 0.045226] pci_bus 0000:00: on NUMA node 0
[ 0.045236] ACPI: PCI Interrupt Routing Table [\_SB_.PCI0._PRT]
[ 0.045409] ACPI: PCI Interrupt Routing Table [\_SB_.PCI0.PCI1._PRT]
[ 0.045456] pci0000:00: ACPI _OSC support notification failed, disabling PCIe ASPM
[ 0.045463] pci0000:00: Unable to request _OSC control (_OSC support mask: 0x08)
[ 0.055791] ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 6 7 10 *11)
[ 0.056034] ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 6 7 10 *11)
[ 0.056238] ACPI: PCI Interrupt Link [LNKC] (IRQs 3 4 5 6 7 10 *11)
[ 0.056442] ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 5 6 7 10 *11)
[ 0.056646] ACPI: PCI Interrupt Link [LNKG] (IRQs 3 4 5 6 7 10 *11)
[ 0.056850] ACPI: PCI Interrupt Link [LNKH] (IRQs 3 4 5 6 7 10 *11)
[ 0.057264] vgaarb: device added: PCI:0000:01:00.0,decodes=io+mem,owns=io+mem,locks=none
[ 0.057271] vgaarb: loaded
[ 0.057274] vgaarb: bridge control possible 0000:01:00.0
[ 0.057670] SCSI subsystem initialized
[ 0.057679] ACPI: bus type scsi registered
[ 0.057900] libata version 3.00 loaded.
[ 0.058342] PCI: Using ACPI for IRQ routing
[ 0.058455] PCI: pci_cache_line_size set to 32 bytes
[ 0.058520] e820: reserve RAM buffer [mem 0x0009fc00-0x0009ffff]
[ 0.058526] e820: reserve RAM buffer [mem 0x2ef60000-0x2fffffff]
[ 0.059175] cfg80211: Calling CRDA to update world regulatory domain
[ 0.059748] Switching to clocksource pit
[ 0.059981] pnp: PnP ACPI init
[ 0.059981] ACPI: bus type pnp registered
[ 0.060910] pnp 00:00: [mem 0x00000000-0x0009ffff]
[ 0.060918] pnp 00:00: [mem 0x000e0000-0x000effff]
[ 0.060924] pnp 00:00: [mem 0x000f0000-0x000fffff]
[ 0.060931] pnp 00:00: [mem 0x00100000-0x2ef5ffff]
[ 0.060937] pnp 00:00: [mem 0x2ef60000-0x2ef6ffff]
[ 0.060944] pnp 00:00: [mem 0x2f000000-0x2fffffff]
[ 0.060950] pnp 00:00: [mem 0x2ef70000-0x2effffff]
[ 0.060957] pnp 00:00: [mem 0xffe00000-0xffffffff]
[ 0.061128] system 00:00: [mem 0x00000000-0x0009ffff] could not be reserved
[ 0.061137] system 00:00: [mem 0x000e0000-0x000effff] could not be reserved
[ 0.061145] system 00:00: [mem 0x000f0000-0x000fffff] could not be reserved
[ 0.061153] system 00:00: [mem 0x00100000-0x2ef5ffff] could not be reserved
[ 0.061161] system 00:00: [mem 0x2ef60000-0x2ef6ffff] could not be reserved
[ 0.061169] system 00:00: [mem 0x2f000000-0x2fffffff] has been reserved
[ 0.061177] system 00:00: [mem 0x2ef70000-0x2effffff] has been reserved
[ 0.061185] system 00:00: [mem 0xffe00000-0xffffffff] could not be reserved
[ 0.061197] system 00:00: Plug and Play ACPI device, IDs PNP0c01 (active)
[ 0.061288] pnp 00:01: [bus 00-ff]
[ 0.061298] pnp 00:01: [io 0x0cf8-0x0cff]
[ 0.061305] pnp 00:01: [io 0x0000-0x0cf7 window]
[ 0.061312] pnp 00:01: [io 0x0d00-0xffff window]
[ 0.061319] pnp 00:01: [mem 0x000a0000-0x000bffff window]
[ 0.061326] pnp 00:01: [mem 0x000d8000-0x000dffff window]
[ 0.061333] pnp 00:01: [mem 0x40100000-0xfee9ffff window]
[ 0.061493] pnp 00:01: Plug and Play ACPI device, IDs PNP0a03 (active)
[ 0.061794] pnp 00:02: [io 0x0000-0x000f]
[ 0.061802] pnp 00:02: [io 0x0081-0x0083]
[ 0.061808] pnp 00:02: [io 0x0087]
[ 0.061814] pnp 00:02: [io 0x0089-0x008b]
[ 0.061820] pnp 00:02: [io 0x008f]
[ 0.061827] pnp 00:02: [io 0x00c0-0x00df]
[ 0.061835] pnp 00:02: [dma 4]
[ 0.061958] pnp 00:02: Plug and Play ACPI device, IDs PNP0200 (active)
[ 0.062000] pnp 00:03: [io 0x0061]
[ 0.062101] pnp 00:03: Plug and Play ACPI device, IDs PNP0800 (active)
[ 0.062130] pnp 00:04: [io 0x00f0-0x00ff]
[ 0.062143] pnp 00:04: [irq 13]
[ 0.062309] pnp 00:04: Plug and Play ACPI device, IDs PNP0c04 (active)
[ 0.062377] pnp 00:05: [io 0x0060]
[ 0.062384] pnp 00:05: [io 0x0064]
[ 0.062391] pnp 00:05: [irq 1]
[ 0.062490] pnp 00:05: Plug and Play ACPI device, IDs PNP0303 (active)
[ 0.062546] pnp 00:06: [irq 12]
[ 0.062649] pnp 00:06: Plug and Play ACPI device, IDs PNP0f13 (active)
[ 0.062678] pnp 00:07: [io 0x0070-0x0071]
[ 0.062686] pnp 00:07: [irq 8]
[ 0.062796] pnp 00:07: Plug and Play ACPI device, IDs PNP0b00 (active)
[ 0.062842] pnp 00:08: [io 0x002e-0x002f]
[ 0.062849] pnp 00:08: [io 0x0062]
[ 0.062856] pnp 00:08: [io 0x0066]
[ 0.062862] pnp 00:08: [io 0x0080]
[ 0.062868] pnp 00:08: [io 0x0084-0x0086]
[ 0.062874] pnp 00:08: [io 0x0088]
[ 0.062880] pnp 00:08: [io 0x008c-0x008e]
[ 0.062886] pnp 00:08: [io 0x0092]
[ 0.062892] pnp 00:08: [io 0x00b0-0x00b3]
[ 0.062899] pnp 00:08: [io 0x00e0-0x00ef]
[ 0.062905] pnp 00:08: [io 0x0370-0x0371]
[ 0.062911] pnp 00:08: [io 0x040b]
[ 0.062917] pnp 00:08: [io 0x0480-0x048f]
[ 0.062923] pnp 00:08: [io 0x04d0-0x04d1]
[ 0.062929] pnp 00:08: [io 0x04d6]
[ 0.062936] pnp 00:08: [io 0x06c0-0x06ff]
[ 0.062942] pnp 00:08: [io 0xe000-0xe07f]
[ 0.062948] pnp 00:08: [io 0xe080-0xe0ff]
[ 0.062954] pnp 00:08: [io 0xe400-0xe47f]
[ 0.062960] pnp 00:08: [io 0xe480-0xe4ff]
[ 0.062967] pnp 00:08: [io 0xe800-0xe87f]
[ 0.062973] pnp 00:08: [io 0xe880-0xe8ff]
[ 0.062979] pnp 00:08: [io 0xec00-0xec7f]
[ 0.062985] pnp 00:08: [io 0xec80-0xecff]
[ 0.062991] pnp 00:08: [io 0xee00-0xee41]
[ 0.062997] pnp 00:08: [io 0xee90-0xee9f]
[ 0.063004] pnp 00:08: [io 0xeeac]
[ 0.063010] pnp 00:08: [io 0xef00-0xef3f]
[ 0.063016] pnp 00:08: [io 0xef40-0xef5f]
[ 0.063054] pnp 00:08: disabling [io 0x002e-0x002f] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063063] pnp 00:08: disabling [io 0x0062] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063071] pnp 00:08: disabling [io 0x0066] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063079] pnp 00:08: disabling [io 0x0080] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063088] pnp 00:08: disabling [io 0x0084-0x0086] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063096] pnp 00:08: disabling [io 0x0088] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063105] pnp 00:08: disabling [io 0x008c-0x008e] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063113] pnp 00:08: disabling [io 0x0092] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063122] pnp 00:08: disabling [io 0x00b0-0x00b3] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063130] pnp 00:08: disabling [io 0x00e0-0x00ef] because it overlaps 0000:00:06.0 BAR 0 [io 0x0000-0x00ff]
[ 0.063315] system 00:08: [io 0x0370-0x0371] has been reserved
[ 0.063324] system 00:08: [io 0x040b] has been reserved
[ 0.063331] system 00:08: [io 0x0480-0x048f] has been reserved
[ 0.063339] system 00:08: [io 0x04d0-0x04d1] has been reserved
[ 0.063347] system 00:08: [io 0x04d6] has been reserved
[ 0.063354] system 00:08: [io 0x06c0-0x06ff] has been reserved
[ 0.063362] system 00:08: [io 0xe000-0xe07f] has been reserved
[ 0.063370] system 00:08: [io 0xe080-0xe0ff] has been reserved
[ 0.063377] system 00:08: [io 0xe400-0xe47f] has been reserved
[ 0.063385] system 00:08: [io 0xe480-0xe4ff] has been reserved
[ 0.063393] system 00:08: [io 0xe800-0xe87f] has been reserved
[ 0.063400] system 00:08: [io 0xe880-0xe8ff] has been reserved
[ 0.063408] system 00:08: [io 0xec00-0xec7f] has been reserved
[ 0.063416] system 00:08: [io 0xec80-0xecff] has been reserved
[ 0.063424] system 00:08: [io 0xee00-0xee41] could not be reserved
[ 0.063432] system 00:08: [io 0xee90-0xee9f] has been reserved
[ 0.063439] system 00:08: [io 0xeeac] has been reserved
[ 0.063447] system 00:08: [io 0xef00-0xef3f] could not be reserved
[ 0.063455] system 00:08: [io 0xef40-0xef5f] has been reserved
[ 0.063464] system 00:08: Plug and Play ACPI device, IDs PNP0c02 (active)
[ 0.065097] pnp 00:09: [io 0x03f8-0x03ff]
[ 0.065106] pnp 00:09: [irq 4]
[ 0.066714] pnp 00:09: Plug and Play ACPI device, IDs PNP0501 (active)
[ 0.068515] pnp 00:0a: Plug and Play ACPI device, IDs SMCf010 (disabled)
[ 0.070340] pnp 00:0b: Plug and Play ACPI device, IDs PNP0401 (disabled)
[ 0.071846] pnp: PnP ACPI: found 12 devices
[ 0.071851] ACPI: ACPI bus type pnp unregistered
[ 0.115129] Switching to clocksource acpi_pm
[ 0.115483] pci 0000:00:11.0: res[9]=[mem 0x04000000-0x03ffffff pref] get_res_add_size add_size 4000000
[ 0.115492] pci 0000:00:11.0: res[10]=[mem 0x04000000-0x03ffffff] get_res_add_size add_size 4000000
[ 0.115502] pci 0000:00:11.1: res[9]=[mem 0x04000000-0x03ffffff pref] get_res_add_size add_size 4000000
[ 0.115510] pci 0000:00:11.1: res[10]=[mem 0x04000000-0x03ffffff] get_res_add_size add_size 4000000
[ 0.115518] pci 0000:00:11.0: res[7]=[io 0x0100-0x00ff] get_res_add_size add_size 100
[ 0.115526] pci 0000:00:11.0: res[8]=[io 0x0100-0x00ff] get_res_add_size add_size 100
[ 0.115534] pci 0000:00:11.1: res[7]=[io 0x0100-0x00ff] get_res_add_size add_size 100
[ 0.115541] pci 0000:00:11.1: res[8]=[io 0x0100-0x00ff] get_res_add_size add_size 100
[ 0.115563] pci 0000:00:11.0: BAR 0: assigned [mem 0x30000000-0x30000fff]
[ 0.115580] pci 0000:00:11.0: BAR 9: assigned [mem 0x34000000-0x37ffffff pref]
[ 0.115589] pci 0000:00:11.0: BAR 10: assigned [mem 0x38000000-0x3bffffff]
[ 0.115598] pci 0000:00:11.1: BAR 0: assigned [mem 0x3c000000-0x3c000fff]
[ 0.115611] pci 0000:00:11.1: BAR 9: assigned [mem 0x40000000-0x43ffffff pref]
[ 0.115620] pci 0000:00:11.1: BAR 10: assigned [mem 0x44000000-0x47ffffff]
[ 0.115630] pci 0000:00:01.0: BAR 9: assigned [mem 0x30100000-0x301fffff pref]
[ 0.115640] pci 0000:00:06.0: BAR 1: assigned [mem 0x30001000-0x30001fff]
[ 0.115652] pci 0000:00:12.0: BAR 0: assigned [mem 0x30002000-0x300021ff]
[ 0.115666] pci 0000:00:06.0: BAR 0: assigned [io 0x1000-0x10ff]
[ 0.115679] pci 0000:00:11.0: BAR 7: assigned [io 0x1400-0x14ff]
[ 0.115689] pci 0000:00:11.0: BAR 8: assigned [io 0x1800-0x18ff]
[ 0.115699] pci 0000:00:11.1: BAR 7: assigned [io 0x1c00-0x1cff]
[ 0.115710] pci 0000:00:11.1: BAR 8: assigned [io 0x2000-0x20ff]
[ 0.115725] pci 0000:01:00.0: BAR 6: assigned [mem 0x30100000-0x3010ffff pref]
[ 0.115733] pci 0000:00:01.0: PCI bridge to [bus 01]
[ 0.115746] pci 0000:00:01.0: bridge window [mem 0xf7f00000-0xfdffffff]
[ 0.115756] pci 0000:00:01.0: bridge window [mem 0x30100000-0x301fffff pref]
[ 0.115769] pci 0000:00:11.0: CardBus bridge to [bus 02-05]
[ 0.115776] pci 0000:00:11.0: bridge window [io 0x1400-0x14ff]
[ 0.115786] pci 0000:00:11.0: bridge window [io 0x1800-0x18ff]
[ 0.115796] pci 0000:00:11.0: bridge window [mem 0x34000000-0x37ffffff pref]
[ 0.115806] pci 0000:00:11.0: bridge window [mem 0x38000000-0x3bffffff]
[ 0.115815] pci 0000:00:11.1: CardBus bridge to [bus 06-09]
[ 0.115822] pci 0000:00:11.1: bridge window [io 0x1c00-0x1cff]
[ 0.115831] pci 0000:00:11.1: bridge window [io 0x2000-0x20ff]
[ 0.115841] pci 0000:00:11.1: bridge window [mem 0x40000000-0x43ffffff pref]
[ 0.115851] pci 0000:00:11.1: bridge window [mem 0x44000000-0x47ffffff]
[ 0.115881] pci 0000:00:01.0: setting latency timer to 64
[ 0.115894] pci 0000:00:11.0: enabling device (0000 -> 0003)
[ 0.116453] ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 11
[ 0.116462] PCI: setting IRQ 11 as level-triggered
[ 0.116480] pci 0000:00:11.1: enabling device (0000 -> 0003)
[ 0.116817] ACPI: PCI Interrupt Link [LNKB] enabled at IRQ 11
[ 0.116833] pci_bus 0000:00: resource 4 [io 0x0000-0xffff]
[ 0.116841] pci_bus 0000:00: resource 5 [mem 0x00000000-0xffffffff]
[ 0.116850] pci_bus 0000:01: resource 1 [mem 0xf7f00000-0xfdffffff]
[ 0.116857] pci_bus 0000:01: resource 2 [mem 0x30100000-0x301fffff pref]
[ 0.116865] pci_bus 0000:02: resource 0 [io 0x1400-0x14ff]
[ 0.116871] pci_bus 0000:02: resource 1 [io 0x1800-0x18ff]
[ 0.116879] pci_bus 0000:02: resource 2 [mem 0x34000000-0x37ffffff pref]
[ 0.116885] pci_bus 0000:02: resource 3 [mem 0x38000000-0x3bffffff]
[ 0.116893] pci_bus 0000:06: resource 0 [io 0x1c00-0x1cff]
[ 0.116900] pci_bus 0000:06: resource 1 [io 0x2000-0x20ff]
[ 0.116907] pci_bus 0000:06: resource 2 [mem 0x40000000-0x43ffffff pref]
[ 0.116914] pci_bus 0000:06: resource 3 [mem 0x44000000-0x47ffffff]
[ 0.117082] NET: Registered protocol family 2
[ 0.117494] TCP established hash table entries: 131072 (order: 8, 1048576 bytes)
[ 0.123672] TCP bind hash table entries: 65536 (order: 6, 262144 bytes)
[ 0.125292] TCP: Hash tables configured (established 131072 bind 65536)
[ 0.125682] TCP: reno registered
[ 0.125715] UDP hash table entries: 512 (order: 1, 8192 bytes)
[ 0.125782] UDP-Lite hash table entries: 512 (order: 1, 8192 bytes)
[ 0.126373] NET: Registered protocol family 1
[ 0.127192] ACPI: PCI Interrupt Link [LNKG] enabled at IRQ 11
[ 0.190104] pci 0000:00:07.0: Activating ISA DMA hang workarounds
[ 0.190139] pci 0000:00:0a.0: Firmware left e100 interrupts enabled; disabling
[ 0.190173] pci 0000:01:00.0: Boot video device
[ 0.190181] PCI: CLS 32 bytes, default 32
[ 0.190372] Trying to unpack rootfs image as initramfs...
[ 0.311289] Freeing initrd memory: 1756k freed
[ 0.322683] Simple Boot Flag at 0x7c set to 0x1
[ 0.325993] HugeTLB registered 4 MB page size, pre-allocated 0 pages
[ 0.335810] msgmni has been set to 1476
[ 0.336669] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 253)
[ 0.336682] io scheduler noop registered
[ 0.336697] io scheduler cfq registered (default)
[ 0.337186] pci_hotplug: PCI Hot Plug PCI Core version: 0.5
[ 0.337486] vesafb: mode is 1024x768x32, linelength=4096, pages=4
[ 0.337492] vesafb: protected mode interface info at c000:780a
[ 0.337499] vesafb: pmi: set display start = c00c782b, set palette = c00c788e
[ 0.337503] vesafb: scrolling: redraw
[ 0.337512] vesafb: Truecolor: size=0:8:8:8, shift=0:16:8:0
[ 0.338794] vesafb: framebuffer at 0xfc000000, mapped to 0xef780000, using 6144k, total 16384k
[ 0.437104] Console: switching to colour frame buffer device 128x48
[ 0.525522] fb0: VESA VGA frame buffer device
[ 0.525822] ACPI: Deprecated procfs I/F for AC is loaded, please retry with CONFIG_ACPI_PROCFS_POWER cleared
[ 0.526057] ACPI: AC Adapter [ADP1] (off-line)
[ 0.526451] input: Lid Switch as /devices/LNXSYSTM:00/device:00/PNP0C0D:00/input/input0
[ 0.526517] ACPI: Lid Switch [LID]
[ 0.526673] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input1
[ 0.526685] ACPI: Power Button [PWRF]
[ 0.527220] ACPI: Fan [FAN] (off)
[ 0.527518] [Firmware Bug]: ACPI: No _BQC method, cannot determine initial brightness
[ 0.528385] acpi device:12: registered as cooling_device1
[ 0.528485] ACPI: Video Device [VGA] (multi-head: yes rom: yes post: no)
[ 0.528620] input: Video Bus as /devices/LNXSYSTM:00/device:00/PNP0A03:00/device:11/LNXVIDEO:00/input/input2
[ 0.528751] ACPI: Requesting acpi_cpufreq
[ 0.529244] tsc: Marking TSC unstable due to TSC halts in idle
[ 0.529269] ACPI: acpi_idle registered with cpuidle
[ 0.533822] thermal LNXTHERM:00: registered as thermal_zone0
[ 0.533839] ACPI: Thermal Zone [THRM] (61 C)
[ 0.535820] ACPI: Deprecated procfs I/F for battery is loaded, please retry with CONFIG_ACPI_PROCFS_POWER cleared
[ 0.535837] ACPI: Battery Slot [BAT1] (battery present)
[ 0.535894] ACPI: Deprecated procfs I/F for battery is loaded, please retry with CONFIG_ACPI_PROCFS_POWER cleared
[ 0.535905] ACPI: Battery Slot [BAT2] (battery absent)
[ 0.536116] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
[ 0.801142] serial8250: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
[ 0.823045] 00:09: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
[ 0.823775] Non-volatile memory driver v1.3
[ 0.823966] Toshiba System Management Mode driver v1.11 26/9/2001
[ 0.824130] Linux agpgart interface v0.103
[ 0.824169] agpgart-ali 0000:00:00.0: ALi M1644 chipset
[ 0.832351] agpgart-ali 0000:00:00.0: AGP aperture is 64M @ 0xf0000000
[ 0.832598] [drm] Initialized drm 1.1.0 20060810
[ 0.836566] brd: module loaded
[ 0.838703] loop: module loaded
[ 0.839217] e100: Intel(R) PRO/100 Network Driver, 3.5.24-k2-NAPI
[ 0.839222] e100: Copyright(c) 1999-2006 Intel Corporation
[ 0.839873] ACPI: PCI Interrupt Link [LNKD] enabled at IRQ 11
[ 0.866140] e100 0000:00:0a.0: eth0: addr 0xf7efe000, irq 11, MAC addr 00:00:39:07:b8:b1
[ 0.866301] yenta_cardbus 0000:00:11.0: CardBus bridge found [1179:0001]
[ 0.988744] yenta_cardbus 0000:00:11.0: ISA IRQ mask 0x04b8, PCI irq 11
[ 0.988752] yenta_cardbus 0000:00:11.0: Socket status: 30000007
[ 0.989320] yenta_cardbus 0000:00:11.1: CardBus bridge found [1179:0001]
[ 1.111851] yenta_cardbus 0000:00:11.1: ISA IRQ mask 0x04b8, PCI irq 11
[ 1.111869] yenta_cardbus 0000:00:11.1: Socket status: 30000020
[ 1.115095] i8042: PNP: PS/2 Controller [PNP0303:KBC,PNP0f13:PS2M] at 0x60,0x64 irq 1,12
[ 1.121097] serio: i8042 KBD port at 0x60,0x64 irq 1
[ 1.121177] serio: i8042 AUX port at 0x60,0x64 irq 12
[ 1.121594] mousedev: PS/2 mouse device common for all mice
[ 1.122676] rtc_cmos 00:07: RTC can wake from S4
[ 1.123004] rtc_cmos 00:07: rtc core: registered rtc_cmos as rtc0
[ 1.123106] rtc0: alarms up to one year, 114 bytes nvram
[ 1.123218] ali1535_smbus 0000:00:08.0: enabling device (0000 -> 0001)
[ 1.123614] alim1535_wdt: initialized. timeout=60 sec (nowayout=0)
[ 1.123685] cpuidle: using governor ladder
[ 1.123751] cpuidle: using governor menu
[ 1.124085] Netfilter messages via NETLINK v0.30.
[ 1.124132] nf_conntrack version 0.5.0 (11810 buckets, 47240 max)
[ 1.124507] ctnetlink v0.93: registering with nfnetlink.
[ 1.125097] ip_tables: (C) 2000-2006 Netfilter Core Team
[ 1.125216] TCP: cubic registered
[ 1.125221] Initializing XFRM netlink socket
[ 1.126107] NET: Registered protocol family 10
[ 1.126939] ip6_tables: (C) 2000-2006 Netfilter Core Team
[ 1.127095] sit: IPv6 over IPv4 tunneling driver
[ 1.127633] NET: Registered protocol family 17
[ 1.127695] Key type dns_resolver registered
[ 1.128377] Using IPI Shortcut mode
[ 1.147041] input: AT Translated Set 2 keyboard as /devices/platform/i8042/serio0/input/input3
[ 1.918485] input: ImPS/2 Generic Wheel Mouse as /devices/platform/i8042/serio1/input/input4
[ 1.924877] Freeing unused kernel memory: 376k freed
[ 1.925945] Write protecting the kernel text: 4164k
[ 1.925992] Write protecting the kernel read-only data: 1032k
[ 1.987139] pcmcia_socket pcmcia_socket1: pccard: CardBus card inserted into slot 1
[ 1.987190] pci 0000:06:00.0: [14e4:4320] type 00 class 0x028000
[ 1.987230] pci 0000:06:00.0: reg 10: [mem 0x00000000-0x00001fff]
[ 1.987349] pci 0000:06:00.0: BAR 0: assigned [mem 0x44000000-0x44001fff]
[ 1.987373] pci 0000:06:00.0: cache line size of 32 is not supported
[ 1.989638] b43-pci-bridge 0000:06:00.0: enabling device (0000 -> 0002)
[ 1.989693] b43-pci-bridge 0000:06:00.0: setting latency timer to 64
[ 1.989753] ssb: Found chip with id 0x4306, rev 0x03 and package 0x00
[ 1.989766] ssb: Core 0 found: ChipCommon (cc 0x800, rev 0x04, vendor 0x4243)
[ 1.989777] ssb: Core 1 found: IEEE 802.11 (cc 0x812, rev 0x05, vendor 0x4243)
[ 1.989788] ssb: Core 2 found: PCMCIA (cc 0x80D, rev 0x02, vendor 0x4243)
[ 1.989798] ssb: Core 3 found: V90 (cc 0x807, rev 0x02, vendor 0x4243)
[ 1.989808] ssb: Core 4 found: PCI (cc 0x804, rev 0x09, vendor 0x4243)
[ 1.996252] ssb: Sonics Silicon Backplane found on PCI device 0000:06:00.0
[ 2.095707] pata_acpi 0000:00:04.0: can't derive routing for PCI INT A
[ 2.105839] scsi0 : pata_acpi
[ 2.108767] scsi1 : pata_acpi
[ 2.111184] ata1: PATA max UDMA/133 cmd 0x1f0 ctl 0x3f6 bmdma 0xeff0 irq 14
[ 2.111199] ata2: PATA max UDMA/133 cmd 0x170 ctl 0x376 bmdma 0xeff8 irq 15
[ 2.677495] ------------[ cut here ]------------
[ 2.677495] WARNING: at drivers/ata/pata_acpi.c:149 pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 2.677495] Hardware name: Portable PC
[ 2.677495] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 2.677495] Modules linked in: pata_acpi ata_generic
[ 2.677495] Pid: 863, comm: scsi_eh_0 Not tainted 3.6.0-1-custom #1
[ 2.677495] Call Trace:
[ 2.677495] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 2.677495] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.677495] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.677495] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 2.677495] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.677495] [<efd84375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 2.677495] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 2.677495] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 2.677495] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 2.677495] [<c127d2d0>] ? ata_release_transport+0x40/0x40
[ 2.677495] [<c1039145>] ? msleep+0x15/0x20
[ 2.677495] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 2.677495] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 2.677495] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 2.677495] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 2.677495] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.677495] [<efd84180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.677495] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.677495] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.677495] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 2.677495] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.677495] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.677495] [<efd84180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.677495] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.677495] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 2.677495] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.677495] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 2.677495] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 2.677495] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 2.677495] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 2.677495] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 2.677495] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.677495] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.677495] [<c104719c>] ? kthread+0x6c/0x80
[ 2.677495] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 2.677495] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 2.677495] ---[ end trace 869d9aa7f2250d15 ]---
[ 2.682255] ata1.00: ATA-5: TOSHIBA MK2018GAP, M1.42 A, max UDMA/100
[ 2.682265] ata1.00: 39070080 sectors, multi 16: LBA
[ 2.688166] ata1.00: configured for UDMA/66
[ 2.699944] scsi 0:0:0:0: Direct-Access ATA TOSHIBA MK2018GA M1.4 PQ: 0 ANSI: 5
[ 2.701564] sd 0:0:0:0: [sda] 39070080 512-byte logical blocks: (20.0 GB/18.6 GiB)
[ 2.701718] sd 0:0:0:0: [sda] Write Protect is off
[ 2.701730] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[ 2.701800] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
[ 2.704132] sd 0:0:0:0: Attached scsi generic sg0 type 0
[ 2.859500] ------------[ cut here ]------------
[ 2.859500] WARNING: at drivers/ata/pata_acpi.c:149 pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 2.859500] Hardware name: Portable PC
[ 2.859500] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 2.704796] ACPI: Invalid Power Resource to register!
[ 2.859500] Modules linked in: pata_acpi ata_generic
[ 2.859500] Pid: 869, comm: scsi_eh_1 Tainted: G W 3.6.0-1-custom #1
[ 2.859500] Call Trace:
[ 2.859500] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 2.859500] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.859500] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.859500] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 2.859500] [<efd842b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.859500] [<efd84375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 2.859500] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 2.859500] [<c11cda30>] ? acpi_os_release_object+0x5/0x8
[ 2.859500] [<c10b0e7b>] ? __kmalloc+0x2b/0x130
[ 2.859500] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 2.859500] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 2.859500] [<c11eaa87>] ? acpi_ut_delete_internal_obj+0x162/0x172
[ 2.859500] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 2.859500] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 2.859500] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 2.859500] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 2.859500] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.859500] [<efd84180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.859500] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.859500] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.859500] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 2.859500] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.859500] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.859500] [<efd84180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.859500] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.859500] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 2.859500] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.859500] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 2.859500] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 2.859500] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 2.859500] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 2.859500] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 2.859500] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.859500] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.859500] [<c104719c>] ? kthread+0x6c/0x80
[ 2.859500] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 2.859500] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 2.859500] ---[ end trace 869d9aa7f2250d16 ]---
[ 2.863806] ata2.00: ATAPI: CD-224E-BA, 7.7C, max UDMA/33
[ 2.863823] ata2.00: simplex DMA is claimed by other device, disabling DMA
[ 2.871217] ata2.00: configured for PIO4
[ 2.888712] scsi 1:0:0:0: CD-ROM TEAC CD-224E-BA 7.7C PQ: 0 ANSI: 5
[ 2.892171] sr0: scsi3-mmc drive: 24x/24x cd/rw xa/form2 cdda tray
[ 2.892184] cdrom: Uniform CD-ROM driver Revision: 3.20
[ 2.893604] sr 1:0:0:0: Attached scsi CD-ROM sr0
[ 2.894315] sr 1:0:0:0: Attached scsi generic sg1 type 5
[ 3.083254] sda: sda1 sda2 sda3
[ 3.085214] sd 0:0:0:0: [sda] Attached SCSI disk
[ 3.662220] PM: Starting manual resume from disk
[ 3.847521] EXT4-fs (sda2): mounted filesystem with ordered data mode. Opts: (null)
[ 22.121796] RPC: Registered named UNIX socket transport module.
[ 22.121800] RPC: Registered udp transport module.
[ 22.121801] RPC: Registered tcp transport module.
[ 22.121803] RPC: Registered tcp NFSv4.1 backchannel transport module.
[ 25.045337] parport_pc 00:0b: [io 0x0378-0x037a]
[ 25.045351] parport_pc 00:0b: [io 0x0778-0x077a]
[ 25.045421] parport_pc 00:0b: [irq 7]
[ 25.045431] parport_pc 00:0b: [dma 1]
[ 25.063832] parport_pc 00:0b: activated
[ 25.063845] parport_pc 00:0b: reported by Plug and Play ACPI
[ 2.895723] ACPI: Invalid Power Resource to register!
[ 25.063899] parport0: PC-style at 0x378 (0x778), irq 7 [PCSPP(,...)]
[ 25.309009] b43-phy0: Broadcom 4306 WLAN found (core revision 5)
[ 25.317548] ACPI: bus type usb registered
[ 25.326948] usbcore: registered new interface driver usbfs
[ 25.333210] Broadcom 43xx driver loaded [ Features: PL ]
[ 25.343457] usbcore: registered new interface driver hub
[ 25.353372] usbcore: registered new device driver usb
[ 25.410903] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
[ 25.594102] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
[ 25.594254] ohci_hcd 0000:00:02.0: OHCI Host Controller
[ 25.594275] ohci_hcd 0000:00:02.0: new USB bus registered, assigned bus number 1
[ 25.594332] ohci_hcd 0000:00:02.0: irq 11, io mem 0xf7eff000
[ 25.651511] hub 1-0:1.0: USB hub found
[ 25.651532] hub 1-0:1.0: 3 ports detected
[ 26.030752] pcmcia_socket pcmcia_socket0: cs: memory probe 0x0c0000-0x0fffff:
[ 26.030785] excluding 0xc0000-0xcbfff 0xe0000-0xfffff
[ 26.030867] pcmcia_socket pcmcia_socket0: cs: memory probe 0xa0000000-0xa0ffffff:
[ 26.030889] clean.
[ 26.030968] pcmcia_socket pcmcia_socket0: cs: memory probe 0x60000000-0x60ffffff:
[ 26.030987] clean.
[ 26.031641] pcmcia_socket pcmcia_socket1: cs: memory probe 0x0c0000-0x0fffff:
[ 26.031660] excluding 0xc0000-0xcbfff 0xe0000-0xfffff
[ 26.031738] pcmcia_socket pcmcia_socket1: cs: memory probe 0xa0000000-0xa0ffffff:
[ 26.031758] clean.
[ 26.031837] pcmcia_socket pcmcia_socket1: cs: memory probe 0x60000000-0x60ffffff:
[ 26.031857] clean.
[ 26.033550] EXT4-fs (sda2): re-mounted. Opts: (null)
[ 26.361191] snd_ali5451 0000:00:06.0: enabling device (0000 -> 0003)
[ 26.361738] ACPI: PCI Interrupt Link [LNKH] enabled at IRQ 11
[ 26.576985] ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
[ 26.593148] Registered led device: b43-phy0::tx
[ 26.594747] Registered led device: b43-phy0::rx
[ 26.596518] Registered led device: b43-phy0::radio
[ 29.146630] Adding 975868k swap on /dev/sda1. Priority:-1 extents:1 across:975868k
[ 31.464545] EXT4-fs (sda3): mounted filesystem with ordered data mode. Opts: (null)
[ 38.347083] b43-phy0: Loading firmware version 666.2 (2011-02-23 01:15:07)
[ 38.408907] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
[ 40.962288] wlan0: authenticate with 00:11:50:9e:c8:62
[ 40.970434] wlan0: send auth to 00:11:50:9e:c8:62 (try 1/3)
[ 40.979215] wlan0: authenticated
[ 40.979672] b43 ssb0:0: wlan0: disabling HT as WMM/QoS is not supported
[ 40.981859] wlan0: associate with 00:11:50:9e:c8:62 (try 1/3)
[ 40.984148] wlan0: RX AssocResp from 00:11:50:9e:c8:62 (capab=0x431 status=0 aid=2)
[ 40.986199] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
[ 40.986607] wlan0: associated
[ 44.494982] wlan0: deauthenticating from 00:11:50:9e:c8:62 by local choice (reason=3)
[ 44.498144] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
[ 44.498407] cfg80211: Calling CRDA to update world regulatory domain
[ 44.607952] cfg80211: World regulatory domain updated:
[ 44.607973] cfg80211: (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp)
[ 44.607983] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz), (300 mBi, 2000 mBm)
[ 44.607991] cfg80211: (2457000 KHz - 2482000 KHz @ 20000 KHz), (300 mBi, 2000 mBm)
[ 44.607999] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz), (300 mBi, 2000 mBm)
[ 44.608007] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz), (300 mBi, 2000 mBm)
[ 44.610227] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz), (300 mBi, 2000 mBm)
^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-22 15:47 ` Phillip Wood
@ 2012-10-22 20:27 ` Borislav Petkov
2012-10-23 10:05 ` Alan Cox
0 siblings, 1 reply; 70+ messages in thread
From: Borislav Petkov @ 2012-10-22 20:27 UTC (permalink / raw)
To: phillip.wood
Cc: Anton V. Boyarshinov, bugzilla-daemon, linux-ide, Jeff Garzik, Alan Cox
On Mon, Oct 22, 2012 at 04:47:52PM +0100, Phillip Wood wrote:
> 00:04.0 IDE interface: ULi Electronics Inc. M5229 IDE (rev c3) (prog-if f0)
> Subsystem: Toshiba America Info Systems Device 0004
> Flags: bus master, medium devsel, latency 64, IRQ 255
> [virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 000003f0 (type 3, non-prefetchable)
> [virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 00000370 (type 3, non-prefetchable)
> I/O ports at eff0 [size=16]
> Capabilities: [60] Power Management version 2
> Kernel driver in use: pata_ali
Ok, your IDE interface is supported by pata_ali...
[ … ]
> If I blacklist pata_acpi and remove it from the initrd image then my
> unpatched distro kernel boots and seems to run fine (I've not checked
> if the hard drive power management is affected though). I've attached
> the dmesg from the patched kernel which was built with a minimal
> config.
Right, as it looks above, pata_ali should be able to support your IDE
interface, so you might not be needing the pata_acpi thing after all.
So yes, blacklisting it and verifying that your system still operates
normally would be something to do. If it does, you could also build a
kernel with pata_acpi disabled (that is, provided you build your own
kernels).
HTH.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-22 20:27 ` Borislav Petkov
@ 2012-10-23 10:05 ` Alan Cox
2012-10-23 10:17 ` Borislav Petkov
0 siblings, 1 reply; 70+ messages in thread
From: Alan Cox @ 2012-10-23 10:05 UTC (permalink / raw)
To: Borislav Petkov
Cc: phillip.wood, Anton V. Boyarshinov, bugzilla-daemon, linux-ide,
Jeff Garzik
> So yes, blacklisting it and verifying that your system still operates
> normally would be something to do. If it does, you could also build a
> kernel with pata_acpi disabled (that is, provided you build your own
> kernels).
The crash is still a bug. It needs chasing down.
Alan
^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-23 10:05 ` Alan Cox
@ 2012-10-23 10:17 ` Borislav Petkov
2012-10-23 16:12 ` Borislav Petkov
2012-10-24 9:28 ` Phillip Wood
0 siblings, 2 replies; 70+ messages in thread
From: Borislav Petkov @ 2012-10-23 10:17 UTC (permalink / raw)
To: Alan Cox
Cc: phillip.wood, Anton V. Boyarshinov, bugzilla-daemon, linux-ide,
Jeff Garzik
On Tue, Oct 23, 2012 at 11:05:49AM +0100, Alan Cox wrote:
> > So yes, blacklisting it and verifying that your system still operates
> > normally would be something to do. If it does, you could also build a
> > kernel with pata_acpi disabled (that is, provided you build your own
> > kernels).
>
> The crash is still a bug. It needs chasing down.
Yes, ata_timing_find_mode gives NULL, we found that out.
Anton, Phillip, anyone willing to run this hunk below and get us the
output:
---
diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index 09723b76beac..80d594d6e7c8 100644
--- a/drivers/ata/pata_acpi.c
+++ b/drivers/ata/pata_acpi.c
@@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
/* Now stuff the nS values into the structure */
t = ata_timing_find_mode(adev->dma_mode);
+ if (!t) {
+ pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
+ __func__, adev->dma_mode);
+
+ return;
+ }
+
if (adev->dma_mode >= XFER_UDMA_0) {
acpi->gtm.drive[unit].dma = t->udma;
acpi->gtm.flags |= (1 << (2 * unit));
--
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply related [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-23 10:17 ` Borislav Petkov
@ 2012-10-23 16:12 ` Borislav Petkov
2012-10-24 6:43 ` Anton V. Boyarshinov
2012-10-24 9:28 ` Phillip Wood
1 sibling, 1 reply; 70+ messages in thread
From: Borislav Petkov @ 2012-10-23 16:12 UTC (permalink / raw)
To: Alan Cox, Tejun Heo
Cc: phillip.wood, Anton V. Boyarshinov, bugzilla-daemon, linux-ide,
Jeff Garzik
On Tue, Oct 23, 2012 at 12:17:51PM +0200, Borislav Petkov wrote:
> On Tue, Oct 23, 2012 at 11:05:49AM +0100, Alan Cox wrote:
> > > So yes, blacklisting it and verifying that your system still operates
> > > normally would be something to do. If it does, you could also build a
> > > kernel with pata_acpi disabled (that is, provided you build your own
> > > kernels).
> >
> > The crash is still a bug. It needs chasing down.
>
> Yes, ata_timing_find_mode gives NULL, we found that out.
>
> Anton, Phillip, anyone willing to run this hunk below and get us the
> output:
>
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..80d594d6e7c8 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> + if (!t) {
> + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> + __func__, adev->dma_mode);
> +
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
Ok, here's the output from Anton's box
(https://bugzilla.kernel.org/show_bug.cgi?id=49151#c16):
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
And in that case we should've matched XFER_PIO_SLOW but it is commented
out for some reason.
Judging by 70cd071e4ecc06c985189665af75c108601fd5a3, I think we should
involve Tejun into this.
@Tejun: so basically there are two people with oopses when using
pata_acpi because pacpi_set_dmamode queries xfer mode with
adev->dma_mode = 0x0 and ata_timing_find_mode returns NULL (presumably a
BIOS bug, I'd say).
More details if you follow the thread here:
http://marc.info/?l=linux-ide&m=135073445731432
I don't know how to fix this since if BIOS gives xfer_mode 0, how can
each pata controller find its max mode? Sure, we can always fall back to
0x0 but that is the slowest and not necessarily optimal.
One other possibility could be to load chipset-specific drivers first
and pata_acpi only as a last resort but I don't know whether this is
doable at all.
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-23 16:12 ` Borislav Petkov
@ 2012-10-24 6:43 ` Anton V. Boyarshinov
0 siblings, 0 replies; 70+ messages in thread
From: Anton V. Boyarshinov @ 2012-10-24 6:43 UTC (permalink / raw)
To: Borislav Petkov
Cc: Alan Cox, Tejun Heo, phillip.wood, bugzilla-daemon, linux-ide,
Jeff Garzik
Hello
В Tue, 23 Oct 2012 18:12:16 +0200
Borislav Petkov wrote:
> @Tejun: so basically there are two people with oopses when using
> pata_acpi
Not two. We have two boxes in our office (about 20 boxes) and more then
ten reports from our users (only from early adopters yet). It seems
that this problem doesn't exists when someone build kernel for his own
box, but will be triggered very often when 3.6 will be wide used distro
kernel.
--
Regards
Anton
^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-23 10:17 ` Borislav Petkov
2012-10-23 16:12 ` Borislav Petkov
@ 2012-10-24 9:28 ` Phillip Wood
2012-10-24 10:57 ` Alan Cox
1 sibling, 1 reply; 70+ messages in thread
From: Phillip Wood @ 2012-10-24 9:28 UTC (permalink / raw)
To: Borislav Petkov
Cc: Alan Cox, phillip.wood, Anton V. Boyarshinov, bugzilla-daemon,
linux-ide, Jeff Garzik
On 10/23/2012 11:17 AM, Borislav Petkov wrote:
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..80d594d6e7c8 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> + if (!t) {
> + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> + __func__, adev->dma_mode);
> +
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
as well here if I build pata_acpi as a module, if I build it into the
kernel I don't get any message.
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-24 9:28 ` Phillip Wood
@ 2012-10-24 10:57 ` Alan Cox
2012-11-03 4:26 ` Borislav Petkov
0 siblings, 1 reply; 70+ messages in thread
From: Alan Cox @ 2012-10-24 10:57 UTC (permalink / raw)
To: phillip.wood
Cc: phillip.wood, Borislav Petkov, Anton V. Boyarshinov,
bugzilla-daemon, linux-ide, Jeff Garzik
On Wed, 24 Oct 2012 10:28:42 +0100
Phillip Wood <phillip.wood@talktalk.net> wrote:
> On 10/23/2012 11:17 AM, Borislav Petkov wrote:
> > ---
> > diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> > index 09723b76beac..80d594d6e7c8 100644
> > --- a/drivers/ata/pata_acpi.c
> > +++ b/drivers/ata/pata_acpi.c
> > @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> >
> > /* Now stuff the nS values into the structure */
> > t = ata_timing_find_mode(adev->dma_mode);
> > + if (!t) {
> > + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> > + __func__, adev->dma_mode);
> > +
> > + return;
> > + }
> > +
> > if (adev->dma_mode >= XFER_UDMA_0) {
> > acpi->gtm.drive[unit].dma = t->udma;
> > acpi->gtm.flags |= (1 << (2 * unit));
> > --
>
> pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
Which is an ATA layer bug - adev->dma_mode should never be called without
a DMA mode in normal use.
> as well here if I build pata_acpi as a module, if I build it into the
> kernel I don't get any message.
If you build the drivers into the kernel the link order ensures the
generic drivers execute last so the native driver will already have been
used. When loading modules it is expected that the distribution is smart
enough to get this right.
So the built in case is covering up the failure case because the code
never gets executed,
Alan
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-10-24 10:57 ` Alan Cox
@ 2012-11-03 4:26 ` Borislav Petkov
2012-11-03 16:30 ` Alan Cox
2012-11-03 16:48 ` Alan Cox
0 siblings, 2 replies; 70+ messages in thread
From: Borislav Petkov @ 2012-11-03 4:26 UTC (permalink / raw)
To: Alan Cox
Cc: phillip.wood, phillip.wood, Anton V. Boyarshinov,
bugzilla-daemon, linux-ide, Jeff Garzik
On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> Which is an ATA layer bug - adev->dma_mode should never be called
> without a DMA mode in normal use.
Ok, it looks like this would take a while to fix.
Alan, what is your suggestion for a proper fix, uncomment XFER_PIO_SLOW
and drop to it with a big warning that ACPI is giving botched
information on those chips and people should try using the
platform-specific driver if they want better/optimal speeds?
Thanks.
--
Regards/Gruss,
Boris.
^ permalink raw reply [flat|nested] 70+ messages in thread* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-11-03 4:26 ` Borislav Petkov
@ 2012-11-03 16:30 ` Alan Cox
2012-11-03 16:48 ` Alan Cox
1 sibling, 0 replies; 70+ messages in thread
From: Alan Cox @ 2012-11-03 16:30 UTC (permalink / raw)
To: Borislav Petkov
Cc: phillip.wood, phillip.wood, Anton V. Boyarshinov,
bugzilla-daemon, linux-ide, Jeff Garzik
On Sat, 3 Nov 2012 05:26:35 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> > Which is an ATA layer bug - adev->dma_mode should never be called
> > without a DMA mode in normal use.
>
> Ok, it looks like this would take a while to fix.
>
> Alan, what is your suggestion for a proper fix, uncomment XFER_PIO_SLOW
> and drop to it with a big warning that ACPI is giving botched
No. The proper fix is to find out how it got called with no DMA mode set.
There is no reason ACPI can't return pure PIO answers. If it does however
then the DMA mode setting call should not be made by the core libata
code. Lots of our ATA driver code relies upon that so if it's actually
what is happening that is what needs fixing.
Alan
^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-11-03 4:26 ` Borislav Petkov
2012-11-03 16:30 ` Alan Cox
@ 2012-11-03 16:48 ` Alan Cox
2012-11-16 4:50 ` Jeff Garzik
1 sibling, 1 reply; 70+ messages in thread
From: Alan Cox @ 2012-11-03 16:48 UTC (permalink / raw)
To: Borislav Petkov
Cc: phillip.wood, phillip.wood, Anton V. Boyarshinov,
bugzilla-daemon, linux-ide, Jeff Garzik
On Sat, 3 Nov 2012 05:26:35 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> > Which is an ATA layer bug - adev->dma_mode should never be called
> > without a DMA mode in normal use.
>
> Ok, it looks like this would take a while to fix.
So a 30 second glance says that the problem is that you seem to have
dma_mode uninitialised as zero which is bogus.
That means either ata_acpi_gtm_xfermask broke (it should have set the
bits to 0xFF if no mode is found), ata_dma_enabled is broken, or
pacpi_qc_issue got called before pacpi_port_start (which seems wildly
unlikely)
Needs someone to go and dump the relevant values in the right places and
see what is breaking in the pata_acpi setup logic.
Alan
^ permalink raw reply [flat|nested] 70+ messages in thread
* Re: [Bug 49151] New: NULL pointer dereference in pata_acpi
2012-11-03 16:48 ` Alan Cox
@ 2012-11-16 4:50 ` Jeff Garzik
0 siblings, 0 replies; 70+ messages in thread
From: Jeff Garzik @ 2012-11-16 4:50 UTC (permalink / raw)
To: Alan Cox
Cc: Borislav Petkov, phillip.wood, phillip.wood,
Anton V. Boyarshinov, bugzilla-daemon, linux-ide
On 11/03/2012 12:48 PM, Alan Cox wrote:
> On Sat, 3 Nov 2012 05:26:35 +0100
> Borislav Petkov <bp@alien8.de> wrote:
>
>> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
>>> Which is an ATA layer bug - adev->dma_mode should never be called
>>> without a DMA mode in normal use.
>>
>> Ok, it looks like this would take a while to fix.
>
> So a 30 second glance says that the problem is that you seem to have
> dma_mode uninitialised as zero which is bogus.
>
> That means either ata_acpi_gtm_xfermask broke (it should have set the
> bits to 0xFF if no mode is found), ata_dma_enabled is broken, or
> pacpi_qc_issue got called before pacpi_port_start (which seems wildly
> unlikely)
>
> Needs someone to go and dump the relevant values in the right places and
> see what is breaking in the pata_acpi setup logic.
Agreed -- though the WARN_ONCE() will at least give us trivially better
poops.
Jeff
^ permalink raw reply [flat|nested] 70+ messages in thread
* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (2 preceding siblings ...)
2012-10-20 12:00 ` [Bug 49151] New: " Borislav Petkov
@ 2012-10-20 12:00 ` bugzilla-daemon
2012-10-21 16:04 ` bugzilla-daemon
` (50 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-20 12:00 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #3 from Borislav Petkov <bp@alien8.de> 2012-10-20 12:00:52 ---
On Sat, Oct 20, 2012 at 10:19:22AM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=49151
>
> Summary: NULL pointer dereference in pata_acpi
> Product: IO/Storage
> Version: 2.5
> Kernel Version: 3.6.2
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: IDE
> AssignedTo: io_ide@kernel-bugs.osdl.org
> ReportedBy: phillip.wood@dunelm.org.uk
> Regression: No
>
>
> Just upgraded from 3.2.20 to 3.6.2 and when I try to boot a get
>
> BUG unable to handle kernel NULL pointer dereference at 00000010
> IP [<efe4c2407>] pacpi_set_dmamode+0x50/0xa0 [pata_acpi]
>
> and it wont find my hard disc. I'm using the standard arch linux kernel config
> available at
> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/config?h=packages/linux
>
> I've attached a couple of photos of the message and backtrace
Ok,
let's first switch to mail.
FWIW, there's another report of this
http://marc.info/?l=linux-ide&m=134995465614435&w=2
and it is on 64-bit while Phillip's is 32-bit. Adding Anton and a couple
more people to CC.
From Anton's disassembly I get:
Ä 2.703078Ü Code: 01 00 00 00 f6 43 10 10 74 0a 41 89 c7 43 8d 0c 3f 41 d3 e6
41 0f b6 bd e1 02 00 00 e8 ce 74 0f 00 41 80 bd e1 02 00 00 3f 77 44 <0f> b7 40
10 41 f7 d6 44 21 73 10 4d 63 ff 42 89 44 fb 04 48 89
All code
========
0: 01 00 add %eax,(%rax)
2: 00 00 add %al,(%rax)
4: f6 43 10 10 testb $0x10,0x10(%rbx)
8: 74 0a je 0x14
a: 41 89 c7 mov %eax,%r15d
d: 43 8d 0c 3f lea (%r15,%r15,1),%ecx
11: 41 d3 e6 shl %cl,%r14d
14: 41 0f b6 bd e1 02 00 movzbl 0x2e1(%r13),%edi
1b: 00
1c: e8 ce 74 0f 00 callq 0xf74ef
21: 41 80 bd e1 02 00 00 cmpb $0x3f,0x2e1(%r13)
28: 3f
29: 77 44 ja 0x6f
2b:* 0f b7 40 10 movzwl 0x10(%rax),%eax <-- trapping
instruction
2f: 41 f7 d6 not %r14d
32: 44 21 73 10 and %r14d,0x10(%rbx)
36: 4d 63 ff movslq %r15d,%r15
39: 42 89 44 fb 04 mov %eax,0x4(%rbx,%r15,8)
3e: 48 rex.W
3f: 89 .byte 0x89
And although I cannot generate the exact code here, building
drivers/ata/pata_acpi.c locally gives only one instruction like the
trapping one (thankfully, function is short enough):
sall %cl, %eax # tmp92, tmp93
orl %eax, 16(%rbx) # tmp93, acpi_6->gtm.flags
jmp .L30 #
.LVL46:
.L29:
.loc 1 151 0
movzwl 16(%rax), %eax # t_12->cycle, t_12->cycle <---
.LVL47:
.loc 1 152 0
leal (%r12,%r12), %ecx #, tmp97
which could mean that ata_timing_find_mode() might be returning NULL
on those systems (t is in %(r|e)ax in both oopses and the 0x10 offset
points to ata_timing->cycle).
So, Anton, Phillip, can you guys try the following debugging patch
to confirm (it is against mainline but should apply cleanly ontop of
3.6-stable):
---
diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index 09723b76beac..c5a54faecb98 100644
--- a/drivers/ata/pata_acpi.c
+++ b/drivers/ata/pata_acpi.c
@@ -144,6 +144,12 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct
ata_device *adev)
/* Now stuff the nS values into the structure */
t = ata_timing_find_mode(adev->dma_mode);
+
+ if (!t) {
+ WARN(1, "%s: ata_timing_find_mode gives NULL\n", __func__);
+ return;
+ }
+
if (adev->dma_mode >= XFER_UDMA_0) {
acpi->gtm.drive[unit].dma = t->udma;
acpi->gtm.flags |= (1 << (2 * unit));
--
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (3 preceding siblings ...)
2012-10-20 12:00 ` [Bug 49151] " bugzilla-daemon
@ 2012-10-21 16:04 ` bugzilla-daemon
2012-10-21 16:58 ` bugzilla-daemon
` (49 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-21 16:04 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #4 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org> 2012-10-21 16:04:17 ---
Reply-To: phillip.wood@talktalk.net
On 10/20/2012 01:00 PM, Borislav Petkov wrote:
> On Sat, Oct 20, 2012 at 10:19:22AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
>> https://bugzilla.kernel.org/show_bug.cgi?id=49151
>>
>> Summary: NULL pointer dereference in pata_acpi
>> Product: IO/Storage
>> Version: 2.5
>> Kernel Version: 3.6.2
>> Platform: All
>> OS/Version: Linux
>> Tree: Mainline
>> Status: NEW
>> Severity: normal
>> Priority: P1
>> Component: IDE
>> AssignedTo: io_ide@kernel-bugs.osdl.org
>> ReportedBy: phillip.wood@dunelm.org.uk
>> Regression: No
>>
>>
>> Just upgraded from 3.2.20 to 3.6.2 and when I try to boot a get
>>
>> BUG unable to handle kernel NULL pointer dereference at 00000010
>> IP [<efe4c2407>] pacpi_set_dmamode+0x50/0xa0 [pata_acpi]
>>
>> and it wont find my hard disc. I'm using the standard arch linux kernel config
>> available at
>> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/config?h=packages/linux
>>
>> I've attached a couple of photos of the message and backtrace
>
> Ok,
>
> let's first switch to mail.
>
> FWIW, there's another report of this
>
> http://marc.info/?l=linux-ide&m=134995465614435&w=2
>
> and it is on 64-bit while Phillip's is 32-bit. Adding Anton and a couple
> more people to CC.
>
> From Anton's disassembly I get:
>
> Ä 2.703078Ü Code: 01 00 00 00 f6 43 10 10 74 0a 41 89 c7 43 8d 0c 3f 41 d3 e6 41 0f b6 bd e1 02 00 00 e8 ce 74 0f 00 41 80 bd e1 02 00 00 3f 77 44 <0f> b7 40 10 41 f7 d6 44 21 73 10 4d 63 ff 42 89 44 fb 04 48 89
> All code
> ========
> 0: 01 00 add %eax,(%rax)
> 2: 00 00 add %al,(%rax)
> 4: f6 43 10 10 testb $0x10,0x10(%rbx)
> 8: 74 0a je 0x14
> a: 41 89 c7 mov %eax,%r15d
> d: 43 8d 0c 3f lea (%r15,%r15,1),%ecx
> 11: 41 d3 e6 shl %cl,%r14d
> 14: 41 0f b6 bd e1 02 00 movzbl 0x2e1(%r13),%edi
> 1b: 00
> 1c: e8 ce 74 0f 00 callq 0xf74ef
> 21: 41 80 bd e1 02 00 00 cmpb $0x3f,0x2e1(%r13)
> 28: 3f
> 29: 77 44 ja 0x6f
> 2b:* 0f b7 40 10 movzwl 0x10(%rax),%eax <-- trapping instruction
> 2f: 41 f7 d6 not %r14d
> 32: 44 21 73 10 and %r14d,0x10(%rbx)
> 36: 4d 63 ff movslq %r15d,%r15
> 39: 42 89 44 fb 04 mov %eax,0x4(%rbx,%r15,8)
> 3e: 48 rex.W
> 3f: 89 .byte 0x89
>
> And although I cannot generate the exact code here, building
> drivers/ata/pata_acpi.c locally gives only one instruction like the
> trapping one (thankfully, function is short enough):
>
> sall %cl, %eax # tmp92, tmp93
> orl %eax, 16(%rbx) # tmp93, acpi_6->gtm.flags
> jmp .L30 #
> .LVL46:
> .L29:
> .loc 1 151 0
> movzwl 16(%rax), %eax # t_12->cycle, t_12->cycle <---
> .LVL47:
> .loc 1 152 0
> leal (%r12,%r12), %ecx #, tmp97
>
> which could mean that ata_timing_find_mode() might be returning NULL
> on those systems (t is in %(r|e)ax in both oopses and the 0x10 offset
> points to ata_timing->cycle).
>
> So, Anton, Phillip, can you guys try the following debugging patch
> to confirm (it is against mainline but should apply cleanly ontop of
> 3.6-stable):
>
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..c5a54faecb98 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,12 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> +
> + if (!t) {
> + WARN(1, "%s: ata_timing_find_mode gives NULL\n", __func__);
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
>
> Thanks.
>
Hi Borislav
Thanks for responding to the bug report so quickly. I've applied your
patch and the kernel now finds my hard drive and the logs (pasted below)
have a couple of warnings generated by the patch. So if I've understood
correctly then your theory that ata_timing_find_mode() is returning NULL
is correct.
Thanks for looking into this, just let me know if you want me to do
anything else
Best Wishes
Phillip
[ 1.932509] ------------[ cut here ]------------
[ 1.932509] WARNING: at drivers/ata/pata_acpi.c:149
pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 1.932509] Hardware name: Portable PC
[ 1.932509] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 1.932509] Modules linked in: pata_acpi ata_generic
[ 1.932509] Pid: 857, comm: scsi_eh_0 Not tainted 3.6.0-1-custom #1
[ 1.932509] Call Trace:
[ 1.932509] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 1.932509] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 1.932509] [<ef77e375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 1.932509] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 1.932509] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 1.932509] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 1.932509] [<c127d2d0>] ? ata_release_transport+0x40/0x40
[ 1.932509] [<c1039145>] ? msleep+0x15/0x20
[ 1.932509] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 1.932509] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 1.932509] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 1.932509] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 1.932509] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 1.932509] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 1.932509] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 1.932509] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 1.932509] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 1.932509] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 1.932509] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 1.932509] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 1.932509] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 1.932509] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 1.932509] [<c104719c>] ? kthread+0x6c/0x80
[ 1.932509] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 1.932509] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 1.932509] ---[ end trace 7db6a26b2c0e9208 ]---
[ 2.106520] ------------[ cut here ]------------
[ 2.106520] WARNING: at drivers/ata/pata_acpi.c:149
pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]()
[ 2.106520] Hardware name: Portable PC
[ 2.106520] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 1.951725] ACPI: Invalid Power Resource to register!
[ 2.106520] Modules linked in: pata_acpi ata_generic
[ 2.106520] Pid: 863, comm: scsi_eh_1 Tainted: G W
3.6.0-1-custom #1
[ 2.106520] Call Trace:
[ 2.106520] [<c102cd28>] ? warn_slowpath_common+0x78/0xb0
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<c102cdf3>] ? warn_slowpath_fmt+0x33/0x40
[ 2.106520] [<ef77e2b7>] ? pacpi_set_dmamode+0xc7/0xe0 [pata_acpi]
[ 2.106520] [<ef77e375>] ? pacpi_qc_issue+0x45/0x64 [pata_acpi]
[ 2.106520] [<c126dfb2>] ? ata_qc_issue+0x152/0x320
[ 2.106520] [<c11cda30>] ? acpi_os_release_object+0x5/0x8
[ 2.106520] [<c10b0e7b>] ? __kmalloc+0x2b/0x130
[ 2.106520] [<c126e3c9>] ? ata_exec_internal_sg+0x249/0x510
[ 2.106520] [<c140d1bd>] ? schedule_timeout+0xed/0x170
[ 2.106520] [<c11eaa87>] ? acpi_ut_delete_internal_obj+0x162/0x172
[ 2.106520] [<c126e6f2>] ? ata_exec_internal+0x62/0xa0
[ 2.106520] [<c126e755>] ? ata_do_dev_read_id+0x25/0x30
[ 2.106520] [<c126ea35>] ? ata_dev_read_id+0x245/0x560
[ 2.106520] [<c127af72>] ? ata_eh_recover+0x762/0x1270
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127c490>] ? ata_do_eh+0x40/0xb0
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<ef77e180>] ? pacpi_port_start+0x80/0x80 [pata_acpi]
[ 2.106520] [<c127e210>] ? ata_sff_wait_after_reset+0x130/0x130
[ 2.106520] [<c127ec77>] ? ata_sff_error_handler+0xb7/0x120
[ 2.106520] [<c127dcb0>] ? ata_sff_drain_fifo+0x80/0x80
[ 2.106520] [<c127bfc5>] ? ata_scsi_port_error_handler+0x495/0x860
[ 2.106520] [<c127ece0>] ? ata_sff_error_handler+0x120/0x120
[ 2.106520] [<c127c413>] ? ata_scsi_error+0x83/0xc0
[ 2.106520] [<c125533c>] ? scsi_error_handler+0x8c/0x470
[ 2.106520] [<c104f6b4>] ? __wake_up_common+0x44/0x70
[ 2.106520] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.106520] [<c12552b0>] ? scsi_eh_get_sense+0xd0/0xd0
[ 2.106520] [<c104719c>] ? kthread+0x6c/0x80
[ 2.106520] [<c1047130>] ? kthread_freezable_should_stop+0x50/0x50
[ 2.106520] [<c140f8f6>] ? kernel_thread_helper+0x6/0xd
[ 2.106520] ---[ end trace 7db6a26b2c0e9209 ]---
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (4 preceding siblings ...)
2012-10-21 16:04 ` bugzilla-daemon
@ 2012-10-21 16:58 ` bugzilla-daemon
2012-10-22 12:15 ` bugzilla-daemon
` (48 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-21 16:58 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #5 from Borislav Petkov <bp@alien8.de> 2012-10-21 16:58:00 ---
On Sun, Oct 21, 2012 at 05:04:12PM +0100, Phillip Wood wrote:
> Thanks for responding to the bug report so quickly. I've applied your
> patch and the kernel now finds my hard drive and the logs (pasted
> below) have a couple of warnings generated by the patch. So if I've
> understood correctly then your theory that ata_timing_find_mode() is
> returning NULL is correct.
Yes, it appears so.
> Thanks for looking into this, just let me know if you want me to do
> anything else.
Right, so we know what exactly happens and I think we have the right
people on CC who can make sense of why it happens.
If I'd be to guess, this is most probably a BIOS bug (what else?! :-))
which the pata_acpi code is not ready to handle.
Btw, Jeff, AFAICT, libata code should the very least catch this
situation so that we know. Patch for this below. From a quick look there
a couple of drivers which do not check ata_timing_find_mode()'s retval
and I guess at least issuing a warning in such situations could be
helpful with future issues.
However, I don't know how chatty this warning could become and whether
this is the right approach and not auditing all users is better.
What you can do, Phillip, is check whether some other specific PATA
driver supports your hardware and enable it instead of PATA_ACPI. What
does lspci on the box say? Or rather 'lspci -v' for more details. You
can also send dmesg from the box.
Thanks.
--
From: Borislav Petkov <bp@alien8.de>
Date: Sun, 21 Oct 2012 18:49:08 +0200
Subject: [PATCH] libata: Warn when unable to find timing descriptor based on
xfer_mode
ata_timing_find_mode could return NULL which is not checked by all
low-level ATA drivers using it and cause a NULL ptr deref. Warn at least
so that possible issues can get fixed easily.
Signed-off-by: Borislav Petkov <bp@alien8.de>
---
drivers/ata/libata-core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 3cc7096cfda7..f46fbd3bd3fb 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2942,6 +2942,10 @@ const struct ata_timing *ata_timing_find_mode(u8
xfer_mode)
if (xfer_mode == t->mode)
return t;
+
+ WARN_ONCE(true, "%s: unable to find timing for xfer_mode 0x%x\n",
+ __func__, xfer_mode);
+
return NULL;
}
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (5 preceding siblings ...)
2012-10-21 16:58 ` bugzilla-daemon
@ 2012-10-22 12:15 ` bugzilla-daemon
2012-10-22 12:21 ` bugzilla-daemon
` (47 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 12:15 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Anton Boyarshinov <boyarsh@altlinux.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |boyarsh@altlinux.org
--- Comment #6 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-22 12:15:50 ---
Thank you for responce!
There is a log with both patches applied. System boots and works.
-------------------------
[ 1.108357] ata3: PATA max UDMA/133 cmd 0xf80 ctl 0xf00 bmdma 0xb800 irq 21
[ 1.108363] ata4: PATA max UDMA/133 cmd 0xe80 ctl 0xe00 bmdma 0xb808 irq 21
[ 1.264255] ------------[ cut here ]------------
[ 1.264303] WARNING: at drivers/ata/libata-core.c:2928
ata_timing_find_mode+0x6a/0x80 [libata]()
[ 1.264307] Hardware name: ATLANT \xffffffd52 4800/251
[ 1.264312] ata_timing_find_mode: unable to find timing for xfer_mode 0x0
[ 1.264315] Modules linked in: ahci libahci pata_acpi libata scsi_mod
[ 1.264332] Pid: 547, comm: scsi_eh_2 Not tainted 3.6.3-un-def-alt1 #1
[ 1.264336] Call Trace:
[ 1.264353] [<ffffffff81059b2a>] warn_slowpath_common+0x7a/0xb0
[ 1.264361] [<ffffffff81059c01>] warn_slowpath_fmt+0x41/0x50
[ 1.264380] [<ffffffffa0097b4a>] ata_timing_find_mode+0x6a/0x80 [libata]
[ 1.264391] [<ffffffffa0037282>] pacpi_set_dmamode+0x42/0xf0 [pata_acpi]
[ 1.264401] [<ffffffffa00373fa>] pacpi_qc_issue+0x5a/0x7c [pata_acpi]
[ 1.264421] [<ffffffffa00997af>] ata_qc_issue+0x1ff/0x370 [libata]
[ 1.264433] [<ffffffff81047e73>] ? default_spin_lock_flags+0x13/0x20
[ 1.264453] [<ffffffffa0099c61>] ata_exec_internal_sg+0x341/0x640 [libata]
[ 1.264475] [<ffffffffa00aaf27>] ? ata_sff_dev_classify+0x67/0x110 [libata]
[ 1.264494] [<ffffffffa0099fd4>] ata_exec_internal+0x74/0xb0 [libata]
[ 1.264514] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.264533] [<ffffffffa009a0b5>] ata_do_dev_read_id+0x25/0x30 [libata]
[ 1.264553] [<ffffffffa00a5d8c>] ? ata_eh_reset+0x24c/0xc80 [libata]
[ 1.264571] [<ffffffffa009a3e4>] ata_dev_read_id+0x324/0x5a0 [libata]
[ 1.264590] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.264599] [<ffffffff81047e73>] ? default_spin_lock_flags+0x13/0x20
[ 1.264619] [<ffffffffa00a7164>] ata_eh_recover+0x824/0x13e0 [libata]
[ 1.264629] [<ffffffff810993e1>] ? load_balance+0x611/0x8c0
[ 1.264649] [<ffffffffa00aae20>] ? ata_sff_drain_fifo+0x80/0x80 [libata]
[ 1.264668] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.264677] [<ffffffffa00371c0>] ? pacpi_port_start+0xa0/0xa0 [pata_acpi]
[ 1.264687] [<ffffffff814acf39>] ? _raw_spin_lock_irq+0x39/0x50
[ 1.264696] [<ffffffff810789cb>] ? wait_on_work+0x1fb/0x210
[ 1.264705] [<ffffffffa00371c0>] ? pacpi_port_start+0xa0/0xa0 [pata_acpi]
[ 1.264724] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.264744] [<ffffffffa00a869d>] ata_do_eh+0x4d/0xc0 [libata]
[ 1.264763] [<ffffffffa00aae20>] ? ata_sff_drain_fifo+0x80/0x80 [libata]
[ 1.264782] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.264802] [<ffffffffa00aabee>] ata_sff_error_handler+0xce/0x130 [libata]
[ 1.264821] [<ffffffffa00aacdf>] ata_bmdma_error_handler+0x8f/0x150
[libata]
[ 1.264841] [<ffffffffa00a82a9>] ata_scsi_port_error_handler+0x499/0x770
[libata]
[ 1.264861] [<ffffffffa00a8613>] ata_scsi_error+0x93/0xd0 [libata]
[ 1.264896] [<ffffffffa0007eba>] scsi_error_handler+0x12a/0x720 [scsi_mod]
[ 1.264915] [<ffffffffa0007d90>] ? scsi_eh_get_sense+0x210/0x210 [scsi_mod]
[ 1.264933] [<ffffffffa0007d90>] ? scsi_eh_get_sense+0x210/0x210 [scsi_mod]
[ 1.264940] [<ffffffff8107f386>] kthread+0x96/0xa0
[ 1.264950] [<ffffffff814b5804>] kernel_thread_helper+0x4/0x10
[ 1.264957] [<ffffffff8107f2f0>] ? kthread_freezable_should_stop+0x80/0x80
[ 1.264964] [<ffffffff814b5800>] ? gs_change+0x13/0x13
[ 1.264969] ---[ end trace a98d36ed22847d07 ]---
[ 1.264972] ------------[ cut here ]------------
[ 1.264980] WARNING: at drivers/ata/pata_acpi.c:149
pacpi_set_dmamode+0xdf/0xf0 [pata_acpi]()
[ 1.264983] Hardware name: ATLANT \xffffffd52 4800/251
[ 1.264987] pacpi_set_dmamode: ata_timing_find_mode gives NULL
[ 1.264989] Modules linked in: ahci libahci pata_acpi libata scsi_mod
[ 1.265002] Pid: 547, comm: scsi_eh_2 Tainted: G W
3.6.3-un-def-alt1 #1
[ 1.265005] Call Trace:
[ 1.265013] [<ffffffff81059b2a>] warn_slowpath_common+0x7a/0xb0
[ 1.265020] [<ffffffff81059c01>] warn_slowpath_fmt+0x41/0x50
[ 1.265030] [<ffffffffa003731f>] pacpi_set_dmamode+0xdf/0xf0 [pata_acpi]
[ 1.265038] [<ffffffffa00373fa>] pacpi_qc_issue+0x5a/0x7c [pata_acpi]
[ 1.265057] [<ffffffffa00997af>] ata_qc_issue+0x1ff/0x370 [libata]
[ 1.265065] [<ffffffff81047e73>] ? default_spin_lock_flags+0x13/0x20
[ 1.265084] [<ffffffffa0099c61>] ata_exec_internal_sg+0x341/0x640 [libata]
[ 1.265104] [<ffffffffa00aaf27>] ? ata_sff_dev_classify+0x67/0x110 [libata]
[ 1.265123] [<ffffffffa0099fd4>] ata_exec_internal+0x74/0xb0 [libata]
[ 1.265142] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.265161] [<ffffffffa009a0b5>] ata_do_dev_read_id+0x25/0x30 [libata]
[ 1.265180] [<ffffffffa00a5d8c>] ? ata_eh_reset+0x24c/0xc80 [libata]
[ 1.265198] [<ffffffffa009a3e4>] ata_dev_read_id+0x324/0x5a0 [libata]
[ 1.265217] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.265226] [<ffffffff81047e73>] ? default_spin_lock_flags+0x13/0x20
[ 1.265246] [<ffffffffa00a7164>] ata_eh_recover+0x824/0x13e0 [libata]
[ 1.265254] [<ffffffff810993e1>] ? load_balance+0x611/0x8c0
[ 1.265273] [<ffffffffa00aae20>] ? ata_sff_drain_fifo+0x80/0x80 [libata]
[ 1.265292] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.265301] [<ffffffffa00371c0>] ? pacpi_port_start+0xa0/0xa0 [pata_acpi]
[ 1.265308] [<ffffffff814acf39>] ? _raw_spin_lock_irq+0x39/0x50
[ 1.265315] [<ffffffff810789cb>] ? wait_on_work+0x1fb/0x210
[ 1.265324] [<ffffffffa00371c0>] ? pacpi_port_start+0xa0/0xa0 [pata_acpi]
[ 1.265343] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.265363] [<ffffffffa00a869d>] ata_do_eh+0x4d/0xc0 [libata]
[ 1.265382] [<ffffffffa00aae20>] ? ata_sff_drain_fifo+0x80/0x80 [libata]
[ 1.265401] [<ffffffffa00ab450>] ? ata_sff_wait_after_reset+0x140/0x140
[libata]
[ 1.265420] [<ffffffffa00aabee>] ata_sff_error_handler+0xce/0x130 [libata]
[ 1.265440] [<ffffffffa00aacdf>] ata_bmdma_error_handler+0x8f/0x150
[libata]
[ 1.265460] [<ffffffffa00a82a9>] ata_scsi_port_error_handler+0x499/0x770
[libata]
[ 1.265480] [<ffffffffa00a8613>] ata_scsi_error+0x93/0xd0 [libata]
[ 1.265499] [<ffffffffa0007eba>] scsi_error_handler+0x12a/0x720 [scsi_mod]
[ 1.265518] [<ffffffffa0007d90>] ? scsi_eh_get_sense+0x210/0x210 [scsi_mod]
[ 1.265535] [<ffffffffa0007d90>] ? scsi_eh_get_sense+0x210/0x210 [scsi_mod]
[ 1.265542] [<ffffffff8107f386>] kthread+0x96/0xa0
[ 1.265550] [<ffffffff814b5804>] kernel_thread_helper+0x4/0x10
[ 1.265558] [<ffffffff8107f2f0>] ? kthread_freezable_should_stop+0x80/0x80
[ 1.265565] [<ffffffff814b5800>] ? gs_change+0x13/0x13
[ 1.265568] ---[ end trace a98d36ed22847d08 ]---
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (6 preceding siblings ...)
2012-10-22 12:15 ` bugzilla-daemon
@ 2012-10-22 12:21 ` bugzilla-daemon
2012-10-22 12:42 ` bugzilla-daemon
` (46 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 12:21 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #7 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-22 12:21:55 ---
lspci -v from the box above
----------------
00:00.0 RAM memory: NVIDIA Corporation MCP65 Memory Controller (rev a3)
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] HyperTransport: Slave or Primary Interface
Capabilities: [dc] HyperTransport: MSI Mapping Enable+ Fixed-
00:01.0 ISA bridge: NVIDIA Corporation MCP65 LPC Bridge (rev a3)
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0
I/O ports at 2f00 [size=256]
00:01.1 SMBus: NVIDIA Corporation MCP65 SMBus (rev a1)
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: 66MHz, fast devsel, IRQ 11
I/O ports at 2900 [size=64]
I/O ports at 2d00 [size=64]
I/O ports at 2e00 [size=64]
Capabilities: [44] Power Management version 2
Kernel driver in use: nForce2_smbus
00:01.2 RAM memory: NVIDIA Corporation MCP65 Memory Controller (rev a1)
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: 66MHz, fast devsel
00:02.0 USB controller: NVIDIA Corporation MCP65 USB Controller (rev a3)
(prog-if 10 [OHCI])
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 23
Memory at f9eff000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Kernel driver in use: ohci_hcd
00:02.1 USB controller: NVIDIA Corporation MCP65 USB Controller (rev a3)
(prog-if 20 [EHCI])
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 22
Memory at f9efec00 (32-bit, non-prefetchable) [size=256]
Capabilities: [44] Debug port: BAR=1 offset=0098
Capabilities: [80] Power Management version 2
Kernel driver in use: ehci_hcd
00:08.0 PCI bridge: NVIDIA Corporation MCP65 PCI bridge (rev a1) (prog-if 01
[Subtractive decode])
Flags: bus master, 66MHz, fast devsel, latency 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=64
Capabilities: [b8] Subsystem: Micro-Star International Co., Ltd. Device
7369
Capabilities: [8c] HyperTransport: MSI Mapping Enable- Fixed-
00:09.0 IDE interface: NVIDIA Corporation MCP65 IDE (rev a1) (prog-if 8a
[Master SecP PriP])
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0
[virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 000003f0 (type 3, non-prefetchable)
[virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 00000370 (type 3, non-prefetchable)
I/O ports at ffa0 [size=16]
Capabilities: [44] Power Management version 2
Kernel driver in use: pata_acpi
00:0a.0 IDE interface: NVIDIA Corporation MCP65 SATA Controller (rev a3)
(prog-if 85 [Master SecO PriO])
Subsystem: Micro-Star International Co., Ltd. Device 7369
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 21
I/O ports at 0f80 [size=8]
I/O ports at 0f00 [size=4]
I/O ports at 0e80 [size=8]
I/O ports at 0e00 [size=4]
I/O ports at b800 [size=16]
Memory at f9efc000 (32-bit, non-prefetchable) [size=8K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/8 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable- Fixed+
Kernel driver in use: pata_acpi
00:0b.0 PCI bridge: NVIDIA Corporation Device 045b (rev a1) (prog-if 00 [Normal
decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:0c.0 PCI bridge: NVIDIA Corporation MCP65 PCI Express bridge (rev a1)
(prog-if 00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
I/O behind bridge: 0000d000-0000dfff
Memory behind bridge: f9f00000-f9ffffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:0d.0 PCI bridge: NVIDIA Corporation MCP65 PCI Express bridge (rev a1)
(prog-if 00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=04, subordinate=04, sec-latency=0
I/O behind bridge: 0000e000-0000efff
Memory behind bridge: fa000000-febfffff
Prefetchable memory behind bridge: 00000000d0000000-00000000dfffffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:0e.0 PCI bridge: NVIDIA Corporation MCP65 PCI Express bridge (rev a1)
(prog-if 00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=05, subordinate=05, sec-latency=0
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
Flags: fast devsel
Capabilities: [80] HyperTransport: Host or Secondary Interface
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address
Map
Flags: fast devsel
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM
Controller
Flags: fast devsel
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
Flags: fast devsel
Capabilities: [f0] Secure device <?>
Kernel driver in use: k8temp
03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168B PCI
Express Gigabit Ethernet controller (rev 01)
Subsystem: Micro-Star International Co., Ltd. Device 369c
Flags: bus master, fast devsel, latency 0, IRQ 44
I/O ports at d800 [size=256]
Memory at f9fff000 (64-bit, non-prefetchable) [size=4K]
Expansion ROM at f9fc0000 [disabled] [size=128K]
Capabilities: [40] Power Management version 2
Capabilities: [48] Vital Product Data
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] Express Endpoint, MSI 00
Capabilities: [84] Vendor Specific Information: Len=4c <?>
Capabilities: [100] Advanced Error Reporting
Capabilities: [12c] Virtual Channel
Capabilities: [148] Device Serial Number 1d-00-00-00-10-ec-81-68
Capabilities: [154] Power Budgeting <?>
Kernel driver in use: r8169
04:00.0 VGA compatible controller: NVIDIA Corporation G84 [GeForce 8600 GT]
(rev a1) (prog-if 00 [VGA controller])
Flags: bus master, fast devsel, latency 0, IRQ 18
Memory at fd000000 (32-bit, non-prefetchable) [size=16M]
Memory at d0000000 (64-bit, prefetchable) [size=256M]
Memory at fa000000 (64-bit, non-prefetchable) [size=32M]
I/O ports at ec00 [size=128]
Expansion ROM at febe0000 [disabled] [size=128K]
Capabilities: [60] Power Management version 2
Capabilities: [68] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [78] Express Endpoint, MSI 00
Capabilities: [100] Virtual Channel
Capabilities: [128] Power Budgeting <?>
Capabilities: [600] Vendor Specific Information: ID=0001 Rev=1 Len=024 <?>
Kernel driver in use: nouveau
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (7 preceding siblings ...)
2012-10-22 12:21 ` bugzilla-daemon
@ 2012-10-22 12:42 ` bugzilla-daemon
2012-10-22 15:48 ` bugzilla-daemon
` (45 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 12:42 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #8 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-22 12:42:35 ---
lspci -v from another box with the same problem and the same reaction on this
workaround.
---------------------------
00:00.0 RAM memory: NVIDIA Corporation C51 Host Bridge (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] HyperTransport: Slave or Primary Interface
Capabilities: [e0] HyperTransport: MSI Mapping Enable+ Fixed-
00:00.1 RAM memory: NVIDIA Corporation C51 Memory Controller 0 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:00.2 RAM memory: NVIDIA Corporation C51 Memory Controller 1 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:00.3 RAM memory: NVIDIA Corporation C51 Memory Controller 5 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:00.4 RAM memory: NVIDIA Corporation C51 Memory Controller 4 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
00:00.5 RAM memory: NVIDIA Corporation C51 Host Bridge (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] #00 [00fe]
Capabilities: [fc] #00 [0000]
00:00.6 RAM memory: NVIDIA Corporation C51 Memory Controller 3 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:00.7 RAM memory: NVIDIA Corporation C51 Memory Controller 2 (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:02.0 PCI bridge: NVIDIA Corporation C51 PCI Express Bridge (rev a1) (prog-if
00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
I/O behind bridge: 0000a000-0000afff
Memory behind bridge: fdd00000-fddfffff
Prefetchable memory behind bridge: 00000000fda00000-00000000fdafffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:03.0 PCI bridge: NVIDIA Corporation C51 PCI Express Bridge (rev a1) (prog-if
00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
I/O behind bridge: 00008000-00008fff
Memory behind bridge: fd900000-fd9fffff
Prefetchable memory behind bridge: 00000000fde00000-00000000fdefffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:04.0 PCI bridge: NVIDIA Corporation C51 PCI Express Bridge (rev a1) (prog-if
00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
I/O behind bridge: 0000b000-0000bfff
Memory behind bridge: fa000000-fcffffff
Prefetchable memory behind bridge: 00000000e0000000-00000000efffffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:09.0 RAM memory: NVIDIA Corporation MCP51 Host Bridge (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] HyperTransport: Slave or Primary Interface
Capabilities: [e0] HyperTransport: MSI Mapping Enable- Fixed-
00:0a.0 ISA bridge: NVIDIA Corporation MCP51 LPC Bridge (rev a3)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
00:0a.1 SMBus: NVIDIA Corporation MCP51 SMBus (rev a3)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel, IRQ 5
I/O ports at 4c00 [size=64]
I/O ports at 4c40 [size=64]
Capabilities: [44] Power Management version 2
Kernel driver in use: nForce2_smbus
00:0a.2 RAM memory: NVIDIA Corporation MCP51 Memory Controller 0 (rev a3)
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: 66MHz, fast devsel
00:0b.0 USB controller: NVIDIA Corporation MCP51 USB Controller (rev a3)
(prog-if 10 [OHCI])
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 23
Memory at fe02f000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Kernel driver in use: ohci_hcd
00:0b.1 USB controller: NVIDIA Corporation MCP51 USB Controller (rev a3)
(prog-if 20 [EHCI])
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 22
Memory at fe02e000 (32-bit, non-prefetchable) [size=256]
Capabilities: [44] Debug port: BAR=1 offset=0098
Capabilities: [80] Power Management version 2
Kernel driver in use: ehci_hcd
00:0d.0 IDE interface: NVIDIA Corporation MCP51 IDE (rev a1) (prog-if 8a
[Master SecP PriP])
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0
[virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 000003f0 (type 3, non-prefetchable)
[virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 00000370 (type 3, non-prefetchable)
I/O ports at f400 [size=16]
Capabilities: [44] Power Management version 2
Kernel driver in use: pata_acpi
00:0e.0 IDE interface: NVIDIA Corporation MCP51 Serial ATA Controller (rev a1)
(prog-if 85 [Master SecO PriO])
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 21
I/O ports at 09f0 [size=8]
I/O ports at 0bf0 [size=4]
I/O ports at 0970 [size=8]
I/O ports at 0b70 [size=4]
I/O ports at e000 [size=16]
Memory at fe02d000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/4 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: pata_acpi
00:0f.0 IDE interface: NVIDIA Corporation MCP51 Serial ATA Controller (rev a1)
(prog-if 85 [Master SecO PriO])
Subsystem: ASUSTeK Computer Inc. Device 81c0
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 20
I/O ports at 09e0 [size=8]
I/O ports at 0be0 [size=4]
I/O ports at 0960 [size=8]
I/O ports at 0b60 [size=4]
I/O ports at cc00 [size=16]
Memory at fe02c000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/4 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: pata_acpi
00:10.0 PCI bridge: NVIDIA Corporation MCP51 PCI Bridge (rev a2) (prog-if 01
[Subtractive decode])
Flags: bus master, 66MHz, fast devsel, latency 0
Bus: primary=00, secondary=04, subordinate=04, sec-latency=128
I/O behind bridge: 00009000-00009fff
Memory behind bridge: fdc00000-fdcfffff
Prefetchable memory behind bridge: fdb00000-fdbfffff
Capabilities: [b8] Subsystem: Gammagraphx, Inc. (or missing ID) Device 0000
Capabilities: [8c] HyperTransport: MSI Mapping Enable+ Fixed-
00:10.1 Audio device: NVIDIA Corporation MCP51 High Definition Audio (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81cb
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 22
Memory at fe024000 (32-bit, non-prefetchable) [size=16K]
Capabilities: [44] Power Management version 2
Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
Capabilities: [6c] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: snd_hda_intel
00:14.0 Bridge: NVIDIA Corporation MCP51 Ethernet Controller (rev a3)
Subsystem: ASUSTeK Computer Inc. Device 816a
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 23
Memory at fe02b000 (32-bit, non-prefetchable) [size=4K]
I/O ports at c800 [size=8]
Capabilities: [44] Power Management version 2
Kernel driver in use: forcedeth
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
Flags: fast devsel
Capabilities: [80] HyperTransport: Host or Secondary Interface
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address
Map
Flags: fast devsel
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM
Controller
Flags: fast devsel
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
Flags: fast devsel
Capabilities: [f0] Secure device <?>
03:00.0 VGA compatible controller: NVIDIA Corporation G73 [GeForce 7600 GS]
(rev a1) (prog-if 00 [VGA controller])
Subsystem: Giga-byte Technology Device 341a
Flags: bus master, fast devsel, latency 0, IRQ 5
Memory at fa000000 (32-bit, non-prefetchable) [size=16M]
Memory at e0000000 (64-bit, prefetchable) [size=256M]
Memory at fb000000 (64-bit, non-prefetchable) [size=16M]
I/O ports at bc00 [size=128]
Expansion ROM at fcfe0000 [disabled] [size=128K]
Capabilities: [60] Power Management version 2
Capabilities: [68] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [78] Express Endpoint, MSI 00
Capabilities: [100] Virtual Channel
Capabilities: [128] Power Budgeting <?>
04:05.0 FireWire (IEEE 1394): Texas Instruments TSB43AB22A IEEE-1394a-2000
Controller (PHY/Link) [iOHCI-Lynx] (prog-if 10 [OHCI])
Subsystem: ASUSTeK Computer Inc. K8N4-E Mainboard
Flags: bus master, medium devsel, latency 32, IRQ 19
Memory at fdcff000 (32-bit, non-prefetchable) [size=2K]
Memory at fdcf8000 (32-bit, non-prefetchable) [size=16K]
Capabilities: [44] Power Management version 2
Kernel driver in use: firewire_ohci
04:09.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ (rev 10)
Subsystem: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+
Flags: bus master, medium devsel, latency 32, IRQ 17
I/O ports at 9c00 [size=256]
Memory at fdcfe000 (32-bit, non-prefetchable) [size=256]
Expansion ROM at fdce0000 [disabled] [size=64K]
Capabilities: [50] Power Management version 2
Kernel driver in use: 8139too
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (8 preceding siblings ...)
2012-10-22 12:42 ` bugzilla-daemon
@ 2012-10-22 15:48 ` bugzilla-daemon
2012-10-22 20:27 ` bugzilla-daemon
` (44 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 15:48 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #9 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org> 2012-10-22 15:47:59 ---
Reply-To: phillip.wood@talktalk.net
On 10/21/2012 05:57 PM, Borislav Petkov wrote:
>
> What you can do, Phillip, is check whether some other specific PATA
> driver supports your hardware and enable it instead of PATA_ACPI. What
> does lspci on the box say? Or rather 'lspci -v' for more details. You
> can also send dmesg from the box.
>
lspci -v gives
00:00.0 Host bridge: ULi Electronics Inc. M1644/M1644T
Northbridge+Trident (rev 01)
Flags: bus master, medium devsel, latency 0
Memory at f0000000 (32-bit, prefetchable) [size=64M]
Capabilities: [b0] AGP version 2.0
Capabilities: [a4] Power Management version 1
Kernel driver in use: agpgart-ali
00:01.0 PCI bridge: ULi Electronics Inc. PCI to AGP Controller (prog-if
00 [Normal decode])
Flags: bus master, slow devsel, latency 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
Memory behind bridge: f7f00000-fdffffff
Prefetchable memory behind bridge: 30100000-301fffff
00:02.0 USB controller: ULi Electronics Inc. USB 1.1 Controller (rev 03)
(prog-if 10 [OHCI])
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 64, IRQ 11
Memory at f7eff000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [60] Power Management version 2
Kernel driver in use: ohci_hcd
00:04.0 IDE interface: ULi Electronics Inc. M5229 IDE (rev c3) (prog-if f0)
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 64, IRQ 255
[virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 000003f0 (type 3, non-prefetchable)
[virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 00000370 (type 3, non-prefetchable)
I/O ports at eff0 [size=16]
Capabilities: [60] Power Management version 2
Kernel driver in use: pata_ali
00:06.0 Multimedia audio controller: ULi Electronics Inc. M5451 PCI
AC-Link Controller Audio Device (rev 01)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, medium devsel, latency 64, IRQ 11
I/O ports at 1000 [size=256]
Memory at 30001000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [dc] Power Management version 2
Kernel driver in use: snd_ali5451
00:07.0 ISA bridge: ULi Electronics Inc. M1533/M1535/M1543 PCI to ISA
Bridge [Aladdin IV/V/V+]
Subsystem: Toshiba America Info Systems Device 0004
Flags: bus master, medium devsel, latency 0
Capabilities: [a0] Power Management version 1
00:08.0 Bridge: ULi Electronics Inc. M7101 Power Management Controller [PMU]
Subsystem: Toshiba America Info Systems Device 0001
Flags: medium devsel
Kernel driver in use: ali1535_smbus
00:0a.0 Ethernet controller: Intel Corporation 82557/8/9/0/1 Ethernet
Pro 100 (rev 0d)
Subsystem: Toshiba America Info Systems 8255x-based Ethernet Adapter
(10/100)
Flags: bus master, medium devsel, latency 64, IRQ 11
Memory at f7efe000 (32-bit, non-prefetchable) [size=4K]
I/O ports at eec0 [size=64]
Memory at f7ec0000 (32-bit, non-prefetchable) [size=128K]
Capabilities: [dc] Power Management version 2
Kernel driver in use: e100
00:11.0 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to
Cardbus Bridge with ZV Support (rev 32)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, slow devsel, latency 168, IRQ 11
Memory at 30000000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=00, secondary=02, subordinate=05, sec-latency=0
Memory window 0: 34000000-37ffffff (prefetchable)
Memory window 1: 38000000-3bffffff
I/O window 0: 00001400-000014ff
I/O window 1: 00001800-000018ff
16-bit legacy interface ports at 0001
Kernel driver in use: yenta_cardbus
00:11.1 CardBus bridge: Toshiba America Info Systems ToPIC100 PCI to
Cardbus Bridge with ZV Support (rev 32)
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, slow devsel, latency 168, IRQ 11
Memory at 3c000000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=00, secondary=06, subordinate=09, sec-latency=0
Memory window 0: 40000000-43ffffff (prefetchable)
Memory window 1: 44000000-47ffffff
I/O window 0: 00001c00-00001cff
I/O window 1: 00002000-000020ff
16-bit legacy interface ports at 0001
Kernel driver in use: yenta_cardbus
00:12.0 System peripheral: Toshiba America Info Systems SD TypA
Controller (rev 03)
Subsystem: Toshiba America Info Systems Device 0001
Flags: medium devsel, IRQ 255
Memory at 30002000 (32-bit, non-prefetchable) [disabled] [size=512]
Capabilities: [80] Power Management version 2
01:00.0 VGA compatible controller: Trident Microsystems CyberBlade XPAi1
(rev 82) (prog-if 00 [VGA controller])
Subsystem: Toshiba America Info Systems Device 0001
Flags: bus master, 66MHz, medium devsel, latency 8, IRQ 11
Memory at fc000000 (32-bit, non-prefetchable) [size=32M]
Memory at fbc00000 (32-bit, non-prefetchable) [size=4M]
Memory at f8000000 (32-bit, non-prefetchable) [size=32M]
Memory at f7ff8000 (32-bit, non-prefetchable) [size=32K]
[virtual] Expansion ROM at 30100000 [disabled] [size=64K]
Capabilities: [80] AGP version 2.0
Capabilities: [90] Power Management version 2
06:00.0 Network controller: Broadcom Corporation BCM4306 802.11b/g
Wireless LAN Controller (rev 03)
Subsystem: Belkin F5D7011 v1000 High-Speed Mode Wireless G Notebook Card
Flags: bus master, fast devsel, latency 64, IRQ 11
Memory at 44000000 (32-bit, non-prefetchable) [size=8K]
Kernel driver in use: b43-pci-bridge
If I blacklist pata_acpi and remove it from the initrd image then my
unpatched distro kernel boots and seems to run fine (I've not checked if
the hard drive power management is affected though). I've attached the
dmesg from the patched kernel which was built with a minimal config.
Best Wishes
Phillip
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (9 preceding siblings ...)
2012-10-22 15:48 ` bugzilla-daemon
@ 2012-10-22 20:27 ` bugzilla-daemon
2012-10-22 20:40 ` bugzilla-daemon
` (43 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 20:27 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #10 from Borislav Petkov <bp@alien8.de> 2012-10-22 20:27:37 ---
On Mon, Oct 22, 2012 at 04:47:52PM +0100, Phillip Wood wrote:
> 00:04.0 IDE interface: ULi Electronics Inc. M5229 IDE (rev c3) (prog-if f0)
> Subsystem: Toshiba America Info Systems Device 0004
> Flags: bus master, medium devsel, latency 64, IRQ 255
> [virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 000003f0 (type 3, non-prefetchable)
> [virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 00000370 (type 3, non-prefetchable)
> I/O ports at eff0 [size=16]
> Capabilities: [60] Power Management version 2
> Kernel driver in use: pata_ali
Ok, your IDE interface is supported by pata_ali...
[ … ]
> If I blacklist pata_acpi and remove it from the initrd image then my
> unpatched distro kernel boots and seems to run fine (I've not checked
> if the hard drive power management is affected though). I've attached
> the dmesg from the patched kernel which was built with a minimal
> config.
Right, as it looks above, pata_ali should be able to support your IDE
interface, so you might not be needing the pata_acpi thing after all.
So yes, blacklisting it and verifying that your system still operates
normally would be something to do. If it does, you could also build a
kernel with pata_acpi disabled (that is, provided you build your own
kernels).
HTH.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (10 preceding siblings ...)
2012-10-22 20:27 ` bugzilla-daemon
@ 2012-10-22 20:40 ` bugzilla-daemon
2012-10-22 21:06 ` bugzilla-daemon
` (42 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 20:40 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Borislav Petkov <bp@alien8.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bp@alien8.de
--- Comment #11 from Borislav Petkov <bp@alien8.de> 2012-10-22 20:40:44 ---
(In reply to comment #7)
[ … ]
> 00:09.0 IDE interface: NVIDIA Corporation MCP65 IDE (rev a1) (prog-if 8a
> [Master SecP PriP])
> Subsystem: Micro-Star International Co., Ltd. Device 7369
> Flags: bus master, 66MHz, fast devsel, latency 0
> [virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 000003f0 (type 3, non-prefetchable)
> [virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
> [virtual] Memory at 00000370 (type 3, non-prefetchable)
> I/O ports at ffa0 [size=16]
> Capabilities: [44] Power Management version 2
> Kernel driver in use: pata_acpi
>
> 00:0a.0 IDE interface: NVIDIA Corporation MCP65 SATA Controller (rev a3)
> (prog-if 85 [Master SecO PriO])
> Subsystem: Micro-Star International Co., Ltd. Device 7369
> Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 21
> I/O ports at 0f80 [size=8]
> I/O ports at 0f00 [size=4]
> I/O ports at 0e80 [size=8]
> I/O ports at 0e00 [size=4]
> I/O ports at b800 [size=16]
> Memory at f9efc000 (32-bit, non-prefetchable) [size=8K]
> Capabilities: [44] Power Management version 2
> Capabilities: [b0] MSI: Enable- Count=1/8 Maskable- 64bit+
> Capabilities: [cc] HyperTransport: MSI Mapping Enable- Fixed+
> Kernel driver in use: pata_acpi
can you try blacklisting pata_acpi and booting the box then (provided
this is a distro kernel and it has all sata drivers as modules and in
the initrd - basically what Phillip did).
From the looks of it, yours should be supported by sata_nv so that you
don't need to use pata_acpi at all.
All IMHO, of course.
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (11 preceding siblings ...)
2012-10-22 20:40 ` bugzilla-daemon
@ 2012-10-22 21:06 ` bugzilla-daemon
2012-10-23 10:01 ` bugzilla-daemon
` (41 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-22 21:06 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #12 from Borislav Petkov <bp@alien8.de> 2012-10-22 21:06:26 ---
... and pata_amd should be supporting your IDE interface.
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (12 preceding siblings ...)
2012-10-22 21:06 ` bugzilla-daemon
@ 2012-10-23 10:01 ` bugzilla-daemon
2012-10-23 10:17 ` bugzilla-daemon
` (40 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 10:01 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #13 from Alan <alan@lxorguk.ukuu.org.uk> 2012-10-23 10:01:07 ---
> So yes, blacklisting it and verifying that your system still operates
> normally would be something to do. If it does, you could also build a
> kernel with pata_acpi disabled (that is, provided you build your own
> kernels).
The crash is still a bug. It needs chasing down.
Alan
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (13 preceding siblings ...)
2012-10-23 10:01 ` bugzilla-daemon
@ 2012-10-23 10:17 ` bugzilla-daemon
2012-10-23 11:02 ` bugzilla-daemon
` (39 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 10:17 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #14 from Borislav Petkov <bp@alien8.de> 2012-10-23 10:17:54 ---
On Tue, Oct 23, 2012 at 11:05:49AM +0100, Alan Cox wrote:
> > So yes, blacklisting it and verifying that your system still operates
> > normally would be something to do. If it does, you could also build a
> > kernel with pata_acpi disabled (that is, provided you build your own
> > kernels).
>
> The crash is still a bug. It needs chasing down.
Yes, ata_timing_find_mode gives NULL, we found that out.
Anton, Phillip, anyone willing to run this hunk below and get us the
output:
---
diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index 09723b76beac..80d594d6e7c8 100644
--- a/drivers/ata/pata_acpi.c
+++ b/drivers/ata/pata_acpi.c
@@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct
ata_device *adev)
/* Now stuff the nS values into the structure */
t = ata_timing_find_mode(adev->dma_mode);
+ if (!t) {
+ pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
+ __func__, adev->dma_mode);
+
+ return;
+ }
+
if (adev->dma_mode >= XFER_UDMA_0) {
acpi->gtm.drive[unit].dma = t->udma;
acpi->gtm.flags |= (1 << (2 * unit));
--
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (14 preceding siblings ...)
2012-10-23 10:17 ` bugzilla-daemon
@ 2012-10-23 11:02 ` bugzilla-daemon
2012-10-23 12:54 ` bugzilla-daemon
` (38 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 11:02 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #15 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-23 11:02:33 ---
> can you try blacklisting pata_acpi and booting the box then (provided
> this is a distro kernel and it has all sata drivers as modules and in
> the initrd - basically what Phillip did).
In this configuration it works (and using pata_amd on second box), but it is
not a good solution for distro kernel. And especially for distro installer
kernel wich should support as more hardware as it possible.
> From the looks of it, yours should be supported by sata_nv so that you
> don't need to use pata_acpi at all.
It seems that more special modules should be loaded before pata_acpi, but it
loads first.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (15 preceding siblings ...)
2012-10-23 11:02 ` bugzilla-daemon
@ 2012-10-23 12:54 ` bugzilla-daemon
2012-10-23 16:12 ` bugzilla-daemon
` (37 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 12:54 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #16 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-23 12:54:17 ---
> + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> + __func__, adev->dma_mode);
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (16 preceding siblings ...)
2012-10-23 12:54 ` bugzilla-daemon
@ 2012-10-23 16:12 ` bugzilla-daemon
2012-10-23 16:39 ` bugzilla-daemon
` (36 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 16:12 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #17 from Borislav Petkov <bp@alien8.de> 2012-10-23 16:12:18 ---
On Tue, Oct 23, 2012 at 12:17:51PM +0200, Borislav Petkov wrote:
> On Tue, Oct 23, 2012 at 11:05:49AM +0100, Alan Cox wrote:
> > > So yes, blacklisting it and verifying that your system still operates
> > > normally would be something to do. If it does, you could also build a
> > > kernel with pata_acpi disabled (that is, provided you build your own
> > > kernels).
> >
> > The crash is still a bug. It needs chasing down.
>
> Yes, ata_timing_find_mode gives NULL, we found that out.
>
> Anton, Phillip, anyone willing to run this hunk below and get us the
> output:
>
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..80d594d6e7c8 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> + if (!t) {
> + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> + __func__, adev->dma_mode);
> +
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
Ok, here's the output from Anton's box
(https://bugzilla.kernel.org/show_bug.cgi?id=49151#c16):
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
And in that case we should've matched XFER_PIO_SLOW but it is commented
out for some reason.
Judging by 70cd071e4ecc06c985189665af75c108601fd5a3, I think we should
involve Tejun into this.
@Tejun: so basically there are two people with oopses when using
pata_acpi because pacpi_set_dmamode queries xfer mode with
adev->dma_mode = 0x0 and ata_timing_find_mode returns NULL (presumably a
BIOS bug, I'd say).
More details if you follow the thread here:
http://marc.info/?l=linux-ide&m=135073445731432
I don't know how to fix this since if BIOS gives xfer_mode 0, how can
each pata controller find its max mode? Sure, we can always fall back to
0x0 but that is the slowest and not necessarily optimal.
One other possibility could be to load chipset-specific drivers first
and pata_acpi only as a last resort but I don't know whether this is
doable at all.
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (17 preceding siblings ...)
2012-10-23 16:12 ` bugzilla-daemon
@ 2012-10-23 16:39 ` bugzilla-daemon
2012-10-23 20:11 ` bugzilla-daemon
` (35 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 16:39 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Szymon Janc <szymon@janc.net.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |szymon@janc.net.pl
--- Comment #18 from Szymon Janc <szymon@janc.net.pl> 2012-10-23 16:39:42 ---
Hi,
I see this crash on pc with ASUS A8N-E board (about half of boot attempts).
But only if both pata_acpi and pata_amd are loaded... I've disabled pata_amd
and I'm not able to reproduce this (tried 10 reboots) if only pata_acpi is
used.
BR
Szymon
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (18 preceding siblings ...)
2012-10-23 16:39 ` bugzilla-daemon
@ 2012-10-23 20:11 ` bugzilla-daemon
2012-10-23 20:41 ` bugzilla-daemon
` (34 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 20:11 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #19 from Borislav Petkov <bp@alien8.de> 2012-10-23 20:11:07 ---
(In reply to comment #18)
> Hi,
>
> I see this crash on pc with ASUS A8N-E board (about half of boot attempts).
>
> But only if both pata_acpi and pata_amd are loaded... I've disabled pata_amd
> and I'm not able to reproduce this (tried 10 reboots) if only pata_acpi is
> used.
Can you catch the oops and upload it, a readable photo from a digicam
suffices too, as long as the oops is complete.
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (19 preceding siblings ...)
2012-10-23 20:11 ` bugzilla-daemon
@ 2012-10-23 20:41 ` bugzilla-daemon
2012-10-23 20:52 ` bugzilla-daemon
` (33 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 20:41 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #20 from Szymon Janc <szymon@janc.net.pl> 2012-10-23 20:41:38 ---
Created an attachment (id=84521)
--> (https://bugzilla.kernel.org/attachment.cgi?id=84521)
crash on A8N-E
not scaled image (~2MiB) available at http://janc.net.pl/DSC_1062.jpg
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (20 preceding siblings ...)
2012-10-23 20:41 ` bugzilla-daemon
@ 2012-10-23 20:52 ` bugzilla-daemon
2012-10-23 21:10 ` bugzilla-daemon
` (32 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 20:52 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #21 from Borislav Petkov <bp@alien8.de> 2012-10-23 20:52:57 ---
Ok, looks like the same issue. You could try the debugging patch in comment #14
but I'll go ahead and guess that it'll say
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
on your system too.
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (21 preceding siblings ...)
2012-10-23 20:52 ` bugzilla-daemon
@ 2012-10-23 21:10 ` bugzilla-daemon
2012-10-24 6:43 ` bugzilla-daemon
` (31 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-23 21:10 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #22 from Szymon Janc <szymon@janc.net.pl> 2012-10-23 21:10:25 ---
sure, i'll put info when build is finished.
btw: I forgot to mention that I don't have any pata drives in that pc.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (22 preceding siblings ...)
2012-10-23 21:10 ` bugzilla-daemon
@ 2012-10-24 6:43 ` bugzilla-daemon
2012-10-24 9:28 ` bugzilla-daemon
` (30 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-24 6:43 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #23 from Anton Boyarshinov <boyarsh@altlinux.org> 2012-10-24 06:43:10 ---
Hello
В Tue, 23 Oct 2012 18:12:16 +0200
Borislav Petkov wrote:
> @Tejun: so basically there are two people with oopses when using
> pata_acpi
Not two. We have two boxes in our office (about 20 boxes) and more then
ten reports from our users (only from early adopters yet). It seems
that this problem doesn't exists when someone build kernel for his own
box, but will be triggered very often when 3.6 will be wide used distro
kernel.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (23 preceding siblings ...)
2012-10-24 6:43 ` bugzilla-daemon
@ 2012-10-24 9:28 ` bugzilla-daemon
2012-10-24 10:52 ` bugzilla-daemon
` (29 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-24 9:28 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #24 from Anonymous Emailer <anonymous@kernel-bugs.osdl.org> 2012-10-24 09:28:47 ---
Reply-To: phillip.wood@talktalk.net
On 10/23/2012 11:17 AM, Borislav Petkov wrote:
> ---
> diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> index 09723b76beac..80d594d6e7c8 100644
> --- a/drivers/ata/pata_acpi.c
> +++ b/drivers/ata/pata_acpi.c
> @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
>
> /* Now stuff the nS values into the structure */
> t = ata_timing_find_mode(adev->dma_mode);
> + if (!t) {
> + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> + __func__, adev->dma_mode);
> +
> + return;
> + }
> +
> if (adev->dma_mode >= XFER_UDMA_0) {
> acpi->gtm.drive[unit].dma = t->udma;
> acpi->gtm.flags |= (1 << (2 * unit));
> --
pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
as well here if I build pata_acpi as a module, if I build it into the
kernel I don't get any message.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (24 preceding siblings ...)
2012-10-24 9:28 ` bugzilla-daemon
@ 2012-10-24 10:52 ` bugzilla-daemon
2012-10-24 15:25 ` bugzilla-daemon
` (28 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-24 10:52 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #25 from Alan <alan@lxorguk.ukuu.org.uk> 2012-10-24 10:52:56 ---
On Wed, 24 Oct 2012 10:28:42 +0100
Phillip Wood <phillip.wood@talktalk.net> wrote:
> On 10/23/2012 11:17 AM, Borislav Petkov wrote:
> > ---
> > diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
> > index 09723b76beac..80d594d6e7c8 100644
> > --- a/drivers/ata/pata_acpi.c
> > +++ b/drivers/ata/pata_acpi.c
> > @@ -144,6 +144,13 @@ static void pacpi_set_dmamode(struct ata_port *ap, struct ata_device *adev)
> >
> > /* Now stuff the nS values into the structure */
> > t = ata_timing_find_mode(adev->dma_mode);
> > + if (!t) {
> > + pr_err("%s: ata_timing_find_mode gives NULL; adev->dma_mode: 0x%x\n",
> > + __func__, adev->dma_mode);
> > +
> > + return;
> > + }
> > +
> > if (adev->dma_mode >= XFER_UDMA_0) {
> > acpi->gtm.drive[unit].dma = t->udma;
> > acpi->gtm.flags |= (1 << (2 * unit));
> > --
>
> pacpi_set_dmamode: ata_timing_find_mode gives NULL; adev->dma_mode: 0x0
Which is an ATA layer bug - adev->dma_mode should never be called without
a DMA mode in normal use.
> as well here if I build pata_acpi as a module, if I build it into the
> kernel I don't get any message.
If you build the drivers into the kernel the link order ensures the
generic drivers execute last so the native driver will already have been
used. When loading modules it is expected that the distribution is smart
enough to get this right.
So the built in case is covering up the failure case because the code
never gets executed,
Alan
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (25 preceding siblings ...)
2012-10-24 10:52 ` bugzilla-daemon
@ 2012-10-24 15:25 ` bugzilla-daemon
2012-10-25 14:31 ` bugzilla-daemon
` (27 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-24 15:25 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #26 from Szymon Janc <szymon@janc.net.pl> 2012-10-24 15:25:34 ---
just to confirm..
[ 5.004024] pacpi_set_dmamode: ata_timing_find_mode gives NULL;
adev->dma_mode: 0x0
[ 5.770251] pacpi_set_dmamode: ata_timing_find_mode gives NULL;
adev->dma_mode: 0x0
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (26 preceding siblings ...)
2012-10-24 15:25 ` bugzilla-daemon
@ 2012-10-25 14:31 ` bugzilla-daemon
2012-10-29 13:15 ` bugzilla-daemon
` (26 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-25 14:31 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Marius Cirsta <mforce2@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mforce2@gmail.com
--- Comment #27 from Marius Cirsta <mforce2@gmail.com> 2012-10-25 14:31:16 ---
I'm also getting this with the 3.6 kernel, it's comming from initrd which
seems to be using dracut.
Here's the lspci -v:
lspci -v
00:00.0 Host bridge: Intel Corporation 82Q35 Express DRAM Controller (rev 02)
Subsystem: Lenovo Device 3037
Flags: bus master, fast devsel, latency 0
Capabilities: [e0] Vendor Specific Information <?>
Kernel driver in use: agpgart-intel
Kernel modules: intel-agp
00:02.0 VGA compatible controller: Intel Corporation 82Q35 Express Integrated
Graphics Controller (rev 02) (prog-if 00 [VGA controller])
Subsystem: Lenovo Device 3037
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at d4400000 (32-bit, non-prefetchable) [size=512K]
I/O ports at 1c70 [size=8]
Memory at c0000000 (32-bit, prefetchable) [size=256M]
Memory at d4300000 (32-bit, non-prefetchable) [size=1M]
Capabilities: [90] Message Signalled Interrupts: Mask- 64bit- Count=1/1
Enable-
Capabilities: [d0] Power Management version 2
00:02.1 Display controller: Intel Corporation 82Q35 Express Integrated Graphics
Controller (rev 02)
Subsystem: Lenovo Device 3037
Flags: fast devsel
Memory at d4500000 (32-bit, non-prefetchable) [disabled] [size=512K]
Capabilities: [d0] Power Management version 2
00:03.0 Communication controller: Intel Corporation 82Q35 Express MEI
Controller (rev 02)
Subsystem: Lenovo Device 3037
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at d46a6000 (64-bit, non-prefetchable) [size=16]
Capabilities: [50] Power Management version 3
Capabilities: [8c] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable-
Kernel driver in use: heci
Kernel modules: heci
00:03.2 IDE interface: Intel Corporation 82Q35 Express PT IDER Controller (rev
02) (prog-if 85 [Master SecO PriO])
Subsystem: Lenovo Device 3037
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 5
I/O ports at 1c88 [disabled] [size=8]
I/O ports at 1c7c [disabled] [size=4]
I/O ports at 1c80 [disabled] [size=8]
I/O ports at 1c78 [disabled] [size=4]
I/O ports at 1c20 [disabled] [size=16]
Capabilities: [c8] Power Management version 3
Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable-
Kernel modules: ide-pci-generic, ata_generic, pata_acpi
00:03.3 Serial controller: Intel Corporation 82Q35 Express Serial KT Controller
(rev 02) (prog-if 02 [16550])
Subsystem: Lenovo Device 3037
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 17
I/O ports at 1c90 [size=8]
Memory at d44a4000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [c8] Power Management version 3
Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable-
Kernel driver in use: serial
00:19.0 Ethernet controller: Intel Corporation 82566DM-2 Gigabit Network
Connection (rev 02)
Subsystem: Lenovo Device 3037
Flags: bus master, fast devsel, latency 0, IRQ 4351
Memory at d4480000 (32-bit, non-prefetchable) [size=128K]
Memory at d44a5000 (32-bit, non-prefetchable) [size=4K]
I/O ports at 1820 [size=32]
Capabilities: [c8] Power Management version 2
Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable+
Capabilities: [e0] PCIe advanced features <?>
Kernel driver in use: e1000e
Kernel modules: e1000e
00:1a.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #4 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 16
I/O ports at 1840 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1a.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #5 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 17
I/O ports at 1860 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1a.2 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #6 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 18
I/O ports at 1880 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1a.7 USB Controller: Intel Corporation 82801I (ICH9 Family) USB2 EHCI
Controller #2 (rev 02) (prog-if 20 [EHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 18
Memory at d46a6800 (32-bit, non-prefetchable) [size=1K]
Capabilities: [50] Power Management version 2
Capabilities: [58] Debug port: BAR=1 offset=00a0
Capabilities: [98] PCIe advanced features <?>
Kernel driver in use: ehci_hcd
Kernel modules: ehci-hcd
00:1b.0 Audio device: Intel Corporation 82801I (ICH9 Family) HD Audio
Controller (rev 02)
Subsystem: Lenovo Device 3037
Flags: bus master, fast devsel, latency 0, IRQ 3
Memory at d44a0000 (64-bit, non-prefetchable) [size=16K]
Capabilities: [50] Power Management version 2
Capabilities: [60] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable-
Capabilities: [70] Express Root Complex Integrated Endpoint, MSI 00
Capabilities: [100] Virtual Channel <?>
Capabilities: [130] Root Complex Link <?>
Kernel modules: snd-hda-intel
00:1d.0 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #1 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 16
I/O ports at 18a0 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1d.1 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #2 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 17
I/O ports at 18c0 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1d.2 USB Controller: Intel Corporation 82801I (ICH9 Family) USB UHCI
Controller #3 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 18
I/O ports at 18e0 [size=32]
Capabilities: [50] PCIe advanced features <?>
Kernel driver in use: uhci_hcd
Kernel modules: uhci-hcd
00:1d.7 USB Controller: Intel Corporation 82801I (ICH9 Family) USB2 EHCI
Controller #1 (rev 02) (prog-if 20 [EHCI])
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0, IRQ 16
Memory at d46a6c00 (32-bit, non-prefetchable) [size=1K]
Capabilities: [50] Power Management version 2
Capabilities: [58] Debug port: BAR=1 offset=00a0
Capabilities: [98] PCIe advanced features <?>
Kernel driver in use: ehci_hcd
Kernel modules: ehci-hcd
00:1e.0 PCI bridge: Intel Corporation 82801 PCI Bridge (rev 92) (prog-if 01
[Subtractive decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=11, subordinate=11, sec-latency=32
I/O behind bridge: 00002000-00002fff
Memory behind bridge: d0000000-d42fffff
Capabilities: [50] Subsystem: Lenovo Device 3037
00:1f.0 ISA bridge: Intel Corporation 82801IO (ICH9DO) LPC Interface Controller
(rev 02)
Subsystem: Lenovo Device 3037
Flags: bus master, medium devsel, latency 0
Capabilities: [e0] Vendor Specific Information <?>
Kernel modules: iTCO_wdt
00:1f.2 IDE interface: Intel Corporation 82801IR/IO/IH (ICH9R/DO/DH) 4 port
SATA IDE Controller (rev 02) (prog-if 8a [Master SecP PriP])
Subsystem: Lenovo Device 3037
Flags: bus master, 66MHz, medium devsel, latency 0, IRQ 17
I/O ports at 01f0 [size=8]
I/O ports at 03f4 [size=1]
I/O ports at 0170 [size=8]
I/O ports at 0374 [size=1]
I/O ports at 1c40 [size=16]
I/O ports at 1c30 [size=16]
Capabilities: [70] Power Management version 3
Capabilities: [b0] PCIe advanced features <?>
Kernel driver in use: ata_piix
Kernel modules: ide-pci-generic, ata_generic, pata_acpi, ata_piix
00:1f.3 SMBus: Intel Corporation 82801I (ICH9 Family) SMBus Controller (rev 02)
Subsystem: Lenovo Device 3037
Flags: medium devsel, IRQ 17
Memory at d46a7000 (64-bit, non-prefetchable) [size=256]
I/O ports at 1c00 [size=32]
Kernel driver in use: i801_smbus
Kernel modules: i2c-i801
00:1f.5 IDE interface: Intel Corporation 82801I (ICH9 Family) 2 port SATA IDE
Controller (rev 02) (prog-if 85 [Master SecO PriO])
Subsystem: Lenovo Device 3037
Flags: bus master, 66MHz, medium devsel, latency 0, IRQ 18
I/O ports at 1cc0 [size=8]
I/O ports at 1cb4 [size=4]
I/O ports at 1cb8 [size=8]
I/O ports at 1cb0 [size=4]
I/O ports at 1c60 [size=16]
I/O ports at 1c50 [size=16]
Capabilities: [70] Power Management version 3
Capabilities: [b0] PCIe advanced features <?>
Kernel driver in use: ata_piix
Kernel modules: ide-pci-generic, ata_generic, pata_acpi, ata_piix
11:0a.0 Audio device: Creative Labs SB X-Fi
Subsystem: Creative Labs Device 6007
Flags: bus master, medium devsel, latency 32, IRQ 22
Memory at d4200000 (32-bit, non-prefetchable) [size=16K]
Memory at d4000000 (64-bit, non-prefetchable) [size=2M]
Memory at d0000000 (64-bit, non-prefetchable) [size=64M]
I/O ports at 2000 [size=32]
Capabilities: [40] Power Management version 2
Capabilities: [50] Message Signalled Interrupts: Mask- 64bit+ Count=1/1
Enable-
Kernel driver in use: CTALSA
Kernel modules: ctxfi
The machine is an Intel based one as you can see. Happens on every boot.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (27 preceding siblings ...)
2012-10-25 14:31 ` bugzilla-daemon
@ 2012-10-29 13:15 ` bugzilla-daemon
2012-10-29 13:36 ` bugzilla-daemon
` (25 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-29 13:15 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
cthx <sntmail@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sntmail@gmail.com
--- Comment #28 from cthx <sntmail@gmail.com> 2012-10-29 13:15:31 ---
I have this crash at asus M2N32-SLI-Deluxe mainboard (kernel 3.6.2, 3.6.3)
lspci -v
00:00.0 RAM memory: NVIDIA Corporation C51 Host Bridge (rev a2)
Subsystem: NVIDIA Corporation C51 Host Bridge
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] HyperTransport: Slave or Primary Interface
Capabilities: [e0] HyperTransport: MSI Mapping Enable+ Fixed-
00:00.1 RAM memory: NVIDIA Corporation C51 Memory Controller 0 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 0
Flags: 66MHz, fast devsel
00:00.2 RAM memory: NVIDIA Corporation C51 Memory Controller 1 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 1
Flags: 66MHz, fast devsel
00:00.3 RAM memory: NVIDIA Corporation C51 Memory Controller 5 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 5
Flags: 66MHz, fast devsel
00:00.4 RAM memory: NVIDIA Corporation C51 Memory Controller 4 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 4
Flags: bus master, 66MHz, fast devsel, latency 0
00:00.5 RAM memory: NVIDIA Corporation C51 Host Bridge (rev a2)
Subsystem: NVIDIA Corporation C51 Host Bridge
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] #00 [0000]
00:00.6 RAM memory: NVIDIA Corporation C51 Memory Controller 3 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 3
Flags: 66MHz, fast devsel
00:00.7 RAM memory: NVIDIA Corporation C51 Memory Controller 2 (rev a2)
Subsystem: NVIDIA Corporation C51 Memory Controller 2
Flags: 66MHz, fast devsel
00:04.0 PCI bridge: NVIDIA Corporation C51 PCI Express Bridge (rev a1) (prog-if
00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=01, subordinate=01, sec-latency=0
I/O behind bridge: 0000a000-0000afff
Memory behind bridge: fa000000-fcffffff
Prefetchable memory behind bridge: 00000000e0000000-00000000efffffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable- Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:08.0 RAM memory: NVIDIA Corporation MCP55 Memory Controller (rev a1)
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0
Capabilities: [44] HyperTransport: Slave or Primary Interface
Capabilities: [e0] #00 [fee0]
00:09.0 ISA bridge: NVIDIA Corporation MCP55 LPC Bridge (rev a2)
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0
00:09.1 SMBus: NVIDIA Corporation MCP55 SMBus (rev a2)
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: 66MHz, fast devsel, IRQ 5
I/O ports at 1c00 [size=64]
I/O ports at 1c40 [size=64]
Capabilities: [44] Power Management version 2
Kernel driver in use: nForce2_smbus
00:0a.0 USB controller: NVIDIA Corporation MCP55 USB Controller (rev a1)
(prog-if 10 [OHCI])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 23
Memory at fe02f000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Kernel driver in use: ohci_hcd
00:0a.1 USB controller: NVIDIA Corporation MCP55 USB Controller (rev a2)
(prog-if 20 [EHCI])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 22
Memory at fe02e000 (32-bit, non-prefetchable) [size=256]
Capabilities: [44] Debug port: BAR=1 offset=0098
Capabilities: [80] Power Management version 2
Kernel driver in use: ehci_hcd
00:0c.0 IDE interface: NVIDIA Corporation MCP55 IDE (rev a1) (prog-if 8a
[Master SecP PriP])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0
[virtual] Memory at 000001f0 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 000003f0 (type 3, non-prefetchable)
[virtual] Memory at 00000170 (32-bit, non-prefetchable) [size=8]
[virtual] Memory at 00000370 (type 3, non-prefetchable)
I/O ports at f400 [size=16]
Capabilities: [44] Power Management version 2
Kernel driver in use: pata_amd
00:0d.0 IDE interface: NVIDIA Corporation MCP55 SATA Controller (rev a2)
(prog-if 85 [Master SecO PriO])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 21
I/O ports at 09f0 [size=8]
I/O ports at 0bf0 [size=4]
I/O ports at 0970 [size=8]
I/O ports at 0b70 [size=4]
I/O ports at e000 [size=16]
Memory at fe02d000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/4 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: sata_nv
00:0d.1 IDE interface: NVIDIA Corporation MCP55 SATA Controller (rev a2)
(prog-if 85 [Master SecO PriO])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 20
I/O ports at 09e0 [size=8]
I/O ports at 0be0 [size=4]
I/O ports at 0960 [size=8]
I/O ports at 0b60 [size=4]
I/O ports at cc00 [size=16]
Memory at fe02c000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/4 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: sata_nv
00:0d.2 IDE interface: NVIDIA Corporation MCP55 SATA Controller (rev a2)
(prog-if 85 [Master SecO PriO])
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 23
I/O ports at c800 [size=8]
I/O ports at c400 [size=4]
I/O ports at c000 [size=8]
I/O ports at bc00 [size=4]
I/O ports at b800 [size=16]
Memory at fe02b000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [44] Power Management version 2
Capabilities: [b0] MSI: Enable- Count=1/4 Maskable- 64bit+
Capabilities: [cc] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: sata_nv
00:0e.0 PCI bridge: NVIDIA Corporation MCP55 PCI bridge (rev a2) (prog-if 01
[Subtractive decode])
Flags: bus master, 66MHz, fast devsel, latency 0
Bus: primary=00, secondary=02, subordinate=02, sec-latency=32
Memory behind bridge: fdf00000-fdffffff
Capabilities: [b8] Subsystem: NVIDIA Corporation Device cb84
Capabilities: [8c] HyperTransport: MSI Mapping Enable+ Fixed-
00:0e.1 Audio device: NVIDIA Corporation MCP55 High Definition Audio (rev a2)
Subsystem: ASUSTeK Computer Inc. Device 81f6
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 20
Memory at fe020000 (32-bit, non-prefetchable) [size=16K]
Capabilities: [44] Power Management version 2
Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
Capabilities: [6c] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: snd_hda_intel
00:10.0 Bridge: NVIDIA Corporation MCP55 Ethernet (rev a2)
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 42
Memory at fe02a000 (32-bit, non-prefetchable) [size=4K]
I/O ports at b400 [size=8]
Memory at fe029000 (32-bit, non-prefetchable) [size=256]
Memory at fe028000 (32-bit, non-prefetchable) [size=16]
Capabilities: [44] Power Management version 2
Capabilities: [70] MSI-X: Enable- Count=8 Masked-
Capabilities: [50] MSI: Enable+ Count=1/8 Maskable+ 64bit+
Capabilities: [6c] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: forcedeth
00:11.0 Bridge: NVIDIA Corporation MCP55 Ethernet (rev a2)
Subsystem: ASUSTeK Computer Inc. Device cb84
Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 21
Memory at fe027000 (32-bit, non-prefetchable) [size=4K]
I/O ports at b000 [size=8]
Memory at fe026000 (32-bit, non-prefetchable) [size=256]
Memory at fe025000 (32-bit, non-prefetchable) [size=16]
Capabilities: [44] Power Management version 2
Capabilities: [70] MSI-X: Enable- Count=8 Masked-
Capabilities: [50] MSI: Enable- Count=1/8 Maskable+ 64bit+
Capabilities: [6c] HyperTransport: MSI Mapping Enable+ Fixed+
Kernel driver in use: forcedeth
00:16.0 PCI bridge: NVIDIA Corporation MCP55 PCI Express bridge (rev a2)
(prog-if 00 [Normal decode])
Flags: bus master, fast devsel, latency 0
Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
I/O behind bridge: 00009000-00009fff
Memory behind bridge: fde00000-fdefffff
Capabilities: [40] Subsystem: NVIDIA Corporation Device 0000
Capabilities: [48] Power Management version 2
Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
Capabilities: [60] HyperTransport: MSI Mapping Enable+ Fixed-
Capabilities: [80] Express Root Port (Slot+), MSI 00
Capabilities: [100] Virtual Channel
Kernel driver in use: pcieport
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
HyperTransport Technology Configuration
Flags: fast devsel
Capabilities: [80] HyperTransport: Host or Secondary Interface
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address
Map
Flags: fast devsel
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM
Controller
Flags: fast devsel
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron]
Miscellaneous Control
Flags: fast devsel
Capabilities: [f0] Secure device <?>
Kernel driver in use: k8temp
01:00.0 VGA compatible controller: NVIDIA Corporation G71 [GeForce 7900 GS]
(rev a1) (prog-if 00 [VGA controller])
Subsystem: eVga.com. Corp. Device e624
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at fa000000 (32-bit, non-prefetchable) [size=16M]
Memory at e0000000 (64-bit, prefetchable) [size=256M]
Memory at fb000000 (64-bit, non-prefetchable) [size=16M]
I/O ports at ac00 [size=128]
[virtual] Expansion ROM at fcfe0000 [disabled] [size=128K]
Capabilities: [60] Power Management version 2
Capabilities: [68] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [78] Express Endpoint, MSI 00
Capabilities: [100] Virtual Channel
Capabilities: [128] Power Budgeting <?>
Kernel driver in use: nvidia
02:0b.0 FireWire (IEEE 1394): Texas Instruments TSB43AB22A IEEE-1394a-2000
Controller (PHY/Link) [iOHCI-Lynx] (prog-if 10 [OHCI])
Subsystem: ASUSTeK Computer Inc. P5W DH Deluxe Motherboard
Flags: bus master, medium devsel, latency 32, IRQ 16
Memory at fdfff000 (32-bit, non-prefetchable) [size=2K]
Memory at fdff8000 (32-bit, non-prefetchable) [size=16K]
Capabilities: [44] Power Management version 2
Kernel driver in use: firewire_ohci
03:00.0 Mass storage controller: Silicon Image, Inc. SiI 3132 Serial ATA Raid
II Controller (rev 01)
Subsystem: ASUSTeK Computer Inc. Device 819f
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at fdeff000 (64-bit, non-prefetchable) [size=128]
Memory at fdef8000 (64-bit, non-prefetchable) [size=16K]
I/O ports at 9c00 [size=128]
Expansion ROM at fde00000 [disabled] [size=512K]
Capabilities: [54] Power Management version 2
Capabilities: [5c] MSI: Enable- Count=1/1 Maskable- 64bit+
Capabilities: [70] Express Legacy Endpoint, MSI 00
Capabilities: [100] Advanced Error Reporting
Kernel driver in use: sata_sil24
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (28 preceding siblings ...)
2012-10-29 13:15 ` bugzilla-daemon
@ 2012-10-29 13:36 ` bugzilla-daemon
2012-11-01 15:18 ` bugzilla-daemon
` (24 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-10-29 13:36 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #29 from cthx <sntmail@gmail.com> 2012-10-29 13:36:13 ---
Created an attachment (id=85211)
--> (https://bugzilla.kernel.org/attachment.cgi?id=85211)
crash on asus m2n32_sli_deluxe
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (29 preceding siblings ...)
2012-10-29 13:36 ` bugzilla-daemon
@ 2012-11-01 15:18 ` bugzilla-daemon
2012-11-02 12:07 ` bugzilla-daemon
` (23 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-01 15:18 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #30 from Roland Bogner <geist1@sms.at> 2012-11-01 15:18:29 ---
crash on 3.7 rc-3 too.
Asus M2N32-SLI
Last working kernel was 3-5.x
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (30 preceding siblings ...)
2012-11-01 15:18 ` bugzilla-daemon
@ 2012-11-02 12:07 ` bugzilla-daemon
2012-11-03 4:23 ` bugzilla-daemon
` (22 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-02 12:07 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #31 from Roland Bogner <geist1@sms.at> 2012-11-02 12:07:37 ---
Re-Compiled ubuntu mainline kernel without enabling "ATA-ACPI Support" then i
was able to boot the kernel without the freeze.
Unfortunaly none IDE HDD's works then.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (31 preceding siblings ...)
2012-11-02 12:07 ` bugzilla-daemon
@ 2012-11-03 4:23 ` bugzilla-daemon
2012-11-03 4:26 ` bugzilla-daemon
` (21 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-03 4:23 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #32 from Borislav Petkov <bp@alien8.de> 2012-11-03 04:23:21 ---
You could try enabling the platform-specific pata driver for your system and
don't compile pata_acpi at all. Until libata folks fix this properly, that
is...
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (32 preceding siblings ...)
2012-11-03 4:23 ` bugzilla-daemon
@ 2012-11-03 4:26 ` bugzilla-daemon
2012-11-03 7:37 ` bugzilla-daemon
` (20 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-03 4:26 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #33 from Borislav Petkov <bp@alien8.de> 2012-11-03 04:26:39 ---
On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> Which is an ATA layer bug - adev->dma_mode should never be called
> without a DMA mode in normal use.
Ok, it looks like this would take a while to fix.
Alan, what is your suggestion for a proper fix, uncomment XFER_PIO_SLOW
and drop to it with a big warning that ACPI is giving botched
information on those chips and people should try using the
platform-specific driver if they want better/optimal speeds?
Thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (33 preceding siblings ...)
2012-11-03 4:26 ` bugzilla-daemon
@ 2012-11-03 7:37 ` bugzilla-daemon
2012-11-03 16:25 ` bugzilla-daemon
` (19 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-03 7:37 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #34 from Roland Bogner <geist1@sms.at> 2012-11-03 07:37:04 ---
(In reply to comment #32)
> You could try enabling the platform-specific pata driver for your system and
> don't compile pata_acpi at all. Until libata folks fix this properly, that
> is...
>
> Thanks.
well for me it is not a big problem without IDE, since my system runs completly
on SATA and this still works fine with the kernel.
Unfortunatly distribution dudes will have big problems when they release the
kernel for the masses, they can't just disable IDE support at all.
Why this problems appeaers now in the kernel, previous ones worked pretty fine.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (34 preceding siblings ...)
2012-11-03 7:37 ` bugzilla-daemon
@ 2012-11-03 16:25 ` bugzilla-daemon
2012-11-03 16:43 ` bugzilla-daemon
` (18 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-03 16:25 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #35 from Alan <alan@lxorguk.ukuu.org.uk> 2012-11-03 16:25:43 ---
On Sat, 3 Nov 2012 05:26:35 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> > Which is an ATA layer bug - adev->dma_mode should never be called
> > without a DMA mode in normal use.
>
> Ok, it looks like this would take a while to fix.
>
> Alan, what is your suggestion for a proper fix, uncomment XFER_PIO_SLOW
> and drop to it with a big warning that ACPI is giving botched
No. The proper fix is to find out how it got called with no DMA mode set.
There is no reason ACPI can't return pure PIO answers. If it does however
then the DMA mode setting call should not be made by the core libata
code. Lots of our ATA driver code relies upon that so if it's actually
what is happening that is what needs fixing.
Alan
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (35 preceding siblings ...)
2012-11-03 16:25 ` bugzilla-daemon
@ 2012-11-03 16:43 ` bugzilla-daemon
2012-11-15 18:05 ` bugzilla-daemon
` (17 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-03 16:43 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #36 from Alan <alan@lxorguk.ukuu.org.uk> 2012-11-03 16:43:14 ---
On Sat, 3 Nov 2012 05:26:35 +0100
Borislav Petkov <bp@alien8.de> wrote:
> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
> > Which is an ATA layer bug - adev->dma_mode should never be called
> > without a DMA mode in normal use.
>
> Ok, it looks like this would take a while to fix.
So a 30 second glance says that the problem is that you seem to have
dma_mode uninitialised as zero which is bogus.
That means either ata_acpi_gtm_xfermask broke (it should have set the
bits to 0xFF if no mode is found), ata_dma_enabled is broken, or
pacpi_qc_issue got called before pacpi_port_start (which seems wildly
unlikely)
Needs someone to go and dump the relevant values in the right places and
see what is breaking in the pata_acpi setup logic.
Alan
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (36 preceding siblings ...)
2012-11-03 16:43 ` bugzilla-daemon
@ 2012-11-15 18:05 ` bugzilla-daemon
2012-11-15 18:07 ` bugzilla-daemon
` (16 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-15 18:05 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #37 from Szymon Janc <szymon@janc.net.pl> 2012-11-15 18:05:10 ---
Hi,
I did some bisecting (10 successful boots == good) and got this:
30dcf76acc695cbd2fa919e294670fe9552e16e7 is the first bad commit
commit 30dcf76acc695cbd2fa919e294670fe9552e16e7
Author: Matthew Garrett <mjg@redhat.com>
Date: Mon Jun 25 16:13:04 2012 +0800
libata: migrate ACPI code over to new bindings
Now that we have the ability to directly glue the ACPI namespace to the
driver model in libata, we don't need the custom code to handle the same
thing. Remove it and migrate the functions over to the new code.
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Holger Macht <holger@homac.de>^[
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
I've also added some prints:
pacpi_port_start is called before pacpi_qc_issue but ata_do_set_mode is called
after pacpi_qc_issue.. that seems not right, right?
Hope this will help someone familiar with that code..
I'll upload full dmesg as well.
--
BR
Szymon Janc
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (37 preceding siblings ...)
2012-11-15 18:05 ` bugzilla-daemon
@ 2012-11-15 18:07 ` bugzilla-daemon
2012-11-16 4:50 ` bugzilla-daemon
` (15 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-15 18:07 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #38 from Szymon Janc <szymon@janc.net.pl> 2012-11-15 18:07:31 ---
Created an attachment (id=86441)
--> (https://bugzilla.kernel.org/attachment.cgi?id=86441)
dmesg
dmesg on A8N-E with some extra prints
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (38 preceding siblings ...)
2012-11-15 18:07 ` bugzilla-daemon
@ 2012-11-16 4:50 ` bugzilla-daemon
2012-11-16 4:59 ` bugzilla-daemon
` (14 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-16 4:50 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #39 from Jeff Garzik <jgarzik@pobox.com> 2012-11-16 04:50:43 ---
On 11/03/2012 12:48 PM, Alan Cox wrote:
> On Sat, 3 Nov 2012 05:26:35 +0100
> Borislav Petkov <bp@alien8.de> wrote:
>
>> On Wed, Oct 24, 2012 at 11:57:46AM +0100, Alan Cox wrote:
>>> Which is an ATA layer bug - adev->dma_mode should never be called
>>> without a DMA mode in normal use.
>>
>> Ok, it looks like this would take a while to fix.
>
> So a 30 second glance says that the problem is that you seem to have
> dma_mode uninitialised as zero which is bogus.
>
> That means either ata_acpi_gtm_xfermask broke (it should have set the
> bits to 0xFF if no mode is found), ata_dma_enabled is broken, or
> pacpi_qc_issue got called before pacpi_port_start (which seems wildly
> unlikely)
>
> Needs someone to go and dump the relevant values in the right places and
> see what is breaking in the pata_acpi setup logic.
Agreed -- though the WARN_ONCE() will at least give us trivially better
poops.
Jeff
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (39 preceding siblings ...)
2012-11-16 4:50 ` bugzilla-daemon
@ 2012-11-16 4:59 ` bugzilla-daemon
2012-11-16 8:39 ` bugzilla-daemon
` (13 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-16 4:59 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Jeff Garzik <jgarzik@pobox.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |aaron.lu@intel.com,
| |jgarzik@pobox.com
--- Comment #40 from Jeff Garzik <jgarzik@pobox.com> 2012-11-16 04:59:50 ---
@Szymon Janc: useful bisection, thanks!
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (40 preceding siblings ...)
2012-11-16 4:59 ` bugzilla-daemon
@ 2012-11-16 8:39 ` bugzilla-daemon
2012-11-17 16:29 ` bugzilla-daemon
` (12 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-16 8:39 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #41 from Aaron Lu <aaron.lu@intel.com> 2012-11-16 08:39:33 ---
The problem I see is:
During init time, identify command needs to be sent;
pacpi_qc_issue is invoked, and if the chipset can not set timing independently
for each drive, and the qc is not for the current drive, dma mode will be set
for the target device if ata_dma_enabled returns true;
At this time, ata_device->dma_mode is still un-initialized as 0, but
ata_dma_enabled would treat this as valid, and the ata_timing table doesn't
handle mode 0, so we get NULL. This problem only occurs when processing
identify command.
So I think we should init ata_device->dma_mode to 0xff when we are to reset the
drive, and the real value will get set in ata_set_mode afterwards. This way,
when pacpi_qc_issue is invoked, it will not attempt to set dma mode for the
device.
And for Szymon's bisect, I think the 'offending' commit actually fixed a
problem of pata_acpi(maybe a long standing problem). And due to this fix,
pata_acpi module triggered this bug.
In previous kernels(pre the 'offending' commit Szymon bisected), the
acpi_port_start function will always fail due to ap->acpi_handle is NULL, the
reason is showed in the following call sequence:
ata_host_start
ap->ops->port_start -> pacpi_port_start -> where ap->acpi_handle is used
ata_host_register
ata_associate_acpi -> where the ap->acpi_handle is assigned
So in previous kernels, pata_acpi module will always fail to init the
controller, effectively hiding this bug.
Please someone test the following patch, as I do not have a system to reproduce
this:
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 3cc7096..e04cdc2 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -2560,6 +2560,7 @@ int ata_bus_probe(struct ata_port *ap)
* bus as we may be talking too fast.
*/
dev->pio_mode = XFER_PIO_0;
+ dev->dma_mode = 0xff;
/* If the controller has a pio mode setup function
* then use it to set the chipset to rights. Don't
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index e60437c..bf039b0 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2657,6 +2657,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
* bus as we may be talking too fast.
*/
dev->pio_mode = XFER_PIO_0;
+ dev->dma_mode = 0xff;
/* If the controller has a pio mode setup function
* then use it to set the chipset to rights. Don't
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply related [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (41 preceding siblings ...)
2012-11-16 8:39 ` bugzilla-daemon
@ 2012-11-17 16:29 ` bugzilla-daemon
2012-11-17 17:22 ` bugzilla-daemon
` (11 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-17 16:29 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
dutra.julio@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dutra.julio@gmail.com
--- Comment #42 from dutra.julio@gmail.com 2012-11-17 16:29:15 ---
Works great.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (42 preceding siblings ...)
2012-11-17 16:29 ` bugzilla-daemon
@ 2012-11-17 17:22 ` bugzilla-daemon
2012-11-25 12:55 ` bugzilla-daemon
` (10 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-17 17:22 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #43 from Szymon Janc <szymon@janc.net.pl> 2012-11-17 17:22:52 ---
Boots fine here as well. Thanks!
Would be also great to see it in stable :)
Tested-by: Szymon Janc <szymon@janc.net.pl>
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (43 preceding siblings ...)
2012-11-17 17:22 ` bugzilla-daemon
@ 2012-11-25 12:55 ` bugzilla-daemon
2012-11-29 2:22 ` bugzilla-daemon
` (9 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-25 12:55 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #44 from Szymon Janc <szymon@janc.net.pl> 2012-11-25 12:55:44 ---
Hi,
Any progress with getting Aaron's patch upstream (and 3.6.x)?
BR
Szymon Janc
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (44 preceding siblings ...)
2012-11-25 12:55 ` bugzilla-daemon
@ 2012-11-29 2:22 ` bugzilla-daemon
2012-11-29 11:21 ` bugzilla-daemon
` (8 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-29 2:22 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #45 from Aaron Lu <aaron.lu@intel.com> 2012-11-29 02:22:11 ---
Created an attachment (id=87661)
--> (https://bugzilla.kernel.org/attachment.cgi?id=87661)
Fix ata_dma_enabled
Hi all,
After another thought, 0 is actually not a valid dma mode either, so probably
we should fix ata_dma_enabled instead of setting 0xff beforehand.
Attached a new patch for test, sorry for the trouble.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (45 preceding siblings ...)
2012-11-29 2:22 ` bugzilla-daemon
@ 2012-11-29 11:21 ` bugzilla-daemon
2012-11-30 17:10 ` bugzilla-daemon
` (7 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-29 11:21 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #46 from dutra.julio@gmail.com 2012-11-29 11:21:36 ---
Works too.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (46 preceding siblings ...)
2012-11-29 11:21 ` bugzilla-daemon
@ 2012-11-30 17:10 ` bugzilla-daemon
2012-12-02 17:46 ` bugzilla-daemon
` (6 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-11-30 17:10 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #47 from Bernd Buschinski <b.buschinski@googlemail.com> 2012-11-30 17:10:34 ---
Also boots fine here, thx :)
That makes the first bootable 3.6 kernel(with patch) for me, I hope this patch
gets upstream soon
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (47 preceding siblings ...)
2012-11-30 17:10 ` bugzilla-daemon
@ 2012-12-02 17:46 ` bugzilla-daemon
2012-12-03 0:51 ` bugzilla-daemon
` (5 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-02 17:46 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #48 from Szymon Janc <szymon@janc.net.pl> 2012-12-02 17:46:37 ---
Hi Aaron,
second patch works for me as well!
BR
Szymon Janc
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (48 preceding siblings ...)
2012-12-02 17:46 ` bugzilla-daemon
@ 2012-12-03 0:51 ` bugzilla-daemon
2012-12-03 3:39 ` bugzilla-daemon
` (4 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-03 0:51 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #49 from Aaron Lu <aaron.lu@intel.com> 2012-12-03 00:51:46 ---
Thank you all for your test result, I'll update the patch with all of your
Tested-by tag, please let me know if you don't think I can add yours. And then
I'll send it to linux-ide mailing list, then Jeff will probably take this
patch.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (49 preceding siblings ...)
2012-12-03 0:51 ` bugzilla-daemon
@ 2012-12-03 3:39 ` bugzilla-daemon
2012-12-07 7:00 ` bugzilla-daemon
` (3 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-03 3:39 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #50 from Aaron Lu <aaron.lu@intel.com> 2012-12-03 03:39:16 ---
Turned out Alan Cox prefer the first approach, so I sent that patch out. Sorry
for the trouble brought by the 2nd patch.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (50 preceding siblings ...)
2012-12-03 3:39 ` bugzilla-daemon
@ 2012-12-07 7:00 ` bugzilla-daemon
2012-12-18 7:13 ` bugzilla-daemon
` (2 subsequent siblings)
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-07 7:00 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #51 from Aaron Lu <aaron.lu@intel.com> 2012-12-07 07:00:37 ---
The patch 'libata: set dma_mode to 0xff in reset' is taken by Jeff so this bug
can be closed, thanks.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (51 preceding siblings ...)
2012-12-07 7:00 ` bugzilla-daemon
@ 2012-12-18 7:13 ` bugzilla-daemon
2012-12-18 7:26 ` bugzilla-daemon
2012-12-18 12:48 ` bugzilla-daemon
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-18 7:13 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #52 from Roland Bogner <geist1@sms.at> 2012-12-18 07:13:02 ---
Is this now fixed in the final 3.7 ?
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (52 preceding siblings ...)
2012-12-18 7:13 ` bugzilla-daemon
@ 2012-12-18 7:26 ` bugzilla-daemon
2012-12-18 12:48 ` bugzilla-daemon
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-18 7:26 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
--- Comment #53 from Aaron Lu <aaron.lu@intel.com> 2012-12-18 07:26:50 ---
No I'm afraid. But it already arrived in Linus' tree so should appear in 3.7
stable tree some time later.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread* [Bug 49151] NULL pointer dereference in pata_acpi
2012-10-20 10:19 [Bug 49151] New: NULL pointer dereference in pata_acpi bugzilla-daemon
` (53 preceding siblings ...)
2012-12-18 7:26 ` bugzilla-daemon
@ 2012-12-18 12:48 ` bugzilla-daemon
54 siblings, 0 replies; 70+ messages in thread
From: bugzilla-daemon @ 2012-12-18 12:48 UTC (permalink / raw)
To: linux-ide
https://bugzilla.kernel.org/show_bug.cgi?id=49151
Aaron Lu <aaron.lu@intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|io_ide@kernel-bugs.osdl.org |aaron.lu@intel.com
--- Comment #54 from Aaron Lu <aaron.lu@intel.com> 2012-12-18 12:48:09 ---
Assign the bug to me to close it.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 70+ messages in thread
